Report for github.com/michelin/ChopChop
A+ Excellent! Found 15 issues across 26 files
gofmt96%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
ChopChop/core/severity_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo84%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
ChopChop/core/signatures.go
- Line 79: warning: cyclomatic complexity 23 of function (*Check).Match() is high (> 15) (gocyclo)
-
-
ChopChop/core/scan.go
- Line 58: warning: cyclomatic complexity 18 of function (Scanner).Scan() is high (> 15) (gocyclo)
-
-
ChopChop/cmd/scan.go
- Line 86: warning: cyclomatic complexity 32 of function parseConfig() is high (> 15) (gocyclo)
-
-
ChopChop/cmd/signatures.go
- Line 23: warning: cyclomatic complexity 18 of function parseSignatures() is high (> 15) (gocyclo)
golint53%
Golint is a linter for Go source code.
-
-
ChopChop/mock/httpget.go
- Line 11: warning: exported type FakeNetClient should have comment or be unexported (golint)
- Line 13: warning: exported method FakeNetClient.Get should have comment or be unexported (golint)
- Line 28: warning: exported var FakeFetcher should have comment or be unexported (golint)
-
-
ChopChop/internal/httpget/httpget.go
- Line 11: warning: exported type IHTTPClient should have comment or be unexported (golint)
- Line 15: warning: exported type HTTPClient should have comment or be unexported (golint)
- Line 20: warning: exported type Fetcher should have comment or be unexported (golint)
- Line 24: warning: exported function NewFetcher should have comment or be unexported (golint)
- Line 38: warning: exported function NewNoRedirectFetcher should have comment or be unexported (golint)
- Line 55: warning: exported method Fetcher.Fetch should have comment or be unexported (golint)
-
-
ChopChop/core/config.go
- Line 3: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
- Line 15: warning: exported type HTTPConfig should have comment or be unexported (golint)
-
-
ChopChop/tests/server.go
- Line 13: warning: exported function HelloServer should have comment or be unexported (golint)
-
-
ChopChop/core/signatures.go
- Line 8: warning: comment on exported type Signatures should be of the form "Signatures ..." (with optional leading article) (golint)
- Line 13: warning: exported type Plugin should have comment or be unexported (golint)
- Line 40: warning: exported method Signatures.FilterBySeverity should have comment or be unexported (golint)
- Line 57: warning: exported method Signatures.FilterByNames should have comment or be unexported (golint)
- Line 160: warning: exported method Signatures.Equals should have comment or be unexported (golint)
- Line 160: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 179: warning: exported method Plugin.Equals should have comment or be unexported (golint)
- Line 179: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 207: warning: exported method Check.Equals should have comment or be unexported (golint)
- Line 207: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 243: warning: exported function SliceStringEqual should have comment or be unexported (golint)
-
-
ChopChop/internal/export/export.go
- Line 12: warning: exported type IFile should have comment or be unexported (golint)
-
-
ChopChop/internal/http.go
- Line 5: warning: exported type HTTPResponse should have comment or be unexported (golint)
-
-
ChopChop/mock/output.go
- Line 7: warning: exported var FakeOutputStatusCode should have comment or be unexported (golint)
- Line 15: warning: exported var FakeOutputMatchOne should have comment or be unexported (golint)
- Line 22: warning: exported var FakeOutputMatchAll should have comment or be unexported (golint)
- Line 30: warning: exported var FakeOutputNotMatch should have comment or be unexported (golint)
- Line 38: warning: exported var FakeOutputNoHeaders should have comment or be unexported (golint)
- Line 46: warning: exported var FakeOutputHeaders should have comment or be unexported (golint)
- Line 54: warning: exported var FakeOutput should have comment or be unexported (golint)
- Line 63: warning: exported var FakeOutputAsCSV should have comment or be unexported (golint)
- Line 64: warning: exported var FakeOutputAsTable should have comment or be unexported (golint)
- Line 65: warning: exported var FakeOutputAsJSON should have comment or be unexported (golint)
-
-
ChopChop/mock/scan.go
- Line 10: warning: exported var FakeScanner should have comment or be unexported (golint)
- Line 12: warning: exported type FakeFetcherWithoutNetclient should have comment or be unexported (golint)
- Line 14: warning: exported method FakeFetcherWithoutNetclient.Fetch should have comment or be unexported (golint)
- Line 21: warning: exported var MyFakeFetcher should have comment or be unexported (golint)
-
-
ChopChop/mock/signatures.go
- Line 13: warning: exported var FakeCheckStatusCode200 should have comment or be unexported (golint)
- Line 20: warning: exported var FakeCheckStatusCode500 should have comment or be unexported (golint)
- Line 27: warning: exported var FakeCheckNoHeaders should have comment or be unexported (golint)
- Line 34: warning: exported var FakeCheckNoHeadersKeyOnly should have comment or be unexported (golint)
- Line 41: warning: exported var FakeCheckHeaders should have comment or be unexported (golint)
- Line 47: warning: exported var FakeCheckHeaders2 should have comment or be unexported (golint)
- Line 54: warning: exported var FakeCheckMatchOne should have comment or be unexported (golint)
- Line 61: warning: exported var FakeCheckMatchAll should have comment or be unexported (golint)
- Line 68: warning: exported var FakeCheckNotMatch should have comment or be unexported (golint)
- Line 77: warning: exported var FakePlugin should have comment or be unexported (golint)
- Line 91: warning: exported var FakeQueryPlugin should have comment or be unexported (golint)
- Line 99: warning: exported var FakePlugin2 should have comment or be unexported (golint)
- Line 107: warning: exported var FakeFollowRedirectPlugin should have comment or be unexported (golint)
- Line 115: warning: comment on exported var FakeSignatures should be of the form "FakeSignatures ..." (golint)
-
-
ChopChop/core/scan.go
- Line 12: warning: exported type SafeData should have comment or be unexported (golint)
- Line 17: warning: exported method SafeData.Add should have comment or be unexported (golint)
- Line 23: warning: exported type IFetcher should have comment or be unexported (golint)
- Line 27: warning: exported type IScanner should have comment or be unexported (golint)
- Line 31: warning: exported type Scanner should have comment or be unexported (golint)
- Line 58: warning: exported method Scanner.Scan should have comment or be unexported (golint)
-
-
ChopChop/core/severity.go
- Line 7: warning: exported function ValidSeverity should have comment or be unexported (golint)
- Line 16: warning: exported function SeveritiesAsString should have comment or be unexported (golint)
- Line 20: warning: exported function SeverityReached should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!