gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• midonet-kubernetes/pkg/cni/utils/network.go
  • Line 33: warning: cyclomatic complexity 19 of function DoNetworking() is high (> 15) (gocyclo)

• midonet-kubernetes/pkg/midonet/client.go
  • Line 126: warning: cyclomatic complexity 16 of function (*Client).Push() is high (> 15) (gocyclo)

golint82%

Golint is a linter for Go source code.

• midonet-kubernetes/pkg/midonet/resources.go
  • Line 96: warning: exported method TunnelZone.MediaType should have comment or be unexported (golint)
  • Line 100: warning: exported method TunnelZone.Path should have comment or be unexported (golint)
  • Line 119: warning: exported method TunnelZoneHost.MediaType should have comment or be unexported (golint)
  • Line 123: warning: exported method TunnelZoneHost.Path should have comment or be unexported (golint)
  • Line 144: warning: exported method Router.MediaType should have comment or be unexported (golint)
  • Line 148: warning: exported method Router.Path should have comment or be unexported (golint)
  • Line 169: warning: exported method Bridge.MediaType should have comment or be unexported (golint)
  • Line 173: warning: exported method Bridge.Path should have comment or be unexported (golint)
  • Line 196: warning: exported method Port.MediaType should have comment or be unexported (golint)
  • Line 200: warning: exported method Port.Path should have comment or be unexported (golint)
  • Line 226: warning: exported method PortLink.MediaType should have comment or be unexported (golint)
  • Line 230: warning: exported method PortLink.Path should have comment or be unexported (golint)
  • Line 253: warning: exported method Route.MediaType should have comment or be unexported (golint)
  • Line 257: warning: exported method Route.Path should have comment or be unexported (golint)
  • Line 276: warning: exported method Chain.MediaType should have comment or be unexported (golint)
  • Line 280: warning: exported method Chain.Path should have comment or be unexported (golint)
  • Line 316: warning: exported method Rule.MediaType should have comment or be unexported (golint)
  • Line 320: warning: exported method Rule.Path should have comment or be unexported (golint)
  • Line 338: warning: exported method Host.CollectionMediaType should have comment or be unexported (golint)
  • Line 342: warning: exported method Host.Path should have comment or be unexported (golint)
  • Line 360: warning: exported method HostInterfacePort.MediaType should have comment or be unexported (golint)
  • Line 364: warning: exported method HostInterfacePort.Path should have comment or be unexported (golint)
  • Line 383: warning: exported method MACPort.MediaType should have comment or be unexported (golint)
  • Line 396: warning: exported method MACPort.Path should have comment or be unexported (golint)
  • Line 415: warning: exported method IPv4MACPair.MediaType should have comment or be unexported (golint)
  • Line 426: warning: exported method IPv4MACPair.Path should have comment or be unexported (golint)

• midonet-kubernetes/pkg/pusher/doc.go
  • Line 16: warning: package comment should be of the form "Package pusher ..." (golint)

• midonet-kubernetes/pkg/converter/pod/portarp.go
  • Line 27: warning: exported type PortARP should have comment or be unexported (golint)
  • Line 33: warning: exported method PortARP.Convert should have comment or be unexported (golint)

• midonet-kubernetes/pkg/converter/doc.go
  • Line 16: warning: package comment should be of the form "Package converter ..." (golint)

• midonet-kubernetes/pkg/nodeapi/path.go
  • Line 19: warning: exported const Path should have comment (or a comment on this block) or be unexported (golint)

• midonet-kubernetes/pkg/cni/types/types.go
  • Line 31: warning: exported type NetworkInfo should have comment or be unexported (golint)

• midonet-kubernetes/pkg/k8s/annotation.go
  • Line 44: warning: exported function AddPodAnnotation should have comment or be unexported (golint)
  • Line 63: warning: exported function DeletePodAnnotation should have comment or be unexported (golint)
  • Line 82: warning: exported function AddNodeAnnotation should have comment or be unexported (golint)

• midonet-kubernetes/pkg/nodeapi/client/annotation.go
  • Line 41: warning: error should be the last type when returning multiple items (golint)
  • Line 41: warning: exported function AddPodAnnotation should have comment or be unexported (golint)
  • Line 62: warning: error should be the last type when returning multiple items (golint)
  • Line 62: warning: exported function DeletePodAnnotation should have comment or be unexported (golint)

• midonet-kubernetes/pkg/util/doc.go
  • Line 16: warning: package comment should be of the form "Package util ..." (golint)

• midonet-kubernetes/pkg/apis/midonet/v1/doc.go
  • Line 19: warning: package comment should be of the form "Package v1 ..." (golint)

• midonet-kubernetes/pkg/controller/doc.go
  • Line 16: warning: package comment should be of the form "Package controller ..." (golint)

• midonet-kubernetes/pkg/nodeapi/doc.go
  • Line 19: warning: package comment should be of the form "Package nodeapi ..." (golint)

• midonet-kubernetes/pkg/cni/utils/utils.go
  • Line 30: warning: exported function Min should have comment or be unexported (golint)
  • Line 72: warning: exported type WEPIdentifiers should have comment or be unexported (golint)
  • Line 120: warning: comment on exported function ConfigureLogging should be of the form "ConfigureLogging ..." (golint)

• midonet-kubernetes/pkg/converter/pod/dnsify.go
  • Line 23: warning: exported function DNSifyMAC should have comment or be unexported (golint)

• midonet-kubernetes/pkg/midonet/doc.go
  • Line 16: warning: package comment should be of the form "Package midonet ..." (golint)

• midonet-kubernetes/pkg/config/doc.go
  • Line 16: warning: package comment should be of the form "Package config ..." (golint)

• midonet-kubernetes/pkg/k8s/doc.go
  • Line 16: warning: package comment should be of the form "Package k8s ..." (golint)

• midonet-kubernetes/pkg/nodeannotator/doc.go
  • Line 16: warning: package comment should be of the form "Package nodeannotator ..." (golint)

• midonet-kubernetes/pkg/midonet/hwaddr.go
  • Line 24: warning: comment on exported type HardwareAddr should be of the form "HardwareAddr ..." (with optional leading article) (golint)
  • Line 27: warning: exported method HardwareAddr.MarshalJSON should have comment or be unexported (golint)
  • Line 31: warning: exported method HardwareAddr.UnmarshalJSON should have comment or be unexported (golint)

• midonet-kubernetes/pkg/cni/doc.go
  • Line 16: warning: package comment should be of the form "Package cni ..." (golint)

• midonet-kubernetes/pkg/cni/utils/network.go
  • Line 150: warning: exported function ConfigureIPForwarding should have comment or be unexported (golint)

• midonet-kubernetes/pkg/converter/pod/portmac.go
  • Line 27: warning: exported type PortMAC should have comment or be unexported (golint)
  • Line 33: warning: exported method PortMAC.Convert should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!