Preparing report...

Report for github.com/moov-io/customers

A+    Excellent!    Found 50 issues across 160 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint70%

Golint is a linter for Go source code.

    • customers/pkg/paygate/mock_client.go
    • Line 11: warning: exported type MockClient should have comment or be unexported (golint)
    • Line 16: warning: exported method MockClient.Ping should have comment or be unexported (golint)
    • Line 20: warning: exported method MockClient.GetMicroDeposits should have comment or be unexported (golint)
    • Line 27: warning: exported method MockClient.InitiateMicroDeposits should have comment or be unexported (golint)
    • customers/pkg/customers/address.go
    • Line 19: warning: exported var ErrAddressTypeDuplicate should have comment or be unexported (golint)
    • Line 22: warning: exported function AddCustomerAddressRoutes should have comment or be unexported (golint)
    • customers/pkg/validator/mock_repository.go
    • Line 10: warning: exported type MockRepository should have comment or be unexported (golint)
    • Line 15: warning: exported method MockRepository.CreateValidation should have comment or be unexported (golint)
    • Line 34: warning: exported method MockRepository.GetValidation should have comment or be unexported (golint)
    • Line 48: warning: exported method MockRepository.UpdateValidation should have comment or be unexported (golint)
    • Line 56: warning: exported method MockRepository.Close should have comment or be unexported (golint)
    • customers/pkg/config/config.go
    • Line 11: warning: exported type Config should have comment or be unexported (golint)
    • Line 15: warning: exported function New should have comment or be unexported (golint)
    • Line 21: warning: exported method Config.Load should have comment or be unexported (golint)
    • customers/pkg/fed/client.go
    • Line 23: warning: exported type Client should have comment or be unexported (golint)
    • Line 93: warning: exported function NewClient should have comment or be unexported (golint)
    • customers/pkg/fed/mock_client.go
    • Line 11: warning: exported type MockClient should have comment or be unexported (golint)
    • Line 16: warning: exported method MockClient.Ping should have comment or be unexported (golint)
    • Line 20: warning: exported method MockClient.LookupInstitution should have comment or be unexported (golint)
    • customers/pkg/documents/disclaimers.go
    • Line 30: warning: exported function AddDisclaimerRoutes should have comment or be unexported (golint)
    • Line 35: warning: exported function AddDisclaimerAdminRoutes should have comment or be unexported (golint)
    • Line 158: warning: exported type DisclaimerRepository should have comment or be unexported (golint)
    • Line 170: warning: exported function NewDisclaimerRepo should have comment or be unexported (golint)
    • customers/pkg/watchman/test_watchman.go
    • Line 9: warning: exported type TestWatchmanClient should have comment or be unexported (golint)
    • Line 16: warning: exported function NewTestWatchmanClient should have comment or be unexported (golint)
    • Line 23: warning: exported method TestWatchmanClient.Ping should have comment or be unexported (golint)
    • Line 27: warning: exported method TestWatchmanClient.Search should have comment or be unexported (golint)
    • customers/pkg/model/yyyymmdd.go
    • Line 14: warning: don't use underscores in Go names; var YYYYMMDD_Format should be YYYYMMDDFormat (golint)
    • Line 14: warning: exported var YYYYMMDD_Format should have comment or be unexported (golint)
    • Line 17: warning: exported type YYYYMMDD should have comment or be unexported (golint)
    • Line 19: warning: exported method YYYYMMDD.UnmarshalJSON should have comment or be unexported (golint)
    • customers/pkg/validator/repository.go
    • Line 11: warning: exported type Validation should have comment or be unexported (golint)
    • Line 22: warning: exported const StatusInit should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported type Repository should have comment or be unexported (golint)
    • Line 32: warning: exported function NewRepo should have comment or be unexported (golint)
    • customers/pkg/validator/strategy.go
    • Line 9: warning: exported type StrategyKey should have comment or be unexported (golint)
    • Line 14: warning: exported type Strategy should have comment or be unexported (golint)
    • Line 19: warning: exported type VendorRequest should have comment or be unexported (golint)
    • Line 20: warning: exported type VendorResponse should have comment or be unexported (golint)
    • customers/pkg/documents/storage/bucket.go
    • Line 27: warning: exported type BucketFunc should have comment or be unexported (golint)
    • Line 29: warning: exported function GetBucket should have comment or be unexported (golint)
    • Line 78: warning: exported function FileblobSigner should have comment or be unexported (golint)
    • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • customers/pkg/customers/approval_ofac.go
    • Line 40: warning: exported type OFACSearcher should have comment or be unexported (golint)
    • Line 45: warning: exported function NewOFACSearcher should have comment or be unexported (golint)
    • Line 100: warning: exported function AddOFACRoutes should have comment or be unexported (golint)
    • customers/pkg/secrets/secrets.go
    • Line 34: warning: exported function NewStringKeeper should have comment or be unexported (golint)
    • Line 42: warning: exported method StringKeeper.Close should have comment or be unexported (golint)
    • customers/pkg/customers/customer_ssn.go
    • Line 20: warning: exported type SSN should have comment or be unexported (golint)
    • Line 36: warning: exported function NewSSNStorage should have comment or be unexported (golint)
    • Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 73: warning: exported type SSNRepository should have comment or be unexported (golint)
    • Line 78: warning: exported function NewCustomerSSNRepository should have comment or be unexported (golint)
    • customers/pkg/accounts/router.go
    • Line 29: warning: exported function RegisterRoutes should have comment or be unexported (golint)
    • Line 84: warning: exported type CreateAccountRequest should have comment or be unexported (golint)
    • Line 96: warning: exported method CreateAccountRequest.Validate should have comment or be unexported (golint)
    • Line 117: warning: exported method CreateAccountRequest.Disfigure should have comment or be unexported (golint)
    • Line 120: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • customers/pkg/customers/customers.go
    • Line 29: warning: exported function AddCustomerRoutes should have comment or be unexported (golint)
    • Line 553: warning: exported type CustomerRepository should have comment or be unexported (golint)
    • Line 577: warning: exported function NewCustomerRepo should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!