Report for github.com/moov-io/go-sftp
(v0.3.0)
A+ Excellent! Found 2 issues across 6 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint66%
Golint is a linter for Go source code.
-
-
client.go
- Line 5: warning: don't use an underscore in package name (golint)
- Line 41: warning: exported type ClientConfig should have comment or be unexported (golint)
- Line 54: warning: exported type Client should have comment or be unexported (golint)
- Line 73: warning: exported function NewClient should have comment or be unexported (golint)
- Line 101: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 283: warning: exported type File should have comment or be unexported (golint)
- Line 288: warning: exported method File.Close should have comment or be unexported (golint)
- Line 396: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
mock_client.go
- Line 5: warning: don't use an underscore in package name (golint)
- Line 16: warning: exported type MockClient should have comment or be unexported (golint)
- Line 22: warning: exported function NewMockClient should have comment or be unexported (golint)
- Line 28: warning: exported method MockClient.Ping should have comment or be unexported (golint)
- Line 32: warning: exported method MockClient.Dir should have comment or be unexported (golint)
- Line 36: warning: exported method MockClient.Close should have comment or be unexported (golint)
- Line 40: warning: exported method MockClient.Open should have comment or be unexported (golint)
- Line 55: warning: exported method MockClient.Delete should have comment or be unexported (golint)
- Line 59: warning: exported method MockClient.UploadFile should have comment or be unexported (golint)
- Line 70: warning: exported method MockClient.ListFiles should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!