Go Report Card

Preparing report...

Report for github.com/netsys-lab/scion-path-discovery

A    Great!    Found 14 issues across 16 files

Tweet
Last refresh:

Refresh now

gofmt81%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint12%

Golint is a linter for Go source code.

    • scion-path-discovery/api/smp.go
    • Line 49: warning: comment on exported type MPPeerSock should be of the form "MPPeerSock ..." (with optional leading article) (golint)
    • Line 64: warning: exported function NewMPPeerSock should have comment or be unexported (golint)
    • Line 72: warning: exported method MPPeerSock.StartPathSelection should have comment or be unexported (golint)
    • Line 103: warning: exported function NewMonitoredConn should have comment or be unexported (golint)
    • Line 116: warning: exported function NewMPSock should have comment or be unexported (golint)
    • Line 123: warning: exported function CloseConn should have comment or be unexported (golint)
    • Line 127: warning: comment on exported method MPPeerSock.Connect should be of the form "Connect ..." (golint)
    • Line 150: warning: exported method MPPeerSock.Disconnect should have comment or be unexported (golint)
    • Line 161: warning: comment on exported method MPPeerSock.DialPath should be of the form "DialPath ..." (golint)
    • Line 172: warning: comment on exported method MPPeerSock.DialAll should be of the form "DialAll ..." (golint)
    • scion-path-discovery/peers/peers.go
    • Line 8: warning: comment on exported type Peer should be of the form "Peer ..." (with optional leading article) (golint)
    • Line 15: warning: comment on exported type PathlevelPeer should be of the form "PathlevelPeer ..." (with optional leading article) (golint)
    • scion-path-discovery/pathselection/latency.go
    • Line 35: warning: comment on exported function SelectLowestLatencies should be of the form "SelectLowestLatencies ..." (golint)
    • Line 53: warning: comment on exported function SelectLowestLatency should be of the form "SelectLowestLatency ..." (golint)
    • scion-path-discovery/pathselection/selection.go
    • Line 11: warning: exported type PathAlternatives should have comment or be unexported (golint)
    • Line 16: warning: exported type PathEnumerator should have comment or be unexported (golint)
    • Line 20: warning: exported type PathQuality should have comment or be unexported (golint)
    • Line 28: warning: exported type QualityDB should have comment or be unexported (golint)
    • Line 47: warning: exported type MeasuringReaderWriter should have comment or be unexported (golint)
    • scion-path-discovery/packets/generator.go
    • Line 5: warning: comment on exported type PacketGenMeta should be of the form "PacketGenMeta ..." (with optional leading article) (golint)
    • Line 12: warning: comment on exported type PacketGen should be of the form "PacketGen ..." (with optional leading article) (golint)
    • scion-path-discovery/packets/scheduler.go
    • Line 7: warning: comment on exported type PacketScheduler should be of the form "PacketScheduler ..." (with optional leading article) (golint)
    • Line 19: warning: comment on exported type WeighedScheduler should be of the form "WeighedScheduler ..." (with optional leading article) (golint)
    • scion-path-discovery/pathselection/mtu.go
    • Line 25: warning: comment on exported function SelectLargestMTUs should be of the form "SelectLargestMTUs ..." (golint)
    • Line 43: warning: comment on exported function SelectLargestMTU should be of the form "SelectLargestMTU ..." (golint)
    • scion-path-discovery/examples/bittorrent/bittorrent.go
    • Line 10: warning: comment on exported type BittorrentPeer should be of the form "BittorrentPeer ..." (with optional leading article) (golint)
    • Line 18: warning: comment on exported type BittorrentMultipathSock should be of the form "BittorrentMultipathSock ..." (with optional leading article) (golint)
    • Line 29: warning: exported function NewBittorrentMultipathSock should have comment or be unexported (golint)
    • Line 35: warning: comment on exported method BittorrentMultipathSock.PeerLokup should be of the form "PeerLokup ..." (golint)
    • Line 46: warning: comment on exported method BittorrentMultipathSock.RequestPiece should be of the form "RequestPiece ..." (golint)
    • Line 59: warning: comment on exported method BittorrentMultipathSock.ReceivePiece should be of the form "ReceivePiece ..." (golint)
    • Line 69: warning: exported method BittorrentMultipathSock.SendPiece should have comment or be unexported (golint)
    • scion-path-discovery/packets/handler.go
    • Line 5: warning: comment on exported type PacketHandlerMeta should be of the form "PacketHandlerMeta ..." (with optional leading article) (golint)
    • Line 11: warning: exported type PacketHandler should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign93%

IneffAssign detects ineffectual assignments in Go code.

misspell93%

Misspell Finds commonly misspelled English words