Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

- Line 1483: warning: cyclomatic complexity 21 of function TestCSPCNodeNameChanges() is high (> 15) (gocyclo)

- Line 57: warning: cyclomatic complexity 20 of function (*Controller).sync() is high (> 15) (gocyclo)

- Line 62: warning: cyclomatic complexity 24 of function (*OperationsConfig).Update() is high (> 15) (gocyclo)

- Line 67: warning: cyclomatic complexity 19 of function (*OperationsConfig).updateNewVdevFromCSPI() is high (> 15) (gocyclo)

- Line 294: warning: cyclomatic complexity 16 of function (*Client).WaitForVolumeManagerTunables() is high (> 15) (gocyclo)

- Line 491: warning: cyclomatic complexity 18 of function (*client).preUpgrade() is high (> 15) (gocyclo)

- Line 442: warning: cyclomatic complexity 19 of function (*fixture).run_() is high (> 15) (gocyclo)

- Line 56: warning: cyclomatic complexity 18 of function (*CStorPoolInstanceController).reconcile() is high (> 15) (gocyclo)

- Line 137: warning: cyclomatic complexity 25 of function (*CStorVolumeController).cStorVolumeEventHandler() is high (> 15) (gocyclo)

- Line 750: warning: cyclomatic complexity 23 of function TestBackupDeleteEndPoint() is high (> 15) (gocyclo)
- Line 606: warning: cyclomatic complexity 16 of function TestBackupGetEndPoint() is high (> 15) (gocyclo)

golint81%

Golint is a linter for Go source code.

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 85: warning: comment on exported method PoolConfig.CreateCSPIDeployment should be of the form "CreateCSPIDeployment ..." (golint)
- Line 92: warning: comment on exported method PoolConfig.ScaleDown should be of the form "ScaleDown ..." (golint)

- Line 1: warning: package comment should be of the form "Package version ..." (golint)

- Line 393: warning: exported function SetTargetIp should have comment or be unexported (golint)
- Line 405: warning: exported function GetTargetIp should have comment or be unexported (golint)
- Line 833: warning: should omit 2nd value from range; this loop is equivalent to `for snapName := range ...` (golint)
- Line 899: warning: should omit 2nd value from range; this loop is equivalent to `for snapName := range ...` (golint)
- Line 926: warning: should omit 2nd value from range; this loop is equivalent to `for snapName := range ...` (golint)
- Line 943: warning: should omit 2nd value from range; this loop is equivalent to `for snapName := range ...` (golint)
- Line 951: warning: should omit 2nd value from range; this loop is equivalent to `for snapName := range ...` (golint)

- Line 1: warning: package comment should be of the form "Package vstats ..." (golint)

- Line 756: warning: should omit 2nd value from range; this loop is equivalent to `for index := range ...` (golint)

- Line 1: warning: package comment should be of the form "Package zfs ..." (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 293: warning: don't use underscores in Go names; method run_ should be run (golint)

- Line 846: warning: exported method CVCController.ShouldReconcile should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package cstorvolumeconfig ..." (golint)

- Line 78: warning: comment on exported var WebhookFailurePolicy should be of the form "WebhookFailurePolicy ..." (golint)

- Line 1: warning: package comment should be of the form "Package targetserver ..." (golint)

- Line 20: warning: should not use dot imports (golint)
- Line 34: warning: comment on exported method Client.GetOnlineCSPICountEventually should be of the form "GetOnlineCSPICountEventually ..." (golint)
- Line 181: warning: comment on exported method Client.GetCSPC should be of the form "GetCSPC ..." (golint)

- Line 1: warning: package comment should be of the form "Package zfs ..." (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 651: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 73: warning: exported method CStorPoolInstanceController.UpdateStatusCondition should have comment or be unexported (golint)

- Line 99: warning: comment on exported method ControllerBuilder.WithKubeClient should be of the form "WithKubeClient ..." (golint)
- Line 105: warning: comment on exported method ControllerBuilder.WithOpenEBSClient should be of the form "WithOpenEBSClient ..." (golint)
- Line 111: warning: comment on exported method ControllerBuilder.WithCSPCLister should be of the form "WithCSPCLister ..." (golint)
- Line 125: warning: comment on exported method ControllerBuilder.WithCSPCSynced should be of the form "WithCSPCSynced ..." (golint)
- Line 139: warning: comment on exported method ControllerBuilder.WithWorkqueueRateLimiting should be of the form "WithWorkqueueRateLimiting ..." (golint)
- Line 145: warning: comment on exported method ControllerBuilder.WithRecorder should be of the form "WithRecorder ..." (golint)
- Line 156: warning: comment on exported method ControllerBuilder.WithEventHandler should be of the form "WithEventHandler ..." (golint)
- Line 239: warning: exported function GetVersionedCSPCInterface should have comment or be unexported (golint)
- Line 243: warning: exported function GetStoredCSPIVersionInterface should have comment or be unexported (golint)
- Line 247: warning: exported method Controller.GetStoredCStorVersionClient should have comment or be unexported (golint)
- Line 251: warning: exported method Controller.GetStoredOpenebsVersionClient should have comment or be unexported (golint)

- Line 99: warning: don't use underscores in Go names; method run_ should be run (golint)

- Line 31: warning: exported type VolumeListSnapshot should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 590: warning: exported method Controller.ShouldReconcile should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package snapshottest ..." (golint)

- Line 39: warning: exported var SupportedCompressionTypes should have comment or be unexported (golint)

- Line 44: warning: exported type Client should have comment or be unexported (golint)
- Line 52: warning: exported function NewClient should have comment or be unexported (golint)

- Line 20: warning: should not use dot imports (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 30: warning: exported type OperationsConfig should have comment or be unexported (golint)

- Line 97: warning: exported type ReplacementTracer should have comment or be unexported (golint)
- Line 103: warning: exported function NewReplacementTracer should have comment or be unexported (golint)
- Line 202: warning: comment on exported method CSPCSpecBuilder.ReplaceBlockDeviceAtPos should be of the form "ReplaceBlockDeviceAtPos ..." (golint)

- Line 1: warning: package comment should be of the form "Package provisioning ..." (golint)
- Line 21: warning: should not use dot imports (golint)
- Line 22: warning: should not use dot imports (golint)

- Line 135: warning: exported function GetVersionDetails should have comment or be unexported (golint)

- Line 41: warning: comment on exported function IsCurrentLessThanNewVersion should be of the form "IsCurrentLessThanNewVersion ..." (golint)

- Line 26: warning: comment on exported const MinimumPoolManagersAvailable should be of the form "MinimumPoolManagersAvailable ..." (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 1: warning: package comment should be of the form "Package zpool ..." (golint)

- Line 40: warning: comment on exported const SuccessSynced should be of the form "SuccessSynced ..." (golint)
- Line 143: warning: comment on exported const OpenEBSIOCSPIID should be of the form "OpenEBSIOCSPIID ..." (golint)

- Line 258: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 111: warning: exported method Config.GetStoredOpenEBSVersionClient should have comment or be unexported (golint)
- Line 115: warning: exported method Config.GetStoredCStorVersionClient should have comment or be unexported (golint)

- Line 35: warning: exported method Controller.UpdateStatusEventually should have comment or be unexported (golint)
- Line 67: warning: exported method Controller.UpdateStatus should have comment or be unexported (golint)
- Line 146: warning: exported function IsPoolMangerAvailable should have comment or be unexported (golint)

- Line 36: warning: comment on exported type ZFSCommandError should be of the form "ZFSCommandError ..." (with optional leading article) (golint)

- Line 1: warning: package comment should be of the form "Package zfs ..." (golint)

- Line 283: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 442: warning: don't use underscores in Go names; method run_ should be run (golint)

- Line 31: warning: exported const ApiVersion should have comment (or a comment on this block) or be unexported (golint)
- Line 34: warning: comment on exported method Config.GetCSPISpec should be of the form "GetCSPISpec ..." (golint)
- Line 106: warning: exported function GetCSPCOwnerReference should have comment or be unexported (golint)

- Line 108: warning: comment on exported method Config.GetUsedNodes should be of the form "GetUsedNodes ..." (golint)
- Line 322: warning: exported function GetCapacity should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell89%

Misspell Finds commonly misspelled English words

- Line 98: warning: "usefull" is a misspelling of "useful" (misspell)
- Line 100: warning: "usefull" is a misspelling of "useful" (misspell)
- Line 552: warning: "successfull" is a misspelling of "successful" (misspell)
- Line 1591: warning: "successfull" is a misspelling of "successful" (misspell)

- Line 42: warning: "requirment" is a misspelling of "requirement" (misspell)

- Line 886: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 922: warning: "occured" is a misspelling of "occurred" (misspell)

- Line 54: warning: "requirment" is a misspelling of "requirement" (misspell)
- Line 74: warning: "requirment" is a misspelling of "requirement" (misspell)
- Line 100: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 135: warning: "untill" is a misspelling of "until" (misspell)
- Line 172: warning: "propogate" is a misspelling of "propagate" (misspell)
- Line 178: warning: "untill" is a misspelling of "until" (misspell)
- Line 205: warning: "untill" is a misspelling of "until" (misspell)
- Line 232: warning: "untill" is a misspelling of "until" (misspell)
- Line 286: warning: "propogate" is a misspelling of "propagate" (misspell)
- Line 293: warning: "untill" is a misspelling of "until" (misspell)

- Line 182: warning: "recieves" is a misspelling of "receives" (misspell)

- Line 164: warning: "successfull" is a misspelling of "successful" (misspell)

- Line 260: warning: "Reconcilation" is a misspelling of "Reconciliation" (misspell)

- Line 106: warning: "successfull" is a misspelling of "successful" (misspell)

- Line 61: warning: "whith" is a misspelling of "with" (misspell)
- Line 67: warning: "whith" is a misspelling of "with" (misspell)

- Line 59: warning: "requirment" is a misspelling of "requirement" (misspell)

- Line 492: warning: "unkown" is a misspelling of "unknown" (misspell)
- Line 493: warning: "unkown" is a misspelling of "unknown" (misspell)

- Line 166: warning: "promethous" is a misspelling of "prometheus" (misspell)

- Line 147: warning: "Recieved" is a misspelling of "Received" (misspell)

- Line 476: warning: "repetion" is a misspelling of "repetition" (misspell)

- Line 732: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 749: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 970: warning: "occured" is a misspelling of "occurred" (misspell)

- Line 43: warning: "Imporve" is a misspelling of "Improve" (misspell)

- Line 600: warning: "exsiting" is a misspelling of "existing" (misspell)

- Line 788: warning: "refering" is a misspelling of "referring" (misspell)
- Line 799: warning: "refering" is a misspelling of "referring" (misspell)

- Line 150: warning: "successfull" is a misspelling of "successful" (misspell)
- Line 156: warning: "successfull" is a misspelling of "successful" (misspell)

- Line 193: warning: "succesful" is a misspelling of "successful" (misspell)

- Line 444: warning: "occured" is a misspelling of "occurred" (misspell)

- Line 478: warning: "occured" is a misspelling of "occurred" (misspell)

- Line 36: warning: "alogrithm" is a misspelling of "algorithm" (misspell)

- Line 541: warning: "occured" is a misspelling of "occurred" (misspell)

- Line 266: warning: "reponse" is a misspelling of "response" (misspell)

- Line 63: warning: "untill" is a misspelling of "until" (misspell)
- Line 64: warning: "occured" is a misspelling of "occurred" (misspell)

- Line 286: warning: "successfull" is a misspelling of "successful" (misspell)
- Line 385: warning: "comparisions" is a misspelling of "comparisons" (misspell)

- Line 49: warning: "requirment" is a misspelling of "requirement" (misspell)
- Line 61: warning: "untill" is a misspelling of "until" (misspell)
- Line 67: warning: "requirment" is a misspelling of "requirement" (misspell)

Go Report Card

Preparing report...

Report for github.com/openebs/cstor-operators

gofmt95%

go_vet100%

gocyclo96%

golint81%

ineffassign100%

license100%

misspell89%