Preparing report...

Report for github.com/openshift/origin

A+    Excellent!    Found 190 issues across 404 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo89%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • origin/test/extended/authorization/authorization.go
    • Line 811: warning: cyclomatic complexity 36 of function (subjectAccessReviewTest).run() is high (> 15) (gocyclo)
    • Line 303: warning: cyclomatic complexity 17 of function (localResourceAccessReviewTest).run() is high (> 15) (gocyclo)
    • Line 226: warning: cyclomatic complexity 16 of function (resourceAccessReviewTest).run() is high (> 15) (gocyclo)
    • origin/test/extended/authorization/authorization_rbac_proxy.go
    • Line 75: warning: cyclomatic complexity 22 of function RunLegacyLocalRoleBindingEndpoint() is high (> 15) (gocyclo)
    • Line 486: warning: cyclomatic complexity 20 of function RunLegacyLocalRoleEndpoint() is high (> 15) (gocyclo)
    • Line 234: warning: cyclomatic complexity 20 of function RunLegacyClusterRoleBindingEndpoint() is high (> 15) (gocyclo)
    • Line 367: warning: cyclomatic complexity 20 of function RunLegacyClusterRoleEndpoint() is high (> 15) (gocyclo)
    • Line 634: warning: cyclomatic complexity 18 of function RunLegacyEndpointConfirmNoEscalation() is high (> 15) (gocyclo)
    • origin/test/e2e/upgrade/upgrade.go
    • Line 254: warning: cyclomatic complexity 34 of function clusterUpgrade() is high (> 15) (gocyclo)
    • Line 176: warning: cyclomatic complexity 24 of function getUpgradeContext() is high (> 15) (gocyclo)
    • Line 525: warning: cyclomatic complexity 23 of function IsPoolUpdated() is high (> 15) (gocyclo)
    • origin/test/extended/cluster/utils.go
    • Line 505: warning: cyclomatic complexity 19 of function CreateTemplates() is high (> 15) (gocyclo)
    • Line 594: warning: cyclomatic complexity 18 of function CreateSimpleTemplates() is high (> 15) (gocyclo)
    • Line 164: warning: cyclomatic complexity 17 of function (*ClusterLoaderObjectType).CreatePods() is high (> 15) (gocyclo)
    • origin/test/extended/util/framework.go
    • Line 62: warning: cyclomatic complexity 39 of function WaitForInternalRegistryHostname() is high (> 15) (gocyclo)
    • Line 234: warning: cyclomatic complexity 28 of function WaitForOpenShiftNamespaceImageStreams() is high (> 15) (gocyclo)
    • Line 904: warning: cyclomatic complexity 16 of function WaitForABuild() is high (> 15) (gocyclo)

golint65%

Golint is a linter for Go source code.

    • origin/doc.go
    • Line 1: warning: package comment should be of the form "Package origin ..." (golint)
    • origin/test/extended/util/prometheus/helpers.go
    • Line 97: warning: exported type MetricCondition should have comment or be unexported (golint)
    • Line 103: warning: exported type MetricConditions should have comment or be unexported (golint)
    • Line 105: warning: exported method MetricConditions.Matches should have comment or be unexported (golint)
    • Line 121: warning: exported function LabelsAsSelector should have comment or be unexported (golint)
    • Line 125: warning: exported function StripLabels should have comment or be unexported (golint)
    • Line 136: warning: exported function RunQuery should have comment or be unexported (golint)
    • origin/test/extended/router/h2spec/types.go
    • Line 9: warning: comment on exported type JUnitTestReport should be of the form "JUnitTestReport ..." (with optional leading article) (golint)
    • Line 51: warning: comment on exported type JUnitError should be of the form "JUnitError ..." (with optional leading article) (golint)
    • origin/pkg/test/ginkgo/cmd_runsuite.go
    • Line 67: warning: exported method Options.AsEnv should have comment or be unexported (golint)
    • Line 74: warning: exported method Options.SelectSuite should have comment or be unexported (golint)
    • Line 116: warning: exported method Options.Run should have comment or be unexported (golint)
    • origin/pkg/synthetictests/event_junits.go
    • Line 12: warning: comment on exported function StableSystemEventInvariants should be of the form "StableSystemEventInvariants ..." (golint)
    • Line 35: warning: comment on exported function SystemUpgradeEventInvariants should be of the form "SystemUpgradeEventInvariants ..." (golint)
    • Line 50: warning: comment on exported function SystemEventInvariants should be of the form "SystemEventInvariants ..." (golint)
    • origin/test/extended/images/image_layers_mocks.go
    • Line 16: warning: comment on exported const BaseImageWith1LayerDigest should be of the form "BaseImageWith1LayerDigest ..." (golint)
    • Line 18: warning: exported const BaseImageWith1Layer should have comment or be unexported (golint)
    • Line 41: warning: comment on exported const BaseImageWith2LayersDigest should be of the form "BaseImageWith2LayersDigest ..." (golint)
    • Line 43: warning: exported const BaseImageWith2Layers should have comment or be unexported (golint)
    • Line 72: warning: comment on exported const ChildImageWith2LayersDigest should be of the form "ChildImageWith2LayersDigest ..." (golint)
    • Line 74: warning: exported const ChildImageWith2Layers should have comment or be unexported (golint)
    • Line 109: warning: comment on exported const ChildImageWith3LayersDigest should be of the form "ChildImageWith3LayersDigest ..." (golint)
    • Line 111: warning: exported const ChildImageWith3Layers should have comment or be unexported (golint)
    • Line 152: warning: comment on exported const MiscImageDigest should be of the form "MiscImageDigest ..." (golint)
    • Line 154: warning: exported const MiscImage should have comment or be unexported (golint)
    • origin/test/extended/images/imagestream_admission.go
    • Line 51: warning: exported function TestImageStreamTagsAdmission should have comment or be unexported (golint)
    • Line 235: warning: exported function TestImageStreamAdmitSpecUpdate should have comment or be unexported (golint)
    • Line 367: warning: exported function TestImageStreamAdmitStatusUpdate should have comment or be unexported (golint)
    • origin/pkg/monitor/types.go
    • Line 9: warning: exported type IntervalCreationFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type SamplerFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type Interface should have comment or be unexported (golint)
    • Line 18: warning: exported type Recorder should have comment or be unexported (golint)
    • origin/test/extended/util/oauthserver/helpers.go
    • Line 28: warning: exported function GetRawExtensionForOsinProvider should have comment or be unexported (golint)
    • Line 36: warning: exported function GetUserForToken should have comment or be unexported (golint)
    • Line 52: warning: exported function GetDirPathFromConfigMapSecretName should have comment or be unexported (golint)
    • Line 56: warning: exported function GetPathFromConfigMapSecretName should have comment or be unexported (golint)
    • origin/test/extended/util/jenkins/ref.go
    • Line 29: warning: exported const UseLocalPluginSnapshotEnvVarName should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: don't use underscores in Go names; struct field uri_tester should be uriTester (golint)
    • Line 188: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 201: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 347: warning: comment on exported function FindJenkinsPod should be of the form "FindJenkinsPod ..." (golint)
    • Line 399: warning: comment on exported function SetupSnapshotImage should be of the form "SetupSnapshotImage ..." (golint)
    • Line 442: warning: exported function ProcessLogURLAnnotations should have comment or be unexported (golint)
    • Line 467: warning: exported function DumpLogs should have comment or be unexported (golint)
    • origin/pkg/monitor/monitorapi/identification.go
    • Line 9: warning: exported function E2ETestLocator should have comment or be unexported (golint)
    • Line 13: warning: exported function IsE2ETest should have comment or be unexported (golint)
    • Line 18: warning: exported function E2ETestFromLocator should have comment or be unexported (golint)
    • Line 31: warning: exported function NodeLocator should have comment or be unexported (golint)
    • Line 35: warning: exported function IsNode should have comment or be unexported (golint)
    • Line 40: warning: exported function NodeFromLocator should have comment or be unexported (golint)
    • Line 48: warning: exported function OperatorLocator should have comment or be unexported (golint)
    • Line 52: warning: exported function IsOperator should have comment or be unexported (golint)
    • Line 57: warning: exported function OperatorFromLocator should have comment or be unexported (golint)
    • origin/pkg/test/ginkgo/junit.go
    • Line 21: warning: comment on exported type JUnitTestSuites should be of the form "JUnitTestSuites ..." (with optional leading article) (golint)
    • Line 29: warning: comment on exported type JUnitTestSuite should be of the form "JUnitTestSuite ..." (with optional leading article) (golint)
    • Line 115: warning: exported const TestResultPass should have comment (or a comment on this block) or be unexported (golint)
    • origin/test/extended/operators/oc_copy.go
    • Line 11: warning: exported type CincinnatiMetadata should have comment or be unexported (golint)
    • Line 20: warning: exported type ReleaseDiff should have comment or be unexported (golint)
    • Line 28: warning: exported type ImageReferenceDiff should have comment or be unexported (golint)
    • Line 35: warning: exported type ReleaseManifestDiff should have comment or be unexported (golint)
    • Line 42: warning: exported type ReleaseInfo should have comment or be unexported (golint)
    • Line 64: warning: exported type Image should have comment or be unexported (golint)
    • origin/test/extended/util/jenkins/monitor.go
    • Line 27: warning: exported const EnableJenkinsMemoryStats should have comment (or a comment on this block) or be unexported (golint)
    • Line 78: warning: exported function StartJenkinsGCTracking should have comment or be unexported (golint)
    • Line 94: warning: exported function StartJenkinsMemoryTracking should have comment or be unexported (golint)
    • origin/pkg/test/ginkgo/podanalysis.go
    • Line 19: warning: exported type PodElement should have comment or be unexported (golint)
    • Line 34: warning: exported method PodElement.KindOwnerKey should have comment or be unexported (golint)
    • Line 38: warning: exported method PodElement.UniqueKey should have comment or be unexported (golint)
    • Line 42: warning: exported function NewPodCollector should have comment or be unexported (golint)
    • Line 49: warning: exported function SetupNewPodCollector should have comment or be unexported (golint)
    • Line 65: warning: exported type Edge should have comment or be unexported (golint)
    • Line 69: warning: exported type PodDisplacements should have comment or be unexported (golint)
    • Line 71: warning: exported method PodDisplacements.Dump should have comment or be unexported (golint)
    • Line 91: warning: exported type PodCollector should have comment or be unexported (golint)
    • Line 118: warning: exported method PodCollector.Setup should have comment or be unexported (golint)
    • Line 144: warning: exported method PodCollector.Run should have comment or be unexported (golint)
    • Line 148: warning: exported method PodCollector.SetEvents should have comment or be unexported (golint)
    • Line 152: warning: exported method PodCollector.JsonDump should have comment or be unexported (golint)
    • Line 157: warning: exported method PodCollector.Import should have comment or be unexported (golint)
    • Line 161: warning: exported method PodCollector.Record should have comment or be unexported (golint)
    • Line 168: warning: exported method PodCollector.ComputePodTransitions should have comment or be unexported (golint)
    • Line 258: warning: exported method PodCollector.PodDisplacements should have comment or be unexported (golint)
    • origin/test/extended/topology_manager/resourcealign.go
    • Line 514: warning: exported type ContainerParams should have comment or be unexported (golint)
    • Line 521: warning: exported type PodParams should have comment or be unexported (golint)
    • Line 525: warning: exported method PodParams.TotalCpuRequest should have comment or be unexported (golint)
    • Line 533: warning: exported method PodParams.TotalDeviceRequest should have comment or be unexported (golint)
    • Line 541: warning: exported method PodParams.MakeSleepingPod should have comment or be unexported (golint)
    • Line 588: warning: exported type PodParamsList should have comment or be unexported (golint)
    • Line 590: warning: exported method PodParamsList.MakePods should have comment or be unexported (golint)
    • Line 598: warning: exported method PodParamsList.TotalCpuRequest should have comment or be unexported (golint)
    • Line 606: warning: exported method PodParamsList.TotalDeviceRequest should have comment or be unexported (golint)
    • origin/test/extended/builds/webhook.go
    • Line 41: warning: exported function TestWebhook should have comment or be unexported (golint)
    • Line 118: warning: exported function TestWebhookGitHubPushWithImage should have comment or be unexported (golint)
    • Line 208: warning: exported function TestWebhookGitHubPushWithImageStream should have comment or be unexported (golint)
    • Line 289: warning: exported function TestWebhookGitHubPing should have comment or be unexported (golint)
    • origin/test/extended/images/hardprune.go
    • Line 340: warning: exported const AcceptSchema2EnvVar should have comment (or a comment on this block) or be unexported (golint)
    • Line 350: warning: comment on exported type RegistryConfiguration should be of the form "RegistryConfiguration ..." (with optional leading article) (golint)
    • Line 438: warning: exported function RedeployRegistry should have comment or be unexported (golint)
    • origin/test/extended/images/imagechange_buildtrigger.go
    • Line 55: warning: exported function TestSimpleImageChangeBuildTriggerFromImageStreamTagSTI should have comment or be unexported (golint)
    • Line 63: warning: exported function TestSimpleImageChangeBuildTriggerFromImageStreamTagSTIWithConfigChange should have comment or be unexported (golint)
    • Line 71: warning: exported function TestSimpleImageChangeBuildTriggerFromImageStreamTagDocker should have comment or be unexported (golint)
    • Line 79: warning: exported function TestSimpleImageChangeBuildTriggerFromImageStreamTagDockerWithConfigChange should have comment or be unexported (golint)
    • Line 87: warning: exported function TestSimpleImageChangeBuildTriggerFromImageStreamTagCustom should have comment or be unexported (golint)
    • Line 118: warning: exported function TestSimpleImageChangeBuildTriggerFromImageStreamTagCustomWithConfigChange should have comment or be unexported (golint)
    • Line 385: warning: exported function TestMultipleImageChangeBuildTriggers should have comment or be unexported (golint)
    • origin/test/e2e/upgrade/upgrade.go
    • Line 93: warning: exported function SetUpgradeDisruptReboot should have comment or be unexported (golint)
    • Line 524: warning: comment on exported function IsPoolUpdated should be of the form "IsPoolUpdated ..." (golint)
    • origin/test/extended/util/url/url.go
    • Line 29: warning: exported type Tester should have comment or be unexported (golint)
    • Line 36: warning: exported function NewTester should have comment or be unexported (golint)
    • Line 40: warning: exported method Tester.Close should have comment or be unexported (golint)
    • Line 47: warning: exported method Tester.Response should have comment or be unexported (golint)
    • Line 58: warning: exported method Tester.Responses should have comment or be unexported (golint)
    • Line 103: warning: exported method Tester.WithErrorPassthrough should have comment or be unexported (golint)
    • Line 108: warning: exported method Tester.Podname should have comment or be unexported (golint)
    • Line 112: warning: exported method Tester.Within should have comment or be unexported (golint)
    • Line 227: warning: exported type Response should have comment or be unexported (golint)
    • Line 239: warning: exported type CURL should have comment or be unexported (golint)
    • Line 243: warning: exported type Test should have comment or be unexported (golint)
    • Line 256: warning: exported function Expect should have comment or be unexported (golint)
    • Line 266: warning: exported method Test.WithBodyToUpload should have comment or be unexported (golint)
    • Line 273: warning: exported method Test.WithToken should have comment or be unexported (golint)
    • Line 277: warning: exported method Test.WithHeader should have comment or be unexported (golint)
    • Line 282: warning: exported method Test.Through should have comment or be unexported (golint)
    • Line 288: warning: exported method Test.HasStatusCode should have comment or be unexported (golint)
    • Line 300: warning: exported method Test.RedirectsTo should have comment or be unexported (golint)
    • Line 315: warning: exported method Test.SkipTLSVerification should have comment or be unexported (golint)
    • Line 320: warning: exported method Test.Test should have comment or be unexported (golint)
    • Line 337: warning: exported method Test.ToShell should have comment or be unexported (golint)
    • origin/test/extended/util/oauthserver/tokencmd/multi.go
    • Line 30: warning: exported function NewMultiHandler should have comment or be unexported (golint)
    • Line 37: warning: exported method MultiHandler.CanHandle should have comment or be unexported (golint)
    • Line 53: warning: exported method MultiHandler.HandleChallenge should have comment or be unexported (golint)
    • Line 90: warning: exported method MultiHandler.CompleteChallenge should have comment or be unexported (golint)
    • Line 97: warning: exported method MultiHandler.Release should have comment or be unexported (golint)
    • origin/pkg/monitor/sampler.go
    • Line 11: warning: exported type ConditionalSampler should have comment or be unexported (golint)
    • Line 26: warning: exported function NewSampler should have comment or be unexported (golint)
    • origin/test/extended/networking/util.go
    • Line 29: warning: should not use dot imports (golint)
    • Line 30: warning: should not use dot imports (golint)
    • Line 33: warning: exported type NodeType should have comment or be unexported (golint)
    • Line 47: warning: comment on exported const SAME_NODE should be of the form "SAME_NODE ..." (golint)
    • Line 49: warning: exported const DIFFERENT_NODE should have comment (or a comment on this block) or be unexported (golint)
    • Line 292: warning: exported function InNonIsolatingContext should have comment or be unexported (golint)
    • Line 304: warning: exported function InIsolatingContext should have comment or be unexported (golint)
    • Line 316: warning: exported function InNetworkPolicyContext should have comment or be unexported (golint)
    • Line 328: warning: exported function InPluginContext should have comment or be unexported (golint)
    • Line 349: warning: exported function InOpenShiftSDNContext should have comment or be unexported (golint)
    • origin/test/extended/util/disruption/controlplane/controlplane.go
    • Line 53: warning: comment on exported function NewOpenShiftAvailableWithConnectionReuseTest should be of the form "NewOpenShiftAvailableWithConnectionReuseTest ..." (golint)
    • Line 62: warning: comment on exported function NewOAuthAvailableWithConnectionReuseTest should be of the form "NewOAuthAvailableWithConnectionReuseTest ..." (golint)
    • origin/test/extended/images/imagestream.go
    • Line 43: warning: exported function TestImageStreamMappingCreate should have comment or be unexported (golint)
    • Line 198: warning: exported function TestImageStreamWithoutDockerImageConfig should have comment or be unexported (golint)
    • Line 260: warning: exported function TestImageStreamTagLifecycleHook should have comment or be unexported (golint)
    • origin/test/extended/util/client.go
    • Line 346: warning: comment on exported method CLI.CreateProject should be of the form "CreateProject ..." (golint)
    • Line 401: warning: exported method CLI.RESTMapper should have comment or be unexported (golint)
    • Line 407: warning: exported method CLI.AppsClient should have comment or be unexported (golint)
    • Line 411: warning: exported method CLI.AuthorizationClient should have comment or be unexported (golint)
    • Line 415: warning: exported method CLI.BuildClient should have comment or be unexported (golint)
    • Line 419: warning: exported method CLI.ImageClient should have comment or be unexported (golint)
    • Line 423: warning: exported method CLI.ProjectClient should have comment or be unexported (golint)
    • Line 427: warning: exported method CLI.QuotaClient should have comment or be unexported (golint)
    • Line 431: warning: exported method CLI.RouteClient should have comment or be unexported (golint)
    • Line 435: warning: exported method CLI.TemplateClient should have comment or be unexported (golint)
    • Line 439: warning: exported method CLI.AdminAppsClient should have comment or be unexported (golint)
    • Line 443: warning: exported method CLI.AdminAuthorizationClient should have comment or be unexported (golint)
    • Line 447: warning: exported method CLI.AdminBuildClient should have comment or be unexported (golint)
    • Line 451: warning: exported method CLI.AdminConfigClient should have comment or be unexported (golint)
    • Line 455: warning: exported method CLI.AdminImageClient should have comment or be unexported (golint)
    • Line 459: warning: exported method CLI.AdminOauthClient should have comment or be unexported (golint)
    • Line 463: warning: exported method CLI.AdminOperatorClient should have comment or be unexported (golint)
    • Line 467: warning: exported method CLI.AdminProjectClient should have comment or be unexported (golint)
    • Line 471: warning: exported method CLI.AdminQuotaClient should have comment or be unexported (golint)
    • Line 475: warning: exported method CLI.AdminOAuthClient should have comment or be unexported (golint)
    • Line 479: warning: exported method CLI.AdminRouteClient should have comment or be unexported (golint)
    • Line 483: warning: exported method CLI.AdminUserClient should have comment or be unexported (golint)
    • Line 487: warning: exported method CLI.AdminSecurityClient should have comment or be unexported (golint)
    • Line 491: warning: exported method CLI.AdminTemplateClient should have comment or be unexported (golint)
    • Line 500: warning: exported method CLI.DynamicClient should have comment or be unexported (golint)
    • Line 509: warning: exported method CLI.AdminDynamicClient should have comment or be unexported (golint)
    • Line 513: warning: exported method CLI.UserConfig should have comment or be unexported (golint)
    • Line 521: warning: exported method CLI.AdminConfig should have comment or be unexported (golint)
    • Line 588: warning: exported type ExitError should have comment or be unexported (golint)
    • Line 688: warning: exported method CLI.AddExplicitResourceToDelete should have comment or be unexported (golint)
    • Line 692: warning: exported method CLI.AddResourceToDelete should have comment or be unexported (golint)
    • Line 696: warning: exported method CLI.CreateUser should have comment or be unexported (golint)
    • Line 708: warning: exported method CLI.GetClientConfigForUser should have comment or be unexported (golint)
    • Line 782: warning: exported method CLI.WaitForAccessAllowed should have comment or be unexported (golint)
    • Line 794: warning: exported method CLI.WaitForAccessDenied should have comment or be unexported (golint)
    • Line 863: warning: exported function IsFIPS should have comment or be unexported (golint)
    • origin/test/extended/util/volumes.go
    • Line 12: warning: exported function DeletePVCsForDeployment should have comment or be unexported (golint)
    • Line 30: warning: exported function DumpPersistentVolumeInfo should have comment or be unexported (golint)
    • origin/test/extended/deployments/util.go
    • Line 545: warning: exported function DeploymentConfigFailureTrap should have comment or be unexported (golint)
    • Line 635: warning: comment on exported function HasValidDCControllerRef should be of the form "HasValidDCControllerRef ..." (golint)
    • Line 655: warning: exported function NewDeployerPodInvariantChecker should have comment or be unexported (golint)
    • Line 817: warning: exported function ReadFixture should have comment or be unexported (golint)
    • Line 831: warning: exported function ReadFixtureOrFail should have comment or be unexported (golint)
    • origin/test/extended/util/router.go
    • Line 15: warning: exported function WaitForRouterInternalIP should have comment or be unexported (golint)
    • Line 42: warning: exported function WaitForRouterServiceIP should have comment or be unexported (golint)
    • origin/test/extended/cluster/metrics/metrics.go
    • Line 10: warning: don't use underscores in Go names; const marker_name should be markerName (golint)
    • Line 13: warning: exported type Metrics should have comment or be unexported (golint)
    • Line 17: warning: exported type BaseMetrics should have comment or be unexported (golint)
    • Line 25: warning: exported type TestDuration should have comment or be unexported (golint)
    • Line 32: warning: exported type StepDuration should have comment or be unexported (golint)
    • Line 35: warning: exported type BaseStepDuration should have comment or be unexported (golint)
    • Line 41: warning: exported type TemplateStepDuration should have comment or be unexported (golint)
    • Line 50: warning: exported type PodStepDuration should have comment or be unexported (golint)
    • Line 66: warning: exported function LogMetrics should have comment or be unexported (golint)
    • Line 76: warning: exported function NewTestDuration should have comment or be unexported (golint)
    • Line 88: warning: exported function NewTemplateStepDuration should have comment or be unexported (golint)
    • Line 99: warning: exported function NewPodStepDuration should have comment or be unexported (golint)
    • origin/tools/buildanalyzer/cmd/buildanalyzer.go
    • Line 18: warning: exported type BuildAnalyzerOptions should have comment or be unexported (golint)
    • Line 38: warning: exported function NewBuildAnalyzerCommand should have comment or be unexported (golint)
    • Line 81: warning: exported method BuildAnalyzerOptions.Run should have comment or be unexported (golint)
    • origin/test/extended/util/framework.go
    • Line 381: warning: exported function DumpSampleOperator should have comment or be unexported (golint)
    • Line 418: warning: exported function GetStatefulSetPods should have comment or be unexported (golint)
    • Line 462: warning: comment on exported function DumpPodLogsStartingWithInNamespace should be of the form "DumpPodLogsStartingWithInNamespace ..." (golint)
    • Line 480: warning: exported function DumpPodLogs should have comment or be unexported (golint)
    • Line 545: warning: exported function PreTestDump should have comment or be unexported (golint)
    • Line 636: warning: exported type LogDumperFunc should have comment or be unexported (golint)
    • Line 638: warning: exported function NewBuildResult should have comment or be unexported (golint)
    • Line 646: warning: exported type BuildResult should have comment or be unexported (golint)
    • Line 802: warning: comment on exported method BuildResult.AssertSuccess should be of the form "AssertSuccess ..." (golint)
    • Line 811: warning: comment on exported method BuildResult.AssertFailure should be of the form "AssertFailure ..." (golint)
    • Line 820: warning: exported function StartBuildResult should have comment or be unexported (golint)
    • Line 1239: warning: exported function WaitForAJob should have comment or be unexported (golint)
    • Line 1596: warning: exported function WaitForEndpoint should have comment or be unexported (golint)
    • Line 1798: warning: exported type GitRepo should have comment or be unexported (golint)
    • Line 1912: warning: exported function FindRouterImage should have comment or be unexported (golint)
    • Line 1926: warning: exported function IsClusterOperated should have comment or be unexported (golint)
    • origin/test/extended/templates/openservicebroker/api/types.go
    • Line 13: warning: exported const XBrokerAPIVersion should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported type Service should have comment or be unexported (golint)
    • Line 32: warning: exported type DashboardClient should have comment or be unexported (golint)
    • Line 38: warning: exported type Plan should have comment or be unexported (golint)
    • Line 48: warning: exported type Schema should have comment or be unexported (golint)
    • Line 53: warning: exported type ServiceInstances should have comment or be unexported (golint)
    • Line 58: warning: exported type ServiceBindings should have comment or be unexported (golint)
    • Line 68: warning: exported type ParameterSchema should have comment or be unexported (golint)
    • Line 72: warning: exported type OpenShiftMetadata should have comment or be unexported (golint)
    • Line 76: warning: exported type CatalogResponse should have comment or be unexported (golint)
    • Line 80: warning: exported type LastOperationResponse should have comment or be unexported (golint)
    • Line 85: warning: exported type LastOperationState should have comment or be unexported (golint)
    • Line 88: warning: exported const LastOperationStateInProgress should have comment (or a comment on this block) or be unexported (golint)
    • Line 93: warning: exported type ProvisionRequest should have comment or be unexported (golint)
    • Line 102: warning: exported type KubernetesContext should have comment or be unexported (golint)
    • Line 107: warning: exported const ContextPlatformKubernetes should have comment or be unexported (golint)
    • Line 109: warning: exported type ProvisionResponse should have comment or be unexported (golint)
    • Line 114: warning: exported type Operation should have comment or be unexported (golint)
    • Line 116: warning: exported type UpdateRequest should have comment or be unexported (golint)
    • Line 129: warning: exported type UpdateResponse should have comment or be unexported (golint)
    • Line 133: warning: exported type BindRequest should have comment or be unexported (golint)
    • Line 144: warning: exported type BindResponse should have comment or be unexported (golint)
    • Line 151: warning: exported type UnbindResponse should have comment or be unexported (golint)
    • Line 154: warning: exported type DeprovisionResponse should have comment or be unexported (golint)
    • Line 158: warning: exported type ErrorResponse should have comment or be unexported (golint)
    • Line 163: warning: exported var AsyncRequired should have comment or be unexported (golint)
    • Line 168: warning: exported var ConcurrencyError should have comment or be unexported (golint)
    • Line 176: warning: exported const ServiceMetadataDisplayName should have comment (or a comment on this block) or be unexported (golint)
    • Line 186: warning: exported type Response should have comment or be unexported (golint)
    • Line 192: warning: exported type Broker should have comment or be unexported (golint)
    • Line 202: warning: exported const OperationProvisioning should have comment (or a comment on this block) or be unexported (golint)
    • origin/test/extended/include.go
    • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 10: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • origin/test/extended/util/oauthserver/tokencmd/basicauth.go
    • Line 14: warning: exported type BasicChallengeHandler should have comment or be unexported (golint)
    • Line 34: warning: exported method BasicChallengeHandler.CanHandle should have comment or be unexported (golint)
    • Line 38: warning: exported method BasicChallengeHandler.HandleChallenge should have comment or be unexported (golint)
    • Line 74: warning: exported method BasicChallengeHandler.CompleteChallenge should have comment or be unexported (golint)
    • Line 78: warning: exported method BasicChallengeHandler.Release should have comment or be unexported (golint)
    • origin/cmd/openshift-tests/storagecaps.go
    • Line 14: warning: exported type StorageClass should have comment or be unexported (golint)
    • Line 18: warning: exported type SnapshotClass should have comment or be unexported (golint)
    • Line 22: warning: exported type Capabilities should have comment or be unexported (golint)
    • Line 38: warning: exported type DriverInfo should have comment or be unexported (golint)
    • Line 43: warning: exported type YamlManifest should have comment or be unexported (golint)
    • origin/pkg/monitor/api.go
    • Line 28: warning: exported const LocatorKubeAPIServerNewConnection should have comment (or a comment on this block) or be unexported (golint)
    • Line 91: warning: exported function StartServerMonitoringWithNewConnections should have comment or be unexported (golint)
    • Line 95: warning: exported function StartServerMonitoringWithConnectionReuse should have comment or be unexported (golint)
    • Line 185: warning: exported function StartKubeAPIMonitoringWithNewConnections should have comment or be unexported (golint)
    • Line 190: warning: exported function StartOpenShiftAPIMonitoringWithNewConnections should have comment or be unexported (golint)
    • Line 195: warning: exported function StartOAuthAPIMonitoringWithNewConnections should have comment or be unexported (golint)
    • Line 200: warning: exported function StartKubeAPIMonitoringWithConnectionReuse should have comment or be unexported (golint)
    • Line 205: warning: exported function StartOpenShiftAPIMonitoringWithConnectionReuse should have comment or be unexported (golint)
    • Line 210: warning: exported function StartOAuthAPIMonitoringWithConnectionReuse should have comment or be unexported (golint)
    • Line 285: warning: exported function NewErrorRecordingListWatcher should have comment or be unexported (golint)
    • origin/tools/junitreport/pkg/cmd/junitreport.go
    • Line 35: warning: exported type JUnitReportOptions should have comment or be unexported (golint)
    • Line 57: warning: exported method JUnitReportOptions.Complete should have comment or be unexported (golint)
    • Line 81: warning: exported method JUnitReportOptions.Run should have comment or be unexported (golint)
    • origin/pkg/monitor/intervalcreation/operator.go
    • Line 11: warning: exported function IntervalsFromEvents_OperatorAvailable should have comment or be unexported (golint)
    • Line 11: warning: don't use underscores in Go names; func IntervalsFromEvents_OperatorAvailable should be IntervalsFromEventsOperatorAvailable (golint)
    • Line 15: warning: exported function IntervalsFromEvents_OperatorProgressing should have comment or be unexported (golint)
    • Line 15: warning: don't use underscores in Go names; func IntervalsFromEvents_OperatorProgressing should be IntervalsFromEventsOperatorProgressing (golint)
    • Line 19: warning: exported function IntervalsFromEvents_OperatorDegraded should have comment or be unexported (golint)
    • Line 19: warning: don't use underscores in Go names; func IntervalsFromEvents_OperatorDegraded should be IntervalsFromEventsOperatorDegraded (golint)
    • Line 23: warning: don't use underscores in Go names; func intervalsFromEvents_OperatorStatus should be intervalsFromEventsOperatorStatus (golint)
    • origin/pkg/monitor/intervalcreation/node.go
    • Line 18: warning: exported function IntervalsFromEvents_NodeChanges should have comment or be unexported (golint)
    • Line 18: warning: don't use underscores in Go names; func IntervalsFromEvents_NodeChanges should be IntervalsFromEventsNodeChanges (golint)
    • origin/test/extended/authorization/authorization.go
    • Line 1002: warning: exported function AddUserToRoleInProject should have comment or be unexported (golint)
    • Line 1027: warning: exported function AddUserAdminToProject should have comment or be unexported (golint)
    • Line 1031: warning: exported function AddUserEditToProject should have comment or be unexported (golint)
    • Line 1035: warning: exported function AddUserViewToProject should have comment or be unexported (golint)
    • origin/test/extended/builds/controllers.go
    • Line 143: warning: exported function RunImageChangeTriggerTest should have comment or be unexported (golint)
    • Line 326: warning: exported function RunBuildDeleteTest should have comment or be unexported (golint)
    • Line 392: warning: exported function RunBuildRunningPodDeleteTest should have comment or be unexported (golint)
    • Line 489: warning: exported function RunBuildCompletePodDeleteTest should have comment or be unexported (golint)
    • Line 553: warning: exported function RunBuildConfigChangeControllerTest should have comment or be unexported (golint)
    • origin/pkg/synthetictests/operator_mapping.go
    • Line 11: warning: exported var ValidBugzillaComponents should have comment or be unexported (golint)
    • Line 87: warning: comment on exported var KnownOperators should be of the form "KnownOperators ..." (golint)
    • Line 164: warning: exported function GetBugzillaComponentForOperator should have comment or be unexported (golint)
    • origin/pkg/monitor/serialization/serialize.go
    • Line 14: warning: comment on exported type EventInterval should be of the form "EventInterval ..." (with optional leading article) (golint)
    • Line 25: warning: comment on exported type EventIntervalList should be of the form "EventIntervalList ..." (with optional leading article) (golint)
    • Line 30: warning: exported function EventsToFile should have comment or be unexported (golint)
    • Line 38: warning: exported function EventsFromFile should have comment or be unexported (golint)
    • Line 67: warning: exported function EventsToJSON should have comment or be unexported (golint)
    • Line 78: warning: exported function EventsIntervalsToFile should have comment or be unexported (golint)
    • Line 86: warning: exported function EventsIntervalsToJSON should have comment or be unexported (golint)
    • origin/pkg/monitor/monitorapi/types.go
    • Line 11: warning: exported type EventLevel should have comment or be unexported (golint)
    • Line 14: warning: exported const Info should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported function EventLevelFromString should have comment or be unexported (golint)
    • Line 46: warning: exported type Condition should have comment or be unexported (golint)
    • Line 53: warning: exported type EventInterval should have comment or be unexported (golint)
    • Line 71: warning: exported type IntervalFilter should have comment or be unexported (golint)
    • Line 73: warning: exported type IntervalFilters should have comment or be unexported (golint)
    • Line 75: warning: exported method IntervalFilters.All should have comment or be unexported (golint)
    • Line 84: warning: exported method IntervalFilters.Any should have comment or be unexported (golint)
    • Line 93: warning: exported function HasDuration should have comment or be unexported (golint)
    • Line 95: warning: exported type Intervals should have comment or be unexported (golint)
    • origin/test/extended/controller_manager/deployment_mock.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 10: warning: exported const ImageStreamName should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported function OkDeploymentConfig should have comment or be unexported (golint)
    • Line 84: warning: exported function OkImageChangeTrigger should have comment or be unexported (golint)
    • origin/pkg/monitor/resourcewatch/storage/git_store.go
    • Line 25: warning: exported type GitStorage should have comment or be unexported (golint)
    • Line 97: warning: exported method GitStorage.OnAdd should have comment or be unexported (golint)
    • Line 102: warning: exported method GitStorage.OnUpdate should have comment or be unexported (golint)
    • Line 107: warning: exported method GitStorage.OnDelete should have comment or be unexported (golint)
    • origin/pkg/test/ginkgo/ginkgo.go
    • Line 39: warning: exported type MinimalReporter should have comment or be unexported (golint)
    • Line 46: warning: exported function NewMinimalReporter should have comment or be unexported (golint)
    • Line 53: warning: exported method MinimalReporter.Fail should have comment or be unexported (golint)
    • Line 56: warning: exported method MinimalReporter.Summary should have comment or be unexported (golint)
    • Line 60: warning: exported method MinimalReporter.SpecSuiteWillBegin should have comment or be unexported (golint)
    • Line 63: warning: exported method MinimalReporter.BeforeSuiteDidRun should have comment or be unexported (golint)
    • Line 67: warning: exported method MinimalReporter.SpecWillRun should have comment or be unexported (golint)
    • Line 70: warning: exported method MinimalReporter.SpecDidComplete should have comment or be unexported (golint)
    • Line 83: warning: exported method MinimalReporter.AfterSuiteDidRun should have comment or be unexported (golint)
    • Line 86: warning: exported method MinimalReporter.SpecSuiteDidEnd should have comment or be unexported (golint)
    • origin/test/extended/util/test.go
    • Line 46: warning: exported var TestContext should have comment or be unexported (golint)
    • Line 48: warning: exported function InitStandardFlags should have comment or be unexported (golint)
    • Line 56: warning: exported function InitTest should have comment or be unexported (golint)
    • Line 100: warning: exported function ExecuteTest should have comment or be unexported (golint)
    • origin/test/extended/util/oauthserver/tokencmd/negotiate.go
    • Line 34: warning: exported function NewNegotiateChallengeHandler should have comment or be unexported (golint)
    • Line 38: warning: exported method NegotiateChallengeHandler.CanHandle should have comment or be unexported (golint)
    • Line 50: warning: exported method NegotiateChallengeHandler.HandleChallenge should have comment or be unexported (golint)
    • Line 70: warning: exported method NegotiateChallengeHandler.CompleteChallenge should have comment or be unexported (golint)
    • Line 97: warning: exported method NegotiateChallengeHandler.Release should have comment or be unexported (golint)
    • origin/test/extended/util/reporter.go
    • Line 18: warning: exported type SimpleReporter should have comment or be unexported (golint)
    • Line 23: warning: exported function NewSimpleReporter should have comment or be unexported (golint)
    • Line 30: warning: exported method SimpleReporter.SpecSuiteWillBegin should have comment or be unexported (golint)
    • Line 34: warning: exported method SimpleReporter.BeforeSuiteDidRun should have comment or be unexported (golint)
    • Line 37: warning: exported method SimpleReporter.SpecWillRun should have comment or be unexported (golint)
    • Line 41: warning: exported method SimpleReporter.SpecDidComplete should have comment or be unexported (golint)
    • Line 46: warning: exported method SimpleReporter.AfterSuiteDidRun should have comment or be unexported (golint)
    • Line 49: warning: exported method SimpleReporter.SpecSuiteDidEnd should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign91%

IneffAssign detects ineffectual assignments in Go code.

    • origin/test/extended/builds/start.go
    • Line 132: warning: ineffectual assignment to err (ineffassign)
    • Line 149: warning: ineffectual assignment to err (ineffassign)
    • Line 164: warning: ineffectual assignment to err (ineffassign)
    • Line 187: warning: ineffectual assignment to err (ineffassign)
    • Line 201: warning: ineffectual assignment to err (ineffassign)
    • Line 215: warning: ineffectual assignment to err (ineffassign)
    • Line 235: warning: ineffectual assignment to err (ineffassign)
    • Line 252: warning: ineffectual assignment to err (ineffassign)
    • Line 262: warning: ineffectual assignment to err (ineffassign)
    • Line 267: warning: ineffectual assignment to err (ineffassign)
    • Line 274: warning: ineffectual assignment to err (ineffassign)
    • Line 286: warning: ineffectual assignment to err (ineffassign)
    • Line 405: warning: ineffectual assignment to err (ineffassign)
    • Line 427: warning: ineffectual assignment to err (ineffassign)
    • Line 517: warning: ineffectual assignment to err (ineffassign)

misspell95%

Misspell Finds commonly misspelled English words

    • origin/test/extended/builds/hooks.go
    • Line 53: warning: "successfuly" is a misspelling of "successfully" (misspell)
    • Line 60: warning: "successfuly" is a misspelling of "successfully" (misspell)
    • Line 127: warning: "successfuly" is a misspelling of "successfully" (misspell)
    • Line 134: warning: "successfuly" is a misspelling of "successfully" (misspell)