Go Report Card

Preparing report...

Report for github.com/oracle/cluster-manager

A    Great!    Found 17 issues across 21 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint19%

Golint is a linter for Go source code.

    • cluster-manager/pkg/controller/cluster/provider/oke/okebmc.go
    • Line 42: warning: exported const ProviderName should have comment (or a comment on this block) or be unexported (golint)
    • Line 60: warning: comment on exported type OkeBmcConfig should be of the form "OkeBmcConfig ..." (with optional leading article) (golint)
    • Line 103: warning: exported type Oke should have comment or be unexported (golint)
    • Line 112: warning: exported function NewOke should have comment or be unexported (golint)
    • Line 138: warning: exported method Oke.GetProviderName should have comment or be unexported (golint)
    • Line 142: warning: exported method Oke.CreateKubeCluster should have comment or be unexported (golint)
    • Line 223: warning: exported type OkeKubeConfig should have comment or be unexported (golint)
    • Line 234: warning: exported type OkeCluster should have comment or be unexported (golint)
    • Line 239: warning: exported type OkeContext should have comment or be unexported (golint)
    • Line 244: warning: exported type OkeUser should have comment or be unexported (golint)
    • Line 249: warning: exported method Oke.ExportKubeConfig should have comment or be unexported (golint)
    • Line 269: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 300: warning: exported method Oke.DeleteKubeCluster should have comment or be unexported (golint)
    • Line 311: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 318: warning: comment on exported method Oke.ScaleKubeCluster should be of the form "ScaleKubeCluster ..." (golint)
    • Line 399: warning: exported method Oke.ValidateKubeCluster should have comment or be unexported (golint)
    • Line 455: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cluster-manager/pkg/controller/cluster/util/cluster_annotation.go
    • Line 19: warning: comment on exported type ClusterAnnotation should be of the form "ClusterAnnotation ..." (with optional leading article) (golint)
    • Line 26: warning: exported method ClusterAnnotation.SetAnnotation should have comment or be unexported (golint)
    • Line 33: warning: exported method ClusterAnnotation.DeleteAnnotation should have comment or be unexported (golint)
    • Line 37: warning: exported method ClusterAnnotation.ApplyAnnotation should have comment or be unexported (golint)
    • cluster-manager/pkg/controller/cluster/util/secret.go
    • Line 28: warning: exported type SecretToolSetInterface should have comment or be unexported (golint)
    • Line 34: warning: exported const KubeconfigSecretDataKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported function CreateKubeconfigSecret should have comment or be unexported (golint)
    • Line 69: warning: exported function DeleteKubeconfigSecret should have comment or be unexported (golint)
    • Line 73: warning: exported function Write should have comment or be unexported (golint)
    • cluster-manager/cmd/controller/main.go
    • Line 35: warning: exported var Version should have comment or be unexported (golint)
    • Line 62: warning: exported function Run should have comment or be unexported (golint)
    • Line 83: warning: exported function StartController should have comment or be unexported (golint)
    • cluster-manager/pkg/controller/cluster/clustercontroller.go
    • Line 51: warning: exported const ClusterManagerName should have comment (or a comment on this block) or be unexported (golint)
    • Line 314: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 344: warning: exported type ClusterController should have comment or be unexported (golint)
    • Line 447: warning: exported method ClusterController.SubmitClusterForProvisioning should have comment or be unexported (golint)
    • cluster-manager/pkg/controller/cluster/provider/kopsAws/kops.go
    • Line 19: warning: don't use MixedCaps in package name; kopsAws should be kopsaws (golint)
    • Line 49: warning: exported const ProviderName should have comment (or a comment on this block) or be unexported (golint)
    • Line 63: warning: comment on exported type AWSKopsConfig should be of the form "AWSKopsConfig ..." (with optional leading article) (golint)
    • Line 148: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 153: warning: exported function NewAwsKops should have comment or be unexported (golint)
    • Line 179: warning: exported type Kops should have comment or be unexported (golint)
    • Line 191: warning: comment on exported method Kops.CreateKubeCluster should be of the form "CreateKubeCluster ..." (golint)
    • Line 213: warning: exported method Kops.GetProviderName should have comment or be unexported (golint)
    • Line 217: warning: exported method Kops.ExportKubeConfig should have comment or be unexported (golint)
    • Line 227: warning: exported method Kops.ExportKubeConfigBuilder should have comment or be unexported (golint)
    • Line 453: warning: exported method Kops.DeleteKubeCluster should have comment or be unexported (golint)
    • Line 542: warning: comment on exported method Kops.ScaleKubeCluster should be of the form "ScaleKubeCluster ..." (golint)
    • Line 607: warning: exported method Kops.ValidateKubeCluster should have comment or be unexported (golint)
    • Line 629: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • cluster-manager/pkg/controller/cluster/util/secret_toolset.go
    • Line 29: warning: exported type SecretToolSet should have comment or be unexported (golint)
    • Line 33: warning: exported function NewSecretToolSet should have comment or be unexported (golint)
    • Line 49: warning: exported method SecretToolSet.CreateSecret should have comment or be unexported (golint)
    • Line 53: warning: exported method SecretToolSet.DeleteSecret should have comment or be unexported (golint)
    • cluster-manager/pkg/common/test/util.go
    • Line 28: warning: comment on exported function CallerfunctionName should be of the form "CallerfunctionName ..." (golint)
    • Line 34: warning: comment on exported function GetFunctionName should be of the form "GetFunctionName ..." (golint)
    • Line 39: warning: comment on exported function CheckExecutionSequence should be of the form "CheckExecutionSequence ..." (golint)
    • Line 57: warning: comment on exported function CheckIfFunctionHasError should be of the form "CheckIfFunctionHasError ..." (golint)
    • Line 78: warning: exported function VerifyExecutionSequenceCompleted should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!