Preparing report...

Report for github.com/pion/ion

A+    Excellent!    Found 19 issues across 39 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint53%

Golint is a linter for Go source code.

    • ion/pkg/error/code.go
    • Line 3: warning: exported type Code should have comment or be unexported (golint)
    • Line 16: warning: exported const Ok should have comment (or a comment on this block) or be unexported (golint)
    • ion/pkg/db/redis.go
    • Line 17: warning: exported type Config should have comment or be unexported (golint)
    • Line 23: warning: exported type Redis should have comment or be unexported (golint)
    • Line 29: warning: exported function NewRedis should have comment or be unexported (golint)
    • Line 70: warning: exported method Redis.Close should have comment or be unexported (golint)
    • Line 79: warning: exported method Redis.Set should have comment or be unexported (golint)
    • Line 88: warning: exported method Redis.Get should have comment or be unexported (golint)
    • Line 97: warning: exported method Redis.HSet should have comment or be unexported (golint)
    • Line 106: warning: exported method Redis.HGet should have comment or be unexported (golint)
    • Line 115: warning: exported method Redis.HMSet should have comment or be unexported (golint)
    • Line 124: warning: exported method Redis.HMGet should have comment or be unexported (golint)
    • Line 133: warning: exported method Redis.HGetAll should have comment or be unexported (golint)
    • Line 142: warning: exported method Redis.HDel should have comment or be unexported (golint)
    • Line 151: warning: exported method Redis.Expire should have comment or be unexported (golint)
    • Line 161: warning: exported method Redis.HSetTTL should have comment or be unexported (golint)
    • Line 176: warning: exported method Redis.HMSetTTL should have comment or be unexported (golint)
    • Line 192: warning: exported method Redis.Keys should have comment or be unexported (golint)
    • Line 201: warning: exported method Redis.Del should have comment or be unexported (golint)
    • ion/apps/room/server/room_signal.go
    • Line 20: warning: comment on exported function NewRoomSignalService should be of the form "NewRoomSignalService ..." (golint)
    • Line 28: warning: exported method RoomSignalService.Signal should have comment or be unexported (golint)
    • Line 98: warning: exported method RoomSignalService.Join should have comment or be unexported (golint)
    • Line 211: warning: exported method RoomSignalService.Leave should have comment or be unexported (golint)
    • Line 257: warning: exported method RoomSignalService.SendMessage should have comment or be unexported (golint)
    • ion/pkg/node/signal/signal.go
    • Line 66: warning: exported type Signal should have comment or be unexported (golint)
    • Line 73: warning: exported function NewSignal should have comment or be unexported (golint)
    • Line 94: warning: exported method Signal.Start should have comment or be unexported (golint)
    • Line 129: warning: exported method Signal.Director should have comment or be unexported (golint)
    • Line 179: warning: exported method Signal.Close should have comment or be unexported (golint)
    • ion/pkg/node/sfu/service.go
    • Line 31: warning: exported type SFUService should have comment or be unexported (golint)
    • Line 38: warning: exported function NewSFUService should have comment or be unexported (golint)
    • Line 49: warning: exported method SFUService.RegisterService should have comment or be unexported (golint)
    • Line 53: warning: exported method SFUService.Close should have comment or be unexported (golint)
    • Line 57: warning: exported method SFUService.BroadcastTrackEvent should have comment or be unexported (golint)
    • Line 79: warning: exported method SFUService.Signal should have comment or be unexported (golint)
    • ion/apps/room/server/room_service.go
    • Line 20: warning: exported type RoomService should have comment or be unexported (golint)
    • Line 28: warning: exported function NewRoomService should have comment or be unexported (golint)
    • Line 38: warning: exported method RoomService.Close should have comment or be unexported (golint)
    • ion/pkg/auth/claims.go
    • Line 5: warning: comment on exported type Claims should be of the form "Claims ..." (with optional leading article) (golint)
    • ion/pkg/proto/proto.go
    • Line 4: warning: exported const ServiceALL should have comment (or a comment on this block) or be unexported (golint)
    • ion/apps/room/server/room.go
    • Line 53: warning: exported method Config.Load should have comment or be unexported (golint)
    • Line 91: warning: exported type RoomServer should have comment or be unexported (golint)
    • Line 215: warning: exported method RoomServer.Close should have comment or be unexported (golint)
    • Line 215: warning: receiver name s should be consistent with previous receiver name r for RoomServer (golint)
    • Line 230: warning: comment on exported method Room.Name should be of the form "Name ..." (golint)
    • ion/pkg/util/grpc.go
    • Line 19: warning: comment on exported function NewGRPCClientConnForNode should be of the form "NewGRPCClientConnForNode ..." (golint)
    • ion/pkg/util/util.go
    • Line 14: warning: exported const DefaultStatCycle should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported function GetRedisRoomKey should have comment or be unexported (golint)
    • Line 43: warning: exported function GetRedisPeerKey should have comment or be unexported (golint)
    • Line 47: warning: exported function GetRedisPeersPrefixKey should have comment or be unexported (golint)
    • Line 51: warning: exported function GetArgs should have comment or be unexported (golint)
    • Line 86: warning: exported function BoolToString should have comment or be unexported (golint)
    • Line 93: warning: exported function StringToBool should have comment or be unexported (golint)
    • ion/pkg/error/error.go
    • Line 11: warning: comment on exported function NewGrpcIonError should be of the form "NewGrpcIonError ..." (golint)
    • Line 23: warning: exported function ParseGrpcIonError should have comment or be unexported (golint)
    • ion/pkg/node/islb/registry.go
    • Line 14: warning: exported type Registry should have comment or be unexported (golint)
    • Line 22: warning: exported function NewRegistry should have comment or be unexported (golint)
    • Line 48: warning: exported method Registry.Close should have comment or be unexported (golint)
    • ion/pkg/node/sfu/sfu.go
    • Line 53: warning: exported method Config.Load should have comment or be unexported (golint)
    • Line 113: warning: exported method SFU.ConfigBase should have comment or be unexported (golint)
    • ion/pkg/util/wrapped.go
    • Line 16: warning: exported type WrapperedServerOptions should have comment or be unexported (golint)
    • Line 27: warning: exported function DefaultWrapperedServerOptions should have comment or be unexported (golint)
    • Line 40: warning: exported function NewWrapperedServerOptions should have comment or be unexported (golint)
    • Line 53: warning: exported type WrapperedGRPCWebServer should have comment or be unexported (golint)
    • Line 58: warning: exported function NewWrapperedGRPCWebServer should have comment or be unexported (golint)
    • Line 109: warning: exported method WrapperedGRPCWebServer.Serve should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell94%

Misspell Finds commonly misspelled English words