Preparing report...

Report for github.com/plasma-umass/systemgo

A+    Excellent!    Found 30 issues across 49 files

Tweet

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint44%

Golint is a linter for Go source code.

    • systemgo/unit/service/service.go
    • Line 14: warning: exported const DEFAULT_TYPE should have comment or be unexported (golint)
    • Line 44: warning: comment on exported type Unit should be of the form "Unit ..." (with optional leading article) (golint)
    • Line 50: warning: comment on exported type Definition should be of the form "Definition ..." (with optional leading article) (golint)
    • Line 64: warning: exported function Supported should have comment or be unexported (golint)
    • systemgo/unit/status.go
    • Line 5: warning: exported type Status should have comment or be unexported (golint)
    • Line 11: warning: exported type ActivationStatus should have comment or be unexported (golint)
    • Line 15: warning: exported type LoadStatus should have comment or be unexported (golint)
    • systemgo/system/state.go
    • Line 3: warning: comment on exported type State should be of the form "State ..." (with optional leading article) (golint)
    • Line 9: warning: exported const Initializing should have comment (or a comment on this block) or be unexported (golint)
    • systemgo/system/unit.go
    • Line 14: warning: exported var ErrIsStarting should have comment or be unexported (golint)
    • Line 16: warning: exported type Unit should have comment or be unexported (golint)
    • Line 68: warning: exported method Unit.IsDead should have comment or be unexported (golint)
    • Line 71: warning: exported method Unit.IsActive should have comment or be unexported (golint)
    • Line 74: warning: exported method Unit.IsActivating should have comment or be unexported (golint)
    • Line 77: warning: exported method Unit.IsDeactivating should have comment or be unexported (golint)
    • Line 80: warning: exported method Unit.IsReloading should have comment or be unexported (golint)
    • Line 84: warning: exported method Unit.IsLoaded should have comment or be unexported (golint)
    • Line 94: warning: exported method Unit.Active should have comment or be unexported (golint)
    • Line 109: warning: exported method Unit.Sub should have comment or be unexported (golint)
    • systemgo/system/log.go
    • Line 10: warning: comment on exported const BUFFER_SIZE should be of the form "BUFFER_SIZE ..." (golint)
    • Line 50: warning: exported method Log.Len should have comment or be unexported (golint)
    • Line 54: warning: exported method Log.Cap should have comment or be unexported (golint)
    • systemgo/systemctl/rpc.go
    • Line 10: warning: exported type Response should have comment or be unexported (golint)
    • Line 24: warning: exported function NewServer should have comment or be unexported (golint)
    • Line 28: warning: exported type Server should have comment or be unexported (golint)
    • Line 32: warning: exported method Server.Start should have comment or be unexported (golint)
    • Line 36: warning: exported method Server.Stop should have comment or be unexported (golint)
    • Line 40: warning: exported method Server.Restart should have comment or be unexported (golint)
    • Line 44: warning: exported method Server.Isolate should have comment or be unexported (golint)
    • Line 48: warning: exported method Server.Reload should have comment or be unexported (golint)
    • Line 52: warning: exported method Server.Enable should have comment or be unexported (golint)
    • Line 56: warning: exported method Server.Disable should have comment or be unexported (golint)
    • Line 60: warning: exported method Server.Status should have comment or be unexported (golint)
    • Line 78: warning: exported method Server.StatusAll should have comment or be unexported (golint)
    • systemgo/unit/errors.go
    • Line 8: warning: exported var ErrNotSet should have comment or be unexported (golint)
    • Line 9: warning: exported var ErrNotExist should have comment or be unexported (golint)
    • Line 10: warning: exported var ErrNotSupported should have comment or be unexported (golint)
    • Line 11: warning: exported var ErrUnknownType should have comment or be unexported (golint)
    • Line 12: warning: exported var ErrPathNotAbs should have comment or be unexported (golint)
    • Line 13: warning: exported var ErrNotParsed should have comment or be unexported (golint)
    • Line 14: warning: exported var ErrWrongVal should have comment or be unexported (golint)
    • Line 15: warning: exported var ErrNotStarted should have comment or be unexported (golint)
    • Line 17: warning: exported type ParseError should have comment or be unexported (golint)
    • Line 22: warning: exported function ParseErr should have comment or be unexported (golint)
    • Line 33: warning: exported type MultiError should have comment or be unexported (golint)
    • Line 35: warning: exported method MultiError.Errors should have comment or be unexported (golint)
    • systemgo/config/config.go
    • Line 14: warning: exported const DEFAULT_PORT should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: comment on exported var Target should be of the form "Target ..." (golint)
    • Line 33: warning: comment on exported var Debug should be of the form "Debug ..." (golint)
    • systemgo/unit/interfaces.go
    • Line 5: warning: exported type Interface should have comment or be unexported (golint)
    • Line 15: warning: exported type Definer should have comment or be unexported (golint)
    • Line 46: warning: exported type Dependency should have comment or be unexported (golint)
    • systemgo/system/errors.go
    • Line 5: warning: exported var ErrIsDir should have comment or be unexported (golint)
    • Line 6: warning: exported var ErrNotDir should have comment or be unexported (golint)
    • Line 7: warning: exported var ErrNotFound should have comment or be unexported (golint)
    • Line 8: warning: exported var ErrDepFail should have comment or be unexported (golint)
    • Line 9: warning: exported var ErrDepConflict should have comment or be unexported (golint)
    • Line 10: warning: exported var ErrNotLoaded should have comment or be unexported (golint)
    • Line 11: warning: exported var ErrNoReload should have comment or be unexported (golint)
    • Line 12: warning: exported var ErrUnknownType should have comment or be unexported (golint)
    • Line 13: warning: exported var ErrNotActive should have comment or be unexported (golint)
    • Line 14: warning: exported var ErrExists should have comment or be unexported (golint)
    • Line 15: warning: exported var ErrNotImplemented should have comment or be unexported (golint)
    • Line 16: warning: exported var ErrUnmergeable should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell95%

Misspell Finds commonly misspelled English words