Go Report Card

Preparing report...

Report for github.com/pydio/cells-client

A+    Excellent!    Found 20 issues across 59 files

Tweet
Last refresh:

Refresh now

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint74%

Golint is a linter for Go source code.

    • cells-client/cmd/files_ls.go
    • Line 250: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 262: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cells-client/v2/rest/files.go
    • Line 23: warning: exported function GetS3Client should have comment or be unexported (golint)
    • Line 35: warning: exported function GetFile should have comment or be unexported (golint)
    • Line 60: warning: exported function PutFile should have comment or be unexported (golint)
    • Line 107: warning: exported function StatNode should have comment or be unexported (golint)
    • Line 119: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 125: warning: exported function ListNodesPath should have comment or be unexported (golint)
    • Line 149: warning: exported function DeleteNode should have comment or be unexported (golint)
    • Line 180: warning: exported function GetBulkMetaNode should have comment or be unexported (golint)
    • Line 197: warning: exported function TreeCreateNodes should have comment or be unexported (golint)
    • cells-client/v2/rest/jobs.go
    • Line 13: warning: exported function MoveParams should have comment or be unexported (golint)
    • Line 20: warning: exported function RenameParams should have comment or be unexported (golint)
    • Line 24: warning: exported function CopyParams should have comment or be unexported (golint)
    • Line 28: warning: exported function BuildParams should have comment or be unexported (golint)
    • Line 43: warning: exported function CopyJob should have comment or be unexported (golint)
    • Line 47: warning: exported function MoveJob should have comment or be unexported (golint)
    • cells-client/rest/clients.go
    • Line 23: warning: exported var DefaultConfig should have comment or be unexported (golint)
    • Line 27: warning: exported var KeyClientKey should have its own declaration (golint)
    • Line 30: warning: exported var KeyS3Region should have its own declaration (golint)
    • Line 33: warning: exported function DefaultConfigFilePath should have comment or be unexported (golint)
    • cells-client/v2/rest/clients.go
    • Line 86: warning: exported function GetConfigFilePath should have comment or be unexported (golint)
    • Line 93: warning: exported function SetConfigFilePath should have comment or be unexported (golint)
    • Line 97: warning: exported function DefaultConfigDirPath should have comment or be unexported (golint)
    • Line 110: warning: exported function DefaultConfigFilePath should have comment or be unexported (golint)
    • Line 120: warning: exported function RefreshAndStoreIfRequired should have comment or be unexported (golint)
    • cells-client/v2/rest/updater.go
    • Line 31: warning: exported type UpdateRequest should have comment or be unexported (golint)
    • Line 48: warning: exported type UpdatePackage should have comment or be unexported (golint)
    • Line 88: warning: exported type UpdateResponse should have comment or be unexported (golint)
    • Line 94: warning: exported function LoadUpdates should have comment or be unexported (golint)
    • Line 166: warning: exported function ApplyUpdate should have comment or be unexported (golint)
    • Line 175: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cells-client/v2/rest/utils.go
    • Line 58: warning: exported function CleanURL should have comment or be unexported (golint)
    • Line 68: warning: exported function IsForbiddenError should have comment or be unexported (golint)
    • cells-client/rest/files.go
    • Line 16: warning: exported function GetS3Client should have comment or be unexported (golint)
    • Line 24: warning: exported function GetFile should have comment or be unexported (golint)
    • Line 49: warning: exported function PutFile should have comment or be unexported (golint)
    • Line 93: warning: exported function StatNode should have comment or be unexported (golint)
    • Line 105: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • cells-client/v2/rest/walker.go
    • Line 20: warning: exported var DryRun should have comment or be unexported (golint)
    • Line 39: warning: exported function NewCrawler should have comment or be unexported (golint)
    • Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 83: warning: exported function NewTarget should have comment or be unexported (golint)
    • Line 195: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 330: warning: exported method CrawlNode.Join should have comment or be unexported (golint)
    • Line 342: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 347: warning: exported method CrawlNode.Base should have comment or be unexported (golint)
    • Line 350: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 355: warning: exported method CrawlNode.Dir should have comment or be unexported (golint)
    • Line 358: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 363: warning: exported type BarsPool should have comment or be unexported (golint)
    • Line 369: warning: exported function NewBarsPool should have comment or be unexported (golint)
    • Line 380: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 388: warning: exported method BarsPool.Done should have comment or be unexported (golint)
    • Line 399: warning: exported method BarsPool.Get should have comment or be unexported (golint)
    • Line 422: warning: exported type PgReader should have comment or be unexported (golint)
    • Line 435: warning: exported method PgReader.CreateErrorChan should have comment or be unexported (golint)
    • Line 478: warning: exported method PgReader.Seek should have comment or be unexported (golint)

gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell86%

Misspell Finds commonly misspelled English words