Report for github.com/qri-io/qfs
A+ Excellent! Found 22 issues across 46 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo91%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
qfs/qipfs/filestore.go
- Line 58: warning: cyclomatic complexity 16 of function NewFilesystem() is high (> 15) (gocyclo)
-
-
qfs/qipfs/go-ipfs-files/file_test.go
- Line 82: warning: cyclomatic complexity 40 of function TestMultipartFiles() is high (> 15) (gocyclo)
-
-
qfs/qipfs/go-ipfs-files/multifilereader_test.go
- Line 11: warning: cyclomatic complexity 36 of function TestOutput() is high (> 15) (gocyclo)
-
-
qfs/write_hooks.go
- Line 87: warning: cyclomatic complexity 21 of function WriteWithHooks() is high (> 15) (gocyclo)
golint63%
Golint is a linter for Go source code.
-
-
qfs/qipfs/go-ipfs-files/readerfile.go
- Line 20: warning: exported function NewReaderFile should have comment or be unexported (golint)
- Line 24: warning: exported function NewReaderPathFile should have comment or be unexported (golint)
- Line 33: warning: exported method ReaderFile.IsDirectory should have comment or be unexported (golint)
- Line 37: warning: exported method ReaderFile.NextFile should have comment or be unexported (golint)
- Line 41: warning: exported method ReaderFile.FileName should have comment or be unexported (golint)
- Line 45: warning: exported method ReaderFile.FullPath should have comment or be unexported (golint)
- Line 49: warning: exported method ReaderFile.AbsPath should have comment or be unexported (golint)
- Line 57: warning: exported method ReaderFile.Close should have comment or be unexported (golint)
- Line 61: warning: exported method ReaderFile.Stat should have comment or be unexported (golint)
- Line 65: warning: exported method ReaderFile.Size should have comment or be unexported (golint)
-
-
qfs/qipfs/go-ipfs-files/slicefile.go
- Line 18: warning: exported function NewSliceFile should have comment or be unexported (golint)
- Line 22: warning: exported method SliceFile.IsDirectory should have comment or be unexported (golint)
- Line 26: warning: exported method SliceFile.NextFile should have comment or be unexported (golint)
- Line 35: warning: exported method SliceFile.FileName should have comment or be unexported (golint)
- Line 39: warning: exported method SliceFile.FullPath should have comment or be unexported (golint)
- Line 47: warning: exported method SliceFile.Close should have comment or be unexported (golint)
- Line 51: warning: exported method SliceFile.Peek should have comment or be unexported (golint)
- Line 55: warning: exported method SliceFile.Length should have comment or be unexported (golint)
- Line 59: warning: exported method SliceFile.Size should have comment or be unexported (golint)
-
-
qfs/file.go
- Line 94: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
qfs/mem.go
- Line 71: warning: exported method MemFS.IsContentAddressedFilesystem should have comment or be unexported (golint)
-
-
qfs/qipfs/go-ipfs-files/multipartfile.go
- Line 32: warning: exported function NewFileFromPart should have comment or be unexported (golint)
- Line 69: warning: exported method MultipartFile.IsDirectory should have comment or be unexported (golint)
- Line 73: warning: exported method MultipartFile.NextFile should have comment or be unexported (golint)
- Line 89: warning: exported method MultipartFile.FileName should have comment or be unexported (golint)
- Line 102: warning: exported method MultipartFile.FullPath should have comment or be unexported (golint)
- Line 113: warning: exported method MultipartFile.Close should have comment or be unexported (golint)
-
-
qfs/qipfs/go-ipfs-files/file.go
- Line 10: warning: exported var ErrNotDirectory should have comment or be unexported (golint)
- Line 40: warning: exported type StatFile should have comment or be unexported (golint)
- Line 46: warning: exported type PeekFile should have comment or be unexported (golint)
- Line 53: warning: exported type SizeFile should have comment or be unexported (golint)
- Line 59: warning: exported type FileInfo should have comment or be unexported (golint)
-
-
qfs/qipfs/go-ipfs-files/is_hidden.go
- Line 10: warning: exported function IsHidden should have comment or be unexported (golint)
-
-
qfs/qipfs/qipfs_http/filestore.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 22: warning: exported type Filestore should have comment or be unexported (golint)
- Line 60: warning: exported method Filestore.IPFSCoreAPI should have comment or be unexported (golint)
- Line 79: warning: exported method Filestore.Has should have comment or be unexported (golint)
- Line 89: warning: exported method Filestore.Get should have comment or be unexported (golint)
- Line 93: warning: exported method Filestore.Fetch should have comment or be unexported (golint)
- Line 97: warning: exported method Filestore.Put should have comment or be unexported (golint)
- Line 106: warning: exported method Filestore.Delete should have comment or be unexported (golint)
- Line 133: warning: exported method Filestore.NewAdder should have comment or be unexported (golint)
- Line 149: warning: exported method Filestore.Pin should have comment or be unexported (golint)
- Line 153: warning: exported method Filestore.Unpin should have comment or be unexported (golint)
-
-
qfs/qipfs/qipfs_http/filestore_test.go
- Line 1: warning: don't use an underscore in package name (golint)
-
-
qfs/httpfs/httpfs.go
- Line 86: warning: receiver name https should be consistent with previous receiver name httpfs for FS (golint)
-
-
qfs/qipfs/go-ipfs-files/linkfile.go
- Line 9: warning: exported type Symlink should have comment or be unexported (golint)
- Line 18: warning: exported function NewLinkFile should have comment or be unexported (golint)
- Line 28: warning: exported method Symlink.IsDirectory should have comment or be unexported (golint)
- Line 32: warning: exported method Symlink.NextFile should have comment or be unexported (golint)
- Line 36: warning: exported method Symlink.FileName should have comment or be unexported (golint)
- Line 36: warning: receiver name f should be consistent with previous receiver name lf for Symlink (golint)
- Line 40: warning: exported method Symlink.Close should have comment or be unexported (golint)
- Line 40: warning: receiver name f should be consistent with previous receiver name lf for Symlink (golint)
- Line 44: warning: exported method Symlink.FullPath should have comment or be unexported (golint)
- Line 44: warning: receiver name f should be consistent with previous receiver name lf for Symlink (golint)
- Line 48: warning: receiver name f should be consistent with previous receiver name lf for Symlink (golint)
-
-
qfs/cafs/test/test.go
- Line 14: warning: exported function EnsureFilestoreBehavior should have comment or be unexported (golint)
- Line 24: warning: exported function EnsureFilestoreSingleFileBehavior should have comment or be unexported (golint)
- Line 74: warning: exported function EnsureDirectoryBehavior should have comment or be unexported (golint)
- Line 125: warning: exported function EnsureFilestoreAdderBehavior should have comment or be unexported (golint)
-
-
qfs/qipfs/filestore.go
- Line 41: warning: exported type Filestore should have comment or be unexported (golint)
- Line 206: warning: exported method Filestore.Online should have comment or be unexported (golint)
- Line 210: warning: exported method Filestore.GoOnline should have comment or be unexported (golint)
- Line 244: warning: exported method Filestore.Has should have comment or be unexported (golint)
- Line 252: warning: exported method Filestore.Get should have comment or be unexported (golint)
- Line 256: warning: exported method Filestore.Fetch should have comment or be unexported (golint)
- Line 270: warning: exported method Filestore.Delete should have comment or be unexported (golint)
- Line 306: warning: exported method Adder.AddFile should have comment or be unexported (golint)
- Line 311: warning: exported method Adder.Added should have comment or be unexported (golint)
- Line 315: warning: exported method Adder.Finalize should have comment or be unexported (golint)
- Line 332: warning: exported method Filestore.NewAdder should have comment or be unexported (golint)
- Line 462: warning: exported method Filestore.Pin should have comment or be unexported (golint)
- Line 466: warning: exported method Filestore.Unpin should have comment or be unexported (golint)
-
-
qfs/qipfs/coreunix/add.go
- Line 57: warning: exported type Link should have comment or be unexported (golint)
- Line 62: warning: exported type Object should have comment or be unexported (golint)
- Line 200: warning: comment on exported method Adder.PinRoot should be of the form "PinRoot ..." (golint)
- Line 481: warning: exported method Adder.AddFile should have comment or be unexported (golint)
-
-
qfs/cafs/castore.go
- Line 1: warning: package comment should be of the form "Package cafs ..." (golint)
-
-
qfs/qipfs/coreunix/metadata.go
- Line 14: warning: exported function AddMetadataTo should have comment or be unexported (golint)
- Line 44: warning: exported function Metadata should have comment or be unexported (golint)
-
-
qfs/qipfs/go-ipfs-files/serialfile.go
- Line 25: warning: exported function NewSerialFile should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell93%
Misspell Finds commonly misspelled English words
-
-
qfs/qipfs/http_api.go
- Line 22: warning: "apparantly" is a misspelling of "apparently" (misspell)
-
-
qfs/cafs/castore.go
- Line 97: warning: "immideately" is a misspelling of "immediately" (misspell)
-
-
qfs/qipfs/filestore_test.go
- Line 73: warning: "occured" is a misspelling of "occurred" (misspell)