gofmt92%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• internal/identifier/parseable.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/roy/gen.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/sf/longpath.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/wikidata/wikidata_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/sf/wikidata_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/siegreader/mmap_unix.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/config/archivematica.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/config/brew.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/config/default.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/config/identifier_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/sf/fpr.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/sf/profile.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/wikidata/wikidata_provenance.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• internal/bytematcher/identify.go
  • Line 27: warning: cyclomatic complexity 44 of function (*Matcher).identify() is high (> 15) (gocyclo)

• pkg/loc/identifier.go
  • Line 243: warning: cyclomatic complexity 23 of function (*Recorder).Report() is high (> 15) (gocyclo)
  • Line 132: warning: cyclomatic complexity 17 of function (*Recorder).Record() is high (> 15) (gocyclo)

• pkg/mimeinfo/mimeinfo.go
  • Line 290: warning: cyclomatic complexity 22 of function toPattern() is high (> 15) (gocyclo)
  • Line 126: warning: cyclomatic complexity 16 of function (mimeinfo).Infos() is high (> 15) (gocyclo)

• internal/riffmatcher/riffmatcher.go
  • Line 134: warning: cyclomatic complexity 21 of function (Matcher).Identify() is high (> 15) (gocyclo)

• internal/bytematcher/frames/frames.go
  • Line 272: warning: cyclomatic complexity 17 of function (Frame).Linked() is high (> 15) (gocyclo)

• cmd/sf/sf.go
  • Line 303: warning: cyclomatic complexity 60 of function main() is high (> 15) (gocyclo)

• cmd/roy/roy.go
  • Line 326: warning: cyclomatic complexity 45 of function getOptions() is high (> 15) (gocyclo)
  • Line 514: warning: cyclomatic complexity 41 of function main() is high (> 15) (gocyclo)

• pkg/pronom/parse.go
  • Line 239: warning: cyclomatic complexity 27 of function appendFragments() is high (> 15) (gocyclo)
  • Line 413: warning: cyclomatic complexity 26 of function processGroup() is high (> 15) (gocyclo)
  • Line 67: warning: cyclomatic complexity 20 of function processPRONOM() is high (> 15) (gocyclo)
  • Line 178: warning: cyclomatic complexity 16 of function processSubSequence() is high (> 15) (gocyclo)

• internal/bytematcher/process.go
  • Line 25: warning: cyclomatic complexity 22 of function (*Matcher).addSignature() is high (> 15) (gocyclo)

• pkg/wikidata/wikidata_signature_processing.go
  • Line 193: warning: cyclomatic complexity 20 of function preValidateSignatures() is high (> 15) (gocyclo)

• internal/identifier/base.go
  • Line 307: warning: cyclomatic complexity 19 of function (*Base).Add() is high (> 15) (gocyclo)

• internal/containermatcher/identify.go
  • Line 181: warning: cyclomatic complexity 18 of function (*ContainerMatcher).processHits() is high (> 15) (gocyclo)

• internal/persist/persist.go
  • Line 338: warning: cyclomatic complexity 17 of function makeInts() is high (> 15) (gocyclo)

• siegfried.go
  • Line 306: warning: cyclomatic complexity 56 of function (*Siegfried).IdentifyBuffer() is high (> 15) (gocyclo)
  • Line 543: warning: cyclomatic complexity 16 of function (*Siegfried).Inspect() is high (> 15) (gocyclo)

• cmd/sf/serve.go
  • Line 52: warning: cyclomatic complexity 31 of function parseRequest() is high (> 15) (gocyclo)

• pkg/pronom/identifier.go
  • Line 242: warning: cyclomatic complexity 26 of function (*Recorder).Report() is high (> 15) (gocyclo)
  • Line 119: warning: cyclomatic complexity 17 of function (*Recorder).Record() is high (> 15) (gocyclo)

• pkg/mimeinfo/identifier.go
  • Line 200: warning: cyclomatic complexity 26 of function (*Recorder).Report() is high (> 15) (gocyclo)

• internal/bytematcher/scorer.go
  • Line 203: warning: cyclomatic complexity 82 of function (*Matcher).scorer() is high (> 15) (gocyclo)

• internal/identifier/parseable.go
  • Line 53: warning: cyclomatic complexity 29 of function inspect() is high (> 15) (gocyclo)

• pkg/mimeinfo/pattern_test.go
  • Line 245: warning: cyclomatic complexity 22 of function TestMask() is high (> 15) (gocyclo)

• cmd/sf/update.go
  • Line 98: warning: cyclomatic complexity 18 of function updateSigs() is high (> 15) (gocyclo)

• internal/logger/logger.go
  • Line 51: warning: cyclomatic complexity 18 of function New() is high (> 15) (gocyclo)
  • Line 163: warning: cyclomatic complexity 17 of function (*Logger).IDs() is high (> 15) (gocyclo)

• pkg/config/identifier.go
  • Line 68: warning: cyclomatic complexity 28 of function Details() is high (> 15) (gocyclo)

• internal/bytematcher/keyframes.go
  • Line 419: warning: cyclomatic complexity 24 of function checkRelated() is high (> 15) (gocyclo)
  • Line 213: warning: cyclomatic complexity 23 of function updatePositions() is high (> 15) (gocyclo)
  • Line 385: warning: cyclomatic complexity 16 of function checkRelatedKF() is high (> 15) (gocyclo)

golint65%

Golint is a linter for Go source code.

• internal/containermatcher/identify.go
  • Line 27: warning: exported method Matcher.Identify should have comment or be unexported (golint)

• internal/identifier/parseable.go
  • Line 181: warning: exported method Blank.IDs should have comment or be unexported (golint)
  • Line 182: warning: exported method Blank.Infos should have comment or be unexported (golint)
  • Line 183: warning: exported method Blank.Globs should have comment or be unexported (golint)
  • Line 184: warning: exported method Blank.MIMEs should have comment or be unexported (golint)
  • Line 185: warning: exported method Blank.XMLs should have comment or be unexported (golint)
  • Line 186: warning: exported method Blank.Signatures should have comment or be unexported (golint)
  • Line 187: warning: exported method Blank.Zips should have comment or be unexported (golint)
  • Line 188: warning: exported method Blank.MSCFBs should have comment or be unexported (golint)
  • Line 189: warning: exported method Blank.RIFFs should have comment or be unexported (golint)
  • Line 190: warning: exported method Blank.Texts should have comment or be unexported (golint)
  • Line 191: warning: exported method Blank.Priorities should have comment or be unexported (golint)
  • Line 581: warning: exported function ApplyConfig should have comment or be unexported (golint)

• pkg/pronom/internal/mappings/report.go
  • Line 24: warning: exported type Report should have comment or be unexported (golint)
  • Line 38: warning: exported type Signature should have comment or be unexported (golint)
  • Line 53: warning: exported type ByteSequence should have comment or be unexported (golint)
  • Line 75: warning: exported type RelatedFormat should have comment or be unexported (golint)
  • Line 89: warning: exported method Report.Superiors should have comment or be unexported (golint)
  • Line 99: warning: exported method Report.Subordinates should have comment or be unexported (golint)
  • Line 109: warning: exported type FormatIdentifier should have comment or be unexported (golint)
  • Line 114: warning: exported method Report.MIME should have comment or be unexported (golint)
  • Line 123: warning: exported method Report.Label should have comment or be unexported (golint)

• internal/siegreader/siegreader.go
  • Line 40: warning: exported var ErrEmpty should have comment or be unexported (golint)

• pkg/sets/sets.go
  • Line 202: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• pkg/config/loc.go
  • Line 49: warning: exported function ZipLOC should have comment or be unexported (golint)
  • Line 53: warning: exported function NoPRONOM should have comment or be unexported (golint)
  • Line 57: warning: exported function SetNoPRONOM should have comment or be unexported (golint)
  • Line 64: warning: exported function SetLOC should have comment or be unexported (golint)

• internal/persist/persist.go
  • Line 24: warning: exported type LoadSaver should have comment or be unexported (golint)
  • Line 30: warning: exported function NewLoadSaver should have comment or be unexported (golint)
  • Line 41: warning: exported method LoadSaver.Bytes should have comment or be unexported (golint)
  • Line 89: warning: exported method LoadSaver.LoadByte should have comment or be unexported (golint)
  • Line 97: warning: exported method LoadSaver.SaveByte should have comment or be unexported (golint)
  • Line 101: warning: exported method LoadSaver.LoadBool should have comment or be unexported (golint)
  • Line 109: warning: exported method LoadSaver.SaveBool should have comment or be unexported (golint)
  • Line 128: warning: exported method LoadSaver.LoadBoolField should have comment or be unexported (golint)
  • Line 157: warning: exported method LoadSaver.SaveBoolField should have comment or be unexported (golint)
  • Line 186: warning: exported method LoadSaver.LoadTinyInt should have comment or be unexported (golint)
  • Line 194: warning: exported method LoadSaver.SaveTinyInt should have comment or be unexported (golint)
  • Line 202: warning: exported method LoadSaver.LoadTinyUInt should have comment or be unexported (golint)
  • Line 206: warning: exported method LoadSaver.SaveTinyUInt should have comment or be unexported (golint)
  • Line 214: warning: exported method LoadSaver.LoadSmallInt should have comment or be unexported (golint)
  • Line 226: warning: exported method LoadSaver.SaveSmallInt should have comment or be unexported (golint)
  • Line 236: warning: exported method LoadSaver.LoadInt should have comment or be unexported (golint)
  • Line 248: warning: exported method LoadSaver.SaveInt should have comment or be unexported (golint)
  • Line 390: warning: exported method LoadSaver.LoadInts should have comment or be unexported (golint)
  • Line 394: warning: exported method LoadSaver.SaveInts should have comment or be unexported (golint)
  • Line 398: warning: exported method LoadSaver.LoadBigInts should have comment or be unexported (golint)
  • Line 410: warning: exported method LoadSaver.SaveBigInts should have comment or be unexported (golint)
  • Line 418: warning: exported method LoadSaver.LoadBytes should have comment or be unexported (golint)
  • Line 422: warning: exported method LoadSaver.SaveBytes should have comment or be unexported (golint)
  • Line 426: warning: exported method LoadSaver.LoadString should have comment or be unexported (golint)
  • Line 430: warning: exported method LoadSaver.SaveString should have comment or be unexported (golint)
  • Line 434: warning: exported method LoadSaver.LoadStrings should have comment or be unexported (golint)
  • Line 446: warning: exported method LoadSaver.SaveStrings should have comment or be unexported (golint)
  • Line 453: warning: exported method LoadSaver.SaveTime should have comment or be unexported (golint)
  • Line 462: warning: exported method LoadSaver.LoadTime should have comment or be unexported (golint)
  • Line 469: warning: exported method LoadSaver.SaveFourCC should have comment or be unexported (golint)
  • Line 473: warning: exported method LoadSaver.LoadFourCC should have comment or be unexported (golint)

• internal/bytematcher/frames/machine.go
  • Line 47: warning: exported method Machine.Test should have comment or be unexported (golint)
  • Line 75: warning: exported method Machine.TestR should have comment or be unexported (golint)
  • Line 103: warning: exported method Machine.Equals should have comment or be unexported (golint)
  • Line 116: warning: exported method Machine.Length should have comment or be unexported (golint)
  • Line 128: warning: comment on exported method Machine.NumSequences should be of the form "NumSequences ..." (golint)
  • Line 130: warning: exported method Machine.Sequences should have comment or be unexported (golint)
  • Line 143: warning: exported method Machine.Save should have comment or be unexported (golint)

• pkg/config/multi.go
  • Line 21: warning: exported const Single should have comment (or a comment on this block) or be unexported (golint)

• cmd/sf/update.go
  • Line 35: warning: exported type Update should have comment or be unexported (golint)

• cmd/sf/sf.go
  • Line 76: warning: exported type ModeError should have comment or be unexported (golint)
  • Line 97: warning: exported type WalkError should have comment or be unexported (golint)

• pkg/pronom/patterns.go
  • Line 15: warning: package comment should be of the form "Package pronom ..." (golint)
  • Line 33: warning: exported type Range should have comment or be unexported (golint)
  • Line 37: warning: exported method Range.Test should have comment or be unexported (golint)
  • Line 49: warning: exported method Range.TestR should have comment or be unexported (golint)
  • Line 61: warning: exported method Range.Equals should have comment or be unexported (golint)
  • Line 73: warning: exported method Range.Length should have comment or be unexported (golint)
  • Line 77: warning: exported method Range.NumSequences should have comment or be unexported (golint)
  • Line 91: warning: exported method Range.Sequences should have comment or be unexported (golint)
  • Line 124: warning: exported method Range.Save should have comment or be unexported (golint)

• pkg/loc/internal/mappings/loc.go
  • Line 22: warning: exported type FDD should have comment or be unexported (golint)
  • Line 35: warning: exported type Other should have comment or be unexported (golint)
  • Line 52: warning: exported type Relation should have comment or be unexported (golint)
  • Line 83: warning: exported method FDD.PUIDs should have comment or be unexported (golint)

• internal/identifier/base.go
  • Line 36: warning: comment on exported type Base should be of the form "Base ..." (with optional leading article) (golint)
  • Line 108: warning: exported function New should have comment or be unexported (golint)
  • Line 119: warning: exported method Base.Save should have comment or be unexported (golint)
  • Line 133: warning: exported function Load should have comment or be unexported (golint)
  • Line 149: warning: exported method Base.Name should have comment or be unexported (golint)
  • Line 153: warning: exported method Base.Details should have comment or be unexported (golint)
  • Line 169: warning: exported method Base.Inspect should have comment or be unexported (golint)
  • Line 187: warning: exported const Priorities should have comment (or a comment on this block) or be unexported (golint)
  • Line 192: warning: exported method Base.GraphP should have comment or be unexported (golint)
  • Line 224: warning: exported method Base.NoPriority should have comment or be unexported (golint)
  • Line 228: warning: exported method Base.Multi should have comment or be unexported (golint)
  • Line 232: warning: exported method Base.ZipDefault should have comment or be unexported (golint)
  • Line 236: warning: exported method Base.Hit should have comment or be unexported (golint)
  • Line 257: warning: exported method Base.Place should have comment or be unexported (golint)
  • Line 278: warning: exported method Base.Lookup should have comment or be unexported (golint)
  • Line 299: warning: exported method Base.Recognise should have comment or be unexported (golint)
  • Line 307: warning: exported method Base.Add should have comment or be unexported (golint)
  • Line 386: warning: exported method Base.Active should have comment or be unexported (golint)
  • Line 407: warning: exported method Base.Start should have comment or be unexported (golint)
  • Line 428: warning: exported method Base.IDs should have comment or be unexported (golint)
  • Line 449: warning: exported method Base.HasSig should have comment or be unexported (golint)

• pkg/pronom/identifier.go
  • Line 32: warning: exported type Identifier should have comment or be unexported (golint)
  • Line 37: warning: exported method Identifier.Save should have comment or be unexported (golint)
  • Line 49: warning: exported function Load should have comment or be unexported (golint)
  • Line 64: warning: exported function New should have comment or be unexported (golint)
  • Line 78: warning: exported method Identifier.Fields should have comment or be unexported (golint)
  • Line 82: warning: exported method Identifier.Recorder should have comment or be unexported (golint)
  • Line 89: warning: exported type Recorder should have comment or be unexported (golint)
  • Line 106: warning: exported method Recorder.Active should have comment or be unexported (golint)
  • Line 119: warning: exported method Recorder.Record should have comment or be unexported (golint)
  • Line 127: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 134: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 155: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 171: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 181: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 187: warning: exported method Recorder.Satisfied should have comment or be unexported (golint)
  • Line 242: warning: exported method Recorder.Report should have comment or be unexported (golint)
  • Line 374: warning: exported type Identification should have comment or be unexported (golint)
  • Line 390: warning: exported method Identification.Known should have comment or be unexported (golint)
  • Line 394: warning: exported method Identification.Warn should have comment or be unexported (golint)
  • Line 398: warning: exported method Identification.Values should have comment or be unexported (golint)
  • Line 414: warning: exported method Identification.Archive should have comment or be unexported (golint)

• pkg/pronom/pronom.go
  • Line 70: warning: comment on exported function NewPronom should be of the form "NewPronom ..." (golint)
  • Line 186: warning: comment on exported function Harvest should be of the form "Harvest ..." (golint)
  • Line 220: warning: exported function GetReleases should have comment or be unexported (golint)
  • Line 228: warning: exported function LoadReleases should have comment or be unexported (golint)
  • Line 234: warning: exported function Releases should have comment or be unexported (golint)
  • Line 344: warning: comment on exported function ExtensionSet should be of the form "ExtensionSet ..." (golint)

• pkg/config/pronom.go
  • Line 66: warning: comment on exported function Droid should be of the form "Droid ..." (golint)
  • Line 82: warning: comment on exported function DroidBase should be of the form "DroidBase ..." (golint)
  • Line 176: warning: comment on exported function ExtendC should be of the form "ExtendC ..." (golint)
  • Line 181: warning: exported function ChangesURL should have comment or be unexported (golint)
  • Line 251: warning: exported function SetHarvestThrottle should have comment or be unexported (golint)

• pkg/mimeinfo/mimeinfo.go
  • Line 413: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/bytematcher/bytematcher.go
  • Line 218: warning: exported method Matcher.DescribeTestTree should have comment or be unexported (golint)
  • Line 234: warning: exported method Matcher.TestTreeLen should have comment or be unexported (golint)
  • Line 238: warning: exported method Matcher.DescribeKeyFrames should have comment or be unexported (golint)
  • Line 249: warning: exported method Matcher.KeyFramesLen should have comment or be unexported (golint)

• pkg/loc/identifier.go
  • Line 32: warning: exported type Identifier should have comment or be unexported (golint)
  • Line 37: warning: exported method Identifier.Save should have comment or be unexported (golint)
  • Line 49: warning: exported function Load should have comment or be unexported (golint)
  • Line 64: warning: exported function New should have comment or be unexported (golint)
  • Line 91: warning: exported method Identifier.Fields should have comment or be unexported (golint)
  • Line 95: warning: exported method Identifier.Recorder should have comment or be unexported (golint)
  • Line 102: warning: exported type Recorder should have comment or be unexported (golint)
  • Line 119: warning: exported method Recorder.Active should have comment or be unexported (golint)
  • Line 132: warning: exported method Recorder.Record should have comment or be unexported (golint)
  • Line 140: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 168: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 179: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 195: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 201: warning: exported method Recorder.Satisfied should have comment or be unexported (golint)
  • Line 243: warning: exported method Recorder.Report should have comment or be unexported (golint)
  • Line 369: warning: exported type Identification should have comment or be unexported (golint)
  • Line 385: warning: exported method Identification.Known should have comment or be unexported (golint)
  • Line 389: warning: exported method Identification.Warn should have comment or be unexported (golint)
  • Line 393: warning: exported method Identification.Values should have comment or be unexported (golint)
  • Line 409: warning: exported method Identification.Archive should have comment or be unexported (golint)

• pkg/reader/compare.go
  • Line 29: warning: exported const Path should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: comment on exported function Base should be of the form "Base ..." (golint)
  • Line 96: warning: exported function Compare should have comment or be unexported (golint)

• pkg/config/mimeinfo.go
  • Line 51: warning: exported function MIMEVersion should have comment or be unexported (golint)
  • Line 63: warning: exported function ZipMIME should have comment or be unexported (golint)
  • Line 67: warning: exported function TextMIME should have comment or be unexported (golint)
  • Line 71: warning: exported function SetMIMEInfo should have comment or be unexported (golint)

• internal/xmlmatcher/xmlmatcher.go
  • Line 28: warning: exported type Matcher should have comment or be unexported (golint)
  • Line 30: warning: exported type SignatureSet should have comment or be unexported (golint)
  • Line 32: warning: exported function Load should have comment or be unexported (golint)
  • Line 49: warning: exported function Save should have comment or be unexported (golint)
  • Line 66: warning: exported function Add should have comment or be unexported (golint)
  • Line 100: warning: exported method Matcher.Identify should have comment or be unexported (golint)

• pkg/pronom/internal/mappings/container.go
  • Line 21: warning: exported type Container should have comment or be unexported (golint)
  • Line 28: warning: exported type ContainerSignature should have comment or be unexported (golint)
  • Line 35: warning: exported type File should have comment or be unexported (golint)
  • Line 40: warning: exported type FormatMapping should have comment or be unexported (golint)
  • Line 45: warning: exported type TriggerPuid should have comment or be unexported (golint)
  • Line 50: warning: exported method Container.Puids should have comment or be unexported (golint)

• internal/bytematcher/frames/segments.go
  • Line 30: warning: exported method Signature.Segment should have comment or be unexported (golint)
  • Line 95: warning: exported type SigType should have comment or be unexported (golint)
  • Line 98: warning: exported const Unknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 109: warning: comment on exported method Signature.Characterise should be of the form "Characterise ..." (golint)
  • Line 110: warning: receiver name seg should be consistent with previous receiver name s for Signature (golint)
  • Line 143: warning: comment on exported type Position should be of the form "Position ..." (with optional leading article) (golint)
  • Line 157: warning: exported function VarLength should have comment or be unexported (golint)
  • Line 202: warning: exported function BOFLength should have comment or be unexported (golint)
  • Line 231: warning: exported function EOFLength should have comment or be unexported (golint)

• internal/textmatcher/textmatcher.go
  • Line 26: warning: exported type Matcher should have comment or be unexported (golint)
  • Line 28: warning: exported function Load should have comment or be unexported (golint)
  • Line 33: warning: exported function Save should have comment or be unexported (golint)
  • Line 41: warning: exported type SignatureSet should have comment or be unexported (golint)
  • Line 43: warning: exported function Add should have comment or be unexported (golint)
  • Line 68: warning: exported method Matcher.Identify should have comment or be unexported (golint)

• pkg/config/siegfried.go
  • Line 15: warning: package comment should be of the form "Package config ..." (golint)
  • Line 79: warning: comment on exported function Local should be of the form "Local ..." (golint)
  • Line 131: warning: comment on exported function Cost should be of the form "Cost ..." (golint)
  • Line 137: warning: comment on exported function Repetition should be of the form "Repetition ..." (golint)

• internal/bytematcher/patterns/bmh.go
  • Line 69: warning: comment on exported method BMHSequence.TestR should be of the form "TestR ..." (golint)
  • Line 160: warning: comment on exported method RBMHSequence.TestR should be of the form "TestR ..." (golint)

• pkg/wikidata/internal/converter/encodings.go
  • Line 25: warning: exported const UnknownEncoding should have comment (or a comment on this block) or be unexported (golint)

• cmd/sf/serve.go
  • Line 52: warning: error should be the last type when returning multiple items (golint)
  • Line 210: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/riffmatcher/riffmatcher.go
  • Line 31: warning: exported type Matcher should have comment or be unexported (golint)
  • Line 36: warning: exported function Load should have comment or be unexported (golint)
  • Line 56: warning: exported function Save should have comment or be unexported (golint)
  • Line 76: warning: exported type SignatureSet should have comment or be unexported (golint)
  • Line 78: warning: exported function Add should have comment or be unexported (golint)
  • Line 134: warning: exported method Matcher.Identify should have comment or be unexported (golint)

• pkg/writer/writer.go
  • Line 32: warning: exported type Writer should have comment or be unexported (golint)
  • Line 38: warning: exported function Null should have comment or be unexported (golint)
  • Line 56: warning: exported function CSV should have comment or be unexported (golint)
  • Line 142: warning: exported function YAML should have comment or be unexported (golint)
  • Line 227: warning: exported function JSON should have comment or be unexported (golint)
  • Line 323: warning: exported function Droid should have comment or be unexported (golint)

• pkg/mimeinfo/patterns.go
  • Line 50: warning: exported type Int8 should have comment or be unexported (golint)
  • Line 63: warning: comment on exported method Int8.TestR should be of the form "TestR ..." (golint)
  • Line 112: warning: exported type Big16 should have comment or be unexported (golint)
  • Line 125: warning: comment on exported method Big16.TestR should be of the form "TestR ..." (golint)
  • Line 180: warning: exported type Big32 should have comment or be unexported (golint)
  • Line 193: warning: comment on exported method Big32.TestR should be of the form "TestR ..." (golint)
  • Line 248: warning: exported type Little16 should have comment or be unexported (golint)
  • Line 261: warning: comment on exported method Little16.TestR should be of the form "TestR ..." (golint)
  • Line 316: warning: exported type Little32 should have comment or be unexported (golint)
  • Line 329: warning: comment on exported method Little32.TestR should be of the form "TestR ..." (golint)
  • Line 384: warning: exported type Host16 should have comment or be unexported (golint)
  • Line 400: warning: comment on exported method Host16.TestR should be of the form "TestR ..." (golint)
  • Line 459: warning: exported type Host32 should have comment or be unexported (golint)
  • Line 475: warning: comment on exported method Host32.TestR should be of the form "TestR ..." (golint)
  • Line 534: warning: exported type IgnoreCase should have comment or be unexported (golint)
  • Line 536: warning: exported method IgnoreCase.Test should have comment or be unexported (golint)
  • Line 554: warning: exported method IgnoreCase.TestR should have comment or be unexported (golint)
  • Line 645: warning: exported type Mask should have comment or be unexported (golint)
  • Line 650: warning: exported method Mask.Test should have comment or be unexported (golint)
  • Line 661: warning: exported method Mask.TestR should have comment or be unexported (golint)

• internal/bytematcher/keyframes.go
  • Line 395: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 400: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 411: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 447: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• pkg/wikidata/wikidata.go
  • Line 15: warning: package comment should be of the form "Package wikidata ..." (golint)

• pkg/pronom/parse.go
  • Line 478: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/chart/chart.go
  • Line 40: warning: exported function Chart should have comment or be unexported (golint)

• internal/priority/priority.go
  • Line 29: warning: comment on exported type Map should be of the form "Map ..." (with optional leading article) (golint)
  • Line 32: warning: exported method Map.Difference should have comment or be unexported (golint)
  • Line 48: warning: exported method Map.Elements should have comment or be unexported (golint)
  • Line 81: warning: comment on exported method Map.Add should be of the form "Add ..." (golint)
  • Line 136: warning: comment on exported method Map.Complete should be of the form "Complete ..." (golint)
  • Line 177: warning: comment on exported method Map.List should be of the form "List ..." (golint)
  • Line 205: warning: exported type List should have comment or be unexported (golint)
  • Line 207: warning: comment on exported method List.Subset should be of the form "Subset ..." (golint)
  • Line 237: warning: comment on exported type Set should be of the form "Set ..." (with optional leading article) (golint)
  • Line 244: warning: exported method Set.Save should have comment or be unexported (golint)
  • Line 260: warning: exported function Load should have comment or be unexported (golint)
  • Line 296: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 330: warning: comment on exported type WaitSet should be of the form "WaitSet ..." (with optional leading article) (golint)
  • Line 389: warning: comment on exported method WaitSet.Put should be of the form "Put ..." (golint)
  • Line 427: warning: comment on exported method WaitSet.PutAt should be of the form "PutAt ..." (golint)
  • Line 511: warning: exported type Filterable should have comment or be unexported (golint)
  • Line 516: warning: exported method WaitSet.ApplyFilter should have comment or be unexported (golint)
  • Line 525: warning: comment on exported method WaitSet.WaitingOn should be of the form "WaitingOn ..." (golint)
  • Line 552: warning: comment on exported method WaitSet.WaitingOnAt should be of the form "WaitingOnAt ..." (golint)

• internal/bytematcher/patterns/patterns.go
  • Line 51: warning: comment on exported type Pattern should be of the form "Pattern ..." (with optional leading article) (golint)
  • Line 126: warning: comment on exported method Sequence.TestR should be of the form "TestR ..." (golint)
  • Line 165: warning: comment on exported method Sequence.Reverse should be of the form "Reverse ..." (golint)
  • Line 212: warning: comment on exported method Choice.TestR should be of the form "TestR ..." (golint)
  • Line 334: warning: comment on exported method List.TestR should be of the form "TestR ..." (golint)
  • Line 458: warning: comment on exported method Not.TestR should be of the form "TestR ..." (golint)
  • Line 541: warning: exported type Mask should have comment or be unexported (golint)
  • Line 543: warning: exported method Mask.Test should have comment or be unexported (golint)
  • Line 553: warning: exported method Mask.TestR should have comment or be unexported (golint)
  • Line 563: warning: exported method Mask.Equals should have comment or be unexported (golint)
  • Line 573: warning: exported method Mask.Length should have comment or be unexported (golint)
  • Line 594: warning: exported method Mask.NumSequences should have comment or be unexported (golint)
  • Line 598: warning: exported method Mask.Sequences should have comment or be unexported (golint)
  • Line 612: warning: exported method Mask.Save should have comment or be unexported (golint)
  • Line 621: warning: exported type AnyMask should have comment or be unexported (golint)
  • Line 623: warning: exported method AnyMask.Test should have comment or be unexported (golint)
  • Line 633: warning: exported method AnyMask.TestR should have comment or be unexported (golint)
  • Line 643: warning: exported method AnyMask.Equals should have comment or be unexported (golint)
  • Line 653: warning: exported method AnyMask.Length should have comment or be unexported (golint)
  • Line 657: warning: exported method AnyMask.NumSequences should have comment or be unexported (golint)
  • Line 661: warning: exported method AnyMask.Sequences should have comment or be unexported (golint)
  • Line 675: warning: exported method AnyMask.Save should have comment or be unexported (golint)

• internal/containermatcher/container.go
  • Line 33: warning: exported const Zip should have comment (or a comment on this block) or be unexported (golint)
  • Line 72: warning: exported type SignatureSet should have comment or be unexported (golint)
  • Line 78: warning: exported function Add should have comment or be unexported (golint)
  • Line 143: warning: exported type ContainerMatcher should have comment or be unexported (golint)
  • Line 306: warning: exported method Matcher.InspectTestTree should have comment or be unexported (golint)

• pkg/wikidata/internal/mappings/wikidata_mapping_structs.go
  • Line 15: warning: package comment should be of the form "Package mappings ..." (golint)

• internal/bytematcher/frames/tests/tests.go
  • Line 19: warning: should not use dot imports (golint)
  • Line 21: warning: should not use dot imports (golint)
  • Line 146: warning: comment on exported var TestMultiLen should be of the form "TestMultiLen ..." (golint)
  • Line 149: warning: comment on exported var TestBumper should be of the form "TestBumper ..." (golint)
  • Line 152: warning: comment on exported var TestMP3 should be of the form "TestMP3 ..." (golint)

• internal/bytematcher/frames/frames.go
  • Line 156: warning: comment on exported method Frame.MatchN should be of the form "MatchN ..." (golint)
  • Line 179: warning: comment on exported method Frame.MatchR should be of the form "MatchR ..." (golint)
  • Line 199: warning: comment on exported method Frame.MatchNR should be of the form "MatchNR ..." (golint)
  • Line 222: warning: exported method Frame.Equals should have comment or be unexported (golint)
  • Line 298: warning: exported method Frame.Save should have comment or be unexported (golint)
  • Line 305: warning: exported function Load should have comment or be unexported (golint)

• internal/bytematcher/frames/signatures.go
  • Line 33: warning: exported method Signature.OneEnough should have comment or be unexported (golint)

• internal/bytematcher/patterns/overlap.go
  • Line 17: warning: comment on exported function Overlap should be of the form "Overlap ..." (golint)
  • Line 23: warning: comment on exported function OverlapR should be of the form "OverlapR ..." (golint)

• pkg/mimeinfo/identifier.go
  • Line 32: warning: exported type Identifier should have comment or be unexported (golint)
  • Line 37: warning: exported method Identifier.Save should have comment or be unexported (golint)
  • Line 50: warning: exported function Load should have comment or be unexported (golint)
  • Line 75: warning: exported function New should have comment or be unexported (golint)
  • Line 101: warning: exported method Identifier.Fields should have comment or be unexported (golint)
  • Line 105: warning: exported method Identifier.Recorder should have comment or be unexported (golint)
  • Line 112: warning: exported type Recorder should have comment or be unexported (golint)
  • Line 121: warning: exported method Recorder.Active should have comment or be unexported (golint)
  • Line 134: warning: exported method Recorder.Record should have comment or be unexported (golint)
  • Line 142: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 149: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 164: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 176: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 186: warning: exported method Recorder.Satisfied should have comment or be unexported (golint)
  • Line 200: warning: exported method Recorder.Report should have comment or be unexported (golint)
  • Line 340: warning: exported type Identification should have comment or be unexported (golint)
  • Line 360: warning: exported method Identification.Known should have comment or be unexported (golint)
  • Line 364: warning: exported method Identification.Warn should have comment or be unexported (golint)
  • Line 368: warning: exported method Identification.Values should have comment or be unexported (golint)
  • Line 383: warning: exported method Identification.Archive should have comment or be unexported (golint)

• internal/checksum/checksum.go
  • Line 26: warning: exported const HashChoices should have comment or be unexported (golint)
  • Line 28: warning: exported type HashTyp should have comment or be unexported (golint)
  • Line 38: warning: exported function GetHash should have comment or be unexported (golint)
  • Line 55: warning: exported function MakeHash should have comment or be unexported (golint)

• internal/bytematcher/frames/block.go
  • Line 122: warning: exported method Block.Test should have comment or be unexported (golint)
  • Line 155: warning: exported method Block.TestR should have comment or be unexported (golint)
  • Line 188: warning: exported method Block.Equals should have comment or be unexported (golint)
  • Line 213: warning: exported method Block.Length should have comment or be unexported (golint)
  • Line 217: warning: comment on exported method Block.NumSequences should be of the form "NumSequences ..." (golint)
  • Line 219: warning: exported method Block.Sequences should have comment or be unexported (golint)
  • Line 244: warning: exported method Block.Save should have comment or be unexported (golint)

• internal/namematcher/namematcher.go
  • Line 33: warning: exported type Matcher should have comment or be unexported (golint)
  • Line 39: warning: exported function Load should have comment or be unexported (golint)
  • Line 68: warning: exported function Save should have comment or be unexported (golint)
  • Line 90: warning: exported type SignatureSet should have comment or be unexported (golint)
  • Line 92: warning: exported function Add should have comment or be unexported (golint)
  • Line 176: warning: exported method Matcher.Identify should have comment or be unexported (golint)

• pkg/pronom/internal/mappings/changes.go
  • Line 23: warning: exported type Releases should have comment or be unexported (golint)
  • Line 28: warning: exported type Release should have comment or be unexported (golint)
  • Line 34: warning: exported type Outline should have comment or be unexported (golint)
  • Line 39: warning: exported type Puid should have comment or be unexported (golint)
  • Line 44: warning: exported type KeyVal should have comment or be unexported (golint)
  • Line 52: warning: comment on exported method OrderedMap.MarshalJSON should be of the form "MarshalJSON ..." (golint)

• pkg/wikidata/internal/converter/converter.go
  • Line 15: warning: package comment should be of the form "Package converter ..." (golint)

• internal/siegreader/reader.go
  • Line 306: warning: exported function TextReaderFrom should have comment or be unexported (golint)
  • Line 356: warning: exported function TextReverseReaderFrom should have comment or be unexported (golint)

• pkg/reader/reader.go
  • Line 35: warning: exported type Reader should have comment or be unexported (golint)
  • Line 40: warning: exported type Head should have comment or be unexported (golint)
  • Line 51: warning: exported type File should have comment or be unexported (golint)
  • Line 239: warning: exported function New should have comment or be unexported (golint)

• pkg/mimeinfo/internal/mappings/mimeinfo.go
  • Line 19: warning: exported type MIMEInfo should have comment or be unexported (golint)
  • Line 24: warning: exported type MIMEType should have comment or be unexported (golint)
  • Line 47: warning: exported type Magic should have comment or be unexported (golint)
  • Line 52: warning: exported type Match should have comment or be unexported (golint)

• pkg/decompress/decompress.go
  • Line 40: warning: exported function SetDroid should have comment or be unexported (golint)
  • Line 44: warning: exported function IsArc should have comment or be unexported (golint)
  • Line 54: warning: exported type Decompressor should have comment or be unexported (golint)
  • Line 64: warning: exported function New should have comment or be unexported (golint)
  • Line 245: warning: receiver name t should be consistent with previous receiver name g for gzipD (golint)
  • Line 321: warning: comment on exported function Arcpath should be of the form "Arcpath ..." (golint)

• pkg/pronom/internal/mappings/droid.go
  • Line 15: warning: package comment should be of the form "Package mappings ..." (golint)
  • Line 24: warning: exported type Droid should have comment or be unexported (golint)
  • Line 31: warning: exported type InternalSignature should have comment or be unexported (golint)
  • Line 36: warning: exported type ByteSeq should have comment or be unexported (golint)
  • Line 41: warning: exported type SubSequence should have comment or be unexported (golint)
  • Line 50: warning: exported type Fragment should have comment or be unexported (golint)
  • Line 57: warning: exported type FileFormat should have comment or be unexported (golint)

• internal/bytematcher/patterns/tests/tests.go
  • Line 18: warning: should not use dot imports (golint)
  • Line 57: warning: comment on exported var TestChoices should be of the form "TestChoices ..." (golint)
  • Line 79: warning: exported var TestMasks should have comment or be unexported (golint)
  • Line 81: warning: exported var TestAnyMasks should have comment or be unexported (golint)

• internal/containermatcher/reader.go
  • Line 19: warning: exported type Reader should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell97%

Misspell Finds commonly misspelled English words

• pkg/config/wikidata.go
  • Line 61: warning: "withing" is a misspelling of "within" (misspell)

• siegfried.go
  • Line 294: warning: "satisifed" is a misspelling of "satisfied" (misspell)

• cmd/sf/conf.go
  • Line 95: warning: "explictly" is a misspelling of "explicitly" (misspell)
  • Line 101: warning: "explictly" is a misspelling of "explicitly" (misspell)

• internal/priority/priority.go
  • Line 333: warning: "satisifed" is a misspelling of "satisfied" (misspell)