Report for github.com/robotomize/gokuu
A+ Excellent! Found 21 issues across 40 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo85%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
gokuu/provider/ecb/csv.go
- Line 16: warning: cyclomatic complexity 21 of function decodeCSV() is high (> 15) (gocyclo)
-
-
gokuu/provider/ecb/xml.go
- Line 25: warning: cyclomatic complexity 18 of function decodeXML() is high (> 15) (gocyclo)
-
-
gokuu/provider/ecb/source_test.go
- Line 79: warning: cyclomatic complexity 18 of function TestSource_FetchLatest() is high (> 15) (gocyclo)
-
-
gokuu/provider/rcb/xml.go
- Line 28: warning: cyclomatic complexity 16 of function decodeXML() is high (> 15) (gocyclo)
-
-
gokuu/internal/gen/gen.go
- Line 91: warning: cyclomatic complexity 52 of function Generate() is high (> 15) (gocyclo)
-
-
gokuu/gokuu_test.go
- Line 182: warning: cyclomatic complexity 16 of function TestExchanger_GetLatest() is high (> 15) (gocyclo)
golint55%
Golint is a linter for Go source code.
-
-
gokuu/provider/ecb/source.go
- Line 43: warning: exported function NewSource should have comment or be unexported (golint)
-
-
gokuu/provider/source.go
- Line 10: warning: comment on exported type Source should be of the form "Source ..." (with optional leading article) (golint)
-
-
gokuu/internal/gen/gen.go
- Line 23: warning: exported const AssetsCurrencyCodesFile should have comment (or a comment on this block) or be unexported (golint)
- Line 32: warning: exported const SuffixGenFileName should have comment or be unexported (golint)
- Line 42: warning: exported var ErrHashingContentEqual should have comment or be unexported (golint)
- Line 53: warning: exported type AssetsMapFunc should have comment or be unexported (golint)
- Line 55: warning: exported function ReadAssets should have comment or be unexported (golint)
- Line 77: warning: exported function Funcs should have comment or be unexported (golint)
- Line 85: warning: exported function Template should have comment or be unexported (golint)
- Line 91: warning: exported function Generate should have comment or be unexported (golint)
-
-
gokuu/provider/cae/provider.go
- Line 12: warning: exported type ExchangeRate should have comment or be unexported (golint)
- Line 19: warning: exported method ExchangeRate.Time should have comment or be unexported (golint)
- Line 23: warning: exported method ExchangeRate.From should have comment or be unexported (golint)
- Line 27: warning: exported method ExchangeRate.To should have comment or be unexported (golint)
- Line 31: warning: exported method ExchangeRate.Rate should have comment or be unexported (golint)
-
-
gokuu/tools/gocyupd/main.go
- Line 40: warning: exported var ErrHashingContentEqual should have comment or be unexported (golint)
- Line 191: warning: exported function NewHTTPClient should have comment or be unexported (golint)
- Line 198: warning: exported type HTTPClient should have comment or be unexported (golint)
-
-
gokuu/provider/rcb/xml.go
- Line 107: warning: exported type XMLAttrTime should have comment or be unexported (golint)
- Line 109: warning: exported method XMLAttrTime.UnmarshalXMLAttr should have comment or be unexported (golint)
- Line 120: warning: exported type XMLCcyRate should have comment or be unexported (golint)
- Line 126: warning: exported type XMLNode should have comment or be unexported (golint)
-
-
gokuu/provider/doc.go
- Line 1: warning: package comment should be of the form "Package provider ..." (golint)
-
-
gokuu/internal/hashio/read.go
- Line 15: warning: exported type HashFunc should have comment or be unexported (golint)
- Line 17: warning: exported var ErrHashFuncNotFound should have comment or be unexported (golint)
- Line 61: warning: exported function HashSumFunc should have comment or be unexported (golint)
- Line 72: warning: exported function MD5 should have comment or be unexported (golint)
- Line 78: warning: exported function SHA1 should have comment or be unexported (golint)
- Line 84: warning: exported function MD5HashFunc should have comment or be unexported (golint)
- Line 90: warning: exported function SHA1HashFunc should have comment or be unexported (golint)
-
-
gokuu/provider/cae/source.go
- Line 31: warning: exported function NewSource should have comment or be unexported (golint)
-
-
gokuu/provider/ecb/doc.go
- Line 1: warning: package comment should be of the form "Package ecb ..." (golint)
-
-
gokuu/internal/logging/logger.go
- Line 19: warning: exported function DefaultLogger should have comment or be unexported (golint)
- Line 26: warning: exported function NewLogger should have comment or be unexported (golint)
- Line 30: warning: exported function WithLogger should have comment or be unexported (golint)
- Line 34: warning: exported function FromContext should have comment or be unexported (golint)
-
-
gokuu/internal/gen/unmarshal_struct.go
- Line 3: warning: exported type Ccy should have comment or be unexported (golint)
- Line 11: warning: exported type CurrencyCodes should have comment or be unexported (golint)
- Line 23: warning: exported type CurrencyNames should have comment or be unexported (golint)
-
-
gokuu/provider/httputil/client.go
- Line 17: warning: exported var ErrStatusCode should have comment or be unexported (golint)
- Line 41: warning: exported type SourceHTTPClient should have comment or be unexported (golint)
- Line 45: warning: exported method SourceHTTPClient.UserAgent should have comment or be unexported (golint)
-
-
gokuu/gokuu.go
- Line 21: warning: exported var ErrConversionRate should have comment or be unexported (golint)
- Line 26: warning: exported const DefaultRequestTimeout should have comment (or a comment on this block) or be unexported (golint)
- Line 40: warning: exported type Exchanger should have comment or be unexported (golint)
- Line 46: warning: exported type Option should have comment or be unexported (golint)
- Line 48: warning: exported type Options should have comment or be unexported (golint)
- Line 55: warning: exported type LatestResponse should have comment or be unexported (golint)
- Line 62: warning: exported method LatestResponse.Verify should have comment or be unexported (golint)
- Line 66: warning: exported type ProviderRespStatus should have comment or be unexported (golint)
- Line 69: warning: exported const ProviderRespStatusFailed should have comment (or a comment on this block) or be unexported (golint)
- Line 73: warning: exported type SourceInfo should have comment or be unexported (golint)
- Line 79: warning: exported type MergeStrategyType should have comment or be unexported (golint)
- Line 82: warning: exported const MergeStrategyTypeRace should have comment (or a comment on this block) or be unexported (golint)
- Line 87: warning: exported type Prior should have comment or be unexported (golint)
- Line 89: warning: exported type Provider should have comment or be unexported (golint)
- Line 194: warning: exported type FetchFunc should have comment or be unexported (golint)
- Line 196: warning: exported type ConvOpt should have comment or be unexported (golint)
- Line 350: warning: exported type ConversionResponse should have comment or be unexported (golint)
- Line 373: warning: exported type ExchangeRate should have comment or be unexported (golint)
- Line 381: warning: exported method ExchangeRate.Time should have comment or be unexported (golint)
- Line 385: warning: exported method ExchangeRate.From should have comment or be unexported (golint)
- Line 389: warning: exported method ExchangeRate.To should have comment or be unexported (golint)
- Line 393: warning: exported method ExchangeRate.Rate should have comment or be unexported (golint)
- Line 397: warning: exported type MergeFunc should have comment or be unexported (golint)
- Line 611: warning: exported type BatchExchanges should have comment or be unexported (golint)
-
-
gokuu/provider/ecb/provider.go
- Line 12: warning: exported type ExchangeRate should have comment or be unexported (golint)
- Line 19: warning: exported method ExchangeRate.Time should have comment or be unexported (golint)
- Line 23: warning: exported method ExchangeRate.From should have comment or be unexported (golint)
- Line 27: warning: exported method ExchangeRate.To should have comment or be unexported (golint)
- Line 31: warning: exported method ExchangeRate.Rate should have comment or be unexported (golint)
-
-
gokuu/provider/rcb/provider.go
- Line 12: warning: exported type ExchangeRate should have comment or be unexported (golint)
- Line 19: warning: exported method ExchangeRate.Time should have comment or be unexported (golint)
- Line 23: warning: exported method ExchangeRate.From should have comment or be unexported (golint)
- Line 27: warning: exported method ExchangeRate.To should have comment or be unexported (golint)
- Line 31: warning: exported method ExchangeRate.Rate should have comment or be unexported (golint)
-
-
gokuu/provider/rcb/source.go
- Line 31: warning: exported function NewSource should have comment or be unexported (golint)
-
-
gokuu/provider/ecb/xml.go
- Line 104: warning: exported type XMLAttrTime should have comment or be unexported (golint)
- Line 106: warning: exported method XMLAttrTime.UnmarshalXMLAttr should have comment or be unexported (golint)
- Line 119: warning: exported type XMLCurrencyAttr should have comment or be unexported (golint)
- Line 121: warning: exported method XMLCurrencyAttr.UnmarshalXMLAttr should have comment or be unexported (golint)
- Line 133: warning: exported type XMLRateAttr should have comment or be unexported (golint)
- Line 135: warning: exported method XMLRateAttr.Float64 should have comment or be unexported (golint)
- Line 139: warning: exported method XMLRateAttr.UnmarshalXMLAttr should have comment or be unexported (golint)
- Line 154: warning: exported type XMLNode should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!