Preparing report...

Report for github.com/sdboyer/gps

A+    Excellent!    Found 24 issues across 140 files

Tweet

gofmt91%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint100%

Golint is a linter for Go source code.

No problems detected. Good job!


gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • gps/lockdiff.go
    • Line 62: warning: cyclomatic complexity 20 of function DiffLocks() is high (> 15) (gocyclo)
    • Line 179: warning: cyclomatic complexity 18 of function DiffProjects() is high (> 15) (gocyclo)
    • gps/vcs_source.go
    • Line 159: warning: cyclomatic complexity 18 of function (*gitSource).listVersions() is high (> 15) (gocyclo)
    • gps/version.go
    • Line 484: warning: cyclomatic complexity 16 of function (versionPair).Intersect() is high (> 15) (gocyclo)
    • gps/pkgtree/pkgtree.go
    • Line 518: warning: cyclomatic complexity 40 of function wmToReach() is high (> 15) (gocyclo)
    • Line 180: warning: cyclomatic complexity 23 of function fillPackage() is high (> 15) (gocyclo)
    • Line 49: warning: cyclomatic complexity 18 of function ListPackages() is high (> 15) (gocyclo)
    • gps/constraint_test.go
    • Line 379: warning: cyclomatic complexity 48 of function TestSemverVersionConstraintOps() is high (> 15) (gocyclo)
    • Line 14: warning: cyclomatic complexity 44 of function TestBranchConstraintOps() is high (> 15) (gocyclo)
    • Line 198: warning: cyclomatic complexity 44 of function TestVersionConstraintOps() is high (> 15) (gocyclo)
    • Line 675: warning: cyclomatic complexity 40 of function TestVersionUnion() is high (> 15) (gocyclo)
    • Line 579: warning: cyclomatic complexity 25 of function TestSemverConstraintOps() is high (> 15) (gocyclo)
    • gps/deduce.go
    • Line 157: warning: cyclomatic complexity 19 of function (bitbucketDeducer).deduceSource() is high (> 15) (gocyclo)
    • gps/solve_test.go
    • Line 314: warning: cyclomatic complexity 28 of function TestBadSolveOpts() is high (> 15) (gocyclo)
    • Line 184: warning: cyclomatic complexity 18 of function fixtureSolveSimpleChecks() is high (> 15) (gocyclo)
    • gps/solver.go
    • Line 168: warning: cyclomatic complexity 26 of function (SolveParameters).toRootdata() is high (> 15) (gocyclo)
    • Line 674: warning: cyclomatic complexity 18 of function (*solver).createVersionQueue() is high (> 15) (gocyclo)
    • Line 1002: warning: cyclomatic complexity 17 of function (*solver).unselectedComparator() is high (> 15) (gocyclo)
    • gps/vcs_source_test.go
    • Line 376: warning: cyclomatic complexity 21 of function testHgSourceInteractions() is high (> 15) (gocyclo)
    • Line 266: warning: cyclomatic complexity 21 of function testBzrSourceInteractions() is high (> 15) (gocyclo)
    • Line 124: warning: cyclomatic complexity 21 of function testGopkginSourceInteractions() is high (> 15) (gocyclo)
    • Line 28: warning: cyclomatic complexity 17 of function testGitSourceInteractions() is high (> 15) (gocyclo)
    • gps/pkgtree/pkgtree_test.go
    • Line 1424: warning: cyclomatic complexity 30 of function TestToReachMap() is high (> 15) (gocyclo)
    • Line 486: warning: cyclomatic complexity 21 of function TestListPackages() is high (> 15) (gocyclo)
    • gps/version_queue_test.go
    • Line 140: warning: cyclomatic complexity 28 of function TestVersionQueueAdvance() is high (> 15) (gocyclo)
    • Line 49: warning: cyclomatic complexity 24 of function TestVersionQueueSetup() is high (> 15) (gocyclo)
    • gps/manager_test.go
    • Line 131: warning: cyclomatic complexity 24 of function TestSourceInit() is high (> 15) (gocyclo)
    • Line 438: warning: cyclomatic complexity 19 of function TestDeduceProjectRoot() is high (> 15) (gocyclo)
    • Line 646: warning: cyclomatic complexity 17 of function TestErrAfterRelease() is high (> 15) (gocyclo)

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell99%

Misspell Finds commonly misspelled English words