Report for github.com/shenwei356/rush
A Great! Found 5 issues across 9 files
gofmt88%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
rush/process/process.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo66%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
rush/string_repl.go
- Line 36: warning: cyclomatic complexity 43 of function fillCommand() is high (> 15) (gocyclo)
-
-
rush/process/process.go
- Line 928: warning: cyclomatic complexity 35 of function (*Command).run() is high (> 15) (gocyclo)
- Line 1309: warning: cyclomatic complexity 29 of function Run() is high (> 15) (gocyclo)
- Line 517: warning: cyclomatic complexity 21 of function checkChildProcess() is high (> 15) (gocyclo)
- Line 1164: warning: cyclomatic complexity 19 of function Run4Output() is high (> 15) (gocyclo)
- Line 727: warning: cyclomatic complexity 18 of function signalChildProcesses() is high (> 15) (gocyclo)
- Line 661: warning: cyclomatic complexity 16 of function getChildProcesses() is high (> 15) (gocyclo)
-
-
rush/process/process_windows.go
- Line 847: warning: cyclomatic complexity 34 of function _signalProcess() is high (> 15) (gocyclo)
golint77%
Golint is a linter for Go source code.
-
-
rush/process/process.go
- Line 49: warning: comment on exported var ChildMarker should be of the form "ChildMarker ..." (golint)
- Line 215: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 218: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 261: warning: exported type TopLevelEnum should have comment or be unexported (golint)
- Line 264: warning: exported const NotTopLevel should have comment (or a comment on this block) or be unexported (golint)
- Line 321: warning: exported function NewImmediateLineWriter should have comment or be unexported (golint)
- Line 339: warning: exported method ImmediateLineWriter.WritePrefixedLines should have comment or be unexported (golint)
- Line 400: warning: exported type ImmediateWriter should have comment or be unexported (golint)
- Line 405: warning: exported function NewImmediateWriter should have comment or be unexported (golint)
- Line 421: warning: comment on exported type IntSet should be of the form "IntSet ..." (with optional leading article) (golint)
- Line 426: warning: exported method IntSet.Add should have comment or be unexported (golint)
- Line 433: warning: exported const INVALID_HANDLE should have comment (or a comment on this block) or be unexported (golint)
- Line 439: warning: comment on exported const SEND_NO_SIGNAL should be of the form "SEND_NO_SIGNAL ..." (golint)
- Line 476: warning: exported type ProcessRecord should have comment or be unexported (golint)
- Line 512: warning: exported type ChildCheckRecord should have comment or be unexported (golint)
-
-
rush/process/process_others.go
- Line 80: warning: exported var Procd should have comment or be unexported (golint)
- Line 169: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
ineffassign66%
IneffAssign detects ineffectual assignments in Go code.
-
-
rush/root.go
- Line 94: warning: ineffectual assignment to errfh (ineffassign)
-
-
rush/process/process.go
- Line 627: warning: ineffectual assignment to err (ineffassign)
- Line 679: warning: ineffectual assignment to err (ineffassign)
-
-
rush/process/process_windows.go
- Line 109: warning: ineffectual assignment to simpleErr (ineffassign)
- Line 110: warning: ineffectual assignment to errorCode (ineffassign)