Report for github.com/similarweb/finala
A+ Excellent! Found 27 issues across 117 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint83%
Golint is a linter for Go source code.
-
-
finala/api/testutils/storage.go
- Line 9: warning: exported type MockStorage should have comment or be unexported (golint)
- Line 13: warning: exported function NewMockStorage should have comment or be unexported (golint)
- Line 20: warning: exported method MockStorage.Save should have comment or be unexported (golint)
- Line 25: warning: exported method MockStorage.GetSummary should have comment or be unexported (golint)
- Line 52: warning: exported method MockStorage.GetExecutions should have comment or be unexported (golint)
- Line 68: warning: exported method MockStorage.GetResources should have comment or be unexported (golint)
- Line 91: warning: exported method MockStorage.GetResourceTrends should have comment or be unexported (golint)
- Line 117: warning: exported method MockStorage.GetExecutionTags should have comment or be unexported (golint)
-
-
finala/collector/testutils/collector.go
- Line 7: warning: exported type MockCollector should have comment or be unexported (golint)
- Line 12: warning: exported function NewMockCollector should have comment or be unexported (golint)
- Line 17: warning: exported method MockCollector.AddResource should have comment or be unexported (golint)
- Line 21: warning: exported method MockCollector.GetCollectorEvent should have comment or be unexported (golint)
- Line 26: warning: exported method MockCollector.CollectStart should have comment or be unexported (golint)
- Line 35: warning: exported method MockCollector.CollectFinish should have comment or be unexported (golint)
- Line 44: warning: exported method MockCollector.CollectError should have comment or be unexported (golint)
-
-
finala/collector/testutils/pointers.go
- Line 5: warning: exported function Int64Pointer should have comment or be unexported (golint)
- Line 9: warning: exported function Float64Pointer should have comment or be unexported (golint)
- Line 13: warning: exported function BoolPointer should have comment or be unexported (golint)
- Line 17: warning: exported function TimePointer should have comment or be unexported (golint)
-
-
finala/notifiers/notifier.go
- Line 14: warning: exported type NotifierMaker should have comment or be unexported (golint)
-
-
finala/collector/aws/run.go
- Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
-
-
finala/api/testutils/server.go
- Line 13: warning: exported type MockWebserver should have comment or be unexported (golint)
-
-
finala/api/storage/structs.go
- Line 12: warning: exported type StorageDescriber should have comment or be unexported (golint)
- Line 28: warning: exported type ExecutionCost should have comment or be unexported (golint)
- Line 44: warning: exported type SummaryData should have comment or be unexported (golint)
- Line 49: warning: exported type Summary should have comment or be unexported (golint)
- Line 56: warning: exported type EventRow should have comment or be unexported (golint)
- Line 65: warning: exported type ResourceData should have comment or be unexported (golint)
-
-
finala/notifiers/testutil/mocks.go
- Line 16: warning: exported function GetNotifierMakerMock should have comment or be unexported (golint)
- Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 33: warning: exported type NotifierMock should have comment or be unexported (golint)
- Line 37: warning: exported method NotifierMock.LoadConfig should have comment or be unexported (golint)
- Line 44: warning: exported method NotifierMock.GetNotifyByTags should have comment or be unexported (golint)
- Line 49: warning: exported method NotifierMock.Send should have comment or be unexported (golint)
- Line 53: warning: exported method NotifierMock.BuildSendURL should have comment or be unexported (golint)
-
-
finala/interpolation/interpolation.go
- Line 45: warning: exported function ExtractTimestamp should have comment or be unexported (golint)
- Line 54: warning: exported function ExtractExecutionName should have comment or be unexported (golint)
-
-
finala/api/storage/elasticsearch/testutils/client.go
- Line 27: warning: exported type MockClient should have comment or be unexported (golint)
- Line 33: warning: exported function NewESMock should have comment or be unexported (golint)
- Line 72: warning: exported function JSONResponse should have comment or be unexported (golint)
- Line 81: warning: exported function LoadResponse should have comment or be unexported (golint)
- Line 98: warning: exported function GetPostParams should have comment or be unexported (golint)
- Line 107: warning: exported function GetDummyDoc should have comment or be unexported (golint)
-
-
finala/webserver/response.go
- Line 3: warning: exported type SettingsResponse should have comment or be unexported (golint)
-
-
finala/notifiers/common/common.go
- Line 3: warning: exported type NotifierConfig should have comment or be unexported (golint)
- Line 4: warning: exported type NotifierName should have comment or be unexported (golint)
- Line 5: warning: exported type ConfigByName should have comment or be unexported (golint)
- Line 7: warning: exported type Notifier should have comment or be unexported (golint)
-
-
finala/api/testutils/version.go
- Line 7: warning: exported type MockVersion should have comment or be unexported (golint)
- Line 10: warning: exported function NewMockVersion should have comment or be unexported (golint)
- Line 14: warning: exported method MockVersion.Get should have comment or be unexported (golint)
-
-
finala/collector/aws/testutils/metric.go
- Line 7: warning: exported var DefaultMetricConfig should have comment or be unexported (golint)
-
-
finala/collector/aws/testutils/pricing.go
- Line 10: warning: exported type MockAWSPricingClient should have comment or be unexported (golint)
- Line 14: warning: exported method MockAWSPricingClient.GetProducts should have comment or be unexported (golint)
- Line 24: warning: exported function NewMockPricing should have comment or be unexported (golint)
-
-
finala/request/http.go
- Line 12: warning: exported type HTTPClientDescriber should have comment or be unexported (golint)
- Line 17: warning: exported type HttpError should have comment or be unexported (golint)
-
-
finala/api/storage/elasticsearch/elasticsearch.go
- Line 20: warning: exported var ErrInvalidQuery should have comment or be unexported (golint)
-
-
finala/collector/aws/testutils/cloudwatch.go
- Line 28: warning: exported type MockAWSCloudwatchClient should have comment or be unexported (golint)
- Line 32: warning: exported method MockAWSCloudwatchClient.GetMetricStatistics should have comment or be unexported (golint)
- Line 41: warning: exported function NewMockCloudwatch should have comment or be unexported (golint)
-
-
finala/collector/aws/testutils/detector.go
- Line 14: warning: exported type MockAWSManager should have comment or be unexported (golint)
- Line 24: warning: exported function AWSManager should have comment or be unexported (golint)
- Line 41: warning: exported method MockAWSManager.GetResourceIdentifier should have comment or be unexported (golint)
- Line 45: warning: exported method MockAWSManager.GetCollector should have comment or be unexported (golint)
- Line 49: warning: exported method MockAWSManager.GetCloudWatchClient should have comment or be unexported (golint)
- Line 53: warning: exported method MockAWSManager.GetPricingClient should have comment or be unexported (golint)
- Line 57: warning: exported method MockAWSManager.GetRegion should have comment or be unexported (golint)
- Line 61: warning: exported method MockAWSManager.GetSession should have comment or be unexported (golint)
- Line 65: warning: exported method MockAWSManager.GetAccountIdentity should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell92%
Misspell Finds commonly misspelled English words
-
-
finala/collector/aws/resources/elasticips.go
- Line 93: warning: "addressess" is a misspelling of "addresses" (misspell)
-
-
finala/interpolation/interpolation_test.go
- Line 43: warning: "retrived" is a misspelling of "retrieved" (misspell)
- Line 54: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 67: warning: "occured" is a misspelling of "occurred" (misspell)
-
-
finala/serverutil/server_test.go
- Line 56: warning: "funtion" is a misspelling of "function" (misspell)
-
-
finala/collector/aws/resources/dynamodb.go
- Line 73: warning: "happend" is a misspelling of "happened" (misspell)
-
-
finala/collector/aws/resources/kinesis.go
- Line 177: warning: "deafult" is a misspelling of "default" (misspell)
-
-
finala/cmd/root.go
- Line 16: warning: "contine" is a misspelling of "continue" (misspell)
-
-
finala/api/testutils/storage.go
- Line 125: warning: "collecton" is a misspelling of "collection" (misspell)
-
-
finala/collector/aws/detector.go
- Line 33: warning: "tje" is a misspelling of "the" (misspell)
-
-
finala/api/storage/elasticsearch/elasticsearch_test.go
- Line 15: warning: "successfull" is a misspelling of "successful" (misspell)
- Line 37: warning: "successfull" is a misspelling of "successful" (misspell)