Go Report Card

Preparing report...

Report for github.com/songtianyi/laosj

A    Great!    Found 10 issues across 10 files

Tweet
Last refresh:

Refresh now

gofmt90%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint0%

Golint is a linter for Go source code.

    • laosj/spider/utils.go
    • Line 21: warning: comment on exported function FindMaxFromSliceString should be of the form "FindMaxFromSliceString ..." (golint)
    • laosj/spider/wrapper.go
    • Line 24: warning: comment on exported type Spider should be of the form "Spider ..." (with optional leading article) (golint)
    • Line 30: warning: comment on exported function CreateSpiderFromUrl should be of the form "CreateSpiderFromUrl ..." (golint)
    • Line 39: warning: exported function CreateSpiderFromResponse should have comment or be unexported (golint)
    • Line 47: warning: exported method Spider.GetHtml should have comment or be unexported (golint)
    • Line 69: warning: exported method Spider.GetText should have comment or be unexported (golint)
    • Line 89: warning: exported method Spider.GetAttr should have comment or be unexported (golint)
    • laosj/downloader/redis.go
    • Line 31: warning: exported const URL_CACHE_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 127: warning: comment on exported method RedisDownloader.WaitCloser should be of the form "WaitCloser ..." (golint)
    • laosj/downloader/wrapper.go
    • Line 7: warning: exported type Downloader should have comment or be unexported (golint)
    • Line 13: warning: exported type Url should have comment or be unexported (golint)
    • Line 21: warning: exported const REALTIME should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported const URL_KEY_PREFIX should have comment (or a comment on this block) or be unexported (golint)
    • laosj/sources/aiss.go
    • Line 34: warning: exported const AISS_DEFAULT_WAITING_QUEUE should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported type ReqBody should have comment or be unexported (golint)
    • Line 42: warning: exported type Aiss should have comment or be unexported (golint)
    • Line 53: warning: exported function NewAiss should have comment or be unexported (golint)
    • Line 126: warning: exported method Aiss.GetOne should have comment or be unexported (golint)
    • Line 133: warning: exported method Aiss.GetAll should have comment or be unexported (golint)
    • Line 155: warning: exported method Aiss.SetReceiver should have comment or be unexported (golint)
    • Line 158: warning: exported method Aiss.Receiver should have comment or be unexported (golint)
    • Line 162: warning: exported method Aiss.Destination should have comment or be unexported (golint)
    • Line 166: warning: exported method Aiss.Name should have comment or be unexported (golint)
    • laosj/sources/douban-album.go
    • Line 31: warning: exported const DOUBAN_ALBUM_WAITTING_QUEUE should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type DoubanAlbum should have comment or be unexported (golint)
    • Line 48: warning: exported function NewDoubanAlbum should have comment or be unexported (golint)
    • Line 60: warning: exported method DoubanAlbum.GetOne should have comment or be unexported (golint)
    • Line 68: warning: exported method DoubanAlbum.GetAll should have comment or be unexported (golint)
    • Line 127: warning: exported method DoubanAlbum.Destination should have comment or be unexported (golint)
    • Line 131: warning: exported method DoubanAlbum.SetReceiver should have comment or be unexported (golint)
    • Line 135: warning: exported method DoubanAlbum.Receiver should have comment or be unexported (golint)
    • Line 139: warning: exported method DoubanAlbum.Name should have comment or be unexported (golint)
    • laosj/sources/mzitu.go
    • Line 29: warning: exported const MZITU_WAITTING_QUEUE should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: exported type Mzitu should have comment or be unexported (golint)
    • Line 45: warning: exported function NewMzitu should have comment or be unexported (golint)
    • Line 55: warning: exported method Mzitu.GetOne should have comment or be unexported (golint)
    • Line 63: warning: exported method Mzitu.GetAll should have comment or be unexported (golint)
    • Line 132: warning: exported method Mzitu.Destination should have comment or be unexported (golint)
    • Line 136: warning: exported method Mzitu.SetReceiver should have comment or be unexported (golint)
    • Line 140: warning: exported method Mzitu.Receiver should have comment or be unexported (golint)
    • Line 144: warning: exported method Mzitu.Name should have comment or be unexported (golint)
    • laosj/downloader/realtime.go
    • Line 15: warning: exported type RealtimeDownloader should have comment or be unexported (golint)
    • Line 28: warning: exported method RealtimeDownloader.Start should have comment or be unexported (golint)
    • Line 77: warning: comment on exported method RealtimeDownloader.WaitCloser should be of the form "WaitCloser ..." (golint)
    • laosj/sources/wrapper.go
    • Line 11: warning: exported type SourceWrapper should have comment or be unexported (golint)
    • Line 20: warning: comment on exported var EOS should be of the form "EOS ..." (golint)
    • Line 21: warning: error var EOS should have name of the form ErrFoo (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign80%

IneffAssign detects ineffectual assignments in Go code.

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!