Go Report Card

Preparing report...

Report for github.com/songxinjianqwe/scheduler

A+    Excellent!    Found 14 issues across 18 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint22%

Golint is a linter for Go source code.

    • scheduler/common/task.go
    • Line 12: warning: exported type Task should have comment or be unexported (golint)
    • Line 35: warning: exported function NewTask should have comment or be unexported (golint)
    • Line 47: warning: comment on exported method Task.PopulateTaskTimer should be of the form "PopulateTaskTimer ..." (golint)
    • Line 48: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 54: warning: exported method Task.PopulateTaskTicker should have comment or be unexported (golint)
    • Line 54: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 60: warning: comment on exported method Task.Execute should be of the form "Execute ..." (golint)
    • Line 66: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 100: warning: comment on exported method Task.Stop should be of the form "Stop ..." (golint)
    • Line 111: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 142: warning: comment on exported method Task.GetLatest should be of the form "GetLatest ..." (golint)
    • Line 143: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 158: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 171: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 189: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 195: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 200: warning: exported method Task.Clone should have comment or be unexported (golint)
    • Line 200: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 213: warning: exported method Task.PrintMe should have comment or be unexported (golint)
    • Line 213: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • scheduler/daemon/handler/handler.go
    • Line 23: warning: exported function GetAllTasksHandler should have comment or be unexported (golint)
    • Line 42: warning: exported function GetTaskInfoHandler should have comment or be unexported (golint)
    • Line 71: warning: exported function SubmitTask should have comment or be unexported (golint)
    • Line 94: warning: exported function StopTask should have comment or be unexported (golint)
    • Line 106: warning: exported function DeleteTask should have comment or be unexported (golint)
    • scheduler/cli/client/client.go
    • Line 14: warning: exported const ServerAddr should have comment (or a comment on this block) or be unexported (golint)
    • Line 17: warning: exported type SchedulerClient should have comment or be unexported (golint)
    • Line 21: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 30: warning: comment on exported method SchedulerClient.List should be of the form "List ..." (golint)
    • Line 33: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 52: warning: comment on exported method SchedulerClient.Submit should be of the form "Submit ..." (golint)
    • Line 55: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 77: warning: comment on exported method SchedulerClient.Get should be of the form "Get ..." (golint)
    • Line 80: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 102: warning: exported method SchedulerClient.Stop should have comment or be unexported (golint)
    • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 119: warning: exported method SchedulerClient.Delete should have comment or be unexported (golint)
    • Line 119: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • scheduler/common/status.go
    • Line 3: warning: comment on exported type TaskStatus should be of the form "TaskStatus ..." (with optional leading article) (golint)
    • scheduler/daemon/engine/standalone/standalone_engine_impl.go
    • Line 10: warning: exported type StandAloneEngine should have comment or be unexported (golint)
    • Line 17: warning: exported function NewStandAloneEngine should have comment or be unexported (golint)
    • Line 24: warning: exported method StandAloneEngine.Stop should have comment or be unexported (golint)
    • Line 24: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 32: warning: exported method StandAloneEngine.Delete should have comment or be unexported (golint)
    • Line 32: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 45: warning: exported method StandAloneEngine.Submit should have comment or be unexported (golint)
    • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 72: warning: comment on exported method StandAloneEngine.Get should be of the form "Get ..." (golint)
    • Line 73: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 82: warning: comment on exported method StandAloneEngine.List should be of the form "List ..." (golint)
    • Line 83: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • scheduler/common/result.go
    • Line 5: warning: exported type TaskResult should have comment or be unexported (golint)
    • Line 10: warning: exported function NewTaskResult should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!