Report for github.com/spotify/flyte-flink-plugin
(v0.1.10)
A+ Excellent! Found 7 issues across 14 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint50%
Golint is a linter for Go source code.
-
-
pkg/flink/validate.go
- Line 25: warning: exported function Validate should have comment or be unexported (golint)
- Line 45: warning: exported function ValidateRegEx should have comment or be unexported (golint)
-
-
pkg/flink/auth.go
- Line 25: warning: exported type ClusterConfig should have comment or be unexported (golint)
- Line 32: warning: exported type Auth should have comment or be unexported (golint)
- Line 37: warning: exported method Auth.GetCA should have comment or be unexported (golint)
- Line 45: warning: exported method Auth.GetToken should have comment or be unexported (golint)
-
-
pkg/flink/config.go
- Line 31: warning: exported function GetFlinkConfig should have comment or be unexported (golint)
-
-
pkg/flink/constants.go
- Line 27: warning: exported const KindFlinkCluster should have comment (or a comment on this block) or be unexported (golint)
- Line 28: warning: comment on exported const FlinkTaskType should be of the form "FlinkTaskType ..." (golint)
-
-
pkg/flink/handler.go
- Line 41: warning: exported type FlinkTaskContext should have comment or be unexported (golint)
- Line 49: warning: exported function NewFlinkTaskContext should have comment or be unexported (golint)
-
-
pkg/flink/resources.go
- Line 38: warning: exported type ContainerTemplateData should have comment or be unexported (golint)
- Line 43: warning: exported function NewContainerTemplateData should have comment or be unexported (golint)
- Line 50: warning: exported type FlinkPropertiesTemplateData should have comment or be unexported (golint)
- Line 56: warning: exported function NewFlinkPropertiesTemplateData should have comment or be unexported (golint)
- Line 64: warning: exported function GroupByScheme should have comment or be unexported (golint)
- Line 73: warning: exported type FlinkCluster should have comment or be unexported (golint)
- Line 278: warning: exported function NewFlinkCluster should have comment or be unexported (golint)
-
-
pkg/flink/types.go
- Line 25: warning: exported type Properties should have comment or be unexported (golint)
- Line 27: warning: exported function MergeProperties should have comment or be unexported (golint)
- Line 39: warning: exported method Properties.GetInt should have comment or be unexported (golint)
- Line 48: warning: exported type Annotations should have comment or be unexported (golint)
- Line 50: warning: exported function GetDefaultAnnotations should have comment or be unexported (golint)
- Line 57: warning: exported type Labels should have comment or be unexported (golint)
- Line 59: warning: exported function GetDefaultLabels should have comment or be unexported (golint)
- Line 66: warning: exported type ClusterName should have comment or be unexported (golint)
- Line 68: warning: exported method ClusterName.Validate should have comment or be unexported (golint)
- Line 76: warning: exported function NewClusterName should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!