gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint70%

Golint is a linter for Go source code.

• operator/controllers/storageoscluster/before_install_operand.go
  • Line 19: warning: exported type BeforeInstallOperand should have comment or be unexported (golint)
  • Line 30: warning: exported method BeforeInstallOperand.Name should have comment or be unexported (golint)
  • Line 31: warning: exported method BeforeInstallOperand.Requires should have comment or be unexported (golint)
  • Line 32: warning: exported method BeforeInstallOperand.RequeueStrategy should have comment or be unexported (golint)
  • Line 33: warning: exported method BeforeInstallOperand.ReadyCheck should have comment or be unexported (golint)
  • Line 36: warning: exported method BeforeInstallOperand.PostReady should have comment or be unexported (golint)
  • Line 36: warning: receiver name c should be consistent with previous receiver name bi for BeforeInstallOperand (golint)
  • Line 38: warning: exported method BeforeInstallOperand.Ensure should have comment or be unexported (golint)
  • Line 51: warning: exported method BeforeInstallOperand.Delete should have comment or be unexported (golint)
  • Line 70: warning: exported function NewBeforeInstallOperand should have comment or be unexported (golint)

• operator/internal/storageos/client.go
  • Line 66: warning: comment on exported function Mock should be of the form "Mock ..." (golint)

• operator/controllers/storageoscluster/after_install_operand.go
  • Line 19: warning: exported type AfterInstallOperand should have comment or be unexported (golint)
  • Line 30: warning: exported method AfterInstallOperand.Name should have comment or be unexported (golint)
  • Line 31: warning: exported method AfterInstallOperand.Requires should have comment or be unexported (golint)
  • Line 32: warning: exported method AfterInstallOperand.RequeueStrategy should have comment or be unexported (golint)
  • Line 33: warning: exported method AfterInstallOperand.ReadyCheck should have comment or be unexported (golint)
  • Line 36: warning: exported method AfterInstallOperand.PostReady should have comment or be unexported (golint)
  • Line 36: warning: receiver name c should be consistent with previous receiver name ai for AfterInstallOperand (golint)
  • Line 38: warning: exported method AfterInstallOperand.Ensure should have comment or be unexported (golint)
  • Line 51: warning: exported method AfterInstallOperand.Delete should have comment or be unexported (golint)
  • Line 70: warning: exported function NewAfterInstallOperand should have comment or be unexported (golint)

• operator/controllers/storageoscluster/api-manager_operand.go
  • Line 37: warning: exported type APIManagerOperand should have comment or be unexported (golint)
  • Line 48: warning: exported method APIManagerOperand.Name should have comment or be unexported (golint)
  • Line 49: warning: exported method APIManagerOperand.Requires should have comment or be unexported (golint)
  • Line 50: warning: exported method APIManagerOperand.RequeueStrategy should have comment or be unexported (golint)
  • Line 52: warning: exported method APIManagerOperand.ReadyCheck should have comment or be unexported (golint)
  • Line 73: warning: exported method APIManagerOperand.PostReady should have comment or be unexported (golint)
  • Line 75: warning: exported method APIManagerOperand.Ensure should have comment or be unexported (golint)
  • Line 88: warning: exported method APIManagerOperand.Delete should have comment or be unexported (golint)
  • Line 155: warning: exported function NewAPIManagerOperand should have comment or be unexported (golint)

• operator/controllers/storageoscluster/csi_operand.go
  • Line 40: warning: exported type CSIOperand should have comment or be unexported (golint)
  • Line 51: warning: exported method CSIOperand.Name should have comment or be unexported (golint)
  • Line 52: warning: exported method CSIOperand.Requires should have comment or be unexported (golint)
  • Line 53: warning: exported method CSIOperand.RequeueStrategy should have comment or be unexported (golint)
  • Line 55: warning: exported method CSIOperand.ReadyCheck should have comment or be unexported (golint)
  • Line 75: warning: exported method CSIOperand.PostReady should have comment or be unexported (golint)
  • Line 77: warning: exported method CSIOperand.Ensure should have comment or be unexported (golint)
  • Line 90: warning: exported method CSIOperand.Delete should have comment or be unexported (golint)
  • Line 138: warning: exported function NewCSIOperand should have comment or be unexported (golint)

• operator/controllers/storageoscluster/node_operand.go
  • Line 69: warning: exported type NodeOperand should have comment or be unexported (golint)
  • Line 80: warning: exported method NodeOperand.Name should have comment or be unexported (golint)
  • Line 81: warning: exported method NodeOperand.Requires should have comment or be unexported (golint)
  • Line 82: warning: exported method NodeOperand.RequeueStrategy should have comment or be unexported (golint)
  • Line 84: warning: exported method NodeOperand.ReadyCheck should have comment or be unexported (golint)
  • Line 107: warning: exported method NodeOperand.Ensure should have comment or be unexported (golint)
  • Line 122: warning: exported method NodeOperand.Delete should have comment or be unexported (golint)
  • Line 363: warning: exported function NewNodeOperand should have comment or be unexported (golint)

• operator/controllers/storageoscluster/operator.go
  • Line 39: warning: exported function NewOperator should have comment or be unexported (golint)
  • Line 94: warning: exported function NewStorageOSClusterController should have comment or be unexported (golint)

• operator/controllers/storageoscluster/scheduler_operand.go
  • Line 36: warning: exported type SchedulerOperand should have comment or be unexported (golint)
  • Line 47: warning: exported method SchedulerOperand.Name should have comment or be unexported (golint)
  • Line 48: warning: exported method SchedulerOperand.Requires should have comment or be unexported (golint)
  • Line 49: warning: exported method SchedulerOperand.RequeueStrategy should have comment or be unexported (golint)
  • Line 51: warning: exported method SchedulerOperand.ReadyCheck should have comment or be unexported (golint)
  • Line 71: warning: exported method SchedulerOperand.PostReady should have comment or be unexported (golint)
  • Line 73: warning: exported method SchedulerOperand.Ensure should have comment or be unexported (golint)
  • Line 86: warning: exported method SchedulerOperand.Delete should have comment or be unexported (golint)
  • Line 141: warning: exported function NewSchedulerOperand should have comment or be unexported (golint)

• operator/controllers/storageoscluster/storageclass_operand.go
  • Line 37: warning: exported type StorageClassOperand should have comment or be unexported (golint)
  • Line 48: warning: exported method StorageClassOperand.Name should have comment or be unexported (golint)
  • Line 49: warning: exported method StorageClassOperand.Requires should have comment or be unexported (golint)
  • Line 50: warning: exported method StorageClassOperand.RequeueStrategy should have comment or be unexported (golint)
  • Line 51: warning: exported method StorageClassOperand.ReadyCheck should have comment or be unexported (golint)
  • Line 54: warning: exported method StorageClassOperand.PostReady should have comment or be unexported (golint)
  • Line 54: warning: receiver name c should be consistent with previous receiver name sc for StorageClassOperand (golint)
  • Line 56: warning: exported method StorageClassOperand.Ensure should have comment or be unexported (golint)
  • Line 73: warning: exported method StorageClassOperand.Delete should have comment or be unexported (golint)
  • Line 120: warning: exported function NewStorageClassOperand should have comment or be unexported (golint)

• operator/controllers/storageoscluster_controller.go
  • Line 41: warning: exported function NewStorageOSClusterReconciler should have comment or be unexported (golint)

• operator/controllers/storageoscluster/common.go
  • Line 11: warning: error var noResourceErr should have name of the form errFoo (golint)

• operator/controllers/storageoscluster/controller.go
  • Line 32: warning: exported type StorageOSClusterController should have comment or be unexported (golint)
  • Line 39: warning: exported method StorageOSClusterController.Default should have comment or be unexported (golint)
  • Line 41: warning: exported method StorageOSClusterController.Validate should have comment or be unexported (golint)
  • Line 43: warning: exported method StorageOSClusterController.Initialize should have comment or be unexported (golint)
  • Line 58: warning: exported method StorageOSClusterController.Operate should have comment or be unexported (golint)
  • Line 64: warning: exported method StorageOSClusterController.Cleanup should have comment or be unexported (golint)
  • Line 70: warning: exported method StorageOSClusterController.UpdateStatus should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• operator/controllers/storageoscluster/node_operand_test.go
  • Line 14: warning: no required module provides package github.com/storageos/operator/internal/storageos/mocks; to add it: (ineffassign)
  • Line 14: warning: could not import github.com/storageos/operator/internal/storageos/mocks (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!