Go Report Card

Preparing report...

Report for github.com/teamnsrg/mida

A    Great!    Found 17 issues across 27 files

Tweet
Last refresh:

Refresh now

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo77%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • mida/build_task.go
    • Line 17: warning: cyclomatic complexity 53 of function BuildCompressedTaskSet() is high (> 15) (gocyclo)
    • mida/postprocess/devtools.go
    • Line 24: warning: cyclomatic complexity 23 of function DevTools() is high (> 15) (gocyclo)
    • Line 148: warning: cyclomatic complexity 17 of function buildCovMapping() is high (> 15) (gocyclo)
    • mida/sanitize/sanitize.go
    • Line 338: warning: cyclomatic complexity 33 of function DataSettings() is high (> 15) (gocyclo)
    • Line 127: warning: cyclomatic complexity 29 of function getBrowserBinaryPath() is high (> 15) (gocyclo)
    • Line 208: warning: cyclomatic complexity 18 of function getBrowserFlags() is high (> 15) (gocyclo)

golint51%

Golint is a linter for Go source code.

    • mida/storage/sftp.go
    • Line 23: warning: exported type SftpParams should have comment or be unexported (golint)
    • Line 31: warning: exported function Sftp should have comment or be unexported (golint)
    • Line 85: warning: exported function StoreResultsSSH should have comment or be unexported (golint)
    • mida/amqp/amqp.go
    • Line 16: warning: exported type ConnParams should have comment or be unexported (golint)
    • Line 22: warning: exported type Consumer should have comment or be unexported (golint)
    • Line 149: warning: exported function NewAMQPTasksConsumer should have comment or be unexported (golint)
    • Line 218: warning: comment on exported function NewAMQPBroadcastConsumer should be of the form "NewAMQPBroadcastConsumer ..." (golint)
    • Line 299: warning: comment on exported method Consumer.Shutdown should be of the form "Shutdown ..." (golint)
    • Line 313: warning: comment on exported function DecodeAMQPMessageToRawTask should be of the form "DecodeAMQPMessageToRawTask ..." (golint)
    • mida/browser/devtools_events.go
    • Line 22: warning: context.Context should be the first parameter of a function (golint)
    • Line 60: warning: context.Context should be the first parameter of a function (golint)
    • Line 60: warning: exported function PageFrameNavigated should have comment or be unexported (golint)
    • Line 91: warning: context.Context should be the first parameter of a function (golint)
    • Line 126: warning: context.Context should be the first parameter of a function (golint)
    • Line 158: warning: context.Context should be the first parameter of a function (golint)
    • Line 185: warning: context.Context should be the first parameter of a function (golint)
    • Line 245: warning: context.Context should be the first parameter of a function (golint)
    • Line 300: warning: context.Context should be the first parameter of a function (golint)
    • Line 300: warning: exported function TargetTargetCreated should have comment or be unexported (golint)
    • Line 343: warning: context.Context should be the first parameter of a function (golint)
    • mida/sanitize/sanitize.go
    • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 92: warning: exported function InteractionSettings should have comment or be unexported (golint)
    • Line 283: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 319: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 329: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 443: warning: exported function LocalOutputSettings should have comment or be unexported (golint)
    • Line 471: warning: exported function SftpOutputSettings should have comment or be unexported (golint)
    • Line 537: warning: exported function ExpandPath should have comment or be unexported (golint)
    • Line 545: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • mida/log/log.go
    • Line 10: warning: comment on exported var Log should be of the form "Log ..." (golint)
    • Line 13: warning: exported function InitGlobalLogger should have comment or be unexported (golint)
    • Line 39: warning: comment on exported function ConfigureLogging should be of the form "ConfigureLogging ..." (golint)
    • mida/base/base.go
    • Line 1: warning: package comment should be of the form "Package base ..." (golint)
    • Line 19: warning: comment on exported type InteractionSettings should be of the form "InteractionSettings ..." (with optional leading article) (golint)
    • Line 27: warning: comment on exported type BrowserSettings should be of the form "BrowserSettings ..." (with optional leading article) (golint)
    • Line 38: warning: comment on exported type CompletionCondition should be of the form "CompletionCondition ..." (with optional leading article) (golint)
    • Line 42: warning: exported const TimeoutOnly should have comment (or a comment on this block) or be unexported (golint)
    • Line 47: warning: exported var CompletionConditions should have comment or be unexported (golint)
    • Line 49: warning: comment on exported type CompletionSettings should be of the form "CompletionSettings ..." (with optional leading article) (golint)
    • Line 56: warning: comment on exported type DataSettings should be of the form "DataSettings ..." (with optional leading article) (golint)
    • Line 68: warning: comment on exported type LocalOutputSettings should be of the form "LocalOutputSettings ..." (with optional leading article) (golint)
    • Line 75: warning: comment on exported type SftpOutputSettings should be of the form "SftpOutputSettings ..." (with optional leading article) (golint)
    • Line 86: warning: comment on exported type OutputSettings should be of the form "OutputSettings ..." (with optional leading article) (golint)
    • Line 93: warning: comment on exported type RawTask should be of the form "RawTask ..." (with optional leading article) (golint)
    • Line 103: warning: comment on exported type SanitizedTask should be of the form "SanitizedTask ..." (with optional leading article) (golint)
    • Line 119: warning: comment on exported type TaskSet should be of the form "TaskSet ..." (with optional leading article) (golint)
    • Line 122: warning: comment on exported type CompressedTaskSet should be of the form "CompressedTaskSet ..." (with optional leading article) (golint)
    • Line 134: warning: comment on exported type TaskWrapper should be of the form "TaskWrapper ..." (with optional leading article) (golint)
    • Line 148: warning: comment on exported type TaskTiming should be of the form "TaskTiming ..." (with optional leading article) (golint)
    • Line 160: warning: comment on exported type TaskSummary should be of the form "TaskSummary ..." (with optional leading article) (golint)
    • Line 178: warning: comment on exported type CrawlerInfo should be of the form "CrawlerInfo ..." (with optional leading article) (golint)
    • Line 186: warning: exported type DevToolsNetworkRawData should have comment or be unexported (golint)
    • Line 191: warning: exported type DevToolsScriptRawData should have comment or be unexported (golint)
    • Line 193: warning: exported type DevToolsRawData should have comment or be unexported (golint)
    • Line 200: warning: comment on exported type RawResult should be of the form "RawResult ..." (with optional leading article) (golint)
    • Line 207: warning: exported type DTResource should have comment or be unexported (golint)
    • Line 212: warning: exported type FinalResult should have comment or be unexported (golint)
    • Line 220: warning: exported function AllocateNewCompressedTaskSet should have comment or be unexported (golint)
    • Line 310: warning: exported function AllocateNewLocalOutputSettings should have comment or be unexported (golint)
    • Line 319: warning: exported function AllocateNewSftpOutputSettings should have comment or be unexported (golint)
    • mida/base/defaults.go
    • Line 4: warning: comment on exported const DefaultLocalOutputPath should be of the form "DefaultLocalOutputPath ..." (golint)
    • Line 6: warning: exported const DefaultPostQueue should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: comment on exported const DefaultOSXChromePath should be of the form "DefaultOSXChromePath ..." (golint)
    • Line 35: warning: comment on exported const DefaultTimeAfterLoad should be of the form "DefaultTimeAfterLoad ..." (golint)
    • Line 40: warning: comment on exported const DefaultNavLockAfterLoad should be of the form "DefaultNavLockAfterLoad ..." (golint)
    • Line 46: warning: comment on exported const DefaultAllResources should be of the form "DefaultAllResources ..." (golint)
    • Line 63: warning: comment on exported var DefaultChromiumBrowserFlags should be of the form "DefaultChromiumBrowserFlags ..." (golint)
    • mida/postprocess/devtools.go
    • Line 24: warning: exported function DevTools should have comment or be unexported (golint)
    • Line 244: warning: exported function ParseMergedTextfile should have comment or be unexported (golint)
    • Line 326: warning: exported function WriteCovFile should have comment or be unexported (golint)
    • mida/storage/storage.go
    • Line 16: warning: exported type SftpConn should have comment or be unexported (golint)
    • Line 21: warning: exported type ConnInfo should have comment or be unexported (golint)
    • Line 35: warning: exported function StoreAll should have comment or be unexported (golint)
    • mida/amqp/defaults.go
    • Line 4: warning: exported const DefaultTls should have comment (or a comment on this block) or be unexported (golint)
    • mida/build_task.go
    • Line 17: warning: exported function BuildCompressedTaskSet should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign88%

IneffAssign detects ineffectual assignments in Go code.

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!