gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• pkg/controller/core.oam.dev/v1alpha2/application/assemble/assemble_suite_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/cue/packages/package_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint97%

Golint is a linter for Go source code.

• e2e/cli.go
  • Line 83: warning: exported function LongTimeExecWithEnv should have comment or be unexported (golint)
  • Line 134: warning: exported function BeforeSuit should have comment or be unexported (golint)

• e2e/commonContext.go
  • Line 63: warning: exported var EnvInitWithNamespaceOptionContext should have comment or be unexported (golint)

• pkg/controller/core.oam.dev/oamruntime_controller.go
  • Line 17: warning: don't use an underscore in package name (golint)

• pkg/webhook/core.oam.dev/register.go
  • Line 17: warning: don't use an underscore in package name (golint)

• test/e2e-apiserver-test/utils.go
  • Line 17: warning: don't use an underscore in package name (golint)
  • Line 29: warning: exported const TestNSprefix should have comment or be unexported (golint)

• apis/core.oam.dev/groupversion_info.go
  • Line 18: warning: don't use an underscore in package name (golint)

• pkg/controller/core.oam.dev/v1alpha2/application/apply_test.go
  • Line 267: warning: don't use underscores in Go names; var deleteResc_1 should be deleteResc1 (golint)
  • Line 268: warning: don't use underscores in Go names; var deleteResc_2 should be deleteResc2 (golint)

• test/e2e-apiserver-test/env_test.go
  • Line 17: warning: don't use an underscore in package name (golint)

• pkg/builtin/build/build.go
  • Line 36: warning: exported function ImageBuildHandler should have comment or be unexported (golint)

• pkg/builtin/http/http.go
  • Line 96: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/builtin/registry/registry.go
  • Line 39: warning: exported function GetTasks should have comment or be unexported (golint)

• pkg/controller/core.oam.dev/doc.go
  • Line 17: warning: don't use an underscore in package name (golint)

• test/e2e-apiserver-test/cluster_test.go
  • Line 17: warning: don't use an underscore in package name (golint)

• pkg/builtin/kind/client.go
  • Line 35: warning: exported function LoadDockerImage should have comment or be unexported (golint)
  • Line 39: warning: exported function LoadDockerImages should have comment or be unexported (golint)
  • Line 43: warning: exported function LoadDockerImagesWithFlags should have comment or be unexported (golint)

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• pkg/controller/core.oam.dev/v1alpha2/application/revision.go
  • Line 186: warning: cyclomatic complexity 18 of function (*AppHandler).gatherRevisionSpec() is high (> 15) (gocyclo)
  • Line 284: warning: cyclomatic complexity 16 of function ComputeAppRevisionHash() is high (> 15) (gocyclo)

• pkg/appfile/parser.go
  • Line 81: warning: cyclomatic complexity 17 of function (*Parser).GenerateAppFile() is high (> 15) (gocyclo)

• references/appfile/addon.go
  • Line 50: warning: cyclomatic complexity 17 of function ApplyTerraform() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/applicationconfiguration/apply_test.go
  • Line 52: warning: cyclomatic complexity 17 of function TestApplyWorkloads() is high (> 15) (gocyclo)
  • Line 677: warning: cyclomatic complexity 16 of function TestApplyInputRef() is high (> 15) (gocyclo)
  • Line 547: warning: cyclomatic complexity 16 of function TestApplyOutputRef() is high (> 15) (gocyclo)

• pkg/definition/definition.go
  • Line 192: warning: cyclomatic complexity 27 of function (*Definition).FromCUE() is high (> 15) (gocyclo)
  • Line 293: warning: cyclomatic complexity 21 of function (*Definition).FromCUEString() is high (> 15) (gocyclo)

• references/cli/def.go
  • Line 159: warning: cyclomatic complexity 27 of function NewDefinitionInitCommand() is high (> 15) (gocyclo)
  • Line 643: warning: cyclomatic complexity 21 of function NewDefinitionRenderCommand() is high (> 15) (gocyclo)
  • Line 544: warning: cyclomatic complexity 16 of function NewDefinitionEditCommand() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/core/scopes/healthscope/healthscope.go
  • Line 405: warning: cyclomatic complexity 22 of function CUEBasedHealthCheck() is high (> 15) (gocyclo)

• pkg/resourcekeeper/statekeep_suite.go
  • Line 30: warning: cyclomatic complexity 17 of function (*resourceKeeper).StateKeep() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/applicationconfiguration/render_test.go
  • Line 56: warning: cyclomatic complexity 39 of function TestRender() is high (> 15) (gocyclo)

• pkg/controller/utils/capability.go
  • Line 142: warning: cyclomatic complexity 25 of function GetOpenAPISchemaFromTerraformComponentDefinition() is high (> 15) (gocyclo)

• pkg/apiserver/rest/usecase/application.go
  • Line 735: warning: cyclomatic complexity 24 of function (*applicationUsecaseImpl).renderOAMApplication() is high (> 15) (gocyclo)
  • Line 147: warning: cyclomatic complexity 20 of function listApp() is high (> 15) (gocyclo)
  • Line 914: warning: cyclomatic complexity 20 of function (*applicationUsecaseImpl).DeleteApplication() is high (> 15) (gocyclo)
  • Line 632: warning: cyclomatic complexity 18 of function (*applicationUsecaseImpl).Deploy() is high (> 15) (gocyclo)

• references/cli/install.go
  • Line 70: warning: cyclomatic complexity 22 of function NewInstallCommand() is high (> 15) (gocyclo)

• references/common/workload.go
  • Line 55: warning: cyclomatic complexity 22 of function BaseComplete() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/applicationconfiguration/component_test.go
  • Line 42: warning: cyclomatic complexity 19 of function TestComponentHandler() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/core/scopes/healthscope/healthscope_test.go
  • Line 400: warning: cyclomatic complexity 16 of function TestCheckVersionEnabledComponent() is high (> 15) (gocyclo)

• cmd/core/main.go
  • Line 69: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/applicationconfiguration/apply.go
  • Line 103: warning: cyclomatic complexity 17 of function (*workloads).Apply() is high (> 15) (gocyclo)

• pkg/apiserver/rest/usecase/addon.go
  • Line 226: warning: cyclomatic complexity 16 of function (*defaultAddonHandler).ListAddons() is high (> 15) (gocyclo)

• pkg/workflow/workflow.go
  • Line 88: warning: cyclomatic complexity 22 of function (*workflow).ExecuteSteps() is high (> 15) (gocyclo)

• references/plugins/cluster.go
  • Line 295: warning: cyclomatic complexity 21 of function GetCapabilityByName() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go
  • Line 104: warning: cyclomatic complexity 35 of function (*Reconciler).Reconcile() is high (> 15) (gocyclo)

• references/cli/init.go
  • Line 195: warning: cyclomatic complexity 27 of function (*appInitOptions).Workload() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/applicationconfiguration/render.go
  • Line 156: warning: cyclomatic complexity 25 of function (*components).renderComponent() is high (> 15) (gocyclo)

• pkg/resourcekeeper/gc.go
  • Line 321: warning: cyclomatic complexity 24 of function (*gcHandler).GarbageCollectLegacyResourceTrackers() is high (> 15) (gocyclo)
  • Line 278: warning: cyclomatic complexity 16 of function (*gcHandler).GarbageCollectComponentRevisionResourceTracker() is high (> 15) (gocyclo)

• apis/standard.oam.dev/v1alpha1/rollout_state.go
  • Line 256: warning: cyclomatic complexity 26 of function (*RolloutStatus).StateTransition() is high (> 15) (gocyclo)

• pkg/policy/envbinding/patch.go
  • Line 151: warning: cyclomatic complexity 17 of function PatchComponents() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/core/scopes/healthscope/healthscope_controller.go
  • Line 200: warning: cyclomatic complexity 23 of function (*Reconciler).GetScopeHealthStatus() is high (> 15) (gocyclo)
  • Line 543: warning: cyclomatic complexity 22 of function (*Reconciler).createWorkloadRefs() is high (> 15) (gocyclo)

• pkg/webhook/core.oam.dev/v1alpha2/applicationconfiguration/validating_handler.go
  • Line 246: warning: cyclomatic complexity 19 of function ValidateTraitConflictFn() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/applicationconfiguration/applicationconfiguration_test.go
  • Line 904: warning: cyclomatic complexity 49 of function TestDependency() is high (> 15) (gocyclo)
  • Line 83: warning: cyclomatic complexity 20 of function TestReconciler() is high (> 15) (gocyclo)

• pkg/appfile/appfile.go
  • Line 676: warning: cyclomatic complexity 27 of function generateTerraformConfigurationWorkload() is high (> 15) (gocyclo)

• pkg/controller/standard.oam.dev/v1alpha1/rollout/rollout_controller.go
  • Line 61: warning: cyclomatic complexity 26 of function (*reconciler).Reconcile() is high (> 15) (gocyclo)

• pkg/cue/model/sets/operation.go
  • Line 108: warning: cyclomatic complexity 20 of function strategyPatchHandle() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/application/assemble/options.go
  • Line 57: warning: cyclomatic complexity 17 of function discoverHelmModuleWorkload() is high (> 15) (gocyclo)

• pkg/apiserver/rest/usecase/cluster.go
  • Line 299: warning: cyclomatic complexity 18 of function (*clusterUsecaseImpl).ModifyKubeCluster() is high (> 15) (gocyclo)

• references/cli/show.go
  • Line 96: warning: cyclomatic complexity 29 of function startReferenceDocsSite() is high (> 15) (gocyclo)

• references/plugins/references.go
  • Line 630: warning: cyclomatic complexity 26 of function (*MarkdownReference).CreateMarkdown() is high (> 15) (gocyclo)
  • Line 841: warning: cyclomatic complexity 20 of function (*ParseReference).parseParameters() is high (> 15) (gocyclo)

• pkg/controller/core.oam.dev/v1alpha2/applicationconfiguration/applicationconfiguration.go
  • Line 695: warning: cyclomatic complexity 22 of function applyOnceOnly() is high (> 15) (gocyclo)

• pkg/builtin/http/http.go
  • Line 45: warning: cyclomatic complexity 17 of function (*HTTPCmd).Run() is high (> 15) (gocyclo)

• pkg/cue/model/sets/utils.go
  • Line 36: warning: cyclomatic complexity 17 of function lookUp() is high (> 15) (gocyclo)

• references/appfile/dryrun/diff.go
  • Line 143: warning: cyclomatic complexity 24 of function (*LiveDiffOption).calculateDiff() is high (> 15) (gocyclo)

• pkg/apiserver/datastore/kubeapi/kubeapi.go
  • Line 331: warning: cyclomatic complexity 23 of function (*kubeapi).List() is high (> 15) (gocyclo)

• pkg/appfile/template.go
  • Line 153: warning: cyclomatic complexity 20 of function LoadTemplateFromRevision() is high (> 15) (gocyclo)
  • Line 72: warning: cyclomatic complexity 18 of function LoadTemplate() is high (> 15) (gocyclo)

• pkg/cue/model/sets/walk.go
  • Line 47: warning: cyclomatic complexity 19 of function (*nodewalker).walk() is high (> 15) (gocyclo)

• pkg/multicluster/cluster_management.go
  • Line 129: warning: cyclomatic complexity 19 of function (*KubeClusterConfig).RegisterClusterManagedByOCM() is high (> 15) (gocyclo)

• pkg/controller/common/rollout/rollout_plan_controller.go
  • Line 76: warning: cyclomatic complexity 19 of function (*Controller).Reconcile() is high (> 15) (gocyclo)

• pkg/workflow/providers/oam/apply.go
  • Line 209: warning: cyclomatic complexity 18 of function (*provider).loadDynamicComponent() is high (> 15) (gocyclo)

• hack/docgen/gen.go
  • Line 98: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• pkg/workflow/tasks/custom/task.go
  • Line 106: warning: cyclomatic complexity 26 of function (*TaskLoader).makeTaskGenerator() is high (> 15) (gocyclo)
  • Line 332: warning: cyclomatic complexity 17 of function (*executor).doSteps() is high (> 15) (gocyclo)

• pkg/addon/addon.go
  • Line 458: warning: cyclomatic complexity 25 of function RenderApp() is high (> 15) (gocyclo)

• references/cli/logs.go
  • Line 103: warning: cyclomatic complexity 24 of function (*Args).Run() is high (> 15) (gocyclo)

• pkg/apiserver/rest/usecase/definition.go
  • Line 100: warning: cyclomatic complexity 16 of function (*definitionUsecaseImpl).listDefinitions() is high (> 15) (gocyclo)

• pkg/workflow/recorder/recorder_test.go
  • Line 80: warning: cyclomatic complexity 16 of function makeMockClient() is high (> 15) (gocyclo)

• pkg/velaql/providers/query/handler.go
  • Line 173: warning: cyclomatic complexity 28 of function (*provider).GeneratorServiceEndpoints() is high (> 15) (gocyclo)
  • Line 302: warning: cyclomatic complexity 17 of function (*provider).CollectLogsInPod() is high (> 15) (gocyclo)

• pkg/definition/definition_test.go
  • Line 32: warning: cyclomatic complexity 20 of function TestDefinitionBasicFunctions() is high (> 15) (gocyclo)

• pkg/builtin/kind/client.go
  • Line 43: warning: cyclomatic complexity 18 of function LoadDockerImagesWithFlags() is high (> 15) (gocyclo)

• apis/core.oam.dev/v1beta1/zz_generated.deepcopy.go
  • Line 169: warning: cyclomatic complexity 17 of function (*ApplicationRevisionSpec).DeepCopyInto() is high (> 15) (gocyclo)

• pkg/cue/definition/template.go
  • Line 289: warning: cyclomatic complexity 30 of function (*traitDef).Complete() is high (> 15) (gocyclo)
  • Line 87: warning: cyclomatic complexity 19 of function (*workloadDef).Complete() is high (> 15) (gocyclo)

• references/cli/portforward.go
  • Line 221: warning: cyclomatic complexity 26 of function (*VelaPortForwardOptions).Complete() is high (> 15) (gocyclo)

• pkg/apiserver/datastore/mongodb/mongodb.go
  • Line 204: warning: cyclomatic complexity 20 of function (*mongodb).List() is high (> 15) (gocyclo)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!