gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• venderctl/cmd/venderctl/tax/ru2019.go
  • Line 59: warning: cyclomatic complexity 19 of function processRu2019() is high (> 15) (gocyclo)

• venderctl/cmd/venderctl/control/cmd-control.go
  • Line 34: warning: cyclomatic complexity 17 of function controlMain() is high (> 15) (gocyclo)

• venderctl/internal/tele/mqtt.go
  • Line 223: warning: cyclomatic complexity 17 of function (*tele).mqttAuthorize() is high (> 15) (gocyclo)

golint20%

Golint is a linter for Go source code.

• venderctl/internal/tele/secrets.go
  • Line 15: warning: comment on exported type Secrets should be of the form "Secrets ..." (with optional leading article) (golint)
  • Line 22: warning: exported method Secrets.CachedReadFile should have comment or be unexported (golint)
  • Line 32: warning: comment on exported method Secrets.UnsafeReadFile should be of the form "UnsafeReadFile ..." (golint)
  • Line 43: warning: comment on exported method Secrets.UnsafeReadFrom should be of the form "UnsafeReadFrom ..." (golint)
  • Line 69: warning: exported method Secrets.WriteFile should have comment or be unexported (golint)
  • Line 91: warning: exported method Secrets.UnsafeWriteTo should have comment or be unexported (golint)
  • Line 109: warning: comment on exported method Secrets.UnsafeSet should be of the form "UnsafeSet ..." (golint)
  • Line 119: warning: exported method Secrets.Verify should have comment or be unexported (golint)

• venderctl/cmd/venderctl/main.go
  • Line 34: warning: exported var BuildVersion should have comment or be unexported (golint)

• venderctl/internal/state/config.go
  • Line 16: warning: exported type Config should have comment or be unexported (golint)
  • Line 20: warning: don't use underscores in Go names; struct field XXX_Include should be XXXInclude (golint)
  • Line 39: warning: don't use underscores in Go names; struct field XXX_testRT should be XXXTestRT (golint)
  • Line 45: warning: don't use underscores in Go names; struct field _copy_guard should be _copyGuard (golint)
  • Line 48: warning: exported type ConfigSource should have comment or be unexported (golint)
  • Line 53: warning: exported method Config.ScaleI should have comment or be unexported (golint)
  • Line 56: warning: exported method Config.ScaleU should have comment or be unexported (golint)
  • Line 57: warning: exported method Config.ScaleA should have comment or be unexported (golint)
  • Line 102: warning: exported function ReadConfig should have comment or be unexported (golint)
  • Line 122: warning: exported function MustReadConfig should have comment or be unexported (golint)

• venderctl/cmd/internal/cli/cmd.go
  • Line 12: warning: exported type Cmd should have comment or be unexported (golint)
  • Line 19: warning: exported function IsHelp should have comment or be unexported (golint)
  • Line 27: warning: exported function SdNotify should have comment or be unexported (golint)

• venderctl/internal/tele/api/interface.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 12: warning: exported type Teler should have comment or be unexported (golint)
  • Line 22: warning: exported function NewStub should have comment or be unexported (golint)

• venderctl/cmd/venderctl/control/cmd-control.go
  • Line 27: warning: exported var Cmd should have comment or be unexported (golint)
  • Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• venderctl/cmd/venderctl/tele/cmd-tele.go
  • Line 25: warning: exported const CmdName should have comment or be unexported (golint)
  • Line 27: warning: exported var Cmd should have comment or be unexported (golint)

• venderctl/internal/tele/config/tele_config.go
  • Line 1: warning: package comment should be of the form "Package tele_config ..." (golint)
  • Line 2: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported type Config should have comment or be unexported (golint)
  • Line 32: warning: exported type Mode should have comment or be unexported (golint)
  • Line 35: warning: exported const ModeDisabled should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported type Connect should have comment or be unexported (golint)
  • Line 48: warning: exported type Listen should have comment or be unexported (golint)
  • Line 56: warning: exported type TLS should have comment or be unexported (golint)
  • Line 75: warning: comment on exported method Config.EnableClient should be of the form "EnableClient ..." (golint)
  • Line 98: warning: exported method Config.EnableServer should have comment or be unexported (golint)
  • Line 106: warning: exported method Config.Disable should have comment or be unexported (golint)
  • Line 108: warning: exported method TLS.TLSConfig should have comment or be unexported (golint)

• venderctl/internal/state/global.go
  • Line 17: warning: exported type Global should have comment or be unexported (golint)
  • Line 26: warning: exported const ContextKey should have comment or be unexported (golint)
  • Line 28: warning: exported function GetGlobal should have comment or be unexported (golint)
  • Line 39: warning: exported method Global.InitDB should have comment or be unexported (golint)

• venderctl/internal/state/io.go
  • Line 12: warning: exported type FullReader should have comment or be unexported (golint)
  • Line 18: warning: exported type OsFullReader should have comment or be unexported (golint)
  • Line 22: warning: exported function NewOsFullReader should have comment or be unexported (golint)
  • Line 26: warning: exported method OsFullReader.SetBase should have comment or be unexported (golint)
  • Line 26: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 35: warning: exported method OsFullReader.Normalize should have comment or be unexported (golint)
  • Line 35: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 45: warning: exported method OsFullReader.ReadAll should have comment or be unexported (golint)
  • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 65: warning: exported type MockFullReader should have comment or be unexported (golint)
  • Line 69: warning: exported function NewMockFullReader should have comment or be unexported (golint)
  • Line 73: warning: exported method MockFullReader.Normalize should have comment or be unexported (golint)
  • Line 73: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 77: warning: exported method MockFullReader.ReadAll should have comment or be unexported (golint)
  • Line 77: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• venderctl/internal/state/test_util.go
  • Line 9: warning: comment on exported function Log2stdlib should be of the form "Log2stdlib ..." (golint)

• venderctl/cmd/venderctl/tax/ru2019.go
  • Line 142: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• venderctl/internal/tele/api/packet.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: comment on exported type PacketKind should be of the form "PacketKind ..." (with optional leading article) (golint)
  • Line 15: warning: exported const PacketInvalid should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported type Packet should have comment or be unexported (golint)
  • Line 32: warning: exported method Packet.CommandResponse should have comment or be unexported (golint)
  • Line 42: warning: exported method Packet.State should have comment or be unexported (golint)
  • Line 52: warning: exported method Packet.Telemetry should have comment or be unexported (golint)

• venderctl/internal/state/new/state-new.go
  • Line 1: warning: package comment should be of the form "Package state_new ..." (golint)
  • Line 2: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported function NewContext should have comment or be unexported (golint)
  • Line 32: warning: exported function NewTestContext should have comment or be unexported (golint)

• venderctl/internal/tele/tele.go
  • Line 1: warning: package comment should be of the form "Package tele ..." (golint)
  • Line 45: warning: exported function NewTele should have comment or be unexported (golint)
  • Line 47: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 63: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 74: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 87: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 89: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 109: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 129: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 142: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• venderctl/internal/tele/tele_test.go
  • Line 22: warning: don't use underscores in Go names; struct field xxx_tele should be xxxTele (golint)

• venderctl/cmd/venderctl/tax/cmd-tax.go
  • Line 1: warning: package comment should be of the form "Package tax ..." (golint)
  • Line 25: warning: exported const CmdName should have comment or be unexported (golint)
  • Line 27: warning: exported var Cmd should have comment or be unexported (golint)
  • Line 108: warning: exported type MTaxJob should have comment or be unexported (golint)
  • Line 123: warning: exported type TaxJobData should have comment or be unexported (golint)
  • Line 139: warning: exported type TaxJobOp should have comment or be unexported (golint)
  • Line 158: warning: exported method MTaxJob.OpKeysString should have comment or be unexported (golint)
  • Line 169: warning: exported method MTaxJob.Update should have comment or be unexported (golint)
  • Line 184: warning: exported method MTaxJob.UpdateFinal should have comment or be unexported (golint)
  • Line 195: warning: exported method MTaxJob.UpdateScheduleLater should have comment or be unexported (golint)
  • Line 200: warning: exported method TaxJobOp.KeyString should have comment or be unexported (golint)

• venderctl/cmd/venderctl/passwd/cmd-passwd.go
  • Line 20: warning: exported var Cmd should have comment or be unexported (golint)

• venderctl/internal/tele/config/role.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 3: warning: exported type Role should have comment or be unexported (golint)
  • Line 6: warning: exported const RoleInvalid should have comment (or a comment on this block) or be unexported (golint)

• venderctl/internal/tele/mqtt.go
  • Line 23: warning: exported const SecretsStale should have comment or be unexported (golint)
  • Line 25: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 46: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 68: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 108: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 127: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 145: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 180: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 223: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 263: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 306: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

• venderctl/internal/tele/api/packet.go
  • Line 29: warning: p.Kind.String undefined (type PacketKind has no field or method String) (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!