Report for github.com/textileio/go-threads
A+ Excellent! Found 62 issues across 107 files
gofmt99%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
go-threads/jsonpatcher/jsonpatcher_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo85%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-threads/test/headbook_suite.go
- Line 153: warning: cyclomatic complexity 21 of function testHeadBookEdge() is high (> 15) (gocyclo)
-
-
go-threads/test/logstore_suite.go
- Line 44: warning: cyclomatic complexity 16 of function testAddrStream() is high (> 15) (gocyclo)
-
-
go-threads/net/net.go
- Line 952: warning: cyclomatic complexity 28 of function (*net).loadRecords() is high (> 15) (gocyclo)
- Line 490: warning: cyclomatic complexity 23 of function (*net).AddReplicator() is high (> 15) (gocyclo)
- Line 286: warning: cyclomatic complexity 19 of function (*net).AddThread() is high (> 15) (gocyclo)
- Line 1393: warning: cyclomatic complexity 16 of function (*net).ensureUniqueLog() is high (> 15) (gocyclo)
-
-
go-threads/net/client.go
- Line 346: warning: cyclomatic complexity 22 of function (*server).exchangeEdges() is high (> 15) (gocyclo)
-
-
go-threads/threadsd/main.go
- Line 32: warning: cyclomatic complexity 30 of function main() is high (> 15) (gocyclo)
-
-
go-threads/net/server.go
- Line 294: warning: cyclomatic complexity 16 of function (*server).ExchangeEdges() is high (> 15) (gocyclo)
-
-
go-threads/db/criterion.go
- Line 67: warning: cyclomatic complexity 67 of function compare() is high (> 15) (gocyclo)
-
-
go-threads/test/keybook_suite.go
- Line 424: warning: cyclomatic complexity 27 of function testKeyBookExport() is high (> 15) (gocyclo)
- Line 170: warning: cyclomatic complexity 26 of function testKeyBookClearKeys() is high (> 15) (gocyclo)
- Line 240: warning: cyclomatic complexity 22 of function testKeyBookClearLogKeys() is high (> 15) (gocyclo)
-
-
go-threads/util/dscopy/main.go
- Line 89: warning: cyclomatic complexity 40 of function copyDatastore() is high (> 15) (gocyclo)
-
-
go-threads/jsonpatcher/jsonpatcher.go
- Line 106: warning: cyclomatic complexity 23 of function (*jsonPatcher).Reduce() is high (> 15) (gocyclo)
-
-
go-threads/db/query.go
- Line 294: warning: cyclomatic complexity 21 of function (*Txn).Find() is high (> 15) (gocyclo)
-
-
go-threads/db/index.go
- Line 278: warning: cyclomatic complexity 16 of function newIterator() is high (> 15) (gocyclo)
- Line 72: warning: cyclomatic complexity 16 of function (*Collection).addIndex() is high (> 15) (gocyclo)
-
-
go-threads/api/service.go
- Line 703: warning: cyclomatic complexity 37 of function (*Service).WriteTransaction() is high (> 15) (gocyclo)
- Line 618: warning: cyclomatic complexity 23 of function (*Service).ReadTransaction() is high (> 15) (gocyclo)
- Line 838: warning: cyclomatic complexity 21 of function (*Service).Listen() is high (> 15) (gocyclo)
-
-
go-threads/logstore/lstoreds/keybook.go
- Line 320: warning: cyclomatic complexity 19 of function (*dsKeyBook).RestoreKeys() is high (> 15) (gocyclo)
- Line 226: warning: cyclomatic complexity 19 of function (*dsKeyBook).DumpKeys() is high (> 15) (gocyclo)
-
-
go-threads/net/queue/ff_test.go
- Line 11: warning: cyclomatic complexity 27 of function TestOperationQueue() is high (> 15) (gocyclo)
golint54%
Golint is a linter for Go source code.
-
-
go-threads/cbor/record.go
- Line 205: warning: exported method Record.BlockID should have comment or be unexported (golint)
- Line 209: warning: exported method Record.GetBlock should have comment or be unexported (golint)
- Line 222: warning: exported method Record.PrevID should have comment or be unexported (golint)
- Line 226: warning: exported method Record.Sig should have comment or be unexported (golint)
- Line 230: warning: exported method Record.PubKey should have comment or be unexported (golint)
- Line 234: warning: exported method Record.Verify should have comment or be unexported (golint)
-
-
go-threads/crypto/crypto.go
- Line 20: warning: comment on exported type DecryptionKey should be of the form "DecryptionKey ..." (with optional leading article) (golint)
-
-
go-threads/test/logstore_suite.go
- Line 27: warning: exported type LogstoreFactory should have comment or be unexported (golint)
- Line 29: warning: exported function LogstoreTest should have comment or be unexported (golint)
-
-
go-threads/util/finalizer.go
- Line 10: warning: comment on exported function NewFinalizer should be of the form "NewFinalizer ..." (golint)
- Line 15: warning: exported type Finalizer should have comment or be unexported (golint)
- Line 19: warning: exported method Finalizer.Add should have comment or be unexported (golint)
- Line 23: warning: exported method Finalizer.Cleanup should have comment or be unexported (golint)
- Line 34: warning: comment on exported function NewContextCloser should be of the form "NewContextCloser ..." (golint)
- Line 39: warning: exported type ContextCloser should have comment or be unexported (golint)
- Line 43: warning: exported method ContextCloser.Close should have comment or be unexported (golint)
-
-
go-threads/util/util.go
- Line 93: warning: exported function DefaultBoostrapPeers should have comment or be unexported (golint)
- Line 102: warning: exported function ParseBootstrapPeers should have comment or be unexported (golint)
- Line 114: warning: exported function TCPAddrFromMultiAddr should have comment or be unexported (golint)
- Line 130: warning: exported function MustParseAddr should have comment or be unexported (golint)
- Line 138: warning: exported function FreeLocalAddr should have comment or be unexported (golint)
- Line 146: warning: exported function SchemaFromInstance should have comment or be unexported (golint)
- Line 151: warning: exported function SchemaFromSchemaString should have comment or be unexported (golint)
- Line 160: warning: exported function JSONFromInstance should have comment or be unexported (golint)
- Line 168: warning: exported function InstanceFromJSON should have comment or be unexported (golint)
- Line 174: warning: exported function SetJSONProperty should have comment or be unexported (golint)
- Line 182: warning: exported function SetJSONID should have comment or be unexported (golint)
- Line 186: warning: exported function GenerateRandomBytes should have comment or be unexported (golint)
- Line 195: warning: exported function MakeToken should have comment or be unexported (golint)
- Line 204: warning: exported type LogHead should have comment or be unexported (golint)
- Line 209: warning: exported function ComputeHeadsEdge should have comment or be unexported (golint)
- Line 225: warning: exported type PeerAddr should have comment or be unexported (golint)
- Line 230: warning: exported function ComputeAddrsEdge should have comment or be unexported (golint)
-
-
go-threads/logstore/lstoreds/logstore.go
- Line 16: warning: comment on exported var AllowEmptyRestore should be of the form "AllowEmptyRestore ..." (golint)
- Line 19: warning: exported const EmptyEdgeValue should have comment or be unexported (golint)
- Line 21: warning: comment on exported type Options should be of the form "Options ..." (with optional leading article) (golint)
-
-
go-threads/db/keytransform/keytransform.go
- Line 41: warning: exported method Datastore.NewTransaction should have comment or be unexported (golint)
- Line 45: warning: exported method Datastore.NewTransactionExtended should have comment or be unexported (golint)
- Line 58: warning: exported method Datastore.QueryExtended should have comment or be unexported (golint)
-
-
go-threads/net/queue/common.go
- Line 14: warning: exported type PeerCall should have comment or be unexported (golint)
- Line 16: warning: exported type CallQueue should have comment or be unexported (golint)
- Line 26: warning: exported type ThreadPack should have comment or be unexported (golint)
- Line 31: warning: exported type ThreadPacker should have comment or be unexported (golint)
-
-
go-threads/test/headbook_suite.go
- Line 26: warning: exported type HeadBookFactory should have comment or be unexported (golint)
- Line 28: warning: exported function HeadBookTest should have comment or be unexported (golint)
- Line 291: warning: exported function BenchmarkHeadBook should have comment or be unexported (golint)
-
-
go-threads/core/db/db.go
- Line 69: warning: exported type ReduceAction should have comment or be unexported (golint)
-
-
go-threads/net/queue/tp.go
- Line 12: warning: comment on exported var InBufSize should be of the form "InBufSize ..." (golint)
- Line 15: warning: comment on exported var OutBufSize should be of the form "OutBufSize ..." (golint)
- Line 42: warning: comment on exported function NewThreadPacker should be of the form "NewThreadPacker ..." (golint)
-
-
go-threads/crypto/asymmetric/asymmetric.go
- Line 24: warning: comment on exported var BoxDecryptionError should be of the form "BoxDecryptionError ..." (golint)
- Line 25: warning: error var BoxDecryptionError should have name of the form ErrFoo (golint)
-
-
go-threads/logstore/lstoremem/keybook.go
- Line 43: warning: exported function NewKeyBook should have comment or be unexported (golint)
-
-
go-threads/logstore/lstoremem/metadata.go
- Line 18: warning: exported function NewThreadMetadata should have comment or be unexported (golint)
-
-
go-threads/cbor/event.go
- Line 132: warning: exported method Event.HeaderID should have comment or be unexported (golint)
- Line 136: warning: exported method Event.GetHeader should have comment or be unexported (golint)
- Line 165: warning: exported method Event.BodyID should have comment or be unexported (golint)
- Line 169: warning: exported method Event.GetBody should have comment or be unexported (golint)
- Line 192: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 204: warning: exported method EventHeader.Key should have comment or be unexported (golint)
-
-
go-threads/net/pb/custom.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 36: warning: exported method ProtoPeerID.Marshal should have comment or be unexported (golint)
- Line 40: warning: exported method ProtoPeerID.MarshalTo should have comment or be unexported (golint)
- Line 44: warning: exported method ProtoPeerID.MarshalJSON should have comment or be unexported (golint)
- Line 49: warning: exported method ProtoPeerID.Unmarshal should have comment or be unexported (golint)
- Line 54: warning: exported method ProtoPeerID.UnmarshalJSON should have comment or be unexported (golint)
- Line 63: warning: exported method ProtoPeerID.Size should have comment or be unexported (golint)
- Line 74: warning: exported method ProtoAddr.Marshal should have comment or be unexported (golint)
- Line 78: warning: exported method ProtoAddr.MarshalTo should have comment or be unexported (golint)
- Line 82: warning: exported method ProtoAddr.MarshalJSON should have comment or be unexported (golint)
- Line 87: warning: exported method ProtoAddr.Unmarshal should have comment or be unexported (golint)
- Line 92: warning: exported method ProtoAddr.UnmarshalJSON should have comment or be unexported (golint)
- Line 101: warning: exported method ProtoAddr.Size should have comment or be unexported (golint)
- Line 112: warning: exported method ProtoCid.Marshal should have comment or be unexported (golint)
- Line 116: warning: exported method ProtoCid.MarshalTo should have comment or be unexported (golint)
- Line 120: warning: exported method ProtoCid.MarshalJSON should have comment or be unexported (golint)
- Line 125: warning: exported method ProtoCid.Unmarshal should have comment or be unexported (golint)
- Line 134: warning: exported method ProtoCid.UnmarshalJSON should have comment or be unexported (golint)
- Line 143: warning: exported method ProtoCid.Size should have comment or be unexported (golint)
- Line 154: warning: exported method ProtoThreadID.Marshal should have comment or be unexported (golint)
- Line 158: warning: exported method ProtoThreadID.MarshalTo should have comment or be unexported (golint)
- Line 162: warning: exported method ProtoThreadID.MarshalJSON should have comment or be unexported (golint)
- Line 167: warning: exported method ProtoThreadID.Unmarshal should have comment or be unexported (golint)
- Line 172: warning: exported method ProtoThreadID.UnmarshalJSON should have comment or be unexported (golint)
- Line 181: warning: exported method ProtoThreadID.Size should have comment or be unexported (golint)
- Line 192: warning: exported method ProtoKey.Marshal should have comment or be unexported (golint)
- Line 196: warning: exported method ProtoKey.MarshalTo should have comment or be unexported (golint)
- Line 201: warning: exported method ProtoKey.MarshalJSON should have comment or be unexported (golint)
- Line 206: warning: exported method ProtoKey.Unmarshal should have comment or be unexported (golint)
- Line 211: warning: exported method ProtoKey.UnmarshalJSON should have comment or be unexported (golint)
- Line 220: warning: exported method ProtoKey.Size should have comment or be unexported (golint)
- Line 232: warning: exported method ProtoPubKey.Marshal should have comment or be unexported (golint)
- Line 236: warning: exported method ProtoPubKey.MarshalTo should have comment or be unexported (golint)
- Line 241: warning: exported method ProtoPubKey.MarshalJSON should have comment or be unexported (golint)
- Line 246: warning: exported method ProtoPubKey.Unmarshal should have comment or be unexported (golint)
- Line 251: warning: exported method ProtoPubKey.UnmarshalJSON should have comment or be unexported (golint)
- Line 260: warning: exported method ProtoPubKey.Size should have comment or be unexported (golint)
- Line 272: warning: exported method ProtoPrivKey.Marshal should have comment or be unexported (golint)
- Line 276: warning: exported method ProtoPrivKey.MarshalTo should have comment or be unexported (golint)
- Line 281: warning: exported method ProtoPrivKey.MarshalJSON should have comment or be unexported (golint)
- Line 286: warning: exported method ProtoPrivKey.Unmarshal should have comment or be unexported (golint)
- Line 291: warning: exported method ProtoPrivKey.UnmarshalJSON should have comment or be unexported (golint)
- Line 300: warning: exported method ProtoPrivKey.Size should have comment or be unexported (golint)
-
-
go-threads/broadcast/broadcast.go
- Line 88: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-threads/db/db.go
- Line 531: warning: exported method DB.Close should have comment or be unexported (golint)
- Line 546: warning: exported method DB.Reduce should have comment or be unexported (golint)
- Line 586: warning: exported method DB.ValidateNetRecordBody should have comment or be unexported (golint)
- Line 610: warning: exported method DB.HandleNetRecord should have comment or be unexported (golint)
-
-
go-threads/test/benchmarks_suite.go
- Line 24: warning: exported function BenchmarkLogstore should have comment or be unexported (golint)
-
-
go-threads/util/dscopy/main.go
- Line 222: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-threads/logstore/lstoreds/metadata.go
- Line 26: warning: exported function NewThreadMetadata should have comment or be unexported (golint)
-
-
go-threads/logstore/lstoremem/logstore.go
- Line 8: warning: comment on exported var AllowEmptyRestore should be of the form "AllowEmptyRestore ..." (golint)
-
-
go-threads/test/keybook_suite.go
- Line 31: warning: exported type KeyBookFactory should have comment or be unexported (golint)
- Line 33: warning: exported function KeyBookTest should have comment or be unexported (golint)
- Line 554: warning: exported function BenchmarkKeyBook should have comment or be unexported (golint)
-
-
go-threads/test/util.go
- Line 13: warning: exported function Multiaddr should have comment or be unexported (golint)
- Line 26: warning: exported function RandomPeer should have comment or be unexported (golint)
- Line 47: warning: exported function AddressProducer should have comment or be unexported (golint)
- Line 60: warning: exported function GenerateAddrs should have comment or be unexported (golint)
- Line 68: warning: exported function GeneratePeerIDs should have comment or be unexported (golint)
- Line 76: warning: exported function AssertAddressesEqual should have comment or be unexported (golint)
-
-
go-threads/integrationtests/foldersync/watcher/watcher.go
- Line 14: warning: exported type Handler should have comment or be unexported (golint)
- Line 16: warning: exported type FolderWatcher should have comment or be unexported (golint)
- Line 28: warning: exported function New should have comment or be unexported (golint)
- Line 45: warning: exported method FolderWatcher.Close should have comment or be unexported (golint)
- Line 59: warning: exported method FolderWatcher.Watch should have comment or be unexported (golint)
-
-
go-threads/net/queue/ff.go
- Line 131: warning: comment on exported function NewFFQueue should be of the form "NewFFQueue ..." (golint)
-
-
go-threads/core/thread/identity.go
- Line 49: warning: exported method Libp2pIdentity.MarshalBinary should have comment or be unexported (golint)
- Line 53: warning: exported method Libp2pIdentity.UnmarshalBinary should have comment or be unexported (golint)
- Line 61: warning: exported method Libp2pIdentity.Sign should have comment or be unexported (golint)
- Line 65: warning: exported method Libp2pIdentity.GetPublic should have comment or be unexported (golint)
- Line 69: warning: exported method Libp2pIdentity.Decrypt should have comment or be unexported (golint)
- Line 77: warning: exported method Libp2pIdentity.Equals should have comment or be unexported (golint)
- Line 85: warning: comment on exported type PubKey should be of the form "PubKey ..." (with optional leading article) (golint)
- Line 112: warning: exported method Libp2pPubKey.MarshalBinary should have comment or be unexported (golint)
- Line 116: warning: exported method Libp2pPubKey.UnmarshalBinary should have comment or be unexported (golint)
- Line 136: warning: exported method Libp2pPubKey.UnmarshalString should have comment or be unexported (golint)
- Line 145: warning: exported method Libp2pPubKey.Encrypt should have comment or be unexported (golint)
- Line 153: warning: exported method Libp2pPubKey.Equals should have comment or be unexported (golint)
- Line 201: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 235: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 289: warning: exported method Credentials.GetRequestMetadata should have comment or be unexported (golint)
- Line 298: warning: exported method Credentials.RequireTransportSecurity should have comment or be unexported (golint)
-
-
go-threads/logstore/lstoremem/headbook.go
- Line 40: warning: exported function NewHeadBook should have comment or be unexported (golint)
-
-
go-threads/logstore/lstoreds/addr_book.go
- Line 45: warning: exported type DsAddrBook should have comment or be unexported (golint)
- Line 128: warning: exported method DsAddrBook.SetAddr should have comment or be unexported (golint)
- Line 132: warning: exported method DsAddrBook.SetAddrs should have comment or be unexported (golint)
- Line 144: warning: exported method DsAddrBook.UpdateAddrs should have comment or be unexported (golint)
- Line 171: warning: exported method DsAddrBook.Addrs should have comment or be unexported (golint)
- Line 186: warning: exported method DsAddrBook.AddrStream should have comment or be unexported (golint)
- Line 194: warning: exported method DsAddrBook.ClearAddrs should have comment or be unexported (golint)
- Line 206: warning: exported method DsAddrBook.LogsWithAddrs should have comment or be unexported (golint)
- Line 216: warning: exported method DsAddrBook.ThreadsFromAddrs should have comment or be unexported (golint)
- Line 226: warning: exported method DsAddrBook.AddrsEdge should have comment or be unexported (golint)
- Line 519: warning: exported method DsAddrBook.Close should have comment or be unexported (golint)
- Line 525: warning: exported method DsAddrBook.DumpAddrs should have comment or be unexported (golint)
- Line 560: warning: exported method DsAddrBook.RestoreAddrs should have comment or be unexported (golint)
-
-
go-threads/net/client.go
- Line 31: warning: exported var PushTimeout should have comment or be unexported (golint)
-
-
go-threads/db/common.go
- Line 14: warning: exported type TxnMapDatastore should have comment or be unexported (golint)
- Line 21: warning: exported function NewTxMapDatastore should have comment or be unexported (golint)
- Line 27: warning: exported method TxnMapDatastore.NewTransaction should have comment or be unexported (golint)
- Line 33: warning: exported method TxnMapDatastore.NewTransactionExtended should have comment or be unexported (golint)
- Line 39: warning: exported method TxnMapDatastore.QueryExtended should have comment or be unexported (golint)
- Line 58: warning: exported function NewSimpleTx should have comment or be unexported (golint)
- Line 65: warning: exported method SimpleTx.Query should have comment or be unexported (golint)
- Line 71: warning: exported method SimpleTx.QueryExtended should have comment or be unexported (golint)
- Line 77: warning: exported method SimpleTx.Get should have comment or be unexported (golint)
- Line 83: warning: exported method SimpleTx.Has should have comment or be unexported (golint)
- Line 89: warning: exported method SimpleTx.GetSize should have comment or be unexported (golint)
- Line 95: warning: exported method SimpleTx.Put should have comment or be unexported (golint)
- Line 102: warning: exported method SimpleTx.Delete should have comment or be unexported (golint)
- Line 109: warning: exported method SimpleTx.Discard should have comment or be unexported (golint)
- Line 114: warning: exported method SimpleTx.Commit should have comment or be unexported (golint)
-
-
go-threads/db/listeners.go
- Line 43: warning: exported type ActionType should have comment or be unexported (golint)
- Line 44: warning: exported type ListenActionType should have comment or be unexported (golint)
- Line 47: warning: exported const ActionCreate should have comment (or a comment on this block) or be unexported (golint)
- Line 53: warning: exported const ListenAll should have comment (or a comment on this block) or be unexported (golint)
- Line 59: warning: exported type Action should have comment or be unexported (golint)
- Line 65: warning: exported type ListenOption should have comment or be unexported (golint)
- Line 71: warning: exported type Listener should have comment or be unexported (golint)
-
-
go-threads/jwt/jwt.go
- Line 8: warning: comment on exported type SigningMethodEd25519 should be of the form "SigningMethodEd25519 ..." (with optional leading article) (golint)
- Line 14: warning: comment on exported var SigningMethodEd25519i should be of the form "SigningMethodEd25519i ..." (golint)
- Line 29: warning: comment on exported method SigningMethodEd25519.Verify should be of the form "Verify ..." (golint)
- Line 59: warning: comment on exported method SigningMethodEd25519.Sign should be of the form "Sign ..." (golint)
-
-
go-threads/crypto/asymmetric/asymmetric_old/asymmetric_old_test.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 127: warning: error var BoxDecryptionError should have name of the form ErrFoo (golint)
-
-
go-threads/logstore/lstorehybrid/logstore.go
- Line 23: warning: exported function NewLogstore should have comment or be unexported (golint)
-
-
go-threads/api/service.go
- Line 61: warning: exported method Service.Close should have comment or be unexported (golint)
- Line 130: warning: exported method Service.GetToken should have comment or be unexported (golint)
- Line 163: warning: exported method Service.NewDB should have comment or be unexported (golint)
- Line 207: warning: exported method Service.NewDBFromAddr should have comment or be unexported (golint)
- Line 284: warning: exported method Service.ListDBs should have comment or be unexported (golint)
- Line 310: warning: exported method Service.GetDBInfo should have comment or be unexported (golint)
- Line 343: warning: exported method Service.DeleteDB should have comment or be unexported (golint)
- Line 356: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 363: warning: exported method Service.NewCollection should have comment or be unexported (golint)
- Line 386: warning: exported method Service.UpdateCollection should have comment or be unexported (golint)
- Line 409: warning: exported method Service.DeleteCollection should have comment or be unexported (golint)
- Line 428: warning: exported method Service.GetCollectionInfo should have comment or be unexported (golint)
- Line 461: warning: exported method Service.GetCollectionIndexes should have comment or be unexported (golint)
- Line 479: warning: exported method Service.ListCollections should have comment or be unexported (golint)
- Line 506: warning: exported method Service.Create should have comment or be unexported (golint)
- Line 522: warning: exported method Service.Verify should have comment or be unexported (golint)
- Line 538: warning: exported method Service.Save should have comment or be unexported (golint)
- Line 554: warning: exported method Service.Delete should have comment or be unexported (golint)
- Line 570: warning: exported method Service.Has should have comment or be unexported (golint)
- Line 586: warning: exported method Service.Find should have comment or be unexported (golint)
- Line 602: warning: exported method Service.FindByID should have comment or be unexported (golint)
- Line 618: warning: exported method Service.ReadTransaction should have comment or be unexported (golint)
- Line 703: warning: exported method Service.WriteTransaction should have comment or be unexported (golint)
- Line 838: warning: exported method Service.Listen should have comment or be unexported (golint)
- Line 991: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-threads/test/addr_book_suite.go
- Line 29: warning: exported type AddrBookFactory should have comment or be unexported (golint)
- Line 31: warning: exported function AddrBookTest should have comment or be unexported (golint)
-
-
go-threads/net/net.go
- Line 761: warning: exported method Record.Value should have comment or be unexported (golint)
- Line 765: warning: exported method Record.ThreadID should have comment or be unexported (golint)
- Line 769: warning: exported method Record.LogID should have comment or be unexported (golint)
- Line 1263: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
go-threads/net/api/service.go
- Line 53: warning: exported method Service.GetHostID should have comment or be unexported (golint)
- Line 125: warning: exported method Service.GetToken should have comment or be unexported (golint)
- Line 158: warning: exported method Service.CreateThread should have comment or be unexported (golint)
- Line 181: warning: exported method Service.AddThread should have comment or be unexported (golint)
- Line 209: warning: exported method Service.GetThread should have comment or be unexported (golint)
- Line 227: warning: exported method Service.PullThread should have comment or be unexported (golint)
- Line 244: warning: exported method Service.DeleteThread should have comment or be unexported (golint)
- Line 261: warning: exported method Service.AddReplicator should have comment or be unexported (golint)
- Line 285: warning: exported method Service.CreateRecord should have comment or be unexported (golint)
- Line 315: warning: exported method Service.AddRecord should have comment or be unexported (golint)
- Line 344: warning: exported method Service.GetRecord should have comment or be unexported (golint)
- Line 372: warning: exported method Service.Subscribe should have comment or be unexported (golint)
-
-
go-threads/net/util/util.go
- Line 10: warning: exported function RecFromServiceRec should have comment or be unexported (golint)
- Line 19: warning: exported function RecToServiceRec should have comment or be unexported (golint)
- Line 28: warning: exported function NewSemaphore should have comment or be unexported (golint)
- Line 32: warning: exported type Semaphore should have comment or be unexported (golint)
- Line 36: warning: comment on exported method Semaphore.Acquire should be of the form "Acquire ..." (golint)
- Line 41: warning: comment on exported method Semaphore.TryAcquire should be of the form "TryAcquire ..." (golint)
- Line 51: warning: exported method Semaphore.Release should have comment or be unexported (golint)
- Line 59: warning: exported type SemaphoreKey should have comment or be unexported (golint)
- Line 63: warning: exported function NewSemaphorePool should have comment or be unexported (golint)
- Line 67: warning: exported type SemaphorePool should have comment or be unexported (golint)
- Line 73: warning: exported method SemaphorePool.Get should have comment or be unexported (golint)
- Line 90: warning: exported method SemaphorePool.Stop should have comment or be unexported (golint)
-
-
go-threads/core/logstore/logstore.go
- Line 222: warning: exported type DumpHeadBook should have comment or be unexported (golint)
- Line 226: warning: exported type ExpiredAddress should have comment or be unexported (golint)
- Line 231: warning: exported type DumpAddrBook should have comment or be unexported (golint)
- Line 235: warning: exported type DumpKeyBook should have comment or be unexported (golint)
- Line 244: warning: exported type MetadataKey should have comment or be unexported (golint)
- Line 249: warning: exported type DumpMetadata should have comment or be unexported (golint)
-
-
go-threads/net/api/client/client.go
- Line 52: warning: exported method Client.GetHostID should have comment or be unexported (golint)
- Line 60: warning: exported method Client.GetToken should have comment or be unexported (golint)
- Line 121: warning: exported method Client.CreateThread should have comment or be unexported (golint)
- Line 141: warning: exported method Client.AddThread should have comment or be unexported (golint)
- Line 161: warning: exported method Client.GetThread should have comment or be unexported (golint)
- Line 176: warning: exported method Client.PullThread should have comment or be unexported (golint)
- Line 188: warning: exported method Client.DeleteThread should have comment or be unexported (golint)
- Line 200: warning: exported method Client.AddReplicator should have comment or be unexported (golint)
- Line 216: warning: exported method Client.CreateRecord should have comment or be unexported (golint)
- Line 236: warning: exported method Client.AddRecord should have comment or be unexported (golint)
- Line 255: warning: exported method Client.GetRecord should have comment or be unexported (golint)
- Line 275: warning: exported method Client.Subscribe should have comment or be unexported (golint)
-
-
go-threads/test/metadata_suite.go
- Line 29: warning: exported type MetadataBookFactory should have comment or be unexported (golint)
- Line 31: warning: exported function MetadataBookTest should have comment or be unexported (golint)
-
-
go-threads/db/index.go
- Line 120: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 264: warning: exported type MarshaledResult should have comment or be unexported (golint)
-
-
go-threads/db/manager.go
- Line 30: warning: exported type Manager should have comment or be unexported (golint)
-
-
go-threads/db/options.go
- Line 175: warning: comment on exported function WithNewManagedBackfillBlock should be of the form "WithNewManagedBackfillBlock ..." (golint)
-
-
go-threads/common/common.go
- Line 33: warning: comment on exported type NetBoostrapper should be of the form "NetBoostrapper ..." (with optional leading article) (golint)
- Line 40: warning: exported function DefaultNetwork should have comment or be unexported (golint)
- Line 148: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 194: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 259: warning: exported type LogstoreType should have comment or be unexported (golint)
- Line 262: warning: exported const LogstoreInMemory should have comment (or a comment on this block) or be unexported (golint)
- Line 267: warning: exported type NetConfig should have comment or be unexported (golint)
- Line 280: warning: exported type NetOption should have comment or be unexported (golint)
- Line 282: warning: exported function WithNetHostAddr should have comment or be unexported (golint)
- Line 289: warning: exported function WithConnectionManager should have comment or be unexported (golint)
- Line 296: warning: exported function WithNetDebug should have comment or be unexported (golint)
- Line 303: warning: exported function WithNetGRPCServerOptions should have comment or be unexported (golint)
- Line 310: warning: exported function WithNetGRPCDialOptions should have comment or be unexported (golint)
- Line 317: warning: exported function WithNetPubSub should have comment or be unexported (golint)
- Line 324: warning: exported function WithNetLogstore should have comment or be unexported (golint)
- Line 331: warning: exported function WithNetBadgerPersistence should have comment or be unexported (golint)
- Line 338: warning: exported function WithNetMongoPersistence should have comment or be unexported (golint)
-
-
go-threads/logstore/lstoremem/addr_book.go
- Line 230: warning: exported function NewAddrBook should have comment or be unexported (golint)
- Line 562: warning: comment on exported type AddrSubManager should be of the form "AddrSubManager ..." (with optional leading article) (golint)
-
-
go-threads/net/net_test.go
- Line 457: warning: context.Context should be the first parameter of a function (golint)
ineffassign97%
IneffAssign detects ineffectual assignments in Go code.
-
-
go-threads/crypto/symmetric/symmetric_test.go
- Line 45: warning: ineffectual assignment to plaintext (ineffassign)
-
-
go-threads/logstore/lstorehybrid/hybrid_test.go
- Line 116: warning: ineffectual assignment to err (ineffassign)
-
-
go-threads/net/net_test.go
- Line 260: warning: ineffectual assignment to sk (ineffassign)
misspell95%
Misspell Finds commonly misspelled English words
-
-
go-threads/api/client/client_test.go
- Line 54: warning: "emtpy" is a misspelling of "empty" (misspell)
-
-
go-threads/jsonpatcher/jsonpatcher.go
- Line 85: warning: "unkown" is a misspelling of "unknown" (misspell)
-
-
go-threads/net/api/client/client_test.go
- Line 61: warning: "emtpy" is a misspelling of "empty" (misspell)
-
-
go-threads/db/collection.go
- Line 149: warning: "gurantees" is a misspelling of "guarantees" (misspell)
- Line 155: warning: "gurantees" is a misspelling of "guarantees" (misspell)
-
-
go-threads/db/query.go
- Line 166: warning: "independant" is a misspelling of "independent" (misspell)