Preparing report...

Report for github.com/thought-machine/please

(v12.2.0+incompatible)

A+    Excellent!    Found 62 issues across 240 files

Tweet

gofmt85%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


gocyclo89%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • src/output/shell_output.go
    • Line 61: warning: cyclomatic complexity 25 of function MonitorState() is high (> 15) (gocyclo)
    • Line 174: warning: cyclomatic complexity 25 of function processResult() is high (> 15) (gocyclo)
    • Line 219: warning: cyclomatic complexity 16 of function printTestResults() is high (> 15) (gocyclo)
    • src/please.go
    • Line 881: warning: cyclomatic complexity 27 of function main() is high (> 15) (gocyclo)
    • Line 668: warning: cyclomatic complexity 19 of function Please() is high (> 15) (gocyclo)
    • src/build/incrementality.go
    • Line 313: warning: cyclomatic complexity 21 of function ruleHash() is high (> 15) (gocyclo)
    • Line 53: warning: cyclomatic complexity 16 of function needsBuilding() is high (> 15) (gocyclo)
    • src/parse/asp/lexer.go
    • Line 164: warning: cyclomatic complexity 38 of function (*lex).nextToken() is high (> 15) (gocyclo)
    • Line 293: warning: cyclomatic complexity 20 of function (*lex).consumeString() is high (> 15) (gocyclo)
    • src/parse/asp/interpreter.go
    • Line 161: warning: cyclomatic complexity 22 of function (*interpreter).optimiseExpressions() is high (> 15) (gocyclo)
    • Line 373: warning: cyclomatic complexity 20 of function (*scope).interpretExpression() is high (> 15) (gocyclo)
    • Line 303: warning: cyclomatic complexity 17 of function (*scope).interpretStatements() is high (> 15) (gocyclo)
    • Line 675: warning: cyclomatic complexity 16 of function (*scope).Constant() is high (> 15) (gocyclo)
    • tools/jarcat/zip/writer.go
    • Line 109: warning: cyclomatic complexity 26 of function (*File).AddZipFile() is high (> 15) (gocyclo)
    • Line 201: warning: cyclomatic complexity 21 of function (*File).walk() is high (> 15) (gocyclo)
    • src/core/config.go
    • Line 469: warning: cyclomatic complexity 24 of function (*Configuration).ApplyOverrides() is high (> 15) (gocyclo)
    • src/gc/gc.go
    • Line 80: warning: cyclomatic complexity 29 of function targetsToRemove() is high (> 15) (gocyclo)
    • Line 30: warning: cyclomatic complexity 17 of function GarbageCollect() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell97%

Misspell Finds commonly misspelled English words