Go Report Card

Preparing report...

Report for github.com/tillkuhn/angkor

A    Great!    Found 20 issues across 34 files

Tweet
Last refresh:

Refresh now

gofmt70%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint50%

Golint is a linter for Go source code.

    • angkor/tools/imagine/http.go
    • Line 24: warning: comment on exported function PostObject should be of the form "PostObject ..." (golint)
    • Line 173: warning: comment on exported function ListObjects should be of the form "ListObjects ..." (golint)
    • Line 187: warning: comment on exported function GetObjectPresignUrl should be of the form "GetObjectPresignUrl ..." (golint)
    • Line 202: warning: comment on exported function DeleteObject should be of the form "DeleteObject ..." (golint)
    • Line 215: warning: comment on exported function Health should be of the form "Health ..." (golint)
    • angkor/tools/topkapi/client.go
    • Line 21: warning: exported type Event should have comment or be unexported (golint)
    • Line 29: warning: exported type Client should have comment or be unexported (golint)
    • Line 164: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • angkor/tools/imagine/image.go
    • Line 13: warning: exported function ExtractExif should have comment or be unexported (golint)
    • Line 50: warning: comment on exported function ResizeImage should be of the form "ResizeImage ..." (golint)
    • angkor/tools/imagine/domain.go
    • Line 3: warning: exported type UploadRequest should have comment or be unexported (golint)
    • Line 13: warning: exported type DownloadRequest should have comment or be unexported (golint)
    • Line 18: warning: exported type ListResponse should have comment or be unexported (golint)
    • Line 22: warning: exported type ListItem should have comment or be unexported (golint)
    • angkor/tools/imagine/util.go
    • Line 13: warning: exported function FileSize should have comment or be unexported (golint)
    • Line 23: warning: exported function MemStats should have comment or be unexported (golint)
    • Line 30: warning: comment on exported function StripRequestParams should be of the form "StripRequestParams ..." (golint)
    • Line 38: warning: exported function HasExtension should have comment or be unexported (golint)
    • Line 42: warning: exported function IsResizableImage should have comment or be unexported (golint)
    • Line 46: warning: comment on exported function IsJPEG should be of the form "IsJPEG ..." (golint)
    • angkor/tools/topkapi/scram_client.go
    • Line 11: warning: exported var SHA256 should have comment or be unexported (golint)
    • Line 15: warning: exported type XDGSCRAMClient should have comment or be unexported (golint)
    • Line 21: warning: exported method XDGSCRAMClient.Begin should have comment or be unexported (golint)
    • Line 30: warning: exported method XDGSCRAMClient.Step should have comment or be unexported (golint)
    • Line 35: warning: exported method XDGSCRAMClient.Done should have comment or be unexported (golint)
    • angkor/tools/imagine/s3worker.go
    • Line 22: warning: exported const TagContentType should have comment or be unexported (golint)
    • Line 24: warning: exported type S3Handler should have comment or be unexported (golint)
    • Line 29: warning: comment on exported method S3Handler.StartWorker should be of the form "StartWorker ..." (golint)
    • Line 41: warning: comment on exported method S3Handler.PutObject should be of the form "PutObject ..." (golint)
    • Line 187: warning: comment on exported method S3Handler.ListObjectsForEntity should be of the form "ListObjectsForEntity ..." (golint)
    • Line 239: warning: comment on exported method S3Handler.GetS3PresignedUrl should be of the form "GetS3PresignedUrl ..." (golint)
    • angkor/tools/imagine/auth/jwtauth.go
    • Line 18: warning: exported type JwtToken should have comment or be unexported (golint)
    • Line 22: warning: comment on exported function NewJwtAuth should be of the form "NewJwtAuth ..." (golint)
    • Line 34: warning: exported method JwtAuth.ParseClaims should have comment or be unexported (golint)
    • Line 41: warning: exported method JwtToken.Name should have comment or be unexported (golint)
    • Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 50: warning: exported method JwtToken.Scope should have comment or be unexported (golint)
    • Line 54: warning: exported method JwtToken.Roles should have comment or be unexported (golint)
    • Line 57: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 62: warning: exported method JwtToken.Subject should have comment or be unexported (golint)
    • Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell97%

Misspell Finds commonly misspelled English words