Preparing report...

Report for github.com/tmpbook/go-app-core

A+    Excellent!    Found 9 issues across 17 files

Tweet

gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint58%

Golint is a linter for Go source code.

    • go-app-core/pkg/ssh/session.go
    • Line 112: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • go-app-core/pkg/grpool/grpool.go
    • Line 110: warning: exported type Jobresult should have comment or be unexported (golint)
    • Line 117: warning: comment on exported type Job should be of the form "Job ..." (with optional leading article) (golint)
    • Line 123: warning: exported type Pool should have comment or be unexported (golint)
    • Line 130: warning: comment on exported function NewPool should be of the form "NewPool ..." (golint)
    • Line 147: warning: comment on exported method Pool.JobDone should be of the form "JobDone ..." (golint)
    • Line 155: warning: comment on exported method Pool.WaitCount should be of the form "WaitCount ..." (golint)
    • Line 164: warning: comment on exported method Pool.WaitAll should be of the form "WaitAll ..." (golint)
    • Line 170: warning: comment on exported method Pool.Release should be of the form "Release ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign70%

IneffAssign detects ineffectual assignments in Go code.

    • go-app-core/pkg/ssh/session.go
    • Line 13: warning: cannot find package "." in: (ineffassign)
    • Line 14: warning: cannot find package "." in: (ineffassign)
    • Line 13: warning: could not import github.com/pkg/sftp (invalid package name: "") (ineffassign)
    • Line 14: warning: could not import golang.org/x/crypto/ssh (invalid package name: "") (ineffassign)
    • Line 13: warning: could not import github.com/pkg/sftp (invalid package name: "") (ineffassign)
    • Line 14: warning: could not import golang.org/x/crypto/ssh (invalid package name: "") (ineffassign)
    • go-app-core/pkg/ssh/ssh.go
    • Line 10: warning: cannot find package "." in: (ineffassign)
    • Line 10: warning: could not import github.com/tmpbook/go-app-core/pkg/grpool (invalid package name: "") (ineffassign)
    • Line 10: warning: could not import github.com/tmpbook/go-app-core/pkg/grpool (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!