Report for github.com/topine/ibm-spectrum-exporter
A+ Excellent! Found 4 issues across 9 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint55%
Golint is a linter for Go source code.
-
-
ibm-spectrum-exporter/collector/collector.go
- Line 55: warning: exported var State should have comment or be unexported (golint)
- Line 127: warning: comment on exported method IbmSpectrumCollector.Collect should be of the form "Collect ..." (golint)
-
-
ibm-spectrum-exporter/main.go
- Line 23: warning: comment on exported var TAG should be of the form "TAG ..." (golint)
- Line 26: warning: comment on exported var COMMIT should be of the form "COMMIT ..." (golint)
- Line 29: warning: comment on exported var VERSION should be of the form "VERSION ..." (golint)
-
-
ibm-spectrum-exporter/spectrumservice/client.go
- Line 40: warning: exported type Client should have comment or be unexported (golint)
- Line 51: warning: exported function NewClient should have comment or be unexported (golint)
- Line 68: warning: exported method Client.CollectFromStorage should have comment or be unexported (golint)
- Line 78: warning: exported method Client.CollectFromSwitch should have comment or be unexported (golint)
- Line 88: warning: exported method Client.CollectFromPools should have comment or be unexported (golint)
- Line 98: warning: exported method Client.CollectAndCacheMetrics should have comment or be unexported (golint)
- Line 146: warning: exported method Client.CollectStorageMetrics should have comment or be unexported (golint)
- Line 354: warning: exported method Client.CollectSwitchMetrics should have comment or be unexported (golint)
- Line 474: warning: exported method Client.CollectPools should have comment or be unexported (golint)
-
-
ibm-spectrum-exporter/spectrumservice/types.go
- Line 3: warning: exported type CollectedStorageMetrics should have comment or be unexported (golint)
- Line 9: warning: exported type CollectedSwitchMetrics should have comment or be unexported (golint)
- Line 15: warning: exported type StorageMetrics should have comment or be unexported (golint)
- Line 22: warning: exported type SwitchMetrics should have comment or be unexported (golint)
- Line 27: warning: exported type CollectedPoolMetrics should have comment or be unexported (golint)
- Line 33: warning: exported type PoolsMetrics should have comment or be unexported (golint)
- Line 39: warning: comment on exported type MetricDetails should be of the form "MetricDetails ..." (with optional leading article) (golint)
- Line 44: warning: comment on exported type MetricDetail should be of the form "MetricDetail ..." (with optional leading article) (golint)
- Line 119: warning: exported type Volumes should have comment or be unexported (golint)
- Line 124: warning: exported type Switch should have comment or be unexported (golint)
- Line 158: warning: exported type Pool should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!