Report for github.com/treydock/gpfs_exporter
A+ Excellent! Found 14 issues across 30 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo90%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
gpfs_exporter/cmd/gpfs_mmdf_exporter/main.go
- Line 70: warning: cyclomatic complexity 21 of function collect() is high (> 15) (gocyclo)
-
-
gpfs_exporter/cmd/gpfs_mmlssnapshot_exporter/main.go
- Line 70: warning: cyclomatic complexity 21 of function collect() is high (> 15) (gocyclo)
-
-
gpfs_exporter/collectors/mmdf.go
- Line 197: warning: cyclomatic complexity 16 of function parse_mmdf() is high (> 15) (gocyclo)
golint60%
Golint is a linter for Go source code.
-
-
gpfs_exporter/collectors/mmlsfileset.go
- Line 46: warning: exported var MmlsfilesetExec should have comment or be unexported (golint)
- Line 49: warning: exported type FilesetMetric should have comment or be unexported (golint)
- Line 60: warning: exported type MmlsfilesetCollector should have comment or be unexported (golint)
- Line 74: warning: exported function NewMmlsfilesetCollector should have comment or be unexported (golint)
- Line 93: warning: exported method MmlsfilesetCollector.Describe should have comment or be unexported (golint)
- Line 102: warning: exported method MmlsfilesetCollector.Collect should have comment or be unexported (golint)
- Line 110: warning: don't use underscores in Go names; var mmlfsfs_filesystems should be mmlfsfsFilesystems (golint)
- Line 171: warning: context.Context should be the first parameter of a function (golint)
- Line 184: warning: don't use underscores in Go names; func parse_mmlsfileset should be parseMmlsfileset (golint)
-
-
gpfs_exporter/collectors/mount.go
- Line 36: warning: exported type MountCollector should have comment or be unexported (golint)
- Line 37: warning: don't use underscores in Go names; struct field fs_mount_status should be fsMountStatus (golint)
- Line 45: warning: exported function NewMountCollector should have comment or be unexported (golint)
- Line 53: warning: exported method MountCollector.Describe should have comment or be unexported (golint)
- Line 57: warning: exported method MountCollector.Collect should have comment or be unexported (golint)
-
-
gpfs_exporter/collectors/verbs.go
- Line 33: warning: exported type VerbsMetrics should have comment or be unexported (golint)
- Line 37: warning: exported type VerbsCollector should have comment or be unexported (golint)
- Line 46: warning: exported function NewVerbsCollector should have comment or be unexported (golint)
- Line 54: warning: exported method VerbsCollector.Describe should have comment or be unexported (golint)
- Line 58: warning: exported method VerbsCollector.Collect should have comment or be unexported (golint)
- Line 105: warning: don't use underscores in Go names; func verbs_parse should be verbsParse (golint)
-
-
gpfs_exporter/collectors/mmdf.go
- Line 36: warning: exported var KbToBytes should have comment or be unexported (golint)
- Line 50: warning: exported type DFMetric should have comment or be unexported (golint)
- Line 63: warning: exported type MmdfCollector should have comment or be unexported (golint)
- Line 79: warning: exported function NewMmdfCollector should have comment or be unexported (golint)
- Line 101: warning: exported method MmdfCollector.Describe should have comment or be unexported (golint)
- Line 112: warning: exported method MmdfCollector.Collect should have comment or be unexported (golint)
- Line 120: warning: don't use underscores in Go names; var mmlfsfs_filesystems should be mmlfsfsFilesystems (golint)
- Line 184: warning: context.Context should be the first parameter of a function (golint)
- Line 197: warning: don't use underscores in Go names; func parse_mmdf should be parseMmdf (golint)
-
-
gpfs_exporter/collectors/mmgetstate.go
- Line 31: warning: exported var MmgetstateExec should have comment or be unexported (golint)
- Line 34: warning: exported type MmgetstateMetrics should have comment or be unexported (golint)
- Line 38: warning: exported type MmgetstateCollector should have comment or be unexported (golint)
- Line 47: warning: exported function NewMmgetstateCollector should have comment or be unexported (golint)
- Line 55: warning: exported method MmgetstateCollector.Describe should have comment or be unexported (golint)
- Line 59: warning: exported method MmgetstateCollector.Collect should have comment or be unexported (golint)
- Line 113: warning: don't use underscores in Go names; func mmgetstate_parse should be mmgetstateParse (golint)
-
-
gpfs_exporter/collectors/mmhealth.go
- Line 47: warning: exported type HealthMetric should have comment or be unexported (golint)
- Line 54: warning: exported type MmhealthCollector should have comment or be unexported (golint)
- Line 63: warning: exported function NewMmhealthCollector should have comment or be unexported (golint)
- Line 71: warning: exported method MmhealthCollector.Describe should have comment or be unexported (golint)
- Line 75: warning: exported method MmhealthCollector.Collect should have comment or be unexported (golint)
- Line 112: warning: don't use underscores in Go names; var mmhealth_out should be mmhealthOut (golint)
- Line 133: warning: don't use underscores in Go names; func mmhealth_parse should be mmhealthParse (golint)
-
-
gpfs_exporter/collectors/mmlssnapshot.go
- Line 37: warning: exported var SnapshotKbToBytes should have comment or be unexported (golint)
- Line 51: warning: exported type SnapshotMetric should have comment or be unexported (golint)
- Line 62: warning: exported type MmlssnapshotCollector should have comment or be unexported (golint)
- Line 74: warning: exported function NewMmlssnapshotCollector should have comment or be unexported (golint)
- Line 89: warning: exported method MmlssnapshotCollector.Describe should have comment or be unexported (golint)
- Line 98: warning: exported method MmlssnapshotCollector.Collect should have comment or be unexported (golint)
- Line 106: warning: don't use underscores in Go names; var mmlfsfs_filesystems should be mmlfsfsFilesystems (golint)
- Line 168: warning: context.Context should be the first parameter of a function (golint)
- Line 185: warning: don't use underscores in Go names; func parse_mmlssnapshot should be parseMmlssnapshot (golint)
-
-
gpfs_exporter/collectors/mmpmon.go
- Line 45: warning: exported var MmpmonExec should have comment or be unexported (golint)
- Line 48: warning: exported type PerfMetrics should have comment or be unexported (golint)
- Line 61: warning: exported type MmpmonCollector should have comment or be unexported (golint)
- Line 62: warning: don't use underscores in Go names; struct field read_bytes should be readBytes (golint)
- Line 63: warning: don't use underscores in Go names; struct field write_bytes should be writeBytes (golint)
- Line 73: warning: exported function NewMmpmonCollector should have comment or be unexported (golint)
- Line 87: warning: exported method MmpmonCollector.Describe should have comment or be unexported (golint)
- Line 94: warning: exported method MmpmonCollector.Collect should have comment or be unexported (golint)
- Line 126: warning: don't use underscores in Go names; var mmpmon_out should be mmpmonOut (golint)
- Line 148: warning: don't use underscores in Go names; func mmpmon_parse should be mmpmonParse (golint)
-
-
gpfs_exporter/collectors/mmrepquota.go
- Line 48: warning: exported type QuotaMetric should have comment or be unexported (golint)
- Line 61: warning: exported type MmrepquotaCollector should have comment or be unexported (golint)
- Line 77: warning: exported function NewMmrepquotaCollector should have comment or be unexported (golint)
- Line 100: warning: exported method MmrepquotaCollector.Describe should have comment or be unexported (golint)
- Line 111: warning: exported method MmrepquotaCollector.Collect should have comment or be unexported (golint)
- Line 170: warning: don't use underscores in Go names; func parse_mmrepquota should be parseMmrepquota (golint)
-
-
gpfs_exporter/collectors/collector.go
- Line 40: warning: exported var MmlsfsExec should have comment or be unexported (golint)
- Line 62: warning: exported type GPFSFilesystem should have comment or be unexported (golint)
- Line 67: warning: exported type GPFSCollector should have comment or be unexported (golint)
- Line 72: warning: exported type Collector should have comment or be unexported (golint)
- Line 93: warning: exported function NewGPFSCollector should have comment or be unexported (golint)
- Line 105: warning: exported function SliceContains should have comment or be unexported (golint)
- Line 114: warning: exported function FileExists should have comment or be unexported (golint)
- Line 128: warning: don't use underscores in Go names; var mmlsfs_filesystems should be mmlsfsFilesystems (golint)
- Line 148: warning: don't use underscores in Go names; func parse_mmlsfs should be parseMmlsfs (golint)
-
-
gpfs_exporter/collectors/mmces.go
- Line 50: warning: exported type CESMetric should have comment or be unexported (golint)
- Line 55: warning: exported type MmcesCollector should have comment or be unexported (golint)
- Line 64: warning: exported function NewMmcesCollector should have comment or be unexported (golint)
- Line 72: warning: exported method MmcesCollector.Describe should have comment or be unexported (golint)
- Line 76: warning: exported method MmcesCollector.Collect should have comment or be unexported (golint)
- Line 122: warning: don't use underscores in Go names; var mmces_state_out should be mmcesStateOut (golint)
- Line 130: warning: context.Context should be the first parameter of a function (golint)
- Line 143: warning: don't use underscores in Go names; func mmces_state_show_parse should be mmcesStateShowParse (golint)
-
-
gpfs_exporter/collectors/mmdiag.go
- Line 39: warning: exported type DiagMetric should have comment or be unexported (golint)
- Line 43: warning: exported type DiagWaiter should have comment or be unexported (golint)
- Line 48: warning: exported type MmdiagCollector should have comment or be unexported (golint)
- Line 57: warning: exported function NewMmdiagCollector should have comment or be unexported (golint)
- Line 65: warning: exported method MmdiagCollector.Describe should have comment or be unexported (golint)
- Line 69: warning: exported method MmdiagCollector.Collect should have comment or be unexported (golint)
- Line 102: warning: context.Context should be the first parameter of a function (golint)
- Line 115: warning: don't use underscores in Go names; func parse_mmdiag_waiters should be parseMmdiagWaiters (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!