Report for github.com/treydock/infiniband_exporter
A+ Excellent! Found 5 issues across 12 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo83%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
infiniband_exporter/collectors/hca.go
- Line 174: warning: cyclomatic complexity 32 of function (*HCACollector).Collect() is high (> 15) (gocyclo)
-
-
infiniband_exporter/collectors/switch.go
- Line 174: warning: cyclomatic complexity 32 of function (*SwitchCollector).Collect() is high (> 15) (gocyclo)
golint58%
Golint is a linter for Go source code.
-
-
infiniband_exporter/collectors/ibnetdiscover.go
- Line 34: warning: exported var IbnetdiscoverExec should have comment or be unexported (golint)
- Line 51: warning: exported type InfinibandDevice should have comment or be unexported (golint)
- Line 60: warning: exported type InfinibandUplink should have comment or be unexported (golint)
- Line 68: warning: exported type IBNetDiscover should have comment or be unexported (golint)
- Line 75: warning: exported function NewIBNetDiscover should have comment or be unexported (golint)
- Line 81: warning: exported method IBNetDiscover.GetPorts should have comment or be unexported (golint)
- Line 95: warning: exported method IBNetDiscover.Describe should have comment or be unexported (golint)
- Line 98: warning: exported method IBNetDiscover.Collect should have comment or be unexported (golint)
- Line 145: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
infiniband_exporter/collectors/perfquery.go
- Line 33: warning: exported var PerfqueryExec should have comment or be unexported (golint)
- Line 36: warning: exported type PerfQueryCounters should have comment or be unexported (golint)
- Line 147: warning: context.Context should be the first parameter of a function (golint)
-
-
infiniband_exporter/collectors/switch.go
- Line 30: warning: exported var CollectSwitch should have comment or be unexported (golint)
- Line 34: warning: exported type SwitchCollector should have comment or be unexported (golint)
- Line 70: warning: exported function NewSwitchCollector should have comment or be unexported (golint)
- Line 140: warning: exported method SwitchCollector.Describe should have comment or be unexported (golint)
- Line 174: warning: exported method SwitchCollector.Collect should have comment or be unexported (golint)
-
-
infiniband_exporter/collectors/collectors.go
- Line 48: warning: exported function ReadFixture should have comment or be unexported (golint)
-
-
infiniband_exporter/collectors/hca.go
- Line 30: warning: exported var CollectHCA should have comment or be unexported (golint)
- Line 34: warning: exported type HCACollector should have comment or be unexported (golint)
- Line 70: warning: exported function NewHCACollector should have comment or be unexported (golint)
- Line 140: warning: exported method HCACollector.Describe should have comment or be unexported (golint)
- Line 174: warning: exported method HCACollector.Collect should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!