Report for github.com/trustbloc/vct
A+ Excellent! Found 10 issues across 36 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo91%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
vct/cmd/log_server/main.go
- Line 83: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)
-
-
vct/cmd/log_signer/main.go
- Line 93: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)
-
-
vct/pkg/storage/postgres/log_storage.go
- Line 460: warning: cyclomatic complexity 21 of function (*logTreeTX).QueueLeaves() is high (> 15) (gocyclo)
golint94%
Golint is a linter for Go source code.
-
-
vct/pkg/storage/postgres/schema/schema.go
- Line 11: warning: comment on exported var SQL should be of the form "SQL ..." (golint)
-
-
vct/pkg/storage/mysql/schema/schema.go
- Line 11: warning: comment on exported var SQL should be of the form "SQL ..." (golint)
ineffassign86%
IneffAssign detects ineffectual assignments in Go code.
-
-
vct/pkg/controller/command/command_test.go
- Line 66: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 85: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 110: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 125: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 145: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 176: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 180: warning: undeclared name: NewMockStorageProvider (ineffassign)
- Line 210: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 241: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 274: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 311: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 344: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 380: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 423: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 427: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 470: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 495: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 524: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 528: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 557: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 561: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 594: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 598: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 637: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 641: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 675: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 710: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 714: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 760: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 785: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 814: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 818: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 863: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 867: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 913: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 954: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 979: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1008: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1012: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1050: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1091: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1137: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1141: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1171: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1175: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1205: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1209: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1241: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1245: warning: undeclared name: NewMockCrypto (ineffassign)
- Line 1248: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1292: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1345: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1391: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1456: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1527: warning: undeclared name: NewMockStorageProvider (ineffassign)
- Line 1536: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1563: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1587: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1615: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1654: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1658: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1696: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1700: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1738: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1742: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1786: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1790: warning: undeclared name: NewMockCrypto (ineffassign)
- Line 1793: warning: undeclared name: NewMockTrillianLogClient (ineffassign)
- Line 1838: warning: undeclared name: NewMockKeyManager (ineffassign)
- Line 1851: warning: undeclared name: NewMockCrypto (ineffassign)
-
-
vct/cmd/vct/startcmd/start_test.go
- Line 70: warning: undeclared name: NewMockTrillianLogServer (ineffassign)
- Line 73: warning: undeclared name: NewMockTrillianAdminServer (ineffassign)
-
-
vct/pkg/storage/postgres/tree_storage_test.go
- Line 91: warning: undeclared name: NewMockSQLResult (ineffassign)
- Line 101: warning: undeclared name: NewMockSQLResult (ineffassign)
-
-
vct/pkg/controller/rest/operation_test.go
- Line 41: warning: undeclared name: NewMockCmd (ineffassign)
- Line 76: warning: undeclared name: NewMockCmd (ineffassign)
- Line 97: warning: undeclared name: NewMockCmd (ineffassign)
- Line 131: warning: undeclared name: NewMockCmd (ineffassign)
- Line 154: warning: undeclared name: NewMockCmd (ineffassign)
- Line 187: warning: undeclared name: NewMockCmd (ineffassign)
- Line 211: warning: undeclared name: NewMockCmd (ineffassign)
- Line 266: warning: undeclared name: NewMockCmd (ineffassign)
- Line 321: warning: undeclared name: NewMockCmd (ineffassign)
- Line 361: warning: undeclared name: NewMockCmd (ineffassign)
-
-
vct/pkg/client/vct/client_test.go
- Line 56: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 87: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 104: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 123: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 145: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 170: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 201: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 226: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 253: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 278: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 302: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 330: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 355: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 383: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 407: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 435: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 461: warning: undeclared name: NewMockHTTPClient (ineffassign)
- Line 489: warning: undeclared name: NewMockHTTPClient (ineffassign)