gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• rotor/updater_fromflags_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rotor/plugins/marathon/marathon.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• rotor/xds/poller/remote_test.go
  • Line 396: warning: cyclomatic complexity 20 of function overlayTest() is high (> 15) (gocyclo)
  • Line 94: warning: cyclomatic complexity 18 of function (remoteObjectsTestCase).run() is high (> 15) (gocyclo)

• rotor/plugins/consul/consul.go
  • Line 361: warning: cyclomatic complexity 19 of function getMkClusterFn() is high (> 15) (gocyclo)

• rotor/plugins/marathon/config/config.go
  • Line 66: warning: cyclomatic complexity 27 of function newFromMeta() is high (> 15) (gocyclo)

• rotor/differ/diff.go
  • Line 91: warning: cyclomatic complexity 16 of function diff() is high (> 15) (gocyclo)

• rotor/xds/poller/remote.go
  • Line 100: warning: cyclomatic complexity 31 of function (svcRemote).ObjectsWithOverrides() is high (> 15) (gocyclo)

golint90%

Golint is a linter for Go source code.

• rotor/plugins/kubernetes/client_fromflags.go
  • Line 101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• rotor/plugins/kubernetes/kubernetes.go
  • Line 73: warning: exported function Cmd should have comment or be unexported (golint)

• rotor/updater/updater.go
  • Line 72: warning: exported function New should have comment or be unexported (golint)

• rotor/plugins/marathon/marathon.go
  • Line 74: warning: exported function Cmd should have comment or be unexported (golint)

• rotor/plugins/aws/aws.go
  • Line 77: warning: exported function AWSCmd should have comment or be unexported (golint)

• rotor/plugins/aws/ecs_aws.go
  • Line 31: warning: exported const DescribeServicesWindowSz should have comment (or a comment on this block) or be unexported (golint)
  • Line 120: warning: error var badWindowSize should have name of the form errFoo (golint)

• rotor/plugins/aws/ecs_aws_test.go
  • Line 32: warning: error var boom should have name of the form errFoo (golint)

• rotor/plugins/aws/ecs_helper.go
  • Line 349: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• rotor/plugins/aws/ecs_helper_test.go
  • Line 187: warning: don't use underscores in Go names; var c1s1_task1arn should be c1s1Task1arn (golint)
  • Line 188: warning: don't use underscores in Go names; var c1s1_task2arn should be c1s1Task2arn (golint)
  • Line 189: warning: don't use underscores in Go names; var c1s2_task1arn should be c1s2Task1arn (golint)
  • Line 207: warning: don't use underscores in Go names; var c1s1ti1_containerarn should be c1s1ti1Containerarn (golint)
  • Line 208: warning: don't use underscores in Go names; var c1s1ti2_containerarn should be c1s1ti2Containerarn (golint)
  • Line 209: warning: don't use underscores in Go names; var c1s2ti1_containerarn should be c1s2ti1Containerarn (golint)

• rotor/plugins/consul/consul.go
  • Line 161: warning: exported function Cmd should have comment or be unexported (golint)

• rotor/differ/diff_test.go
  • Line 27: warning: error var someErr should have name of the form errFoo (golint)

• rotor/plugins/aws/ecs.go
  • Line 61: warning: exported function ECSCmd should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

• rotor/xds/adapter/adapter.go
  • Line 278: warning: ineffectual assignment to hcsOk (ineffassign)

• rotor/updater_fromflags_test.go
  • Line 85: warning: ineffectual assignment to calls (ineffassign)

• rotor/differ/diff.go
  • Line 205: warning: ineffectual assignment to checksum (ineffassign)

• rotor/xds/poller/remote.go
  • Line 157: warning: ineffectual assignment to domains (ineffassign)
  • Line 173: warning: ineffectual assignment to listeners (ineffassign)
  • Line 220: warning: ineffectual assignment to clusters (ineffassign)

misspell95%

Misspell Finds commonly misspelled English words

• rotor/xds/poller/fromflags.go
  • Line 47: warning: "Minimium" is a misspelling of "Minimum" (misspell)

• rotor/xds/poller/objects.go
  • Line 192: warning: "existant" is a misspelling of "existent" (misspell)

• rotor/plugins/aws/client_fromflags.go
  • Line 102: warning: "hierachy" is a misspelling of "hierarchy" (misspell)

• rotor/plugins/aws/ecs_helper.go
  • Line 288: warning: "abotu" is a misspelling of "about" (misspell)

• rotor/plugins/aws/ecs_helper_test.go
  • Line 605: warning: "sucessful" is a misspelling of "successful" (misspell)

• rotor/plugins/aws/ecs_helptext.go
  • Line 101: warning: "wih" is a misspelling of "with" (misspell)
  • Line 103: warning: "wih" is a misspelling of "with" (misspell)
  • Line 105: warning: "wih" is a misspelling of "with" (misspell)
  • Line 106: warning: "wih" is a misspelling of "with" (misspell)