gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• makisu/tools/bin/mkrootfs/main.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• makisu/bin/makisu/cmd/pull.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• makisu/lib/builder/step/step.go
  • Line 87: warning: cyclomatic complexity 20 of function NewDockerfileStep() is high (> 15) (gocyclo)

• makisu/lib/snapshot/mem_fs.go
  • Line 574: warning: cyclomatic complexity 25 of function (*MemFS).untarOneItem() is high (> 15) (gocyclo)
  • Line 165: warning: cyclomatic complexity 22 of function (*MemFS).UpdateFromTarReader() is high (> 15) (gocyclo)

• makisu/lib/parser/dockerfile/healthcheck.go
  • Line 44: warning: cyclomatic complexity 23 of function newHealthcheckDirective() is high (> 15) (gocyclo)

• makisu/lib/fileio/copy.go
  • Line 334: warning: cyclomatic complexity 17 of function (*Copier).mkdirAll() is high (> 15) (gocyclo)

• makisu/bin/makisu/cmd/build.go
  • Line 218: warning: cyclomatic complexity 20 of function (*buildCmd).Build() is high (> 15) (gocyclo)

• makisu/bin/makisu/cmd/push.go
  • Line 159: warning: cyclomatic complexity 17 of function (*pushCmd).importTar() is high (> 15) (gocyclo)

• makisu/bin/makisu/cmd/diff.go
  • Line 55: warning: cyclomatic complexity 16 of function (*diffCmd).Diff() is high (> 15) (gocyclo)

• makisu/lib/tario/untar.go
  • Line 37: warning: cyclomatic complexity 21 of function untar() is high (> 15) (gocyclo)

golint96%

Golint is a linter for Go source code.

• makisu/lib/parser/dockerfile/healthcheck.go
  • Line 24: warning: comment on exported type HealthcheckDirective should be of the form "HealthcheckDirective ..." (with optional leading article) (golint)

• makisu/lib/storage/image_store.go
  • Line 72: warning: exported method ImageStore.SaveManifest should have comment or be unexported (golint)

• makisu/lib/registry/security/basicauth.go
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• makisu/lib/registry/pull_fixture.go
  • Line 21: warning: comment on exported function PullClientFixtureWithAlpine should be of the form "PullClientFixtureWithAlpine ..." (golint)
  • Line 30: warning: comment on exported function PullClientFixtureWithAlpineDup should be of the form "PullClientFixtureWithAlpineDup ..." (golint)

• makisu/lib/fileio/copy.go
  • Line 96: warning: exported type CopyOption should have comment or be unexported (golint)
  • Line 98: warning: exported function WithDstDirOwner should have comment or be unexported (golint)
  • Line 108: warning: exported function WithDstFileAndChildrenOwner should have comment or be unexported (golint)

• makisu/lib/cache/keyvalue/redis_store.go
  • Line 25: warning: exported const MaxRetires should have comment (or a comment on this block) or be unexported (golint)

• makisu/bin/makisu/cmd/root.go
  • Line 73: warning: exported function Execute should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• makisu/lib/tario/compare_test.go
  • Line 339: warning: ineffectual assignment to similar (ineffassign)
  • Line 339: warning: ineffectual assignment to err (ineffassign)

• makisu/lib/storage/root_preserver_test.go
  • Line 66: warning: ineffectual assignment to b (ineffassign)

• makisu/bin/makisu/cmd/push.go
  • Line 207: warning: ineffectual assignment to err (ineffassign)
  • Line 230: warning: ineffectual assignment to err (ineffassign)

misspell99%

Misspell Finds commonly misspelled English words

• makisu/lib/registry/security/security.go
  • Line 41: warning: "addtional" is a misspelling of "additional" (misspell)