Report for github.com/viant/dsc
A+ Excellent! Found 19 issues across 55 files
gofmt96%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
dsc/dml_provider.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
dsc/sql_dialect.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint76%
Golint is a linter for Go source code.
-
-
dsc/dml_provider.go
- Line 141: warning: exported function NewMapDmlProvider should have comment or be unexported (golint)
-
-
dsc/file_manager.go
- Line 39: warning: exported method FileManager.Init should have comment or be unexported (golint)
- Line 171: warning: exported method FileManager.PersistTableData should have comment or be unexported (golint)
- Line 471: warning: exported type DelimiteredRecord should have comment or be unexported (golint)
-
-
dsc/sql_parser.go
- Line 52: warning: exported method SQLCriteria.Expression should have comment or be unexported (golint)
- Line 77: warning: exported method SQLCriterion.Expression should have comment or be unexported (golint)
-
-
dsc/sql_scanner.go
- Line 5: warning: exported type SQLScanner should have comment or be unexported (golint)
- Line 14: warning: exported method SQLScanner.ColumnTypes should have comment or be unexported (golint)
- Line 18: warning: exported method SQLScanner.Columns should have comment or be unexported (golint)
- Line 22: warning: exported method SQLScanner.Scan should have comment or be unexported (golint)
-
-
dsc/api.go
- Line 188: warning: exported type ColumnType should have comment or be unexported (golint)
-
-
dsc/column.go
- Line 8: warning: exported type TableColumn should have comment or be unexported (golint)
- Line 19: warning: exported method TableColumn.Name should have comment or be unexported (golint)
- Line 23: warning: exported method TableColumn.Length should have comment or be unexported (golint)
- Line 30: warning: exported method TableColumn.DecimalSize should have comment or be unexported (golint)
- Line 37: warning: exported method TableColumn.ScanType should have comment or be unexported (golint)
- Line 41: warning: exported method TableColumn.Nullable should have comment or be unexported (golint)
- Line 48: warning: comment on exported method TableColumn.DatabaseTypeName should be of the form "DatabaseTypeName ..." (golint)
-
-
dsc/config.go
- Line 57: warning: comment on exported method Config.GetMap should be of the form "GetMap ..." (golint)
- Line 171: warning: exported method Config.ApplyCredentials should have comment or be unexported (golint)
- Line 268: warning: comment on exported function NewConfigFromURL should be of the form "NewConfigFromURL ..." (golint)
-
-
dsc/dialect.go
- Line 9: warning: exported type DefaultDialect should have comment or be unexported (golint)
- Line 11: warning: exported method DefaultDialect.GetDatastores should have comment or be unexported (golint)
- Line 15: warning: exported method DefaultDialect.GetTables should have comment or be unexported (golint)
- Line 19: warning: exported method DefaultDialect.DropTable should have comment or be unexported (golint)
- Line 23: warning: exported method DefaultDialect.IsKeyCheckSwitchSessionLevel should have comment or be unexported (golint)
- Line 27: warning: exported method DefaultDialect.CreateTable should have comment or be unexported (golint)
- Line 31: warning: exported method DefaultDialect.CanCreateDatastore should have comment or be unexported (golint)
- Line 35: warning: exported method DefaultDialect.GetColumns should have comment or be unexported (golint)
- Line 39: warning: exported method DefaultDialect.CreateDatastore should have comment or be unexported (golint)
- Line 43: warning: exported method DefaultDialect.CanDropDatastore should have comment or be unexported (golint)
- Line 47: warning: exported method DefaultDialect.DropDatastore should have comment or be unexported (golint)
- Line 51: warning: exported method DefaultDialect.GetCurrentDatastore should have comment or be unexported (golint)
- Line 55: warning: exported method DefaultDialect.BulkInsertType should have comment or be unexported (golint)
- Line 59: warning: exported method DefaultDialect.GetSequence should have comment or be unexported (golint)
- Line 63: warning: exported method DefaultDialect.GetKeyName should have comment or be unexported (golint)
- Line 67: warning: exported method DefaultDialect.IsAutoincrement should have comment or be unexported (golint)
- Line 71: warning: exported method DefaultDialect.CanPersistBatch should have comment or be unexported (golint)
- Line 75: warning: exported method DefaultDialect.Init should have comment or be unexported (golint)
- Line 84: warning: comment on exported method DefaultDialect.EnableForeignKeyCheck should be of the form "EnableForeignKeyCheck ..." (golint)
- Line 89: warning: exported method DefaultDialect.NormalizeSQL should have comment or be unexported (golint)
- Line 93: warning: exported method DefaultDialect.ShowCreateTable should have comment or be unexported (golint)
- Line 97: warning: exported method DefaultDialect.CanHandleTransaction should have comment or be unexported (golint)
- Line 119: warning: exported method DefaultDialect.Ping should have comment or be unexported (golint)
-
-
dsc/table.go
- Line 20: warning: exported method TableDescriptor.From should have comment or be unexported (golint)
-
-
dsc/file_scanner.go
- Line 22: warning: comment on exported method FileScanner.ColumnTypes should be of the form "ColumnTypes ..." (golint)
-
-
dsc/manager.go
- Line 16: warning: exported var BulkInsertAllType should have comment or be unexported (golint)
- Line 17: warning: exported var UnionSelectInsert should have comment or be unexported (golint)
- Line 18: warning: exported var CopyLocalInsert should have comment or be unexported (golint)
-
-
dsc/scanner.go
- Line 35: warning: exported function NewScanner should have comment or be unexported (golint)
-
-
dsc/table_descriptor.go
- Line 93: warning: comment on exported function NewTableDescriptorRegistry should be of the form "NewTableDescriptorRegistry ..." (golint)
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
dsc/manager.go
- Line 347: warning: cyclomatic complexity 18 of function (*AbstractManager).PersistData() is high (> 15) (gocyclo)
-
-
dsc/sql_parser.go
- Line 386: warning: cyclomatic complexity 24 of function (*baseParser).readCriteria() is high (> 15) (gocyclo)
- Line 572: warning: cyclomatic complexity 19 of function (*QueryParser).Parse() is high (> 15) (gocyclo)
- Line 502: warning: cyclomatic complexity 18 of function (*QueryParser).readQueryColumns() is high (> 15) (gocyclo)
ineffassign87%
IneffAssign detects ineffectual assignments in Go code.
-
-
dsc/file_dialect.go
- Line 55: warning: ineffectual assignment to err (ineffassign)
-
-
dsc/file_manager.go
- Line 159: warning: ineffectual assignment to err (ineffassign)
- Line 203: warning: ineffectual assignment to err (ineffassign)
-
-
dsc/record_mapper.go
- Line 78: warning: ineffectual assignment to ok (ineffassign)
-
-
dsc/sql_dialect_test.go
- Line 59: warning: ineffectual assignment to err (ineffassign)
- Line 61: warning: ineffectual assignment to err (ineffassign)
-
-
dsc/sql_manager_test.go
- Line 356: warning: ineffectual assignment to updated (ineffassign)
-
-
dsc/sql_parser.go
- Line 621: warning: ineffectual assignment to err (ineffassign)
-
-
dsc/sql_parser_test.go
- Line 573: warning: ineffectual assignment to err (ineffassign)
- Line 581: warning: ineffectual assignment to err (ineffassign)