Report for github.com/vlorc/hprose-gateway
A+ Excellent! Found 4 issues across 7 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint42%
Golint is a linter for Go source code.
-
-
hprose-gateway/gateway/gateway.go
- Line 11: warning: exported type HproseGateway should have comment or be unexported (golint)
- Line 15: warning: exported function NewGateway should have comment or be unexported (golint)
- Line 24: warning: exported function NewGatewayWith should have comment or be unexported (golint)
- Line 28: warning: exported method HproseGateway.Invoke should have comment or be unexported (golint)
-
-
hprose-gateway/gateway/invoker.go
- Line 11: warning: exported type Invoker should have comment or be unexported (golint)
- Line 13: warning: exported function NewInvoker should have comment or be unexported (golint)
- Line 17: warning: exported method Invoker.Level should have comment or be unexported (golint)
- Line 21: warning: exported method Invoker.Close should have comment or be unexported (golint)
- Line 25: warning: exported method Invoker.Name should have comment or be unexported (golint)
- Line 29: warning: context.Context should be the first parameter of a function (golint)
- Line 29: warning: exported method Invoker.Handler should have comment or be unexported (golint)
- Line 30: warning: don't use underscores in Go names; var app_id should be appID (golint)
- Line 31: warning: don't use underscores in Go names; var client_id should be clientID (golint)
-
-
hprose-gateway/gateway/table.go
- Line 13: warning: exported type HproseTable should have comment or be unexported (golint)
- Line 21: warning: exported function NewTable should have comment or be unexported (golint)
- Line 29: warning: exported method HproseTable.Push should have comment or be unexported (golint)
- Line 38: warning: exported method HproseTable.Pop should have comment or be unexported (golint)
- Line 42: warning: exported method HproseTable.Close should have comment or be unexported (golint)
- Line 82: warning: exported method HproseTable.Pipe should have comment or be unexported (golint)
-
-
hprose-gateway/named/mode.go
- Line 8: warning: exported type ModuleNamed should have comment or be unexported (golint)
- Line 9: warning: exported type AppNamed should have comment or be unexported (golint)
- Line 11: warning: exported method ModuleNamed.Resolver should have comment or be unexported (golint)
- Line 24: warning: exported method AppNamed.Resolver should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!