Report for github.com/wirepair/gcd
A Great! Found 30 issues across 44 files
gofmt90%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
gcd/v2/gcdmessage/gcdmessage.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
gcd/v2/observer/message_observer.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
gcd/v2/gcdapi/version.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
gcd/gcdapi/version.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint34%
Golint is a linter for Go source code.
-
-
gcd/gcdmessage/gcdmessage.go
- Line 38: warning: exported type ChromeTargeter should have comment or be unexported (golint)
- Line 45: warning: comment on exported type Message should be of the form "Message ..." (with optional leading article) (golint)
- Line 54: warning: comment on exported type ChromeResponse should be of the form "ChromeResponse ..." (with optional leading article) (golint)
- Line 60: warning: comment on exported type ChromeRequest should be of the form "ChromeRequest ..." (with optional leading article) (golint)
- Line 67: warning: comment on exported type ChromeErrorResponse should be of the form "ChromeErrorResponse ..." (with optional leading article) (golint)
- Line 73: warning: comment on exported type ChromeError should be of the form "ChromeError ..." (with optional leading article) (golint)
- Line 79: warning: comment on exported type ChromeRequestErr should be of the form "ChromeRequestErr ..." (with optional leading article) (golint)
- Line 89: warning: comment on exported type ChromeEmptyResponseErr should be of the form "ChromeEmptyResponseErr ..." (with optional leading article) (golint)
- Line 97: warning: exported type ChromeApiTimeoutErr should have comment or be unexported (golint)
- Line 104: warning: exported type ChromeDoneErr should have comment or be unexported (golint)
- Line 111: warning: comment on exported type ParamRequest should be of the form "ParamRequest ..." (with optional leading article) (golint)
- Line 118: warning: comment on exported function SendCustomReturn should be of the form "SendCustomReturn ..." (golint)
- Line 147: warning: comment on exported function SendDefaultRequest should be of the form "SendDefaultRequest ..." (golint)
-
-
gcd/v2/gcdapigen/downloader.go
- Line 45: warning: exported type ChromiumRevision should have comment or be unexported (golint)
- Line 66: warning: exported type RevisionInfo should have comment or be unexported (golint)
-
-
gcd/gcdapigen/event.go
- Line 27: warning: exported type Event should have comment or be unexported (golint)
- Line 35: warning: exported function NewEvent should have comment or be unexported (golint)
-
-
gcd/v2/observer/message_observer.go
- Line 5: warning: exported type MessageObserver should have comment or be unexported (golint)
- Line 20: warning: exported function NewIgnoreMessagesObserver should have comment or be unexported (golint)
- Line 24: warning: exported type IgnoreMessagesObserver should have comment or be unexported (golint)
- Line 26: warning: exported method IgnoreMessagesObserver.Request should have comment or be unexported (golint)
- Line 30: warning: exported method IgnoreMessagesObserver.Response should have comment or be unexported (golint)
- Line 34: warning: exported method IgnoreMessagesObserver.Event should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/event.go
- Line 27: warning: exported type Event should have comment or be unexported (golint)
- Line 35: warning: exported function NewEvent should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/protocol.go
- Line 27: warning: comment on exported type ProtoDebuggerApi should be of the form "ProtoDebuggerApi ..." (with optional leading article) (golint)
- Line 33: warning: comment on exported type ProtoApiVersion should be of the form "ProtoApiVersion ..." (with optional leading article) (golint)
- Line 39: warning: comment on exported type ProtoDomain should be of the form "ProtoDomain ..." (with optional leading article) (golint)
- Line 50: warning: comment on exported type ProtoType should be of the form "ProtoType ..." (with optional leading article) (golint)
- Line 63: warning: exported method ProtoType.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 67: warning: exported method ProtoType.GetUnderlyingType should have comment or be unexported (golint)
- Line 71: warning: exported method ProtoType.GetArrayType should have comment or be unexported (golint)
- Line 84: warning: exported method ProtoType.IsArray should have comment or be unexported (golint)
- Line 88: warning: comment on exported type ProtoProperty should be of the form "ProtoProperty ..." (with optional leading article) (golint)
- Line 101: warning: exported method ProtoProperty.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 105: warning: exported method ProtoProperty.GetUnderlyingType should have comment or be unexported (golint)
- Line 109: warning: exported method ProtoProperty.GetArrayType should have comment or be unexported (golint)
- Line 122: warning: exported method ProtoProperty.IsArray should have comment or be unexported (golint)
- Line 126: warning: comment on exported type ProtoItem should be of the form "ProtoItem ..." (with optional leading article) (golint)
- Line 135: warning: comment on exported type ProtoCommand should be of the form "ProtoCommand ..." (with optional leading article) (golint)
- Line 148: warning: comment on exported type ProtoCommandReturns should be of the form "ProtoCommandReturns ..." (with optional leading article) (golint)
- Line 157: warning: comment on exported type ProtoEvent should be of the form "ProtoEvent ..." (with optional leading article) (golint)
- Line 171: warning: exported method ProtoEvent.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 175: warning: exported method ProtoEvent.GetUnderlyingType should have comment or be unexported (golint)
- Line 179: warning: exported method ProtoEvent.GetArrayType should have comment or be unexported (golint)
- Line 192: warning: exported method ProtoEvent.IsArray should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/return.go
- Line 27: warning: exported type Return should have comment or be unexported (golint)
- Line 41: warning: exported function NewReturn should have comment or be unexported (golint)
- Line 65: warning: exported method Return.ArrayRef should have comment or be unexported (golint)
- Line 72: warning: comment on exported method Return.GetGoType should be of the form "GetGoType ..." (golint)
- Line 77: warning: exported method Return.SetIsTypeArray should have comment or be unexported (golint)
- Line 81: warning: exported method Return.GetEnumVals should have comment or be unexported (golint)
- Line 85: warning: exported method Return.GetRef should have comment or be unexported (golint)
- Line 89: warning: exported method Return.SetIsRef should have comment or be unexported (golint)
- Line 93: warning: exported method Return.GetIsRef should have comment or be unexported (golint)
- Line 97: warning: exported method Return.SetGoType should have comment or be unexported (golint)
- Line 101: warning: exported method Return.GetDescription should have comment or be unexported (golint)
- Line 104: warning: exported method Return.SetDescription should have comment or be unexported (golint)
- Line 108: warning: exported method Return.SetPointerType should have comment or be unexported (golint)
- Line 112: warning: comment on exported method Return.IsNonPropertiesObject should be of the form "IsNonPropertiesObject ..." (golint)
- Line 117: warning: exported method Return.GetUnderlyingType should have comment or be unexported (golint)
- Line 121: warning: exported method Return.IsArray should have comment or be unexported (golint)
- Line 125: warning: exported method Return.GetArrayType should have comment or be unexported (golint)
-
-
gcd/gcdapigen/command.go
- Line 27: warning: exported type Command should have comment or be unexported (golint)
- Line 40: warning: exported function NewCommand should have comment or be unexported (golint)
-
-
gcd/gcdapigen/domain.go
- Line 36: warning: exported type Domain should have comment or be unexported (golint)
- Line 53: warning: exported function NewDomain should have comment or be unexported (golint)
- Line 63: warning: comment on exported method Domain.PopulateTypes should be of the form "PopulateTypes ..." (golint)
- Line 78: warning: exported method Domain.PopulateEvents should have comment or be unexported (golint)
- Line 93: warning: exported method Domain.PopulateCommands should have comment or be unexported (golint)
- Line 269: warning: comment on exported method Domain.ResolveImports should be of the form "ResolveImports ..." (golint)
- Line 280: warning: exported method Domain.WriteDomain should have comment or be unexported (golint)
-
-
gcd/v2/gcd.go
- Line 47: warning: exported var GCDVERSION should have comment or be unexported (golint)
- Line 50: warning: exported var ErrNoTabAvailable should have comment or be unexported (golint)
- Line 53: warning: comment on exported type GcdBodyReadErr should be of the form "GcdBodyReadErr ..." (with optional leading article) (golint)
- Line 62: warning: comment on exported type GcdDecodingErr should be of the form "GcdDecodingErr ..." (with optional leading article) (golint)
- Line 71: warning: exported type TerminatedHandler should have comment or be unexported (golint)
- Line 73: warning: comment on exported type Gcd should be of the form "Gcd ..." (with optional leading article) (golint)
- Line 98: warning: comment on exported function NewChromeDebugger should be of the form "NewChromeDebugger ..." (golint)
- Line 145: warning: exported function WithDeleteProfileOnExit should have comment or be unexported (golint)
- Line 151: warning: exported function WithLogger should have comment or be unexported (golint)
- Line 157: warning: exported function WithContext should have comment or be unexported (golint)
- Line 163: warning: exported function WithEventDebugging should have comment or be unexported (golint)
- Line 169: warning: exported function WithInternalDebugMessages should have comment or be unexported (golint)
- Line 175: warning: exported function WithMessageObserver should have comment or be unexported (golint)
-
-
gcd/gcdapigen/type.go
- Line 31: warning: exported type Type should have comment or be unexported (golint)
- Line 42: warning: exported function NewType should have comment or be unexported (golint)
- Line 55: warning: exported function NewSubType should have comment or be unexported (golint)
- Line 69: warning: exported method Type.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 73: warning: exported method Type.GetUnderlyingType should have comment or be unexported (golint)
- Line 77: warning: exported method Type.IsArray should have comment or be unexported (golint)
- Line 81: warning: exported method Type.GetArrayType should have comment or be unexported (golint)
-
-
gcd/gcdapi/version.go
- Line 8: warning: comment on exported const CHROME_CHANNEL should be of the form "CHROME_CHANNEL ..." (golint)
- Line 10: warning: comment on exported const CHROME_VERSION should be of the form "CHROME_VERSION ..." (golint)
-
-
gcd/v2/gcdmessage/gcdmessage.go
- Line 39: warning: exported type ChromeTargeter should have comment or be unexported (golint)
- Line 48: warning: comment on exported type Message should be of the form "Message ..." (with optional leading article) (golint)
- Line 57: warning: comment on exported type ChromeResponse should be of the form "ChromeResponse ..." (with optional leading article) (golint)
- Line 63: warning: comment on exported type ChromeRequest should be of the form "ChromeRequest ..." (with optional leading article) (golint)
- Line 70: warning: comment on exported type ChromeErrorResponse should be of the form "ChromeErrorResponse ..." (with optional leading article) (golint)
- Line 76: warning: comment on exported type ChromeError should be of the form "ChromeError ..." (with optional leading article) (golint)
- Line 82: warning: comment on exported type ChromeRequestErr should be of the form "ChromeRequestErr ..." (with optional leading article) (golint)
- Line 92: warning: comment on exported type ChromeEmptyResponseErr should be of the form "ChromeEmptyResponseErr ..." (with optional leading article) (golint)
- Line 100: warning: exported type ChromeApiTimeoutErr should have comment or be unexported (golint)
- Line 107: warning: exported type ChromeDoneErr should have comment or be unexported (golint)
- Line 114: warning: exported type ChromeCtxDoneErr should have comment or be unexported (golint)
- Line 121: warning: comment on exported type ParamRequest should be of the form "ParamRequest ..." (with optional leading article) (golint)
-
-
gcd/gcdapigen/return.go
- Line 27: warning: exported type Return should have comment or be unexported (golint)
- Line 41: warning: exported function NewReturn should have comment or be unexported (golint)
- Line 65: warning: exported method Return.ArrayRef should have comment or be unexported (golint)
- Line 72: warning: comment on exported method Return.GetGoType should be of the form "GetGoType ..." (golint)
- Line 77: warning: exported method Return.SetIsTypeArray should have comment or be unexported (golint)
- Line 81: warning: exported method Return.GetEnumVals should have comment or be unexported (golint)
- Line 85: warning: exported method Return.GetRef should have comment or be unexported (golint)
- Line 89: warning: exported method Return.SetIsRef should have comment or be unexported (golint)
- Line 93: warning: exported method Return.GetIsRef should have comment or be unexported (golint)
- Line 97: warning: exported method Return.SetGoType should have comment or be unexported (golint)
- Line 101: warning: exported method Return.GetDescription should have comment or be unexported (golint)
- Line 104: warning: exported method Return.SetDescription should have comment or be unexported (golint)
- Line 108: warning: exported method Return.SetPointerType should have comment or be unexported (golint)
- Line 112: warning: comment on exported method Return.IsNonPropertiesObject should be of the form "IsNonPropertiesObject ..." (golint)
- Line 117: warning: exported method Return.GetUnderlyingType should have comment or be unexported (golint)
- Line 121: warning: exported method Return.IsArray should have comment or be unexported (golint)
- Line 125: warning: exported method Return.GetArrayType should have comment or be unexported (golint)
-
-
gcd/chrome_target.go
- Line 289: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
gcd/v2/gcdapi/version.go
- Line 8: warning: comment on exported const CHROME_CHANNEL should be of the form "CHROME_CHANNEL ..." (golint)
- Line 10: warning: comment on exported const CHROME_VERSION should be of the form "CHROME_VERSION ..." (golint)
-
-
gcd/v2/gcdapigen/gcdapigen.go
- Line 38: warning: exported type GlobalReference should have comment or be unexported (golint)
-
-
gcd/gcdapigen/protocol.go
- Line 27: warning: comment on exported type ProtoDebuggerApi should be of the form "ProtoDebuggerApi ..." (with optional leading article) (golint)
- Line 33: warning: comment on exported type ProtoApiVersion should be of the form "ProtoApiVersion ..." (with optional leading article) (golint)
- Line 39: warning: comment on exported type ProtoDomain should be of the form "ProtoDomain ..." (with optional leading article) (golint)
- Line 50: warning: comment on exported type ProtoType should be of the form "ProtoType ..." (with optional leading article) (golint)
- Line 63: warning: exported method ProtoType.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 67: warning: exported method ProtoType.GetUnderlyingType should have comment or be unexported (golint)
- Line 71: warning: exported method ProtoType.GetArrayType should have comment or be unexported (golint)
- Line 84: warning: exported method ProtoType.IsArray should have comment or be unexported (golint)
- Line 88: warning: comment on exported type ProtoProperty should be of the form "ProtoProperty ..." (with optional leading article) (golint)
- Line 101: warning: exported method ProtoProperty.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 105: warning: exported method ProtoProperty.GetUnderlyingType should have comment or be unexported (golint)
- Line 109: warning: exported method ProtoProperty.GetArrayType should have comment or be unexported (golint)
- Line 122: warning: exported method ProtoProperty.IsArray should have comment or be unexported (golint)
- Line 126: warning: comment on exported type ProtoItem should be of the form "ProtoItem ..." (with optional leading article) (golint)
- Line 135: warning: comment on exported type ProtoCommand should be of the form "ProtoCommand ..." (with optional leading article) (golint)
- Line 148: warning: comment on exported type ProtoCommandReturns should be of the form "ProtoCommandReturns ..." (with optional leading article) (golint)
- Line 157: warning: comment on exported type ProtoEvent should be of the form "ProtoEvent ..." (with optional leading article) (golint)
- Line 171: warning: exported method ProtoEvent.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 175: warning: exported method ProtoEvent.GetUnderlyingType should have comment or be unexported (golint)
- Line 179: warning: exported method ProtoEvent.GetArrayType should have comment or be unexported (golint)
- Line 192: warning: exported method ProtoEvent.IsArray should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/command.go
- Line 27: warning: exported type Command should have comment or be unexported (golint)
- Line 40: warning: exported function NewCommand should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/domain.go
- Line 36: warning: exported type Domain should have comment or be unexported (golint)
- Line 53: warning: exported function NewDomain should have comment or be unexported (golint)
- Line 63: warning: comment on exported method Domain.PopulateTypes should be of the form "PopulateTypes ..." (golint)
- Line 78: warning: exported method Domain.PopulateEvents should have comment or be unexported (golint)
- Line 93: warning: exported method Domain.PopulateCommands should have comment or be unexported (golint)
- Line 269: warning: comment on exported method Domain.ResolveImports should be of the form "ResolveImports ..." (golint)
- Line 280: warning: exported method Domain.WriteDomain should have comment or be unexported (golint)
-
-
gcd/gcdapigen/gcdapigen.go
- Line 38: warning: exported type GlobalReference should have comment or be unexported (golint)
-
-
gcd/gcdapigen/utils.go
- Line 32: warning: exported type PropSetter should have comment or be unexported (golint)
- Line 45: warning: exported type SharedProperties should have comment or be unexported (golint)
- Line 52: warning: comment on exported function PopulateReferences should be of the form "PopulateReferences ..." (golint)
-
-
gcd/gcd.go
- Line 45: warning: exported var GCDVERSION should have comment or be unexported (golint)
- Line 48: warning: exported var ErrNoTabAvailable should have comment or be unexported (golint)
- Line 51: warning: comment on exported type GcdBodyReadErr should be of the form "GcdBodyReadErr ..." (with optional leading article) (golint)
- Line 60: warning: comment on exported type GcdDecodingErr should be of the form "GcdDecodingErr ..." (with optional leading article) (golint)
- Line 69: warning: exported type TerminatedHandler should have comment or be unexported (golint)
- Line 71: warning: comment on exported type Gcd should be of the form "Gcd ..." (with optional leading article) (golint)
- Line 90: warning: comment on exported function NewChromeDebugger should be of the form "NewChromeDebugger ..." (golint)
- Line 103: warning: comment on exported method Gcd.SetTerminationHandler should be of the form "SetTerminationHandler ..." (golint)
- Line 133: warning: exported method Gcd.DeleteProfileOnExit should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/type.go
- Line 31: warning: exported type Type should have comment or be unexported (golint)
- Line 42: warning: exported function NewType should have comment or be unexported (golint)
- Line 55: warning: exported function NewSubType should have comment or be unexported (golint)
- Line 69: warning: exported method Type.IsNonPropertiesObject should have comment or be unexported (golint)
- Line 73: warning: exported method Type.GetUnderlyingType should have comment or be unexported (golint)
- Line 77: warning: exported method Type.IsArray should have comment or be unexported (golint)
- Line 81: warning: exported method Type.GetArrayType should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/utils.go
- Line 32: warning: exported type PropSetter should have comment or be unexported (golint)
- Line 45: warning: exported type SharedProperties should have comment or be unexported (golint)
- Line 52: warning: comment on exported function PopulateReferences should be of the form "PopulateReferences ..." (golint)
-
-
gcd/gcdapigen/downloader.go
- Line 45: warning: exported type ChromiumRevision should have comment or be unexported (golint)
- Line 66: warning: exported type RevisionInfo should have comment or be unexported (golint)
-
-
gcd/v2/gcdapigen/type_properties.go
- Line 27: warning: comment on exported type TypeProperties should be of the form "TypeProperties ..." (with optional leading article) (golint)
- Line 42: warning: exported function NewTypeProperties should have comment or be unexported (golint)
- Line 60: warning: comment on exported method TypeProperties.GetGoType should be of the form "GetGoType ..." (golint)
- Line 65: warning: exported method TypeProperties.SetGoType should have comment or be unexported (golint)
- Line 69: warning: exported method TypeProperties.GetIsRef should have comment or be unexported (golint)
- Line 73: warning: exported method TypeProperties.SetIsRef should have comment or be unexported (golint)
- Line 77: warning: exported method TypeProperties.SetIsTypeArray should have comment or be unexported (golint)
- Line 81: warning: exported method TypeProperties.GetRef should have comment or be unexported (golint)
- Line 85: warning: exported method TypeProperties.GetEnumVals should have comment or be unexported (golint)
- Line 89: warning: exported method TypeProperties.GetDescription should have comment or be unexported (golint)
- Line 92: warning: exported method TypeProperties.SetDescription should have comment or be unexported (golint)
- Line 96: warning: exported method TypeProperties.SetPointerType should have comment or be unexported (golint)
- Line 100: warning: comment on exported method TypeProperties.IsNonPropertiesObject should be of the form "IsNonPropertiesObject ..." (golint)
- Line 105: warning: exported method TypeProperties.GetUnderlyingType should have comment or be unexported (golint)
- Line 109: warning: exported method TypeProperties.IsArray should have comment or be unexported (golint)
- Line 113: warning: exported method TypeProperties.GetArrayType should have comment or be unexported (golint)
- Line 124: warning: exported method TypeProperties.ArrayRef should have comment or be unexported (golint)
-
-
gcd/gcdapigen/type_properties.go
- Line 27: warning: comment on exported type TypeProperties should be of the form "TypeProperties ..." (with optional leading article) (golint)
- Line 42: warning: exported function NewTypeProperties should have comment or be unexported (golint)
- Line 60: warning: comment on exported method TypeProperties.GetGoType should be of the form "GetGoType ..." (golint)
- Line 65: warning: exported method TypeProperties.SetGoType should have comment or be unexported (golint)
- Line 69: warning: exported method TypeProperties.GetIsRef should have comment or be unexported (golint)
- Line 73: warning: exported method TypeProperties.SetIsRef should have comment or be unexported (golint)
- Line 77: warning: exported method TypeProperties.SetIsTypeArray should have comment or be unexported (golint)
- Line 81: warning: exported method TypeProperties.GetRef should have comment or be unexported (golint)
- Line 85: warning: exported method TypeProperties.GetEnumVals should have comment or be unexported (golint)
- Line 89: warning: exported method TypeProperties.GetDescription should have comment or be unexported (golint)
- Line 92: warning: exported method TypeProperties.SetDescription should have comment or be unexported (golint)
- Line 96: warning: exported method TypeProperties.SetPointerType should have comment or be unexported (golint)
- Line 100: warning: comment on exported method TypeProperties.IsNonPropertiesObject should be of the form "IsNonPropertiesObject ..." (golint)
- Line 105: warning: exported method TypeProperties.GetUnderlyingType should have comment or be unexported (golint)
- Line 109: warning: exported method TypeProperties.IsArray should have comment or be unexported (golint)
- Line 113: warning: exported method TypeProperties.GetArrayType should have comment or be unexported (golint)
- Line 124: warning: exported method TypeProperties.ArrayRef should have comment or be unexported (golint)
-
-
gcd/v2/logger.go
- Line 5: warning: exported type Log should have comment or be unexported (golint)
- Line 9: warning: exported type LogDiscarder should have comment or be unexported (golint)
- Line 11: warning: exported method LogDiscarder.Println should have comment or be unexported (golint)
- Line 13: warning: exported type DebugLogger should have comment or be unexported (golint)
- Line 15: warning: exported method DebugLogger.Println should have comment or be unexported (golint)
ineffassign95%
IneffAssign detects ineffectual assignments in Go code.
-
-
gcd/v2/gcd.go
- Line 258: warning: ineffectual assignment to err (ineffassign)
- Line 303: warning: ineffectual assignment to err (ineffassign)
-
-
gcd/gcd.go
- Line 202: warning: ineffectual assignment to err (ineffassign)
- Line 241: warning: ineffectual assignment to err (ineffassign)
misspell97%
Misspell Finds commonly misspelled English words
-
-
gcd/v2/chrome_target.go
- Line 334: warning: "reciever" is a misspelling of "receiver" (misspell)