Report for github.com/wzshiming/shadowsocks
A+ Excellent! Found 19 issues across 26 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
shadowsocks/socks.go
- Line 116: warning: cyclomatic complexity 16 of function writeAddress() is high (> 15) (gocyclo)
golint30%
Golint is a linter for Go source code.
-
-
shadowsocks/stream/cast5-cfb/init.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 14: warning: exported function NewCast5StreamEncrypt should have comment or be unexported (golint)
- Line 22: warning: exported function NewCast5StreamDecrypt should have comment or be unexported (golint)
-
-
shadowsocks/init/init.go
- Line 4: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
-
-
shadowsocks/stream/salsa20/init.go
- Line 15: warning: exported function NewSalsa20Stream should have comment or be unexported (golint)
-
-
shadowsocks/packet_server.go
- Line 13: warning: exported type PacketServer should have comment or be unexported (golint)
- Line 50: warning: exported function NewPacketServer should have comment or be unexported (golint)
- Line 68: warning: exported method PacketServer.ServePacket should have comment or be unexported (golint)
-
-
shadowsocks/stream/des-cfb/init.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 14: warning: exported function NewDESStreamEncrypt should have comment or be unexported (golint)
- Line 22: warning: exported function NewDESStreamDecrypt should have comment or be unexported (golint)
-
-
shadowsocks/stream/aes-x-cfb/init.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 16: warning: exported function NewAESCFBStreamEncrypt should have comment or be unexported (golint)
- Line 24: warning: exported function NewAESCFBStreamDecrypt should have comment or be unexported (golint)
-
-
shadowsocks/packet_client.go
- Line 10: warning: exported type PacketClient should have comment or be unexported (golint)
- Line 32: warning: exported function NewPacketClient should have comment or be unexported (golint)
- Line 74: warning: exported method PacketClient.ListenPacket should have comment or be unexported (golint)
-
-
shadowsocks/aead/chacha20-ietf-poly1305/init.go
- Line 1: warning: don't use an underscore in package name (golint)
-
-
shadowsocks/stream/chacha20/init.go
- Line 15: warning: exported function NewChaCha20Stream should have comment or be unexported (golint)
-
-
shadowsocks/stream/cipher.go
- Line 12: warning: exported function RegisterCipher should have comment or be unexported (golint)
- Line 24: warning: exported type Cipher should have comment or be unexported (golint)
- Line 32: warning: exported method Cipher.StreamConn should have comment or be unexported (golint)
- Line 58: warning: exported method Cipher.Encrypt should have comment or be unexported (golint)
- Line 75: warning: exported method Cipher.Decrypt should have comment or be unexported (golint)
-
-
shadowsocks/packet.go
- Line 9: warning: exported type ListenPacket should have comment or be unexported (golint)
-
-
shadowsocks/simple_server.go
- Line 18: warning: comment on exported function NewSimpleServer should be of the form "NewSimpleServer ..." (golint)
-
-
shadowsocks/aead/aes-x-gcm/init.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 15: warning: exported function NewAESGCM should have comment or be unexported (golint)
-
-
shadowsocks/stream/aes-x-ctr/init.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 16: warning: exported function NewAESCTRStream should have comment or be unexported (golint)
-
-
shadowsocks/stream/bf-cfb/init.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 14: warning: exported function NewBlowFishStreamEncrypt should have comment or be unexported (golint)
- Line 22: warning: exported function NewBlowFishStreamDecrypt should have comment or be unexported (golint)
-
-
shadowsocks/stream/rc4-md5-x/init.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 16: warning: exported function NewRC4MD5Stream should have comment or be unexported (golint)
-
-
shadowsocks/aead/cipher.go
- Line 17: warning: exported function RegisterCipher should have comment or be unexported (golint)
- Line 28: warning: exported type Cipher should have comment or be unexported (golint)
- Line 34: warning: exported method Cipher.StreamConn should have comment or be unexported (golint)
- Line 38: warning: exported method Cipher.KeySize should have comment or be unexported (golint)
- Line 42: warning: exported method Cipher.SaltSize should have comment or be unexported (golint)
- Line 93: warning: exported method Cipher.Encrypt should have comment or be unexported (golint)
- Line 111: warning: exported method Cipher.Decrypt should have comment or be unexported (golint)
-
-
shadowsocks/cipher.go
- Line 16: warning: exported type ConnCipher should have comment or be unexported (golint)
- Line 24: warning: exported function RegisterCipher should have comment or be unexported (golint)
- Line 28: warning: exported function CipherList should have comment or be unexported (golint)
- Line 50: warning: comment on exported function KDF should be of the form "KDF ..." (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!