gofmt76%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• goexif2/tiff/tiff_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• goexif2/exif/exif.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• goexif2/exif/regress_expected_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo84%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• goexif2/tiff/tag.go
  • Line 185: warning: cyclomatic complexity 42 of function (*Tag).convertVals() is high (> 15) (gocyclo)

• goexif2/exif/exif.go
  • Line 244: warning: cyclomatic complexity 18 of function Decode() is high (> 15) (gocyclo)

golint46%

Golint is a linter for Go source code.

• goexif2/tiff/tag.go
  • Line 20: warning: exported const IntVal should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported var ErrShortReadTagValue should have comment or be unexported (golint)
  • Line 46: warning: exported const DTByte should have comment (or a comment on this block) or be unexported (golint)
  • Line 409: warning: exported method Tag.MarshalJSON should have comment or be unexported (golint)
  • Line 414: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• goexif2/tiff/tiff.go
  • Line 18: warning: exported type ReadAtReaderSeeker should have comment or be unexported (golint)
  • Line 23: warning: exported type TiffError should have comment or be unexported (golint)
  • Line 39: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• goexif2/exif/exif.go
  • Line 21: warning: don't use underscores in Go names; const jpeg_MARKER should be jpegMARKER (golint)
  • Line 22: warning: don't use underscores in Go names; const jpeg_APP1 should be jpegAPP1 (golint)
  • Line 23: warning: don't use underscores in Go names; const jpeg_COM should be jpegCOM (golint)
  • Line 86: warning: exported function IsTagNotPresentError should have comment or be unexported (golint)
  • Line 123: warning: comment on exported function IsCriticalError should be of the form "IsCriticalError ..." (golint)
  • Line 430: warning: exported method Exif.TimeZone should have comment or be unexported (golint)
  • Line 650: warning: comment on exported method Exif.MarshalJSON should be of the form "MarshalJSON ..." (golint)
  • Line 734: warning: receiver name s should be consistent with previous receiver name app for appSec (golint)

• goexif2/exif/fields.go
  • Line 3: warning: exported type FieldName should have comment or be unexported (golint)

• goexif2/mknote/fields.go
  • Line 21: warning: don't use underscores in Go names; const WB_RBLevels should be WBRBLevels (golint)
  • Line 104: warning: don't use underscores in Go names; const Nikon_Version should be NikonVersion (golint)
  • Line 105: warning: don't use underscores in Go names; const Nikon_WhiteBalance should be NikonWhiteBalance (golint)
  • Line 106: warning: don't use underscores in Go names; const Nikon_ColorSpace should be NikonColorSpace (golint)
  • Line 107: warning: don't use underscores in Go names; const Nikon_LightSource should be NikonLightSource (golint)
  • Line 108: warning: don't use underscores in Go names; const Nikon_Saturation should be NikonSaturation (golint)
  • Line 109: warning: don't use underscores in Go names; const Nikon_ShotInfo should be NikonShotInfo (golint)
  • Line 110: warning: don't use underscores in Go names; const Nikon_VRInfo should be NikonVRInfo (golint)
  • Line 111: warning: don't use underscores in Go names; const Nikon_PictureControl should be NikonPictureControl (golint)
  • Line 112: warning: don't use underscores in Go names; const Nikon_WorldTime should be NikonWorldTime (golint)
  • Line 113: warning: don't use underscores in Go names; const Nikon_ISOInfo should be NikonISOInfo (golint)
  • Line 114: warning: don't use underscores in Go names; const Nikon_AFInfo should be NikonAFInfo (golint)
  • Line 115: warning: don't use underscores in Go names; const Nikon_ColorBalance should be NikonColorBalance (golint)
  • Line 116: warning: don't use underscores in Go names; const Nikon_LensData should be NikonLensData (golint)
  • Line 117: warning: don't use underscores in Go names; const Nikon_SerialNO should be NikonSerialNO (golint)
  • Line 118: warning: don't use underscores in Go names; const Nikon_FlashInfo should be NikonFlashInfo (golint)
  • Line 119: warning: don't use underscores in Go names; const Nikon_MultiExposure should be NikonMultiExposure (golint)
  • Line 120: warning: don't use underscores in Go names; const Nikon_AFInfo2 should be NikonAFInfo2 (golint)
  • Line 121: warning: don't use underscores in Go names; const Nikon_FileInfo should be NikonFileInfo (golint)
  • Line 122: warning: don't use underscores in Go names; const Nikon_AFTune should be NikonAFTune (golint)
  • Line 129: warning: don't use underscores in Go names; const Canon_CameraSettings should be CanonCameraSettings (golint)
  • Line 130: warning: don't use underscores in Go names; const Canon_ShotInfo should be CanonShotInfo (golint)
  • Line 131: warning: don't use underscores in Go names; const Canon_AFInfo should be CanonAFInfo (golint)
  • Line 132: warning: don't use underscores in Go names; const Canon_TimeInfo should be CanonTimeInfo (golint)
  • Line 133: warning: don't use underscores in Go names; const Canon_0x0000 should be Canon0x0000 (golint)
  • Line 134: warning: don't use underscores in Go names; const Canon_0x0003 should be Canon0x0003 (golint)
  • Line 135: warning: don't use underscores in Go names; const Canon_0x00b5 should be Canon0x00b5 (golint)
  • Line 136: warning: don't use underscores in Go names; const Canon_0x00c0 should be Canon0x00c0 (golint)
  • Line 137: warning: don't use underscores in Go names; const Canon_0x00c1 should be Canon0x00c1 (golint)

• goexif2/mknote/mknote.go
  • Line 23: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 53: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 58: warning: receiver name should not be an underscore, omit the name if it is unused (golint)

• goexif2/cmd/goexif2/main.go
  • Line 57: warning: exported type Walker should have comment or be unexported (golint)
  • Line 59: warning: exported method Walker.Walk should have comment or be unexported (golint)
  • Line 59: warning: receiver name should not be an underscore, omit the name if it is unused (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!