Preparing report...

Report for github.com/zalando-incubator/mate

A    Great!    Found 21 issues across 30 files

Tweet

gofmt73%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • mate/consumers/aws_test.go
    • Line 208: warning: cyclomatic complexity 20 of function TestRecordInfo() is high (> 15) (gocyclo)
    • Line 431: warning: cyclomatic complexity 18 of function checkEndpointSlices() is high (> 15) (gocyclo)

golint53%

Golint is a linter for Go source code.

    • mate/pkg/aws/test/test_client.go
    • Line 9: warning: exported type Client should have comment or be unexported (golint)
    • Line 18: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 28: warning: exported method Client.ListRecordSets should have comment or be unexported (golint)
    • Line 32: warning: exported method Client.ChangeRecordSets should have comment or be unexported (golint)
    • Line 47: warning: exported method Client.GetCanonicalZoneIDs should have comment or be unexported (golint)
    • Line 56: warning: exported method Client.GetHostedZones should have comment or be unexported (golint)
    • mate/pkg/aws/client.go
    • Line 18: warning: comment on exported type Logger should be of the form "Logger ..." (with optional leading article) (golint)
    • Line 29: warning: exported type Options should have comment or be unexported (golint)
    • Line 33: warning: exported type Client should have comment or be unexported (golint)
    • Line 37: warning: exported var ErrInvalidAWSResponse should have comment or be unexported (golint)
    • Line 39: warning: exported function New should have comment or be unexported (golint)
    • mate/producers/fake.go
    • Line 32: warning: exported type FakeProducerOptions should have comment or be unexported (golint)
    • Line 45: warning: exported function NewFakeProducer should have comment or be unexported (golint)
    • mate/consumers/synced.go
    • Line 9: warning: exported type SynchronizedConsumer should have comment or be unexported (golint)
    • Line 22: warning: exported method SynchronizedConsumer.Sync should have comment or be unexported (golint)
    • Line 28: warning: exported method SynchronizedConsumer.Process should have comment or be unexported (golint)
    • mate/controller/controller.go
    • Line 22: warning: exported type Controller should have comment or be unexported (golint)
    • Line 40: warning: exported type Options should have comment or be unexported (golint)
    • Line 45: warning: exported function New should have comment or be unexported (golint)
    • Line 65: warning: exported method Controller.Run should have comment or be unexported (golint)
    • Line 75: warning: exported method Controller.Wait should have comment or be unexported (golint)
    • Line 85: warning: exported method Controller.Synchronize should have comment or be unexported (golint)
    • Line 114: warning: exported method Controller.Watch should have comment or be unexported (golint)
    • mate/producers/kubernetes.go
    • Line 24: warning: exported type KubernetesOptions should have comment or be unexported (golint)
    • Line 31: warning: exported function NewKubernetesProducer should have comment or be unexported (golint)
    • mate/pkg/aws/test/test_data.go
    • Line 8: warning: exported function GetHostedZones should have comment or be unexported (golint)
    • Line 16: warning: exported function GetOriginalState should have comment or be unexported (golint)
    • mate/pkg/err.go
    • Line 5: warning: exported var ErrEventChannelClosed should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell96%

Misspell Finds commonly misspelled English words