Report for gitlab.com/mergetb/tech/canopy
A Great! Found 10 issues across 13 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo76%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
/gitlab.com/mergetb/tech/canopy/util/client/main.go
- Line 17: warning: cyclomatic complexity 35 of function main() is high (> 15) (gocyclo)
-
-
/gitlab.com/mergetb/tech/canopy/lib/server.go
- Line 79: warning: cyclomatic complexity 22 of function (*Server).set() is high (> 15) (gocyclo)
-
-
/gitlab.com/mergetb/tech/canopy/lib/common.go
- Line 13: warning: cyclomatic complexity 22 of function List() is high (> 15) (gocyclo)
golint30%
Golint is a linter for Go source code.
-
-
/gitlab.com/mergetb/tech/canopy/lib/client-ops.go
- Line 5: warning: exported method Client.SetLink should have comment or be unexported (golint)
- Line 11: warning: exported method Client.SetLinks should have comment or be unexported (golint)
- Line 18: warning: exported method Client.SetMtu should have comment or be unexported (golint)
- Line 24: warning: exported method Client.SetMtus should have comment or be unexported (golint)
- Line 32: warning: exported method Client.SetAccessPort should have comment or be unexported (golint)
- Line 38: warning: exported method Client.SetAccessPorts should have comment or be unexported (golint)
- Line 46: warning: exported method Client.SetTaggedPort should have comment or be unexported (golint)
- Line 52: warning: exported method Client.SetTaggedPorts should have comment or be unexported (golint)
- Line 60: warning: exported method Client.SetUntaggedPort should have comment or be unexported (golint)
- Line 66: warning: exported method Client.SetUntaggedPorts should have comment or be unexported (golint)
- Line 74: warning: exported method Client.SetMaster should have comment or be unexported (golint)
- Line 80: warning: exported method Client.SetMasters should have comment or be unexported (golint)
- Line 88: warning: exported method Client.SetLearningVtep should have comment or be unexported (golint)
- Line 94: warning: exported method Client.SetLearningVteps should have comment or be unexported (golint)
- Line 102: warning: exported method Client.SetVlanAwareBridge should have comment or be unexported (golint)
- Line 108: warning: exported method Client.SetVlanAwareBridges should have comment or be unexported (golint)
- Line 116: warning: exported method Client.SetBridgePresent should have comment or be unexported (golint)
- Line 122: warning: exported method Client.SetBridgesPresent should have comment or be unexported (golint)
- Line 130: warning: exported method Client.SetVtep should have comment or be unexported (golint)
- Line 136: warning: exported method Client.SetVteps should have comment or be unexported (golint)
- Line 150: warning: exported method Client.Add should have comment or be unexported (golint)
- Line 174: warning: exported method Client.AddMany should have comment or be unexported (golint)
- Line 196: warning: exported method Client.GetPort should have comment or be unexported (golint)
- Line 213: warning: exported method Client.GetPorts should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/common.go
- Line 9: warning: exported function Any should have comment or be unexported (golint)
- Line 13: warning: exported function List should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/config.go
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 15: warning: exported function ReadConfig should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/errors.go
- Line 9: warning: exported function ErrorE should have comment or be unexported (golint)
- Line 22: warning: exported function ErrorEF should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/cli_support.go
- Line 15: warning: exported method Client.SavePending should have comment or be unexported (golint)
- Line 31: warning: exported method Client.SavePendingQueries should have comment or be unexported (golint)
- Line 52: warning: exported method Client.SavePendingCommands should have comment or be unexported (golint)
- Line 139: warning: exported function LoadPendingQueries should have comment or be unexported (golint)
- Line 162: warning: exported function LoadPendingCommands should have comment or be unexported (golint)
- Line 222: warning: exported function LoadClient should have comment or be unexported (golint)
- Line 239: warning: exported function ClearPending should have comment or be unexported (golint)
- Line 263: warning: exported function ShowResult should have comment or be unexported (golint)
- Line 273: warning: exported function ShowErrors should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/client.go
- Line 16: warning: exported type Elements should have comment or be unexported (golint)
- Line 18: warning: exported type Client should have comment or be unexported (golint)
- Line 25: warning: exported method Elements.Set should have comment or be unexported (golint)
- Line 38: warning: comment on exported type CommandSet should be of the form "CommandSet ..." (with optional leading article) (golint)
- Line 41: warning: comment on exported type QuerySet should be of the form "QuerySet ..." (with optional leading article) (golint)
- Line 53: warning: exported method Client.Commit should have comment or be unexported (golint)
- Line 107: warning: exported method Client.Query should have comment or be unexported (golint)
- Line 153: warning: exported function NewClient should have comment or be unexported (golint)
- Line 161: warning: exported function SendSet should have comment or be unexported (golint)
- Line 192: warning: exported function ListPorts should have comment or be unexported (golint)
- Line 251: warning: exported function SendGet should have comment or be unexported (golint)
- Line 294: warning: exported function ParsePresence should have comment or be unexported (golint)
- Line 306: warning: exported function ParseOnOff should have comment or be unexported (golint)
- Line 318: warning: exported function ParseLinkState should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/server-ops.go
- Line 12: warning: exported function SetLink should have comment or be unexported (golint)
- Line 46: warning: exported function SetMtu should have comment or be unexported (golint)
- Line 69: warning: exported function SetAccess should have comment or be unexported (golint)
- Line 129: warning: exported function SetTagged should have comment or be unexported (golint)
- Line 162: warning: exported function SetUntagged should have comment or be unexported (golint)
- Line 195: warning: exported function SetMaster should have comment or be unexported (golint)
- Line 234: warning: exported function SetBridgePresence should have comment or be unexported (golint)
- Line 274: warning: exported function SetVtepPresence should have comment or be unexported (golint)
- Line 333: warning: exported function SetLearning should have comment or be unexported (golint)
- Line 362: warning: exported function SetVlanAware should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/server.go
- Line 18: warning: exported type Server should have comment or be unexported (golint)
- Line 22: warning: comment on exported method Server.Run should be of the form "Run ..." (golint)
- Line 36: warning: comment on exported method Server.Set should be of the form "Set ..." (golint)
- Line 52: warning: comment on exported method Server.Get should be of the form "Get ..." (golint)
- Line 67: warning: exported method Server.List should have comment or be unexported (golint)
-
-
/gitlab.com/mergetb/tech/canopy/lib/canopy.go
- Line 3: warning: comment on exported var Version should be of the form "Version ..." (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!