Go Report Card

Preparing report...

Report for gitlab.com/mergetb/tech/rally

A+    Excellent!    Found 13 issues across 25 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint56%

Golint is a linter for Go source code.

    • /gitlab.com/mergetb/tech/rally/pkg/rbd.go
    • Line 390: warning: exported function ModifyNamespace should have comment or be unexported (golint)
    • Line 421: warning: comment on exported function MakeNamespace should be of the form "MakeNamespace ..." (golint)
    • Line 428: warning: comment on exported function RemoveNamespace should be of the form "RemoveNamespace ..." (golint)
    • Line 572: warning: exported function ModifyBlock should have comment or be unexported (golint)
    • Line 630: warning: exported function MakeBlock should have comment or be unexported (golint)
    • Line 634: warning: exported function RemoveBlock should have comment or be unexported (golint)
    • /gitlab.com/mergetb/tech/rally/pkg/storage.go
    • Line 11: warning: exported var CephKey should have comment or be unexported (golint)
    • Line 13: warning: exported type Filesystem should have comment or be unexported (golint)
    • Line 17: warning: exported type BlockDevice should have comment or be unexported (golint)
    • Line 23: warning: exported type CephData should have comment or be unexported (golint)
    • Line 52: warning: receiver name cu should be consistent with previous receiver name cd for CephData (golint)
    • Line 56: warning: comment on exported method CephData.GenerateCephUserPath should be of the form "GenerateCephUserPath ..." (golint)
    • Line 57: warning: receiver name cu should be consistent with previous receiver name cd for CephData (golint)
    • Line 79: warning: receiver name cu should be consistent with previous receiver name cd for CephData (golint)
    • Line 98: warning: receiver name cu should be consistent with previous receiver name cd for CephData (golint)
    • Line 141: warning: receiver name cu should be consistent with previous receiver name cd for CephData (golint)
    • Line 211: warning: comment on exported function CreateCephUser should be of the form "CreateCephUser ..." (golint)
    • /gitlab.com/mergetb/tech/rally/main.go
    • Line 99: warning: comment on exported method Rallyd.ModifyCephQuota should be of the form "ModifyCephQuota ..." (golint)
    • Line 394: warning: exported method Rallyd.MakeRadosNamespace should have comment or be unexported (golint)
    • Line 415: warning: exported method Rallyd.RemoveRadosNamespace should have comment or be unexported (golint)
    • Line 438: warning: exported method Rallyd.ListRadosBlocks should have comment or be unexported (golint)
    • Line 458: warning: exported method Rallyd.MakeRadosBlock should have comment or be unexported (golint)
    • Line 483: warning: exported method Rallyd.RemoveRadosBlock should have comment or be unexported (golint)
    • Line 504: warning: exported method Rallyd.GetDefaultPool should have comment or be unexported (golint)
    • /gitlab.com/mergetb/tech/rally/common/config.go
    • Line 50: warning: exported type RadosConfig should have comment or be unexported (golint)
    • Line 113: warning: exported var Current should have comment or be unexported (golint)
    • Line 115: warning: exported function LoadConfig should have comment or be unexported (golint)
    • Line 160: warning: exported method Config.GetCephFSRoot should have comment or be unexported (golint)
    • Line 168: warning: exported method Config.GetCephFSUsers should have comment or be unexported (golint)
    • Line 176: warning: exported method Config.GetCephFSOwners should have comment or be unexported (golint)
    • Line 184: warning: exported method Config.GetRBDPool should have comment or be unexported (golint)
    • Line 192: warning: exported method Config.GetRBDQuota should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign92%

IneffAssign detects ineffectual assignments in Go code.

misspell96%

Misspell Finds commonly misspelled English words