gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• /k8s.io/cloud-provider-azure/pkg/provider/azure_storageaccount.go
  • Line 55: warning: cyclomatic complexity 30 of function (*Cloud).getStorageAccounts() is high (> 15) (gocyclo)
  • Line 158: warning: cyclomatic complexity 21 of function (*Cloud).EnsureStorageAccount() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_managedDiskController.go
  • Line 80: warning: cyclomatic complexity 27 of function (*ManagedDiskController).CreateManagedDisk() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/cmd/cloud-controller-manager/app/core.go
  • Line 160: warning: cyclomatic complexity 20 of function startNodeIpamController() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/cmd/cloud-controller-manager/app/testing/testserver.go
  • Line 62: warning: cyclomatic complexity 18 of function StartTestServer() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/util/controller/testutil/test_utils.go
  • Line 267: warning: cyclomatic complexity 18 of function (*FakeNodeHandler).Patch() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/nodeipam/ipam/range_allocator_test.go
  • Line 702: warning: cyclomatic complexity 21 of function TestReleaseCIDRSuccess() is high (> 15) (gocyclo)
  • Line 322: warning: cyclomatic complexity 18 of function TestAllocateOrOccupyCIDRSuccess() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/tests/e2e/network/service_annotations.go
  • Line 603: warning: cyclomatic complexity 19 of function validateLoadBalancerBackendPools() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/nodeipam/ipam/cloud_cidr_allocator.go
  • Line 86: warning: cyclomatic complexity 19 of function NewCloudCIDRAllocator() is high (> 15) (gocyclo)
  • Line 419: warning: cyclomatic complexity 16 of function (*cloudCIDRAllocator).updateCIDRsAllocation() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_controller_vmss.go
  • Line 140: warning: cyclomatic complexity 24 of function (*ScaleSet).DetachDisk() is high (> 15) (gocyclo)
  • Line 34: warning: cyclomatic complexity 20 of function (*ScaleSet).AttachDisk() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_vmss_cache.go
  • Line 151: warning: cyclomatic complexity 17 of function (*ScaleSet).newVMSSVirtualMachinesCache() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_blobDiskController.go
  • Line 333: warning: cyclomatic complexity 16 of function (*BlobDiskController).ensureDefaultContainer() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_test.go
  • Line 2024: warning: cyclomatic complexity 33 of function validateConfig() is high (> 15) (gocyclo)
  • Line 2889: warning: cyclomatic complexity 28 of function TestCanCombineSharedAndPrivateRulesInSameGroup() is high (> 15) (gocyclo)
  • Line 1592: warning: cyclomatic complexity 28 of function validateLoadBalancer() is high (> 15) (gocyclo)
  • Line 2700: warning: cyclomatic complexity 18 of function TestIfSomeServicesShareARuleAndOneIsDeletedItIsRemovedFromTheRightRule() is high (> 15) (gocyclo)
  • Line 2541: warning: cyclomatic complexity 17 of function TestIfServicesSpecifySharedRuleButSomeAreOnDifferentPortsThenRulesAreSeparatedOrConsoliatedByPort() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_vmss.go
  • Line 1055: warning: cyclomatic complexity 30 of function (*ScaleSet).ensureVMSSInPool() is high (> 15) (gocyclo)
  • Line 924: warning: cyclomatic complexity 24 of function (*ScaleSet).EnsureHostInPool() is high (> 15) (gocyclo)
  • Line 1434: warning: cyclomatic complexity 22 of function (*ScaleSet).EnsureBackendPoolDeleted() is high (> 15) (gocyclo)
  • Line 1192: warning: cyclomatic complexity 17 of function (*ScaleSet).EnsureHostsInPool() is high (> 15) (gocyclo)
  • Line 248: warning: cyclomatic complexity 16 of function (*ScaleSet).getVmssVMByInstanceID() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_standard.go
  • Line 964: warning: cyclomatic complexity 25 of function (*availabilitySet).EnsureBackendPoolDeleted() is high (> 15) (gocyclo)
  • Line 839: warning: cyclomatic complexity 19 of function (*availabilitySet).EnsureHostInPool() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_controller_standard.go
  • Line 136: warning: cyclomatic complexity 22 of function (*availabilitySet).DetachDisk() is high (> 15) (gocyclo)
  • Line 34: warning: cyclomatic complexity 18 of function (*availabilitySet).AttachDisk() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_instance_metadata.go
  • Line 119: warning: cyclomatic complexity 19 of function (*InstanceMetadataService).getMetadata() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer_test.go
  • Line 2802: warning: cyclomatic complexity 16 of function TestReconcilePublicIP() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/nodeipam/ipam/cidrset/cidr_set_test.go
  • Line 1097: warning: cyclomatic complexity 18 of function TestCIDRSetv6() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer.go
  • Line 1425: warning: cyclomatic complexity 30 of function (*Cloud).reconcileLoadBalancer() is high (> 15) (gocyclo)
  • Line 1288: warning: cyclomatic complexity 29 of function (*Cloud).isFrontendIPConfigUnsafeToDelete() is high (> 15) (gocyclo)
  • Line 2223: warning: cyclomatic complexity 27 of function (*Cloud).reconcileSecurityRules() is high (> 15) (gocyclo)
  • Line 1652: warning: cyclomatic complexity 27 of function (*Cloud).reconcileFrontendIPConfigs() is high (> 15) (gocyclo)
  • Line 951: warning: cyclomatic complexity 26 of function (*Cloud).ensurePublicIPExists() is high (> 15) (gocyclo)
  • Line 484: warning: cyclomatic complexity 26 of function (*Cloud).reconcileSharedLoadBalancer() is high (> 15) (gocyclo)
  • Line 2002: warning: cyclomatic complexity 25 of function (*Cloud).getExpectedLBRules() is high (> 15) (gocyclo)
  • Line 623: warning: cyclomatic complexity 24 of function (*Cloud).getServiceLoadBalancer() is high (> 15) (gocyclo)
  • Line 2752: warning: cyclomatic complexity 23 of function (*Cloud).safeDeletePublicIP() is high (> 15) (gocyclo)
  • Line 2141: warning: cyclomatic complexity 20 of function (*Cloud).reconcileSecurityGroup() is high (> 15) (gocyclo)
  • Line 2688: warning: cyclomatic complexity 19 of function (*Cloud).getPublicIPUpdates() is high (> 15) (gocyclo)
  • Line 1236: warning: cyclomatic complexity 18 of function (*Cloud).isFrontendIPChanged() is high (> 15) (gocyclo)
  • Line 2611: warning: cyclomatic complexity 17 of function (*Cloud).reconcilePublicIP() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure.go
  • Line 395: warning: cyclomatic complexity 29 of function (*Cloud).InitializeCloudFromConfig() is high (> 15) (gocyclo)
  • Line 863: warning: cyclomatic complexity 16 of function (*Cloud).updateNodeCaches() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_controller_common.go
  • Line 148: warning: cyclomatic complexity 28 of function (*controllerCommon).AttachDisk() is high (> 15) (gocyclo)
  • Line 454: warning: cyclomatic complexity 18 of function (*controllerCommon).SetDiskLun() is high (> 15) (gocyclo)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_routes.go
  • Line 104: warning: cyclomatic complexity 23 of function (*delayedRouteUpdater).updateRoutes() is high (> 15) (gocyclo)

golint92%

Golint is a linter for Go source code.

• /k8s.io/cloud-provider-azure/cmd/cloud-controller-manager/app/config/config.go
  • Line 67: warning: exported type DynamicReloadingConfig should have comment or be unexported (golint)

• /k8s.io/cloud-provider-azure/pkg/consts/consts.go
  • Line 73: warning: exported const DiskEncryptionSetIDFormat should have comment (or a comment on this block) or be unexported (golint)

• /k8s.io/cloud-provider-azure/pkg/provider/azure.go
  • Line 225: warning: exported type InitSecretConfig should have comment or be unexported (golint)
  • Line 344: warning: exported function NewCloudFromSecret should have comment or be unexported (golint)

• /k8s.io/cloud-provider-azure/pkg/provider/azure_vmss.go
  • Line 513: warning: comment on exported method ScaleSet.GetPrivateIPsByNodeName should be of the form "GetPrivateIPsByNodeName ..." (golint)
  • Line 1552: warning: comment on exported method ScaleSet.GetNodeCIDRMasksByProviderID should be of the form "GetNodeCIDRMasksByProviderID ..." (golint)

• /k8s.io/cloud-provider-azure/cmd/cloud-controller-manager/app/dynamic/watch_secret.go
  • Line 35: warning: exported type SecretWatcher should have comment or be unexported (golint)
  • Line 52: warning: exported function RunSecretWatcherOrDie should have comment or be unexported (golint)

• /k8s.io/cloud-provider-azure/pkg/azureclients/zoneclient/mockzoneclient/doc.go
  • Line 17: warning: package comment should be of the form "Package mockzoneclient ..." (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/network/ensureloadbalancer.go
  • Line 39: warning: should not use dot imports (golint)
  • Line 40: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/network/node.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/utils/kubectl.go
  • Line 32: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/utils/resource_group_utils.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/auth/cred.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/autoscaling/autoscaler.go
  • Line 34: warning: should not use dot imports (golint)
  • Line 35: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/network/standard_lb.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/utils/node_utils.go
  • Line 264: warning: exported function LabelNode should have comment or be unexported (golint)
  • Line 279: warning: exported function GetNodepoolNodeMap should have comment or be unexported (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/utils/pod_utils.go
  • Line 75: warning: exported function WaitPodsToBeReady should have comment or be unexported (golint)

• /k8s.io/cloud-provider-azure/pkg/version/verflag/verflag.go
  • Line 36: warning: exported const VersionFalse should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: exported function VersionVar should have comment or be unexported (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/network/network_security_group.go
  • Line 37: warning: should not use dot imports (golint)
  • Line 38: warning: should not use dot imports (golint)

• /k8s.io/cloud-provider-azure/tests/e2e/network/service_annotations.go
  • Line 43: warning: should not use dot imports (golint)
  • Line 44: warning: should not use dot imports (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign0%

IneffAssign detects ineffectual assignments in Go code.

An error occurred while running this test (signal: killed)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!