Preparing report...

Report for github.com/knative/serving-operator

A+    Excellent!    Found 9 issues across 70 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint87%

Golint is a linter for Go source code.

    • serving-operator/test/clients.go
    • Line 88: warning: exported method Clients.KnativeServing should have comment or be unexported (golint)
    • Line 92: warning: exported method Clients.KnativeServingAll should have comment or be unexported (golint)
    • serving-operator/pkg/apis/serving/v1alpha1/knativeserving_lifecycle.go
    • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
    • Line 34: warning: exported method KnativeServingStatus.IsReady should have comment or be unexported (golint)
    • Line 38: warning: exported method KnativeServingStatus.IsInstalled should have comment or be unexported (golint)
    • Line 42: warning: exported method KnativeServingStatus.IsAvailable should have comment or be unexported (golint)
    • Line 46: warning: exported method KnativeServingStatus.IsDeploying should have comment or be unexported (golint)
    • Line 50: warning: exported method KnativeServingStatus.IsFullySupported should have comment or be unexported (golint)
    • Line 54: warning: exported method KnativeServingStatus.GetCondition should have comment or be unexported (golint)
    • Line 58: warning: exported method KnativeServingStatus.InitializeConditions should have comment or be unexported (golint)
    • Line 62: warning: exported method KnativeServingStatus.MarkInstallFailed should have comment or be unexported (golint)
    • Line 69: warning: exported method KnativeServingStatus.MarkInstallSucceeded should have comment or be unexported (golint)
    • Line 77: warning: exported method KnativeServingStatus.MarkDeploymentsAvailable should have comment or be unexported (golint)
    • Line 81: warning: exported method KnativeServingStatus.MarkDeploymentsNotReady should have comment or be unexported (golint)
    • Line 88: warning: exported method KnativeServingStatus.MarkDependenciesInstalled should have comment or be unexported (golint)
    • Line 92: warning: exported method KnativeServingStatus.MarkDependencyInstalling should have comment or be unexported (golint)
    • Line 99: warning: exported method KnativeServingStatus.MarkDependencyMissing should have comment or be unexported (golint)
    • serving-operator/pkg/apis/serving/v1alpha1/register.go
    • Line 30: warning: comment on exported const GroupName should be of the form "GroupName ..." (golint)
    • Line 33: warning: comment on exported const SchemaVersion should be of the form "SchemaVersion ..." (golint)
    • Line 36: warning: comment on exported const Kind should be of the form "Kind ..." (golint)
    • Line 61: warning: exported var AddToScheme should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!