Preparing report...

Report for mae.earth/pkg/trustedtimestamps

B    Not bad!    Found 8 issues across 9 files

Tweet

gofmt55%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint22%

Golint is a linter for Go source code.

    • /mae.earth/pkg/trustedtimestamps/client.go
    • Line 1: warning: package comment should be of the form "Package trustedtimestamps ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 19: warning: exported type ServerBanner should have comment or be unexported (golint)
    • Line 25: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
    • Line 38: warning: comment on exported method Client.Stat should be of the form "Stat ..." (golint)
    • Line 46: warning: comment on exported method Client.AddToKeychain should be of the form "AddToKeychain ..." (golint)
    • Line 130: warning: don't use underscores in Go names; range var banner_in_chain should be bannerInChain (golint)
    • Line 148: warning: comment on exported method Client.RemoveFromKeychain should be of the form "RemoveFromKeychain ..." (golint)
    • Line 190: warning: comment on exported method Client.KnownFingerprints should be of the form "KnownFingerprints ..." (golint)
    • Line 205: warning: comment on exported method Client.Prepare should be of the form "Prepare ..." (golint)
    • Line 212: warning: comment on exported method Client.Verify should be of the form "Verify ..." (golint)
    • Line 266: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • /mae.earth/pkg/trustedtimestamps/definitions.go
    • Line 1: warning: package comment should be of the form "Package trustedtimestamps ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 14: warning: exported var ErrNoKey should have comment or be unexported (golint)
    • Line 28: warning: exported type Stat should have comment or be unexported (golint)
    • Line 32: warning: comment on exported type Timestamp should be of the form "Timestamp ..." (with optional leading article) (golint)
    • Line 54: warning: exported method Timestamp.Armour should have comment or be unexported (golint)
    • Line 58: warning: exported method Timestamp.Equals should have comment or be unexported (golint)
    • Line 110: warning: exported type Configuration should have comment or be unexported (golint)
    • Line 118: warning: exported type HashFunc should have comment or be unexported (golint)
    • /mae.earth/pkg/trustedtimestamps/funcs.go
    • Line 1: warning: package comment should be of the form "Package trustedtimestamps ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 13: warning: comment on exported function CreateTimestamp should be of the form "CreateTimestamp ..." (golint)
    • Line 63: warning: don't use underscores in Go names; var sig_b should be sigB (golint)
    • /mae.earth/pkg/trustedtimestamps/server.go
    • Line 1: warning: package comment should be of the form "Package trustedtimestamps ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 19: warning: exported const BannerType should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: comment on exported type Server should be of the form "Server ..." (with optional leading article) (golint)
    • Line 36: warning: exported method Server.Stat should have comment or be unexported (golint)
    • Line 43: warning: comment on exported method Server.Timestamp should be of the form "Timestamp ..." (golint)
    • Line 56: warning: comment on exported method Server.Key should be of the form "Key ..." (golint)
    • Line 64: warning: comment on exported method Server.HaveKey should be of the form "HaveKey ..." (golint)
    • Line 72: warning: comment on exported method Server.UseKey should be of the form "UseKey ..." (golint)
    • Line 86: warning: comment on exported method Server.ExportBanner should be of the form "ExportBanner ..." (golint)
    • Line 115: warning: comment on exported method Server.GenerateKey should be of the form "GenerateKey ..." (golint)
    • Line 131: warning: comment on exported function NewServer should be of the form "NewServer ..." (golint)
    • Line 170: warning: don't use underscores in Go names; var p_b should be pB (golint)
    • /mae.earth/pkg/trustedtimestamps/timestamps.go
    • Line 1: warning: package comment should be of the form "Package trustedtimestamps ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 25: warning: exported var ErrEmptyDataHash should have comment or be unexported (golint)
    • Line 31: warning: exported const TimestampFormat should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported var Delimiter should have comment or be unexported (golint)
    • Line 38: warning: comment on exported function Fingerprint should be of the form "Fingerprint ..." (golint)
    • Line 59: warning: comment on exported function EqualsFingerprint should be of the form "EqualsFingerprint ..." (golint)
    • Line 75: warning: comment on exported function VerifyTimestamp should be of the form "VerifyTimestamp ..." (golint)
    • Line 97: warning: comment on exported function NewTimestamp should be of the form "NewTimestamp ..." (golint)
    • Line 143: warning: don't use underscores in Go names; var sig_b should be sigB (golint)
    • Line 165: warning: comment on exported function ArmourTimestamps should be of the form "ArmourTimestamps ..." (golint)
    • Line 224: warning: comment on exported function DearmourTimestamps should be of the form "DearmourTimestamps ..." (golint)
    • Line 248: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 261: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 278: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 305: warning: comment on exported function CompressArmoured should be of the form "CompressArmoured ..." (golint)
    • Line 329: warning: comment on exported function UncompressArmoured should be of the form "UncompressArmoured ..." (golint)
    • Line 350: warning: comment on exported function TimestampArmourCompress should be of the form "TimestampArmourCompress ..." (golint)
    • Line 366: warning: comment on exported function Fuzz should be of the form "Fuzz ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell88%

Misspell Finds commonly misspelled English words