Preparing report...

Report for sigs.k8s.io/cluster-api-provider-aws

(v1.5.3)

A+    Excellent!    Found 40 issues across 563 files

Tweet

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • pkg/cloud/services/ec2/instances.go
    • Line 113: warning: cyclomatic complexity 28 of function (*Service).CreateInstance() is high (> 15) (gocyclo)
    • Line 261: warning: cyclomatic complexity 26 of function (*Service).findSubnet() is high (> 15) (gocyclo)
    • Line 473: warning: cyclomatic complexity 17 of function (*Service).runInstance() is high (> 15) (gocyclo)
    • test/e2e/shared/aws.go
    • Line 239: warning: cyclomatic complexity 20 of function (*AWSInfrastructure).CreateInfrastructure() is high (> 15) (gocyclo)
    • Line 300: warning: cyclomatic complexity 19 of function (*AWSInfrastructure).DeleteInfrastructure() is high (> 15) (gocyclo)
    • controllers/awsmachine_controller.go
    • Line 431: warning: cyclomatic complexity 29 of function (*AWSMachineReconciler).reconcileNormal() is high (> 15) (gocyclo)
    • Line 286: warning: cyclomatic complexity 18 of function (*AWSMachineReconciler).reconcileDelete() is high (> 15) (gocyclo)
    • Line 141: warning: cyclomatic complexity 16 of function (*AWSMachineReconciler).Reconcile() is high (> 15) (gocyclo)
    • main.go
    • Line 116: warning: cyclomatic complexity 26 of function main() is high (> 15) (gocyclo)
    • Line 280: warning: cyclomatic complexity 18 of function enableGates() is high (> 15) (gocyclo)
    • pkg/cloud/services/s3/s3_test.go
    • Line 358: warning: cyclomatic complexity 21 of function Test_Create_object() is high (> 15) (gocyclo)
    • Line 51: warning: cyclomatic complexity 20 of function Test_Reconcile_bucket() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!