gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• /sigs.k8s.io/descheduler/pkg/api/v1alpha1/zz_generated.conversion.go
  • Line 38: warning: cyclomatic complexity 17 of function RegisterConversions() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/pkg/descheduler/pod/pods.go
  • Line 70: warning: cyclomatic complexity 19 of function ListPodsOnANode() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/pkg/utils/predicates.go
  • Line 115: warning: cyclomatic complexity 17 of function uniqueSortNodeSelectorRequirements() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/pkg/descheduler/strategies/lownodeutilization.go
  • Line 69: warning: cyclomatic complexity 16 of function LowNodeUtilization() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/pkg/utils/qos.go
  • Line 22: warning: cyclomatic complexity 19 of function GetPodQOS() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/test/e2e/e2e_test.go
  • Line 494: warning: cyclomatic complexity 18 of function testEvictSystemCritical() is high (> 15) (gocyclo)
  • Line 624: warning: cyclomatic complexity 18 of function testPriority() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/pkg/descheduler/strategies/topologyspreadconstraint.go
  • Line 73: warning: cyclomatic complexity 28 of function RemovePodsViolatingTopologySpreadConstraint() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/pkg/descheduler/strategies/duplicates.go
  • Line 63: warning: cyclomatic complexity 25 of function RemoveDuplicatePods() is high (> 15) (gocyclo)
  • Line 223: warning: cyclomatic complexity 17 of function getTargetNodes() is high (> 15) (gocyclo)

• /sigs.k8s.io/descheduler/pkg/descheduler/strategies/node_affinity.go
  • Line 50: warning: cyclomatic complexity 16 of function RemovePodsViolatingNodeAffinity() is high (> 15) (gocyclo)

golint57%

Golint is a linter for Go source code.

• /sigs.k8s.io/descheduler/pkg/descheduler/evictions/evictions.go
  • Line 48: warning: exported type PodEvictor should have comment or be unexported (golint)
  • Line 59: warning: exported function NewPodEvictor should have comment or be unexported (golint)
  • Line 165: warning: exported type Options should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/apis/componentconfig/v1alpha1/doc.go
  • Line 23: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

• /sigs.k8s.io/descheduler/pkg/apis/componentconfig/v1alpha1/register.go
  • Line 25: warning: exported var SchemeBuilder should have comment or be unexported (golint)
  • Line 32: warning: exported const GroupVersion should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/apis/componentconfig/v1alpha1/types.go
  • Line 28: warning: exported type DeschedulerConfiguration should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/descheduler/scheme/scheme.go
  • Line 30: warning: exported var Scheme should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/descheduler/pod/pods.go
  • Line 30: warning: exported type Options should have comment or be unexported (golint)
  • Line 161: warning: exported function IsBestEffortPod should have comment or be unexported (golint)
  • Line 165: warning: exported function IsBurstablePod should have comment or be unexported (golint)
  • Line 169: warning: exported function IsGuaranteedPod should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/cmd/descheduler/app/options/options.go
  • Line 34: warning: exported const DefaultDeschedulerPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: comment on exported method DeschedulerServer.Validate should be of the form "Validate ..." (golint)
  • Line 82: warning: receiver name rs should be consistent with previous receiver name s for DeschedulerServer (golint)

• /sigs.k8s.io/descheduler/pkg/api/v1alpha1/doc.go
  • Line 23: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

• /sigs.k8s.io/descheduler/pkg/descheduler/evictions/utils/utils.go
  • Line 24: warning: exported const EvictionKind should have comment (or a comment on this block) or be unexported (golint)

• /sigs.k8s.io/descheduler/cmd/descheduler/app/server.go
  • Line 92: warning: exported function Run should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/test/e2e/e2e_test.go
  • Line 1086: warning: context.Context should be the first parameter of a function (golint)

• /sigs.k8s.io/descheduler/pkg/apis/componentconfig/register.go
  • Line 25: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/api/register.go
  • Line 25: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/utils/predicates.go
  • Line 182: warning: exported function NodeSelectorsEqual should have comment or be unexported (golint)
  • Line 264: warning: exported function TolerationsEqual should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/descheduler/strategies/topologyspreadconstraint.go
  • Line 73: warning: exported function RemovePodsViolatingTopologySpreadConstraint should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/apis/componentconfig/types.go
  • Line 28: warning: exported type DeschedulerConfiguration should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/api/types.go
  • Line 26: warning: exported type DeschedulerPolicy should have comment or be unexported (golint)
  • Line 48: warning: exported type StrategyName should have comment or be unexported (golint)
  • Line 49: warning: exported type StrategyList should have comment or be unexported (golint)
  • Line 51: warning: exported type DeschedulerStrategy should have comment or be unexported (golint)
  • Line 69: warning: comment on exported type StrategyParameters should be of the form "StrategyParameters ..." (with optional leading article) (golint)
  • Line 85: warning: exported type Percentage should have comment or be unexported (golint)
  • Line 86: warning: exported type ResourceThresholds should have comment or be unexported (golint)
  • Line 88: warning: exported type NodeResourceUtilizationThresholds should have comment or be unexported (golint)
  • Line 94: warning: exported type PodsHavingTooManyRestarts should have comment or be unexported (golint)
  • Line 99: warning: exported type RemoveDuplicates should have comment or be unexported (golint)
  • Line 103: warning: exported type PodLifeTime should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/api/v1alpha1/types.go
  • Line 26: warning: exported type DeschedulerPolicy should have comment or be unexported (golint)
  • Line 48: warning: exported type StrategyName should have comment or be unexported (golint)
  • Line 49: warning: exported type StrategyList should have comment or be unexported (golint)
  • Line 51: warning: exported type DeschedulerStrategy should have comment or be unexported (golint)
  • Line 69: warning: comment on exported type StrategyParameters should be of the form "StrategyParameters ..." (with optional leading article) (golint)
  • Line 83: warning: exported type Percentage should have comment or be unexported (golint)
  • Line 84: warning: exported type ResourceThresholds should have comment or be unexported (golint)
  • Line 86: warning: exported type NodeResourceUtilizationThresholds should have comment or be unexported (golint)
  • Line 92: warning: exported type PodsHavingTooManyRestarts should have comment or be unexported (golint)
  • Line 97: warning: exported type RemoveDuplicates should have comment or be unexported (golint)
  • Line 101: warning: exported type PodLifeTime should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/metrics/metrics.go
  • Line 33: warning: exported var PodsEvicted should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/test/test_utils.go
  • Line 182: warning: comment on exported function SetNodeExtendedResource should be of the form "SetNodeExtendedResource ..." (golint)

• /sigs.k8s.io/descheduler/pkg/descheduler/policyconfig.go
  • Line 31: warning: exported function LoadPolicyConfig should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/utils/priority.go
  • Line 15: warning: exported const SystemCriticalPriority should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/cmd/descheduler/app/version.go
  • Line 26: warning: exported function NewVersionCommand should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/api/v1alpha1/register.go
  • Line 25: warning: exported var SchemeBuilder should have comment or be unexported (golint)
  • Line 32: warning: exported const GroupVersion should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/descheduler/descheduler.go
  • Line 39: warning: exported function Run should have comment or be unexported (golint)
  • Line 68: warning: exported function RunDeschedulerStrategies should have comment or be unexported (golint)

• /sigs.k8s.io/descheduler/pkg/utils/pod.go
  • Line 15: warning: comment on exported const LocalStorageCapacityIsolation should be of the form "LocalStorageCapacityIsolation ..." (golint)
  • Line 21: warning: comment on exported const PodOverhead should be of the form "PodOverhead ..." (golint)
  • Line 124: warning: comment on exported function IsPodWithPVC should be of the form "IsPodWithPVC ..." (golint)

• /sigs.k8s.io/descheduler/pkg/descheduler/client/client.go
  • Line 29: warning: exported function CreateClient should have comment or be unexported (golint)
  • Line 53: warning: exported function GetMasterFromKubeconfig should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!