gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• sources-for-knative/pkg/client/injection/reconciler/sources/v1alpha1/vspheresource/reconciler.go
  • Line 169: warning: cyclomatic complexity 22 of function (*reconcilerImpl).Reconcile() is high (> 15) (gocyclo)

• sources-for-knative/plugins/vsphere/pkg/command/source.go
  • Line 74: warning: cyclomatic complexity 16 of function NewSourceCommand() is high (> 15) (gocyclo)

• sources-for-knative/pkg/apis/sources/v1alpha1/vspherebinding_lifecycle.go
  • Line 152: warning: cyclomatic complexity 17 of function (*VSphereBinding).Undo() is high (> 15) (gocyclo)

golint76%

Golint is a linter for Go source code.

• sources-for-knative/pkg/apis/sources/v1alpha1/vspheresource_validation.go
  • Line 25: warning: exported method VCheckpointSpec.Validate should have comment or be unexported (golint)

• sources-for-knative/test/e2e/util.go
  • Line 27: warning: exported function CreateJobBinding should have comment or be unexported (golint)
  • Line 77: warning: exported function RunBashJob should have comment or be unexported (golint)
  • Line 81: warning: exported function RunPowershellJob should have comment or be unexported (golint)
  • Line 85: warning: exported function RunJobScript should have comment or be unexported (golint)
  • Line 145: warning: exported function RunJobListener should have comment or be unexported (golint)
  • Line 277: warning: exported function CreateSource should have comment or be unexported (golint)

• sources-for-knative/test/clients.go
  • Line 26: warning: comment on exported const Namespace should be of the form "Namespace ..." (golint)
  • Line 36: warning: exported type Clients should have comment or be unexported (golint)
  • Line 43: warning: exported type VMWareClients should have comment or be unexported (golint)
  • Line 50: warning: exported function NewClients should have comment or be unexported (golint)
  • Line 55: warning: exported function Setup should have comment or be unexported (golint)
  • Line 64: warning: exported function NewClientsFromConfig should have comment or be unexported (golint)
  • Line 89: warning: exported function BuildClientConfig should have comment or be unexported (golint)
  • Line 100: warning: exported method Clients.AsPluginClients should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/command/flags.go
  • Line 8: warning: exported function MutuallyExclusiveStringFlags should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/command/version.go
  • Line 14: warning: exported var Version should have comment or be unexported (golint)
  • Line 15: warning: exported var BuildDate should have comment or be unexported (golint)
  • Line 16: warning: exported var GitRevision should have comment or be unexported (golint)

• sources-for-knative/pkg/vsphere/client.go
  • Line 31: warning: exported const VolumeName should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported type EnvConfig should have comment or be unexported (golint)

• sources-for-knative/pkg/reconciler/vspherebinding/controller.go
  • Line 90: warning: exported function ListAll should have comment or be unexported (golint)

• sources-for-knative/pkg/apis/sources/v1alpha1/vspheresource_types.go
  • Line 48: warning: exported type VCheckpointSpec should have comment or be unexported (golint)

• sources-for-knative/pkg/reconciler/vspheresource/resources/vspherebinding.go
  • Line 20: warning: exported function MakeVSphereBinding should have comment or be unexported (golint)

• sources-for-knative/pkg/apis/sources/v1alpha1/register.go
  • Line 30: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/command/root.go
  • Line 13: warning: comment on exported function NewRootCommand should be of the form "NewRootCommand ..." (golint)

• sources-for-knative/pkg/vsphere/checkpoint.go
  • Line 15: warning: comment on exported const CheckpointDefaultAge should be of the form "CheckpointDefaultAge ..." (golint)
  • Line 17: warning: comment on exported const CheckpointDefaultPeriod should be of the form "CheckpointDefaultPeriod ..." (golint)
  • Line 24: warning: exported var ErrInvalidInterval should have comment or be unexported (golint)

• sources-for-knative/cmd/sources-for-knative-controller/main.go
  • Line 39: warning: exported function NewDefaultingAdmissionController should have comment or be unexported (golint)
  • Line 63: warning: exported function NewValidationAdmissionController should have comment or be unexported (golint)
  • Line 87: warning: exported function NewConfigValidationController should have comment or be unexported (golint)
  • Line 104: warning: exported function NewVSphereBindingWebhook should have comment or be unexported (golint)

• sources-for-knative/pkg/reconciler/vspheresource/resources/deployment.go
  • Line 26: warning: exported function MakeDeployment should have comment or be unexported (golint)

• sources-for-knative/pkg/apis/sources/v1alpha1/vspheresource_lifecycle.go
  • Line 32: warning: exported method VSphereSourceStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 36: warning: exported method VSphereSourceStatus.PropagateAuthStatus should have comment or be unexported (golint)
  • Line 50: warning: exported method VSphereSourceStatus.PropagateAdapterStatus should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/command/binding.go
  • Line 22: warning: exported type BindingOptions should have comment or be unexported (golint)
  • Line 35: warning: exported function NewBindingCommand should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/command/fake_client_config.go
  • Line 14: warning: exported type FakeClientConfig should have comment or be unexported (golint)
  • Line 18: warning: exported method FakeClientConfig.RawConfig should have comment or be unexported (golint)
  • Line 22: warning: exported method FakeClientConfig.ClientConfig should have comment or be unexported (golint)
  • Line 26: warning: exported method FakeClientConfig.Namespace should have comment or be unexported (golint)
  • Line 31: warning: exported method FakeClientConfig.ConfigAccess should have comment or be unexported (golint)

• sources-for-knative/pkg/vsphere/adapter.go
  • Line 42: warning: exported function NewEnvConfig should have comment or be unexported (golint)
  • Line 57: warning: exported function NewAdapter should have comment or be unexported (golint)

• sources-for-knative/pkg/apis/sources/register.go
  • Line 9: warning: exported const GroupName should have comment (or a comment on this block) or be unexported (golint)

• sources-for-knative/pkg/reconciler/vspheresource/resources/names/names.go
  • Line 14: warning: exported function Deployment should have comment or be unexported (golint)
  • Line 18: warning: exported function VSphereBinding should have comment or be unexported (golint)
  • Line 22: warning: exported function ConfigMap should have comment or be unexported (golint)
  • Line 26: warning: exported function RoleBinding should have comment or be unexported (golint)
  • Line 30: warning: exported function ServiceAccount should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/clients.go
  • Line 19: warning: exported function NewClients should have comment or be unexported (golint)
  • Line 44: warning: exported type Clients should have comment or be unexported (golint)
  • Line 50: warning: exported method Clients.GetExplicitOrDefaultNamespace should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/command/login.go
  • Line 26: warning: exported type LoginOptions should have comment or be unexported (golint)
  • Line 36: warning: exported function NewLoginCommand should have comment or be unexported (golint)

• sources-for-knative/plugins/vsphere/pkg/command/source.go
  • Line 23: warning: exported type SourceOptions should have comment or be unexported (golint)
  • Line 39: warning: exported method SourceOptions.AsSinkDestination should have comment or be unexported (golint)
  • Line 74: warning: exported function NewSourceCommand should have comment or be unexported (golint)

• sources-for-knative/pkg/apis/sources/v1alpha1/doc.go
  • Line 6: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• sources-for-knative/pkg/apis/sources/v1alpha1/vspherebinding_lifecycle.go
  • Line 152: warning: exported method VSphereBinding.Undo should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!