Report for github.com/appscode/go
A+ Excellent! Found 74 issues across 126 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo97%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go/net/httpclient/httpclient.go
- Line 134: warning: cyclomatic complexity 18 of function (*Client).NewRequest() is high (> 15) (gocyclo)
-
-
go/net/ips.go
- Line 52: warning: cyclomatic complexity 23 of function NodeIP() is high (> 15) (gocyclo)
- Line 139: warning: cyclomatic complexity 20 of function detectIPs() is high (> 15) (gocyclo)
-
-
go/ioutil/copy.go
- Line 101: warning: cyclomatic complexity 17 of function CopyDir() is high (> 15) (gocyclo)
golint42%
Golint is a linter for Go source code.
-
-
go/term/scanner.go
- Line 13: warning: exported function Read should have comment or be unexported (golint)
- Line 26: warning: exported function ReadMasked should have comment or be unexported (golint)
- Line 38: warning: exported function Ask should have comment or be unexported (golint)
- Line 68: warning: exported function Confirm should have comment or be unexported (golint)
- Line 83: warning: exported function List should have comment or be unexported (golint)
-
-
go/log/log.go
- Line 16: warning: exported function Fatal should have comment or be unexported (golint)
- Line 20: warning: exported function Fatalln should have comment or be unexported (golint)
- Line 24: warning: exported function Fatalf should have comment or be unexported (golint)
- Line 28: warning: exported function Error should have comment or be unexported (golint)
- Line 32: warning: exported function Errorln should have comment or be unexported (golint)
- Line 36: warning: exported function Errorf should have comment or be unexported (golint)
- Line 40: warning: exported function Warning should have comment or be unexported (golint)
- Line 44: warning: exported function Warningln should have comment or be unexported (golint)
- Line 48: warning: exported function Warningf should have comment or be unexported (golint)
- Line 52: warning: exported function Info should have comment or be unexported (golint)
- Line 56: warning: exported function Infoln should have comment or be unexported (golint)
- Line 60: warning: exported function Infof should have comment or be unexported (golint)
- Line 64: warning: exported function Debug should have comment or be unexported (golint)
- Line 70: warning: exported function Debugln should have comment or be unexported (golint)
- Line 76: warning: exported function Debugf should have comment or be unexported (golint)
-
-
go/encoding/sql/types/json_proto.go
- Line 8: warning: exported type JsonProto should have comment or be unexported (golint)
- Line 10: warning: exported method JsonProto.FromDB should have comment or be unexported (golint)
- Line 15: warning: exported method JsonProto.ToDB should have comment or be unexported (golint)
- Line 22: warning: exported method JsonProto.IsEmpty should have comment or be unexported (golint)
- Line 26: warning: exported method JsonProto.Default should have comment or be unexported (golint)
- Line 30: warning: exported method JsonProto.Marshal should have comment or be unexported (golint)
- Line 37: warning: exported method JsonProto.Unmarshal should have comment or be unexported (golint)
- Line 45: warning: exported method JsonProto.Bytes should have comment or be unexported (golint)
- Line 49: warning: exported function NewJsonpb should have comment or be unexported (golint)
- Line 58: warning: exported function MustJsonpb should have comment or be unexported (golint)
-
-
go/encoding/json/types/int_hash.go
- Line 24: warning: exported function ParseIntHash should have comment or be unexported (golint)
- Line 68: warning: exported function NewIntHash should have comment or be unexported (golint)
- Line 70: warning: exported function IntHashForGeneration should have comment or be unexported (golint)
- Line 72: warning: exported function IntHashForHash should have comment or be unexported (golint)
- Line 74: warning: exported method IntHash.Generation should have comment or be unexported (golint)
- Line 78: warning: exported method IntHash.Hash should have comment or be unexported (golint)
- Line 90: warning: exported method IntHash.Equal should have comment or be unexported (golint)
- Line 106: warning: exported method IntHash.MatchGeneration should have comment or be unexported (golint)
- Line 119: warning: exported method IntHash.DeepCopyInto should have comment or be unexported (golint)
- Line 123: warning: exported method IntHash.DeepCopy should have comment or be unexported (golint)
- Line 136: warning: exported method IntHash.MarshalJSON should have comment or be unexported (golint)
- Line 146: warning: exported method IntHash.UnmarshalJSON should have comment or be unexported (golint)
- Line 180: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
- Line 184: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
-
-
go/sets/int.go
- Line 26: warning: comment on exported type Int should be of the form "Int ..." (with optional leading article) (golint)
- Line 29: warning: comment on exported function NewInt should be of the form "NewInt ..." (golint)
- Line 110: warning: receiver name s1 should be consistent with previous receiver name s for Int (golint)
- Line 126: warning: receiver name s1 should be consistent with previous receiver name s for Int (golint)
- Line 145: warning: receiver name s1 should be consistent with previous receiver name s for Int (golint)
- Line 157: warning: receiver name s1 should be consistent with previous receiver name s for Int (golint)
- Line 186: warning: comment on exported method Int.PopAny should be of the form "PopAny ..." (golint)
-
-
go/encoding/json/types/bool_yo.go
- Line 8: warning: exported type BoolYo should have comment or be unexported (golint)
- Line 10: warning: exported method BoolYo.MarshalJSON should have comment or be unexported (golint)
- Line 18: warning: exported method BoolYo.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/wait/wait.go
- Line 27: warning: comment on exported var ForeverTestTimeout should be of the form "ForeverTestTimeout ..." (golint)
-
-
go/context/context.go
- Line 11: warning: exported function ID should have comment or be unexported (golint)
- Line 21: warning: exported function WithID should have comment or be unexported (golint)
- Line 25: warning: exported function NewID should have comment or be unexported (golint)
-
-
go/encoding/sql/types/json_object.go
- Line 7: warning: exported type JsonObj should have comment or be unexported (golint)
- Line 9: warning: exported method JsonObj.FromDB should have comment or be unexported (golint)
- Line 14: warning: exported method JsonObj.ToDB should have comment or be unexported (golint)
- Line 21: warning: exported method JsonObj.IsEmpty should have comment or be unexported (golint)
- Line 25: warning: exported method JsonObj.Default should have comment or be unexported (golint)
- Line 29: warning: exported method JsonObj.Marshal should have comment or be unexported (golint)
- Line 34: warning: exported method JsonObj.Unmarshal should have comment or be unexported (golint)
- Line 42: warning: exported method JsonObj.Bytes should have comment or be unexported (golint)
- Line 46: warning: exported function NewJsonObj should have comment or be unexported (golint)
- Line 54: warning: exported function MustJsonObj should have comment or be unexported (golint)
-
-
go/log/golog/flags.go
- Line 9: warning: exported type Options should have comment or be unexported (golint)
- Line 16: warning: exported function ParseFlags should have comment or be unexported (golint)
- Line 31: warning: exported method Options.ToFlags should have comment or be unexported (golint)
-
-
go/encoding/j2/types/str_yo.go
- Line 16: warning: exported method StrYo.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/container/serializer/serializer.go
- Line 14: warning: exported function New should have comment or be unexported (golint)
-
-
go/strings/preconditions.go
- Line 5: warning: exported function Val should have comment or be unexported (golint)
-
-
go/encoding/yaml/helpers.go
- Line 214: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 222: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
go/runtime/runtime.go
- Line 86: warning: comment on exported function HandleError should be of the form "HandleError ..." (golint)
- Line 132: warning: exported function GOPath should have comment or be unexported (golint)
-
-
go/container/serializer/heap.go
- Line 3: warning: exported type Entry should have comment or be unexported (golint)
-
-
go/encoding/json/types/urlset.go
- Line 16: warning: exported type URLSet should have comment or be unexported (golint)
- Line 22: warning: exported function NewURLSet should have comment or be unexported (golint)
- Line 30: warning: exported method URLSet.Insert should have comment or be unexported (golint)
- Line 34: warning: exported method URLSet.Delete should have comment or be unexported (golint)
- Line 38: warning: exported method URLSet.Has should have comment or be unexported (golint)
- Line 42: warning: exported method URLSet.Equal should have comment or be unexported (golint)
- Line 42: warning: receiver name s1 should be consistent with previous receiver name us for URLSet (golint)
- Line 48: warning: exported method URLSet.MarshalJSON should have comment or be unexported (golint)
- Line 69: warning: exported method URLSet.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/os/script/linux_generic.go
- Line 16: warning: comment on exported type LinuxGeneric should be of the form "LinuxGeneric ..." (with optional leading article) (golint)
- Line 23: warning: exported method LinuxGeneric.Init should have comment or be unexported (golint)
- Line 36: warning: exported method LinuxGeneric.AppDir should have comment or be unexported (golint)
- Line 40: warning: exported method LinuxGeneric.WorkingDir should have comment or be unexported (golint)
- Line 44: warning: exported method LinuxGeneric.Raw should have comment or be unexported (golint)
- Line 48: warning: exported method LinuxGeneric.Mkdir should have comment or be unexported (golint)
- Line 54: warning: exported method LinuxGeneric.Chmod should have comment or be unexported (golint)
- Line 60: warning: exported method LinuxGeneric.Symlink should have comment or be unexported (golint)
- Line 66: warning: exported method LinuxGeneric.ChownRecurse should have comment or be unexported (golint)
- Line 72: warning: exported method LinuxGeneric.ChgrpRecurse should have comment or be unexported (golint)
- Line 78: warning: exported method LinuxGeneric.CmdOut should have comment or be unexported (golint)
- Line 88: warning: exported method LinuxGeneric.Run should have comment or be unexported (golint)
- Line 92: warning: exported method LinuxGeneric.SetEnv should have comment or be unexported (golint)
- Line 96: warning: exported method LinuxGeneric.UserExists should have comment or be unexported (golint)
- Line 102: warning: exported method LinuxGeneric.AddLine should have comment or be unexported (golint)
- Line 122: warning: exported method LinuxGeneric.UncommentLine should have comment or be unexported (golint)
- Line 138: warning: exported method LinuxGeneric.CheckPathExists should have comment or be unexported (golint)
- Line 144: warning: exported method LinuxGeneric.ReadAsBase64 should have comment or be unexported (golint)
- Line 149: warning: exported method LinuxGeneric.WriteBase64String should have comment or be unexported (golint)
- Line 157: warning: exported method LinuxGeneric.WriteString should have comment or be unexported (golint)
- Line 161: warning: exported method LinuxGeneric.WriteBytes should have comment or be unexported (golint)
- Line 165: warning: exported method LinuxGeneric.ProcessExists should have comment or be unexported (golint)
- Line 170: warning: exported method LinuxGeneric.ProcessStart should have comment or be unexported (golint)
- Line 179: warning: exported method LinuxGeneric.ProcessRestart should have comment or be unexported (golint)
- Line 188: warning: exported method LinuxGeneric.DeactivateDaemons should have comment or be unexported (golint)
- Line 190: warning: exported method LinuxGeneric.ActivateDaemons should have comment or be unexported (golint)
-
-
go/os/script/script.go
- Line 5: warning: exported type Script should have comment or be unexported (golint)
-
-
go/net/ips.go
- Line 15: warning: exported type IPRange should have comment or be unexported (golint)
- Line 20: warning: exported function NewIPRange should have comment or be unexported (golint)
- Line 30: warning: exported function IsPrivateIP should have comment or be unexported (golint)
- Line 42: warning: error var InterfaceDownErr should have name of the form ErrFoo (golint)
- Line 42: warning: exported var InterfaceDownErr should have comment or be unexported (golint)
- Line 43: warning: error var LoopbackInterfaceErr should have name of the form ErrFoo (golint)
- Line 44: warning: error var KnownLocalInterfaceErr should have name of the form ErrFoo (golint)
- Line 45: warning: error var NotFoundErr should have name of the form ErrFoo (golint)
- Line 82: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 96: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 104: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go/ioutil/copy.go
- Line 1: warning: package comment should be of the form "Package ioutil ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 84: warning: exported type CopyDirFn should have comment or be unexported (golint)
- Line 86: warning: exported function IgnoreDestination should have comment or be unexported (golint)
- Line 92: warning: exported function ReplaceDestination should have comment or be unexported (golint)
-
-
go/ioutil/writer.go
- Line 37: warning: exported type FileProjection should have comment or be unexported (golint)
- Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go/flags/flags.go
- Line 21: warning: comment on exported function InitFlags should be of the form "InitFlags ..." (golint)
- Line 29: warning: comment on exported function SetLogLevel should be of the form "SetLogLevel ..." (golint)
- Line 37: warning: comment on exported function EnsureRequiredFlags should be of the form "EnsureRequiredFlags ..." (golint)
- Line 53: warning: comment on exported function EnsureAlterableFlags should be of the form "EnsureAlterableFlags ..." (golint)
- Line 75: warning: exported function DumpAll should have comment or be unexported (golint)
-
-
go/encoding/j2/types/urlamp.go
- Line 14: warning: exported type URLMap should have comment or be unexported (golint)
- Line 20: warning: exported function NewURLMap should have comment or be unexported (golint)
- Line 28: warning: exported method URLMap.Insert should have comment or be unexported (golint)
- Line 32: warning: exported method URLMap.Delete should have comment or be unexported (golint)
- Line 38: warning: exported method URLMap.Has should have comment or be unexported (golint)
- Line 43: warning: exported method URLMap.Equal should have comment or be unexported (golint)
- Line 49: warning: exported method URLMap.MarshalJSON should have comment or be unexported (golint)
- Line 76: warning: exported method URLMap.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/encoding/j2/types/urlset.go
- Line 16: warning: exported type URLSet should have comment or be unexported (golint)
- Line 22: warning: exported function NewURLSet should have comment or be unexported (golint)
- Line 30: warning: exported method URLSet.Insert should have comment or be unexported (golint)
- Line 34: warning: exported method URLSet.Delete should have comment or be unexported (golint)
- Line 38: warning: exported method URLSet.Has should have comment or be unexported (golint)
- Line 42: warning: exported method URLSet.Equal should have comment or be unexported (golint)
- Line 42: warning: receiver name s1 should be consistent with previous receiver name us for URLSet (golint)
- Line 48: warning: exported method URLSet.MarshalJSON should have comment or be unexported (golint)
- Line 69: warning: exported method URLSet.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/types/mapper/structs.go
- Line 21: warning: comment on exported function ByNameKey should be of the form "ByNameKey ..." (golint)
-
-
go/types/convert_types.go
- Line 66: warning: comment on exported function TrueP should be of the form "TrueP ..." (golint)
-
-
go/sets/int64.go
- Line 26: warning: comment on exported type Int64 should be of the form "Int64 ..." (with optional leading article) (golint)
- Line 29: warning: comment on exported function NewInt64 should be of the form "NewInt64 ..." (golint)
- Line 110: warning: receiver name s1 should be consistent with previous receiver name s for Int64 (golint)
- Line 126: warning: receiver name s1 should be consistent with previous receiver name s for Int64 (golint)
- Line 145: warning: receiver name s1 should be consistent with previous receiver name s for Int64 (golint)
- Line 157: warning: receiver name s1 should be consistent with previous receiver name s for Int64 (golint)
- Line 186: warning: comment on exported method Int64.PopAny should be of the form "PopAny ..." (golint)
-
-
go/net/httpclient/httpclient.go
- Line 29: warning: exported type Client should have comment or be unexported (golint)
- Line 44: warning: exported function Default should have comment or be unexported (golint)
- Line 48: warning: exported function New should have comment or be unexported (golint)
- Line 67: warning: exported method Client.WithBaseURL should have comment or be unexported (golint)
- Line 72: warning: exported method Client.WithBasicAuth should have comment or be unexported (golint)
- Line 79: warning: exported method Client.WithBearerToken should have comment or be unexported (golint)
- Line 86: warning: exported method Client.WithTLSConfig should have comment or be unexported (golint)
- Line 112: warning: exported method Client.WithInsecureSkipVerify should have comment or be unexported (golint)
- Line 121: warning: exported method Client.WithUserAgent should have comment or be unexported (golint)
- Line 126: warning: exported method Client.WithTimeout should have comment or be unexported (golint)
- Line 292: warning: exported method Client.Call should have comment or be unexported (golint)
-
-
go/arrays/convert.go
- Line 8: warning: exported function InterfaceToSlice should have comment or be unexported (golint)
-
-
go/log/context.go
- Line 11: warning: comment on exported type Logger should be of the form "Logger ..." (with optional leading article) (golint)
- Line 26: warning: exported method Logger.Fatal should have comment or be unexported (golint)
- Line 30: warning: exported method Logger.Fatalln should have comment or be unexported (golint)
- Line 34: warning: exported method Logger.Fatalf should have comment or be unexported (golint)
- Line 42: warning: exported method Logger.Errorln should have comment or be unexported (golint)
- Line 46: warning: exported method Logger.Errorf should have comment or be unexported (golint)
- Line 50: warning: exported method Logger.Warning should have comment or be unexported (golint)
- Line 54: warning: exported method Logger.Warningln should have comment or be unexported (golint)
- Line 58: warning: exported method Logger.Warningf should have comment or be unexported (golint)
- Line 62: warning: exported method Logger.Info should have comment or be unexported (golint)
- Line 66: warning: exported method Logger.Infoln should have comment or be unexported (golint)
- Line 70: warning: exported method Logger.Infof should have comment or be unexported (golint)
- Line 74: warning: exported method Logger.Debug should have comment or be unexported (golint)
- Line 80: warning: exported method Logger.Debugln should have comment or be unexported (golint)
- Line 86: warning: exported method Logger.Debugf should have comment or be unexported (golint)
-
-
go/encoding/sql/types/json_array.go
- Line 7: warning: exported type JsonArr should have comment or be unexported (golint)
- Line 9: warning: exported method JsonArr.FromDB should have comment or be unexported (golint)
- Line 14: warning: exported method JsonArr.ToDB should have comment or be unexported (golint)
- Line 21: warning: exported method JsonArr.IsEmpty should have comment or be unexported (golint)
- Line 25: warning: exported method JsonArr.Default should have comment or be unexported (golint)
- Line 29: warning: exported method JsonArr.Marshal should have comment or be unexported (golint)
- Line 34: warning: exported method JsonArr.Unmarshal should have comment or be unexported (golint)
- Line 42: warning: exported method JsonArr.Bytes should have comment or be unexported (golint)
- Line 46: warning: exported function NewJsonArr should have comment or be unexported (golint)
- Line 54: warning: exported function MustJsonArr should have comment or be unexported (golint)
-
-
go/encoding/json/types/str_yo.go
- Line 16: warning: exported method StrYo.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/crypto/rand/random.go
- Line 10: warning: comment on exported function Characters should be of the form "Characters ..." (golint)
- Line 15: warning: exported function WithUniqSuffix should have comment or be unexported (golint)
- Line 19: warning: exported function GenerateToken should have comment or be unexported (golint)
- Line 23: warning: exported function GenerateTokenWithLength should have comment or be unexported (golint)
- Line 27: warning: exported function GeneratePassword should have comment or be unexported (golint)
- Line 31: warning: exported function DigestForIndex should have comment or be unexported (golint)
-
-
go/os/lib.go
- Line 5: warning: exported function LookupEnv should have comment or be unexported (golint)
- Line 17: warning: exported function Getenv should have comment or be unexported (golint)
-
-
go/reflect/util.go
- Line 5: warning: comment on exported function IsZero should be of the form "IsZero ..." (golint)
-
-
go/encoding/json/types/str_to_bool.go
- Line 15: warning: exported method StrToBool.MarshalJSON should have comment or be unexported (golint)
- Line 23: warning: exported method StrToBool.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/term/grpclogger.go
- Line 3: warning: comment on exported type NullLogger should be of the form "NullLogger ..." (with optional leading article) (golint)
- Line 6: warning: exported method NullLogger.Fatal should have comment or be unexported (golint)
- Line 9: warning: exported method NullLogger.Fatalf should have comment or be unexported (golint)
- Line 12: warning: exported method NullLogger.Fatalln should have comment or be unexported (golint)
- Line 15: warning: exported method NullLogger.Print should have comment or be unexported (golint)
- Line 18: warning: exported method NullLogger.Printf should have comment or be unexported (golint)
- Line 21: warning: exported method NullLogger.Println should have comment or be unexported (golint)
-
-
go/ioutil/watcher.go
- Line 13: warning: exported type Watcher should have comment or be unexported (golint)
- Line 26: warning: exported method Watcher.Run should have comment or be unexported (golint)
-
-
go/os/repos/debian_repo.go
- Line 3: warning: exported type DebianRepo should have comment or be unexported (golint)
- Line 10: warning: comment on exported var DebianRepos should be of the form "DebianRepos ..." (golint)
- Line 42: warning: exported var DefaultSaltstackVersion should have comment or be unexported (golint)
-
-
go/term/printer.go
- Line 12: warning: exported function Print should have comment or be unexported (golint)
- Line 16: warning: exported function Println should have comment or be unexported (golint)
- Line 20: warning: exported function Printf should have comment or be unexported (golint)
- Line 24: warning: exported function Infoln should have comment or be unexported (golint)
- Line 28: warning: exported function Warningln should have comment or be unexported (golint)
- Line 32: warning: exported function Successln should have comment or be unexported (golint)
- Line 36: warning: exported function Errorln should have comment or be unexported (golint)
- Line 40: warning: exported function Fatalln should have comment or be unexported (golint)
- Line 45: warning: exported function ExitOnError should have comment or be unexported (golint)
-
-
go/crypto/ssh/types.go
- Line 19: warning: exported const RSABitSize should have comment or be unexported (golint)
- Line 21: warning: exported type SSHKey should have comment or be unexported (golint)
- Line 28: warning: comment on exported function NewSSHKeyPair should be of the form "NewSSHKeyPair ..." (golint)
- Line 82: warning: exported function ParseSSHKeyPair should have comment or be unexported (golint)
-
-
go/sets/types/types.go
- Line 24: warning: exported type ReferenceSetTypes should have comment or be unexported (golint)
-
-
go/encoding/j2/types/bool_yo.go
- Line 8: warning: exported type BoolYo should have comment or be unexported (golint)
- Line 10: warning: exported method BoolYo.MarshalJSON should have comment or be unexported (golint)
- Line 18: warning: exported method BoolYo.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/encoding/json/types/array_or_int.go
- Line 10: warning: comment on exported type ArrayOrInt should be of the form "ArrayOrInt ..." (with optional leading article) (golint)
- Line 18: warning: exported method ArrayOrInt.MarshalJSON should have comment or be unexported (golint)
- Line 39: warning: exported method ArrayOrInt.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/strings/optionals.go
- Line 5: warning: exported function VString should have comment or be unexported (golint)
-
-
go/env/env.go
- Line 10: warning: exported type Environment should have comment or be unexported (golint)
- Line 13: warning: exported const Dev should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported const Key should have comment (or a comment on this block) or be unexported (golint)
- Line 25: warning: exported method Environment.IsPublic should have comment or be unexported (golint)
- Line 34: warning: exported method Environment.IsHosted should have comment or be unexported (golint)
- Line 43: warning: exported method Environment.DebugEnabled should have comment or be unexported (golint)
- Line 52: warning: exported method Environment.DevMode should have comment or be unexported (golint)
- Line 56: warning: exported method Environment.APIServer should have comment or be unexported (golint)
- Line 71: warning: exported method Environment.MarshalJSON should have comment or be unexported (golint)
- Line 75: warning: exported method Environment.UnmarshalJSON should have comment or be unexported (golint)
- Line 83: warning: exported function FromHost should have comment or be unexported (golint)
- Line 87: warning: exported function FromString should have comment or be unexported (golint)
- Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 106: warning: comment on exported function InCluster should be of the form "InCluster ..." (golint)
-
-
go/analytics/analytics.go
- Line 12: warning: exported function ClientID should have comment or be unexported (golint)
-
-
go/encoding/j2/filter.go
- Line 8: warning: exported function Filter should have comment or be unexported (golint)
-
-
go/encoding/yaml/yaml.go
- Line 36: warning: exported function Marshal should have comment or be unexported (golint)
- Line 74: warning: exported function Unmarshal should have comment or be unexported (golint)
- Line 78: warning: exported function ToString should have comment or be unexported (golint)
-
-
go/strings/strings.go
- Line 9: warning: comment on exported function Reverse should be of the form "Reverse ..." (golint)
- Line 21: warning: exported function PrefixFold should have comment or be unexported (golint)
- Line 25: warning: exported function IsEmpty should have comment or be unexported (golint)
- Line 29: warning: exported function IsBothAlphaNum should have comment or be unexported (golint)
- Line 45: warning: exported function Contains should have comment or be unexported (golint)
- Line 54: warning: comment on exported function DomainForm should be of the form "DomainForm ..." (golint)
- Line 68: warning: exported function Filter should have comment or be unexported (golint)
- Line 78: warning: exported function Join should have comment or be unexported (golint)
- Line 86: warning: exported function EqualSlice should have comment or be unexported (golint)
-
-
go/os/script/debian_generic.go
- Line 12: warning: exported type DebianGeneric should have comment or be unexported (golint)
- Line 16: warning: exported method DebianGeneric.ProcessEnable should have comment or be unexported (golint)
- Line 22: warning: exported method DebianGeneric.ProcessDisable should have comment or be unexported (golint)
- Line 42: warning: exported method DebianGeneric.AddPPA should have comment or be unexported (golint)
- Line 52: warning: comment on exported method DebianGeneric.AddRepo should be of the form "AddRepo ..." (golint)
- Line 73: warning: exported method DebianGeneric.UpdateRepos should have comment or be unexported (golint)
- Line 77: warning: exported method DebianGeneric.UpgradePkgs should have comment or be unexported (golint)
- Line 81: warning: exported method DebianGeneric.InstallPkgDeps should have comment or be unexported (golint)
- Line 85: warning: exported method DebianGeneric.InstallPkgs should have comment or be unexported (golint)
- Line 94: warning: exported method DebianGeneric.DeactivateDaemons should have comment or be unexported (golint)
- Line 101: warning: exported method DebianGeneric.ActivateDaemons should have comment or be unexported (golint)
- Line 110: warning: exported method DebianGeneric.InstallSaltMaster should have comment or be unexported (golint)
- Line 118: warning: exported method DebianGeneric.InstallSaltMinion should have comment or be unexported (golint)
-
-
go/os/script/ubuntu_generic.go
- Line 8: warning: exported type UbuntuGeneric should have comment or be unexported (golint)
- Line 12: warning: exported method UbuntuGeneric.ProcessEnable should have comment or be unexported (golint)
- Line 16: warning: exported method UbuntuGeneric.ProcessDisable should have comment or be unexported (golint)
- Line 21: warning: exported method UbuntuGeneric.InstallSaltMaster should have comment or be unexported (golint)
- Line 26: warning: exported method UbuntuGeneric.InstallSaltMinion should have comment or be unexported (golint)
-
-
go/crypto/ssh/util.go
- Line 14: warning: exported function MakePrivateKeySignerFromFile should have comment or be unexported (golint)
- Line 23: warning: exported function MakePrivateKeySignerFromBytes should have comment or be unexported (golint)
- Line 31: warning: exported function ParsePublicKeyFromFile should have comment or be unexported (golint)
- Line 48: warning: exported function EncodePrivateKey should have comment or be unexported (golint)
- Line 55: warning: exported function EncodePublicKey should have comment or be unexported (golint)
- Line 66: warning: exported function EncodeSSHKey should have comment or be unexported (golint)
- Line 74: warning: exported function GenerateKey should have comment or be unexported (golint)
-
-
go/crypto/aead/gcm.go
- Line 10: warning: comment on exported type Cryptor should be of the form "Cryptor ..." (with optional leading article) (golint)
- Line 23: warning: exported type RealCryptor should have comment or be unexported (golint)
- Line 25: warning: exported method RealCryptor.EncryptString should have comment or be unexported (golint)
- Line 33: warning: exported method RealCryptor.Encrypt should have comment or be unexported (golint)
- Line 47: warning: exported method RealCryptor.DecryptString should have comment or be unexported (golint)
- Line 59: warning: exported method RealCryptor.Decrypt should have comment or be unexported (golint)
- Line 81: warning: exported type PassThroughCryptor should have comment or be unexported (golint)
- Line 83: warning: exported method PassThroughCryptor.EncryptString should have comment or be unexported (golint)
- Line 87: warning: exported method PassThroughCryptor.Encrypt should have comment or be unexported (golint)
- Line 91: warning: exported method PassThroughCryptor.DecryptString should have comment or be unexported (golint)
- Line 95: warning: exported method PassThroughCryptor.Decrypt should have comment or be unexported (golint)
-
-
go/ntp/ntp.go
- Line 10: warning: exported function CheckSkew should have comment or be unexported (golint)
- Line 14: warning: exported function CheckSkewFromServer should have comment or be unexported (golint)
-
-
go/encoding/j2/types/array_or_int.go
- Line 10: warning: comment on exported type ArrayOrInt should be of the form "ArrayOrInt ..." (with optional leading article) (golint)
- Line 18: warning: exported method ArrayOrInt.MarshalJSON should have comment or be unexported (golint)
- Line 39: warning: exported method ArrayOrInt.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/version/version.go
- Line 53: warning: exported var Version should have comment or be unexported (golint)
- Line 55: warning: exported function NewCmdVersion should have comment or be unexported (golint)
-
-
go/encoding/sql/types/json_map.go
- Line 7: warning: exported type JsonMap should have comment or be unexported (golint)
- Line 9: warning: exported method JsonMap.FromDB should have comment or be unexported (golint)
- Line 14: warning: exported method JsonMap.ToDB should have comment or be unexported (golint)
- Line 21: warning: exported method JsonMap.Default should have comment or be unexported (golint)
-
-
go/sets/byte.go
- Line 26: warning: comment on exported type Byte should be of the form "Byte ..." (with optional leading article) (golint)
- Line 29: warning: comment on exported function NewByte should be of the form "NewByte ..." (golint)
- Line 110: warning: receiver name s1 should be consistent with previous receiver name s for Byte (golint)
- Line 126: warning: receiver name s1 should be consistent with previous receiver name s for Byte (golint)
- Line 145: warning: receiver name s1 should be consistent with previous receiver name s for Byte (golint)
- Line 157: warning: receiver name s1 should be consistent with previous receiver name s for Byte (golint)
- Line 186: warning: comment on exported method Byte.PopAny should be of the form "PopAny ..." (golint)
-
-
go/crypto/ssh/ssh.go
- Line 63: warning: exported type Client should have comment or be unexported (golint)
- Line 69: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
- Line 108: warning: comment on exported method Client.Exec should be of the form "Exec ..." (golint)
- Line 138: warning: comment on exported method Client.SCP should be of the form "SCP ..." (golint)
- Line 194: warning: comment on exported function Exec should be of the form "Exec ..." (golint)
- Line 205: warning: comment on exported function SCP should be of the form "SCP ..." (golint)
-
-
go/encoding/json/filter.go
- Line 8: warning: exported function Filter should have comment or be unexported (golint)
-
-
go/arrays/slice.go
- Line 7: warning: exported function Reverse should have comment or be unexported (golint)
- Line 19: warning: exported function Filter should have comment or be unexported (golint)
- Line 33: warning: exported function Contains should have comment or be unexported (golint)
-
-
go/encoding/j2/types/str_to_bool.go
- Line 15: warning: exported method StrToBool.MarshalJSON should have comment or be unexported (golint)
- Line 23: warning: exported method StrToBool.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/util/errors/aggregator.go
- Line 65: warning: exported function Must should have comment or be unexported (golint)
-
-
go/sets/string.go
- Line 26: warning: comment on exported type String should be of the form "String ..." (with optional leading article) (golint)
- Line 29: warning: comment on exported function NewString should be of the form "NewString ..." (golint)
- Line 110: warning: receiver name s1 should be consistent with previous receiver name s for String (golint)
- Line 126: warning: receiver name s1 should be consistent with previous receiver name s for String (golint)
- Line 145: warning: receiver name s1 should be consistent with previous receiver name s for String (golint)
- Line 157: warning: receiver name s1 should be consistent with previous receiver name s for String (golint)
- Line 186: warning: comment on exported method String.PopAny should be of the form "PopAny ..." (golint)
-
-
go/term/types.go
- Line 5: warning: exported var Interactive should have comment or be unexported (golint)
- Line 7: warning: exported var Env should have comment or be unexported (golint)
-
-
go/ioutil/helpers.go
- Line 13: warning: exported function ReadFile should have comment or be unexported (golint)
- Line 21: warning: exported function ReadFileAs should have comment or be unexported (golint)
- Line 63: warning: exported function WriteJson should have comment or be unexported (golint)
- Line 76: warning: exported function WriteString should have comment or be unexported (golint)
- Line 86: warning: exported function AppendToFile should have comment or be unexported (golint)
- Line 104: warning: exported function EnsureDirectory should have comment or be unexported (golint)
- Line 112: warning: exported function IsFileExists should have comment or be unexported (golint)
-
-
go/encoding/j2/types/int_hash.go
- Line 24: warning: exported function ParseIntHash should have comment or be unexported (golint)
- Line 68: warning: exported function NewIntHash should have comment or be unexported (golint)
- Line 70: warning: exported function IntHashForGeneration should have comment or be unexported (golint)
- Line 72: warning: exported function IntHashForHash should have comment or be unexported (golint)
- Line 74: warning: exported method IntHash.Generation should have comment or be unexported (golint)
- Line 78: warning: exported method IntHash.Hash should have comment or be unexported (golint)
- Line 90: warning: exported method IntHash.Equal should have comment or be unexported (golint)
- Line 106: warning: exported method IntHash.DeepCopyInto should have comment or be unexported (golint)
- Line 110: warning: exported method IntHash.DeepCopy should have comment or be unexported (golint)
- Line 123: warning: exported method IntHash.MarshalJSON should have comment or be unexported (golint)
- Line 133: warning: exported method IntHash.UnmarshalJSON should have comment or be unexported (golint)
- Line 167: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
- Line 171: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
-
-
go/encoding/json/types/urlamp.go
- Line 14: warning: exported type URLMap should have comment or be unexported (golint)
- Line 20: warning: exported function NewURLMap should have comment or be unexported (golint)
- Line 28: warning: exported method URLMap.Insert should have comment or be unexported (golint)
- Line 32: warning: exported method URLMap.Delete should have comment or be unexported (golint)
- Line 38: warning: exported method URLMap.Has should have comment or be unexported (golint)
- Line 43: warning: exported method URLMap.Equal should have comment or be unexported (golint)
- Line 49: warning: exported method URLMap.MarshalJSON should have comment or be unexported (golint)
- Line 76: warning: exported method URLMap.UnmarshalJSON should have comment or be unexported (golint)
-
-
go/strings/fmt.go
- Line 7: warning: exported function Fmt should have comment or be unexported (golint)
- Line 15: warning: comment on exported type Stripe should be of the form "Stripe ..." (with optional leading article) (golint)
- Line 56: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go/types/doc.go
- Line 1: warning: package comment should be of the form "Package types ..." (golint)
ineffassign98%
IneffAssign detects ineffectual assignments in Go code.
-
-
go/encoding/j2/types/str_yo_test.go
- Line 39: warning: ineffectual assignment to err (ineffassign)
- Line 71: warning: ineffectual assignment to err (ineffassign)
-
-
go/encoding/json/types/str_yo_test.go
- Line 39: warning: ineffectual assignment to err (ineffassign)
- Line 71: warning: ineffectual assignment to err (ineffassign)