Preparing report...

Report for github.com/99designs/aws-vault

(v3.7.1+incompatible)

A    Great!    Found 19 issues across 26 files

Tweet

gofmt76%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint42%

Golint is a linter for Go source code.

    • ls.go
    • Line 10: warning: exported type LsCommandInput should have comment or be unexported (golint)
    • Line 14: warning: exported function LsCommand should have comment or be unexported (golint)
    • main.go
    • Line 16: warning: exported const KeyringName should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: exported var Version should have comment or be unexported (golint)
    • sessions.go
    • Line 17: warning: exported type KeyringSessions should have comment or be unexported (golint)
    • Line 22: warning: exported function NewKeyringSessions should have comment or be unexported (golint)
    • Line 42: warning: exported method KeyringSessions.Retrieve should have comment or be unexported (golint)
    • Line 59: warning: exported method KeyringSessions.Store should have comment or be unexported (golint)
    • Line 76: warning: exported method KeyringSessions.Delete should have comment or be unexported (golint)
    • keyring/keyring.go
    • Line 6: warning: exported const SecretServiceBackend should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported var DefaultBackend should have comment or be unexported (golint)
    • Line 16: warning: exported function SupportedBackends should have comment or be unexported (golint)
    • Line 26: warning: exported function Open should have comment or be unexported (golint)
    • Line 35: warning: exported type Item should have comment or be unexported (golint)
    • Line 43: warning: exported type Keyring should have comment or be unexported (golint)
    • Line 50: warning: exported var ErrNoAvailImpl should have comment or be unexported (golint)
    • Line 51: warning: exported var ErrKeyNotFound should have comment or be unexported (golint)
    • keyring/kwallet.go
    • Line 12: warning: exported const DBUS_SERVICE_NAME should have comment (or a comment on this block) or be unexported (golint)
    • rm.go
    • Line 11: warning: exported type RemoveCommandInput should have comment or be unexported (golint)
    • Line 17: warning: exported function RemoveCommand should have comment or be unexported (golint)
    • prompt/prompt.go
    • Line 5: warning: exported type PromptFunc should have comment or be unexported (golint)
    • Line 7: warning: exported var Methods should have comment or be unexported (golint)
    • Line 11: warning: exported function Available should have comment or be unexported (golint)
    • Line 19: warning: exported function Method should have comment or be unexported (golint)
    • provider.go
    • Line 19: warning: exported const MaxSessionDuration should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: exported type VaultOptions should have comment or be unexported (golint)
    • Line 38: warning: exported method VaultOptions.Validate should have comment or be unexported (golint)
    • Line 53: warning: exported method VaultOptions.ApplyDefaults should have comment or be unexported (golint)
    • Line 63: warning: exported type VaultProvider should have comment or be unexported (golint)
    • Line 74: warning: exported function NewVaultProvider should have comment or be unexported (golint)
    • Line 89: warning: exported method VaultProvider.Retrieve should have comment or be unexported (golint)
    • Line 295: warning: exported type KeyringProvider should have comment or be unexported (golint)
    • Line 300: warning: exported method KeyringProvider.IsExpired should have comment or be unexported (golint)
    • Line 304: warning: exported method KeyringProvider.Retrieve should have comment or be unexported (golint)
    • Line 317: warning: exported method KeyringProvider.Store should have comment or be unexported (golint)
    • Line 329: warning: exported method KeyringProvider.Delete should have comment or be unexported (golint)
    • Line 333: warning: exported type VaultCredentials should have comment or be unexported (golint)
    • Line 338: warning: exported function NewVaultCredentials should have comment or be unexported (golint)
    • Line 347: warning: exported method VaultCredentials.Expires should have comment or be unexported (golint)
    • add.go
    • Line 13: warning: exported type AddCommandInput should have comment or be unexported (golint)
    • Line 19: warning: exported function AddCommand should have comment or be unexported (golint)
    • exec.go
    • Line 17: warning: exported type ExecCommandInput should have comment or be unexported (golint)
    • Line 31: warning: exported function ExecCommand should have comment or be unexported (golint)
    • login.go
    • Line 26: warning: exported type LoginCommandInput should have comment or be unexported (golint)
    • Line 36: warning: exported function LoginCommand should have comment or be unexported (golint)
    • rotate.go
    • Line 17: warning: exported type RotateCommandInput should have comment or be unexported (golint)
    • Line 24: warning: exported function RotateCommand should have comment or be unexported (golint)
    • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • server.go
    • Line 24: warning: exported type ServerCommandInput should have comment or be unexported (golint)
    • Line 27: warning: exported function ServerCommand should have comment or be unexported (golint)
    • keyring/array.go
    • Line 3: warning: exported type ArrayKeyring should have comment or be unexported (golint)
    • Line 7: warning: exported function NewArrayKeyring should have comment or be unexported (golint)
    • Line 15: warning: exported method ArrayKeyring.Get should have comment or be unexported (golint)
    • Line 22: warning: exported method ArrayKeyring.Set should have comment or be unexported (golint)
    • Line 30: warning: exported method ArrayKeyring.Remove should have comment or be unexported (golint)
    • Line 35: warning: exported method ArrayKeyring.Keys should have comment or be unexported (golint)

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • login.go
    • Line 36: warning: cyclomatic complexity 20 of function LoginCommand() is high (> 15) (gocyclo)
    • exec.go
    • Line 31: warning: cyclomatic complexity 19 of function ExecCommand() is high (> 15) (gocyclo)
    • rotate.go
    • Line 24: warning: cyclomatic complexity 16 of function RotateCommand() is high (> 15) (gocyclo)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!